From 92fcf33575d4cae403591dde8737e4ce53ab9bc5 Mon Sep 17 00:00:00 2001
From: Catalina Wei <fancy@apache.org>
Date: Sat, 15 Aug 2009 00:30:09 +0000
Subject: [PATCH] OPENJPA-1185 Subquery restructure code cleanup comments in
 testcase

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@804418 13f79535-47bb-0310-9956-ffa450edef68
---
 .../openjpa/persistence/embed/TestEmbeddable.java  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/embed/TestEmbeddable.java b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/embed/TestEmbeddable.java
index d8415423f..e1ad64e1a 100644
--- a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/embed/TestEmbeddable.java
+++ b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/embed/TestEmbeddable.java
@@ -1621,9 +1621,9 @@ public class TestEmbeddable extends SingleEMFTestCase {
         }
         for (int i = 0; i < query2.length; i++) {
             try {
-            rs = em.createQuery(query2[i]).getResultList();
+                rs = em.createQuery(query2[i]).getResultList();
             } catch(ArgumentException e) {
-                // as expected
+                // as expected: comparison over embedded object is not allowed
             }
         }
         EntityTransaction tran = em.getTransaction();
@@ -1692,7 +1692,7 @@ public class TestEmbeddable extends SingleEMFTestCase {
                 " from EntityA_Coll_Embed_Embed a1, in (a1.embeds) e2) " +
                 " order by e.intVal3",
             // non-corelated subquery:
-            // TODO: known problem in table alias resolution for subquery
+            // Fixed in OPENJPA-1185: known problem in table alias resolution for subquery
             //       the genarated SQL subquery should be non-corelated,
             //       but generated corelated subquery.
             "select e, e.intVal1, e.embed.intVal2 from " +
@@ -1717,7 +1717,7 @@ public class TestEmbeddable extends SingleEMFTestCase {
                 " from EntityA_Coll_Embed_Embed a, in (a.embeds) e) " +
                 " order by e.intVal3",
             // corelated subquery:
-            // TODO: known problem in table alias resolution for subquery
+            // Fixed in OPENJPA-1185: known problem in table alias resolution for subquery
             //       the genarated SQL subquery should be corelated,
             //       but generated non-corelated subquery.
             "select e, e.intVal1, e.embed.intVal2 from " +
@@ -1777,7 +1777,7 @@ public class TestEmbeddable extends SingleEMFTestCase {
             try {
             rs = em.createQuery(query3[i]).setParameter(1, obj).getResultList();
             } catch(ArgumentException e) {
-                // as expected
+                // as expected: comparison over embedded object is not allowed
             }
         }
 
@@ -1855,7 +1855,7 @@ public class TestEmbeddable extends SingleEMFTestCase {
                 setParameter(1, (Embed) obj).
                 getResultList();
             } catch (ArgumentException e) {
-                // expected exception
+                // expected exception: comparison over embedded object is not allowed
             }
         }
         try {
@@ -1865,7 +1865,7 @@ public class TestEmbeddable extends SingleEMFTestCase {
                 setParameter(1, ea.getEmbed()).
                 getResultList();
         } catch (ArgumentException e) {
-            // expected exception
+            // expected exception: comparison over embedded object is not allowed
         }
         em.clear();