Apache/openjpa
1
0
Fork 0
mirror of https://github.com/apache/openjpa.git synced 2025-02-21 01:15:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

OPENJPA-1700 FindBugs - Method invokes inefficient new String() constructor

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956878 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Donald Woods 2010-06-22 13:16:01 +00:00
parent a7c61414ca
commit af772a734b
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DB2Dictionary.java
View File

@ -113,8 +113,7 @@ public class DB2Dictionary
fixedSizeTypeNameSet.addAll(Arrays.asList(new String[]{
"LONG VARCHAR FOR BIT DATA", "LONG VARCHAR", "LONG VARGRAPHIC",
}));
systemSchemas = new String(
"SYSCAT,SYSIBM,SYSSTAT,SYSIBMADM,SYSTOOLS");
systemSchemas = "SYSCAT,SYSIBM,SYSSTAT,SYSIBMADM,SYSTOOLS";
maxConstraintNameLength = 18;
maxIndexNameLength = 18;
maxColumnNameLength = 30;
@ -573,7 +572,6 @@ public class DB2Dictionary
*/
private String appendExtendedExceptionMsg(String msg, SQLException sqle){
final String GETSQLCA ="getSqlca";
String exceptionMsg = new String();
try {
Method sqlcaM2 = sqle.getNextException().getClass()
.getMethod(GETSQLCA,null);
@ -591,17 +589,23 @@ public class DB2Dictionary
for (int i = 0; i < errds.length; i++)
errdStr.append(errdStr.length() > 0 ? ", " : "").
append(errds[i]);
exceptionMsg = exceptionMsg.concat( "SQLCA OUTPUT" +
"[Errp=" + getSqlErrpMethd.invoke(sqlca, new Object[]{})
+ ", Errd=" + errdStr);
StringBuilder exceptionMsg = new StringBuilder();
exceptionMsg.append("SQLCA OUTPUT");
exceptionMsg.append("[Errp=");
exceptionMsg.append(getSqlErrpMethd.invoke(sqlca, new Object[]{}));
exceptionMsg.append(", Errd=");
exceptionMsg.append(errdStr);
String Warn = new String((char[]) getSqlWarnMethd.
invoke(sqlca, new Object[]{}));
if (Warn.trim().length() != 0)
exceptionMsg = exceptionMsg.concat(", Warn=" +Warn + "]" );
else
exceptionMsg = exceptionMsg.concat( "]" );
msg = msg.concat(exceptionMsg);
if (Warn.trim().length() != 0) {
exceptionMsg.append(", Warn=");
exceptionMsg.append(Warn);
exceptionMsg.append("]");
} else {
exceptionMsg.append("]");
}
msg = msg.concat(exceptionMsg.toString());
// for batched execution failures, SQLExceptions are nested
SQLException sqle2 = sqle.getNextException();