Apache
/
openjpa
mirror of https://github.com/apache/openjpa.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove @Allowfailure in lock manager tests after FinderCache fix. 

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@748276 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Albert Lee 2009-02-26 19:27:19 +00:00
parent a9c858b39a
commit bcfb4e9c83
2 changed files with 30 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/lockmgr/TestJPA2LockManager.java
View File

@ -20,8 +20,6 @@ package org.apache.openjpa.persistence.lockmgr;
import javax.persistence.LockModeType; import javax.persistence.LockModeType;
import org.apache.openjpa.persistence.test.AllowFailure;
/** /**
* Test JPA 2.0 LockMode type behaviors with "jpa2" lock manager. * Test JPA 2.0 LockMode type behaviors with "jpa2" lock manager.
*/ */
@ -824,12 +822,11 @@ public class TestJPA2LockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1PessimisticReadTest() { public void testConcurrentThread1PessimisticReadTest() {
getLog().info("---> testConcurrentThread1PessimisticReadTest()"); getLog().info("---> testConcurrentThread1PessimisticReadTest()");
String baseFirstName; String baseFirstName;
@ -1191,12 +1188,11 @@ public class TestJPA2LockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1PessimisticForceIncTest() { public void testConcurrentThread1PessimisticForceIncTest() {
getLog().info("---> testConcurrentThread1PessimisticForceIncTest()"); getLog().info("---> testConcurrentThread1PessimisticForceIncTest()");
String baseFirstName; String baseFirstName;

46
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/lockmgr/TestPessimisticLockManager.java
View File

@ -20,8 +20,6 @@ package org.apache.openjpa.persistence.lockmgr;
import javax.persistence.LockModeType; import javax.persistence.LockModeType;
import org.apache.openjpa.persistence.test.AllowFailure;
/** /**
* Test JPA 2.0 LockTypeMode semantics using OpenJPA pessimistic * Test JPA 2.0 LockTypeMode semantics using OpenJPA pessimistic
* "pessimistic" lock manager. * "pessimistic" lock manager.
@ -132,12 +130,11 @@ public class TestPessimisticLockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1ReadTest() { public void testConcurrentThread1ReadTest() {
getLog().info("---> testConcurrentThread1ReadTest()"); getLog().info("---> testConcurrentThread1ReadTest()");
String baseFirstName; String baseFirstName;
@ -487,12 +484,11 @@ public class TestPessimisticLockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1WriteTest() { public void testConcurrentThread1WriteTest() {
getLog().info("---> testConcurrentThread1WriteTest()"); getLog().info("---> testConcurrentThread1WriteTest()");
String baseFirstName; String baseFirstName;
@ -842,12 +838,11 @@ public class TestPessimisticLockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1PessimisticReadTest() { public void testConcurrentThread1PessimisticReadTest() {
getLog().info("---> testConcurrentThread1PessimisticReadTest()"); getLog().info("---> testConcurrentThread1PessimisticReadTest()");
String baseFirstName; String baseFirstName;
@ -1209,12 +1204,11 @@ public class TestPessimisticLockManager extends LockManagerTestBase {
); );
} }
// TODO: // @AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock "
@AllowFailure(message="OPENJPA-924 is preventing RR behavior: pessimistic lock " // + "blocked read on thread 2, once thread-1 commit, thread-2 returns "
+ "blocked read on thread 2, once thread-1 commit, thread-2 returns " // + "with pre-thread 1 committed data. hence causing an "
+ "with pre-thread 1 committed data. hence causing an " // + "OptimisticLockException. Disable FinderCache to workaround the "
+ "OptimisticLockException. Disable FinderCache to workaround the " // + "problem.")
+ "problem.")
public void testConcurrentThread1PessimisticForceIncTest() { public void testConcurrentThread1PessimisticForceIncTest() {
getLog().info("---> testConcurrentThread1PessimisticForceIncTest()"); getLog().info("---> testConcurrentThread1PessimisticForceIncTest()");
String baseFirstName; String baseFirstName;