Apache
/
openjpa
mirror of https://github.com/apache/openjpa.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPENJPA-556. This implementation does some extra copying to accomodate DataCache.getAll(), which takes a List instead of a Collection. 

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@644627 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Patrick Linskey 2008-04-04 06:55:13 +00:00
parent 36c68c49f5
commit dd7014a527
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
openjpa-kernel/src/main/java/org/apache/openjpa/datacache/DataCacheStoreManager.java
View File

@ -26,8 +26,8 @@ import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.ListIterator;
import java.util.Map;
import java.util.Map.Entry;
import org.apache.openjpa.enhance.PCDataGenerator;
import org.apache.openjpa.kernel.DelegatingStoreManager;
@ -260,16 +260,26 @@ public class DataCacheStoreManager
*/
private void transformToVersionSafePCDatas(DataCache cache,
List holders) {
PCDataHolder holder;
DataCachePCData oldpc;
for (ListIterator iter = holders.listIterator(); iter.hasNext();) {
holder = (PCDataHolder) iter.next();
oldpc = cache.get(holder.sm.getObjectId());
Map<Object,Integer> ids = new HashMap<Object,Integer>(holders.size());
// this list could be removed if DataCache.getAll() took a Collection
List idList = new ArrayList(holders.size());
int i = 0;
for (PCDataHolder holder : (List<PCDataHolder>) holders) {
ids.put(holder.sm.getObjectId(), i++);
idList.add(holder.sm.getObjectId());
}
Map<Object,DataCachePCData> pcdatas = cache.getAll(idList);
for (Entry<Object,DataCachePCData> entry : pcdatas.entrySet()) {
Integer index = ids.get(entry.getKey());
DataCachePCData oldpc = entry.getValue();
PCDataHolder holder = (PCDataHolder) holders.get(index);
if (oldpc != null && compareVersion(holder.sm,
holder.sm.getVersion(), oldpc.getVersion()) == VERSION_EARLIER)
iter.remove();
holders.remove(index);
else
iter.set(holder.pcdata);
holders.set(index, holder.pcdata);
}
}