Commit Graph

1439 Commits

Author SHA1 Message Date
Mark Struberg 2a3fc73861 OPENJPA-2855 revert PK name handling
Seems this got broken as side effect of dd9bce0cc9
which was for OPENJPA-2816. We need to check HerdDB again
2021-04-01 21:19:59 +02:00
Mark Struberg a3bf818402 remove unused import 2021-04-01 19:28:16 +02:00
Mark Struberg c3bbb92557 OPENJPA-2854 fix OffsetTime handling for PostgreSQL
PostgreSQL doesn't natively support OffsetTime. While it has a column type
time with time zone it actually only stores the time as UTC time.
2021-04-01 17:02:25 +02:00
Mark Struberg e9f3f9cdfc OPENJPA-2883 fix handling of java.sql.Time on MSSQL 2021-03-31 19:11:08 +02:00
Mark Struberg 68aa6a3d17 OPENJPA-1303 KEY is also an invalid column name 2021-03-31 09:38:44 +02:00
Mark Struberg 6a47c4c033 OPENJPA-1303 ColumnDefIdentifierRule did not use invalidColumnWordSet 2021-03-31 00:29:51 +02:00
Mark Struberg d48f439bc8 OPENJPA-2182 fix invalidColumnWordSet handling
invalidColumnWordSet should get populated with the list of reserved words
if not explicitly configured otherwise.
2021-03-30 20:52:31 +02:00
Mark Struberg 1a8bcfb6b1 OPENJPA-2849 fix UnaryOp to use DBDictionary
UnaryOps should use the DBDictionary to resolve the requested data whenever possible.
Previously we always have been requesting JDBC native types when doing max(), min(), etc.
But this returns values of types which we potentially cannot handle.
2021-03-30 14:38:14 +02:00
Mark Struberg 8283ea0fb2 OPENJPA-2850 use VARBINARY(MAX) instead BLOB column type 2021-03-30 09:19:57 +02:00
Mark Struberg 9c9138603d OPENJPA-2814 fix mem leak in ForeignKey
detected by Gregory Jevardat, thanks!
2021-03-29 18:26:35 +02:00
Mark Struberg c7c13d3e8b OPENJPA-2848 duplicate DROP SEQUENCE stmt
txs to Christian Tu for the patch!
2021-03-28 19:58:28 +02:00
Enrico Olivelli 117f75ce0b fix checkstyle 2020-10-28 11:09:58 +01:00
Enrico Olivelli a998255a1e add test cases 2020-10-28 09:45:49 +01:00
Enrico Olivelli bb35ca7129 add test case and set supportsCascadeUpdateAction=false 2020-10-27 17:10:33 +01:00
Enrico Olivelli 02e91440e5 OPENJPA-2836 HerdDBDictionary: enable ForeignKeys and Unique Indexes 2020-10-27 14:51:18 +01:00
Romain Manni-Bucau 629ebaefce useless import 2020-10-01 10:52:41 +02:00
Romain Manni-Bucau 758b866706
Merge pull request #75 from eolivelli/fix/OPENJPA-2832
OPENJPA-2832 DROP COLUMN does not use delimiters and always add double quotes
2020-09-30 12:25:03 +02:00
Romain Manni-Bucau 049c2ef163
Merge pull request #71 from eolivelli/fix/OPENJPA-2820-delim
OPENJPA-2820 Track when a DBIdentifier is already delimited in order to save memory allocations and cpu
2020-09-30 12:24:21 +02:00
Enrico Olivelli 61f11a7088 add test 2020-09-28 18:12:03 +02:00
Enrico Olivelli b24a6a239c OPENJPA-2832 DROP COLUMN does not use delimiters and always add double quotes 2020-09-28 17:50:54 +02:00
Enrico Olivelli e95dbc8a0b add tests 2020-09-21 13:28:56 +02:00
Enrico Olivelli 963ed59ad4 remove useless conversion and extension point 2020-09-18 16:35:14 +02:00
Enrico Olivelli dd9bce0cc9 OPENJPA-2816 Add HerdDB DBDictionary - more fixes 2020-09-18 16:26:51 +02:00
Romain Manni-Bucau 33fc72ac85 [OPENJPA-2831] import [collections4] used classes and drop the dependency 2020-09-16 12:17:13 +02:00
Romain Manni-Bucau a38684b323 [OPENJPA-2830] ensure we don't drop a SQL statement when running action executeScript 2020-09-15 17:57:24 +02:00
Romain Manni-Bucau 8dbdc14321 [OPENJPA-2829] ensure empty lines are ignored for executeScript action 2020-09-15 16:57:43 +02:00
Mark Struberg f92c85314d OPENJPA-2795 add documentation and PostgreSQL support
Postgres also doesn't automatically create a foreign key index.
2020-08-31 16:09:17 +02:00
Robert Mayer c13f0b0e13 This fixes OPENJPA-2795 in that generation of indizes for @ManyToOne relations that are also foreign keys can optionally be turned on if so desired. Default behaviour of OpenJPA is unchanged.
This commit contains two new features:
1) A new DB-specific flag DBDictionary#indexPhysicalForeignKeys so that indices for foreign keys will be generated for
database systems that don't automatically create an index for foreign keys.
2) A new boolean property MappingDefaults.IndexPhysicalForeignKeys that will turn the feature from 1) on or off.
By default MappingDefaults.IndexPhysicalForeignKeys is false so that the feature from 1) is disabled.

Note: DBDictionary#indexPhysicalForeignKeys works similar to the pre-existing flag DBDictionary#indexLogicalForeignKeys.

Note: this commit enables FK indices for Oracle and MS SQLServer. Other database systems may benefit, too, and should also be changed.
2020-08-31 16:08:53 +02:00
Enrico Olivelli bc63cd2e45 OPENJPA-2820 2020-07-23 10:14:46 +02:00
Enrico Olivelli e3bb1f1657
OPENJPA-2818 DBDictionary > delimitIdentifiers = true does not work (#69) 2020-07-21 14:43:40 +02:00
Enrico Olivelli c93313767d OPENJPA-2816 Add HerdDB DBDictionary
- implement HerdDBDictionary
- add autodiscovery of HerdDB
2020-07-13 17:18:23 +02:00
Mark Struberg f18f28b633 [maven-release-plugin] prepare for next development iteration 2020-07-07 11:19:15 +02:00
Mark Struberg 66d2a72cb2 [maven-release-plugin] prepare release 3.1.2 2020-07-07 11:19:15 +02:00
Francesco Chicchiriccò 55e6829b1d Checking array size before access to avoid ArrayIndexOutOfBoundsException 2020-06-09 12:34:49 +02:00
Romain Manni-Bucau e721abfdaa ensure TestSnakeCaseDDL runs in enhanced mode otherwise there is an issue in column name uniqueness check + fixing MappingDefaultsImpl name definition 2020-05-07 10:02:45 +02:00
Romain Manni-Bucau d0875670dd OPENJPA-2812 snake_case support in dbdictionary for db column names 2020-04-29 20:47:28 +02:00
Romain Manni-Bucau bf418eb1b3 OPENJPA-2813 PersistenceProvider#generateSchema (misses the boolean state) 2020-04-29 20:47:12 +02:00
Mark Struberg ff2a1e6c1f OPENJPA-2807 trim spaces from column names
@Index(columnList="a, b, c") used to not trim the spaces.
Thus it was looking for a column "a ", "b " and "c " which obviously could
not be found.
2020-04-25 20:11:04 +02:00
Maxim Solodovnik 2a57904355 [OPENJPA-2810] try-with-resource to check jira-git integration 2020-04-25 05:32:35 +07:00
NeMuX 26b1f6be28
* Fixed bad return value in DBDictionary.getMinorVersion() (#61) 2020-04-22 09:14:22 +07:00
Maxim Solodovnik 44c4d8dc02 [OPENJPA-2798] Automatic-Module-Name is added 2020-03-15 15:59:45 +07:00
Mark Struberg 962cbbc624 Revert "[OPENJPA-2798] java11 friendly (#57)"
this introduces a dependency which requires attribution. No need to imo

This reverts commit 7ec0015edf.
2020-02-29 16:05:56 +01:00
Mark Struberg fd9585839a [maven-release-plugin] prepare for next development iteration 2020-02-14 12:12:11 +01:00
Mark Struberg 1440702eec [maven-release-plugin] prepare release 3.1.1 2020-02-14 12:12:01 +01:00
Maxim Solodovnik 7ec0015edf
[OPENJPA-2798] java11 friendly (#57)
* [OPENJPA-2798] geronimo-jpa_2.2_spec is replaced with jakarta.persistence, Automatic module names are added
2020-01-16 20:00:56 +07:00
Romain Manni-Bucau ef98e18480 OPENJPA-2743 skip AttributeConverter when loading the Metamodel and preparing the broker to avoid to fail if it was registered in persistent classes (allowed in JPA to bypass scanning but enable converters) 2019-07-29 17:40:09 +02:00
Will Dazey 389a82db97 OPENJPA-2767: Incomplete ValueMapDiscriminatorStrategy cache and MetaDataRepository race condition
Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
2019-05-14 15:25:43 -05:00
Mark Struberg 9f26ed29bf [maven-release-plugin] prepare for next development iteration 2019-04-10 20:13:15 +02:00
Mark Struberg afcec21a1d [maven-release-plugin] prepare release 3.1.0 2019-04-10 20:13:04 +02:00
Mark Struberg a7969c120b OPENJPA-2555 rename DBDictionary property to dateFractionDigits
dateFractionDigits is more self-explaning than defaultFractionDigits.
It also fits better into the already existing date* config settings.
2019-04-05 13:58:05 +02:00
Mark Struberg 4e59c48364 OPENJPA-2555 use a defaultFractionLength of 0 for backward compat
This is how the default of MySQL and the previous behaviour of OpenJPA did.
If a user want he can use either @Column(scale=n) or set it via DBDictionary:
openjpa.jdbc.DBDictionary=(defaultFractionLength=6)
2019-04-05 10:29:27 +02:00
Mark Struberg 14263ca52d OPENJPA-2775 improve JavaDoc for sub-second fractions 2019-04-02 22:53:17 +02:00
Mark Struberg 11cfff3f78 move to 3.1.0-SNAPSHOT as we upped the jpa-spec API to 2.2 2019-03-31 22:32:56 +02:00
Mark Struberg acf78d8091 OPENJPA-2713 fix wrong offset after daylight saving switched 2019-03-31 22:32:17 +02:00
Mark Struberg 53b946d9ca add deprecation info and clean up code
no functional change
2019-03-26 11:14:07 +01:00
Maxim Solodovnik cb20dd6b95
[OPENJPA-2777] Javax index (#39)
[OPENJPA-2777] javax.persistense.Index can be used on Table annotation
2019-03-05 20:44:49 +07:00
Mark Struberg 1690076b37 fix formatting and readability 2019-02-14 15:25:50 +01:00
Mark Struberg c1ae373a0f OPENJPA-2713 add java8 time api for SQLServer 2019-02-14 15:21:53 +01:00
Mark Struberg fa6ce77004 OPENJPA-2773 set dbcp defaults to align with commons dbcp
Especially the maxIdle=0 was problematic.
It effectively disables the whole pooling, which is counter productive.
2019-02-07 09:56:15 +01:00
Mark Struberg 037a2dc4c0 OPENJPA-2775 fix hsql metadata handling 2019-02-06 10:23:22 +01:00
Mark Struberg 11863ed932 OPENJPA-2772 update list of h2 resorved words 2019-02-02 13:48:22 +01:00
Mark Struberg af39516fc8 OPENJPA-2713 add java8 time support for h2 2019-02-02 13:04:15 +01:00
Mark Struberg 43aa42ccb5 OPENJPA-2771 fix h2 'unlimited' LIMIT case
With h2 one should omit the LIMIT section to get all results.
Our old LIMIT 0 did effectively prune the whole result list to zero entries.
2019-02-02 12:02:58 +01:00
Mark Struberg ad4ed02728 OPENJPA-2713 fix h2 2019-01-30 22:33:08 +01:00
Mark Struberg e82d1ec2fb OPENJPA-2713 remove left over in PostgresDictionary 2019-01-29 22:22:15 +01:00
Mark Struberg be62c5a123 OPENJPA-2713 add LocalDate support for Oracle DB
Oracle does still not support native LocalDate, etc in their JDBC driver.
So we have to treat it like the old datatypes.
2019-01-29 13:02:05 +01:00
Mark Struberg e908a9c293 formatting only 2019-01-28 13:01:16 +01:00
Mark Struberg fffc74f0a7 OPENJPA-2713 improve MariaDB Dictionary
Seems like MariaDB does still have quite a few problems in their JDBC driver.
I at least tried to iron out new functionality.
2019-01-28 13:00:05 +01:00
Mark Struberg 362474e5c9 OPENJPA-2713 add java8 time support for MySQL and MariaDB 2019-01-25 21:37:16 +01:00
Mark Struberg 6d2544f390 OPENJPA-2713 properly handle WITH TIME ZONE if supported by db
This includes handling the  new java.sql.Types.TIME_WITH_ZONE
and DATE_WITH_ZONE.
2019-01-25 16:42:15 +01:00
Mark Struberg dbfb360e85 OPENJPA-2713 add OffsetTime support
Works, but something is a bit fishy still.
2019-01-22 22:07:32 +01:00
Mark Struberg e57fd518b3 OPENJPA-2713 implement native java8 types
Since some DBs (e.g. PostgreSQL) do support LocalDate, etc
in their JDBC drivers, it's probably the best to support it
on a way deeper level.
2019-01-20 23:51:10 +01:00
Mark Struberg 89335fd48c OPENJPA-2713 add support for java.time.LocalDate
plus some cleanup
2019-01-20 14:49:20 +01:00
Mark Struberg aae0a95f6c OPENJPA-2761 properly handle javax.sql.Types.SQLXML 2019-01-10 13:29:49 +01:00
Mark Struberg bb6bad0702 OPENJPA-2753 add a profile for Oracle as Docker image
-Ptest-oracle-docker
as new profile to start Oracle 11_XE
2019-01-06 23:43:41 +01:00
Mark Struberg 6afab6486a OPENJPA-2754 re-enable dbcp2 auto detection 2019-01-03 00:13:59 +01:00
Maxim Solodovnik d874cbf6d3
[OPENJPA-2754] maxActive -> maxTotal (#24)
* [OPENJPA-2754] maxActive -> maxTotal

* commons-pool2 and commons-dbcp2 versions are updated, setMaxActive is deprecated with warn being logged

* DBCPDriverDataSource and AutoDriverDataSource are removed

* BasicDataSource is being loaded in case jdbc.DriverDataSource is set to 'dbcp'

* Normal call is replaced with reflection
2018-11-16 13:48:40 +07:00
Mark Struberg db6f6b6422 OPENJPA-2756 escape search strings for all Postgres versions
Can be disabled via config by explicitly setting the
DBDictionary to requiresSearchStringEscapeForLike=false
via persistence.xml for example.
2018-11-10 20:47:09 +01:00
Mark Struberg 0530b5b72b OPENJPA-2755 OPENJPA-2555 support fractions of a second
For now just in MySQL. Should also get added to PostgreSQL.
Txs also to Ancoron Luciferis for a patch which also
gave some important input!
2018-11-01 21:06:41 +01:00
Mark Struberg 3b4c2e6f42 OPENJPA-2755 OPENJPA-2555 use scale to set Date fractions 2018-11-01 14:20:49 +01:00
Mark Struberg 9461ffdfcd OPENJPA-2775 OPENJPA-2555 fraction of seconds in MySQL
This is a first fix for supporting fractions of a second in MySQL.
2018-10-31 20:51:31 +01:00
Mark Struberg 73582cc780 move tests to junit4 style 2018-10-22 13:25:07 +02:00
Maxim Solodovnik 9a5096308c [OPENJPA-2752] libraries are updated to most recent versions 2018-10-18 12:38:31 +07:00
Maxim Solodovnik e25438a174 [OPENJPA-2751] imports, @Overrides and @Deprecated are organized, redundant type arguments and unnecessary casts are removed
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1842686 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 08:11:59 +00:00
Maxim Solodovnik f2fc98031e [OPENJPA-2751] trailing white-spaces were removed
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1842614 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 12:32:32 +00:00
Maxim Solodovnik 4709f38ba2 [OPENJPA-2748] commons-collection is updated to most recent version
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1841941 13f79535-47bb-0310-9956-ffa450edef68
2018-09-25 15:16:54 +00:00
Francesco Chicchiriccò f399f912cf [OPENJPA-2750] Commons dbcp is updated to latest version - thx @solomax - This closes #22
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1841800 13f79535-47bb-0310-9956-ffa450edef68
2018-09-24 06:41:20 +00:00
Francesco Chicchiriccò 9a98d6a2bf [OPENJPA-2567] various MySql and MariaDB text types support is added - thanks @solomax - This closes #18
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1839940 13f79535-47bb-0310-9956-ffa450edef68
2018-09-03 11:41:07 +00:00
Will Dazey c79c09ac39 OPENJPA-2745: Clean up try-catch implementation for DB2Dictionary
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1837662 13f79535-47bb-0310-9956-ffa450edef68
2018-08-08 16:59:04 +00:00
Will Dazey 4477ace6fd OPENJPA-2704: The openjpa.jdbc.Schema no longer overrides orm.xml default
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1834900 13f79535-47bb-0310-9956-ffa450edef68
2018-07-02 21:07:29 +00:00
Francesco Chicchiriccò 0303fb28f8 [OPENPJA-2742] Rollback before DDL can be disabled - default behavior is kept
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1834818 13f79535-47bb-0310-9956-ffa450edef68
2018-07-02 06:06:45 +00:00
Mark Struberg ffe3fe4a50 [maven-release-plugin] prepare for next development iteration
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1833210 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 20:34:53 +00:00
Mark Struberg 101ee9946a [maven-release-plugin] prepare release openjpa-parent-3.0.0
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1833208 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 20:34:24 +00:00
Will Dazey 8be86a6903 OPENJPA-2646: Sporadic NullPointerException and ClassCastException caused by query cache misses in multithreaded environments.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1831596 13f79535-47bb-0310-9956-ffa450edef68
2018-05-14 22:25:05 +00:00
Francesco Chicchiriccò 778e8e9449 [OPENJPA-2598] Applying provided patch
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1806888 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 06:38:48 +00:00
Jody Grassel 5c94a7ff67 OPENJPA-2705: ArrayOutOfBoundsException occurs with an @EmbeddedId (commit on wdazeys behalf)
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1802529 13f79535-47bb-0310-9956-ffa450edef68
2017-07-20 20:11:40 +00:00
Christian Schneider 49c1478cf3 [OPENJPA-2690] Update OSGi Import-Package to support Oracle CLOB/BLOB
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1786518 13f79535-47bb-0310-9956-ffa450edef68
2017-03-11 18:20:01 +00:00
Mark Struberg 8567a5e5c2 OPENJPA-2689 prevent IllegalArgumentException with package scoped OraclePreparedStatementWrapper classes
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1784577 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 15:00:22 +00:00
Romain Manni-Bucau af8ea38f87 OPENJPA-2554 JPA 2.1 - Schema Generation, patch from Roberto Cortez, doc to update still
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1770509 13f79535-47bb-0310-9956-ffa450edef68
2016-11-19 18:08:44 +00:00
Mark Struberg bdc1da9423 OPENJPA use Locale.ENGLISH for toLowerCase and toUperCase where possible
* we now use fixed english Locale for 'framework parts' which are by spec portable
* we do NOT yet use a fixed Locale for anything related to column or table names!

txs to Kaloyan Spiridonov for the catch!



git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1768216 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 13:46:23 +00:00