Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix some SpotBugs reports 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898383 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2022-02-24 18:12:25 +00:00
parent bb18d585f8
commit 25769795de
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
poi-integration/src/test/java/org/apache/poi/stress/AbstractFileHandler.java
View File

@ -44,7 +44,8 @@ import org.apache.poi.util.IOUtils;
* in the integration tests, mostly text-extraction related at the moment.
*/
public abstract class AbstractFileHandler implements FileHandler {
public static final Set<String> EXPECTED_EXTRACTOR_FAILURES = new HashSet<>(Arrays.asList(
// some FileHandlers extend this list!?!
protected static final Set<String> EXPECTED_EXTRACTOR_FAILURES = new HashSet<>(Arrays.asList(
// password protected files without password
// ... currently none ...

5
poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java
View File

@ -18,7 +18,7 @@ package org.apache.poi.stress;
import java.io.File;
import java.io.InputStream;
import java.util.function.Supplier;
import java.lang.reflect.InvocationTargetException;
@SuppressWarnings("unused")
public enum FileHandlerKnown {
@ -46,7 +46,8 @@ public enum FileHandlerKnown {
// Because of no-scratchpad handling, we need to resort to reflection here
String n = name().replace("NULL", "Null");
return (FileHandler)Class.forName("org.apache.poi.stress." + n + "FileHandler").getDeclaredConstructor().newInstance();
} catch (Exception e) {
} catch (RuntimeException | ClassNotFoundException | NoSuchMethodException | InstantiationException |
IllegalAccessException | InvocationTargetException e) {
return new NullFileHandler();
}
}