Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rework test somewhat and enable logger to better indicate if the test is 

failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2018-12-19 10:22:01 +00:00
parent ad6440e181
commit 4199a2f0a3
1 changed files with 202 additions and 202 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

336
src/testcases/org/apache/poi/hpsf/basic/TestWrite.java
View File

@ -61,15 +61,17 @@ import org.apache.poi.poifs.eventfilesystem.POIFSReader;
import org.apache.poi.poifs.eventfilesystem.POIFSReaderEvent; import org.apache.poi.poifs.eventfilesystem.POIFSReaderEvent;
import org.apache.poi.poifs.eventfilesystem.POIFSReaderListener; import org.apache.poi.poifs.eventfilesystem.POIFSReaderListener;
import org.apache.poi.poifs.filesystem.DirectoryEntry; import org.apache.poi.poifs.filesystem.DirectoryEntry;
import org.apache.poi.poifs.filesystem.DocumentNode;
import org.apache.poi.poifs.filesystem.DocumentInputStream; import org.apache.poi.poifs.filesystem.DocumentInputStream;
import org.apache.poi.poifs.filesystem.DocumentNode;
import org.apache.poi.poifs.filesystem.DocumentOutputStream; import org.apache.poi.poifs.filesystem.DocumentOutputStream;
import org.apache.poi.poifs.filesystem.POIFSDocument; import org.apache.poi.poifs.filesystem.POIFSDocument;
import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.apache.poi.poifs.filesystem.POIFSFileSystem;
import org.apache.poi.util.CodePageUtil; import org.apache.poi.util.CodePageUtil;
import org.apache.poi.util.CommonsLogger;
import org.apache.poi.util.IOUtils; import org.apache.poi.util.IOUtils;
import org.apache.poi.util.LittleEndianConsts; import org.apache.poi.util.LittleEndianConsts;
import org.apache.poi.util.TempFile; import org.apache.poi.util.TempFile;
import org.junit.AfterClass;
import org.junit.Assume; import org.junit.Assume;
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Test; import org.junit.Test;
@ -91,11 +93,28 @@ public class TestWrite {
"LANG environment variable to a proper value, e.g. " + "LANG environment variable to a proper value, e.g. " +
"\"de_DE\"."; "\"de_DE\".";
private static String loggerBefore;
@BeforeClass @BeforeClass
public static void setUp() { public static void setUpClass() {
loggerBefore = System.getProperty("org.apache.poi.util.POILogger");
// this test may fails in newer JDKs because of disallowed access if
// properties are missing, make this visible
System.setProperty("org.apache.poi.util.POILogger", CommonsLogger.class.getName());
VariantSupport.setLogUnsupportedTypes(false); VariantSupport.setLogUnsupportedTypes(false);
} }
@AfterClass
public static void tearDownClass() {
if(loggerBefore == null) {
System.clearProperty("org.apache.poi.util.POILogger");
} else {
System.setProperty("org.apache.poi.util.POILogger", loggerBefore);
}
}
/** /**
* <p>Writes an empty property set to a POIFS and reads it back * <p>Writes an empty property set to a POIFS and reads it back
* in.</p> * in.</p>
@ -164,8 +183,6 @@ public class TestWrite {
r.read(filename); r.read(filename);
} }
/** /**
* <p>Writes a simple property set with a SummaryInformation section to a * <p>Writes a simple property set with a SummaryInformation section to a
* POIFS and reads it back in.</p> * POIFS and reads it back in.</p>
@ -295,7 +312,6 @@ public class TestWrite {
} }
static class MyPOIFSReaderListener implements POIFSReaderListener { static class MyPOIFSReaderListener implements POIFSReaderListener {
@Override @Override
public void processPOIFSReaderEvent(final POIFSReaderEvent event) { public void processPOIFSReaderEvent(final POIFSReaderEvent event) {
@ -307,8 +323,6 @@ public class TestWrite {
} }
} }
/** /**
* Writes and reads back various variant types and checks whether the * Writes and reads back various variant types and checks whether the
* stuff that has been read back equals the stuff that was written. * stuff that has been read back equals the stuff that was written.
@ -486,219 +500,205 @@ public class TestWrite {
*/ */
@Test @Test
public void inPlaceNPOIFSWrite() throws Exception { public void inPlaceNPOIFSWrite() throws Exception {
POIFSFileSystem fs;
DirectoryEntry root;
DocumentNode sinfDoc;
DocumentNode dinfDoc;
SummaryInformation sinf;
DocumentSummaryInformation dinf;
// We need to work on a File for in-place changes, so create a temp one // We need to work on a File for in-place changes, so create a temp one
final File copy = TempFile.createTempFile("Test-HPSF", "ole2"); final File copy = TempFile.createTempFile("Test-HPSF", "ole2");
copy.deleteOnExit(); copy.deleteOnExit();
// Copy a test file over to our temp location // Copy a test file over to our temp location
InputStream inp = _samples.openResourceAsStream("TestShiftJIS.doc"); try (FileOutputStream out = new FileOutputStream(copy);
FileOutputStream out = new FileOutputStream(copy); InputStream inp = _samples.openResourceAsStream("TestShiftJIS.doc")) {
IOUtils.copy(inp, out); IOUtils.copy(inp, out);
inp.close(); }
out.close();
// Open the copy in read/write mode // Open the copy in read/write mode
fs = new POIFSFileSystem(copy, false); try (POIFSFileSystem fs = new POIFSFileSystem(copy, false)) {
root = fs.getRoot(); DirectoryEntry root = fs.getRoot();
// Read the properties in there
DocumentNode sinfDoc = (DocumentNode) root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
DocumentNode dinfDoc = (DocumentNode) root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream = new DocumentInputStream(sinfDoc);
SummaryInformation sinf = (SummaryInformation) PropertySetFactory.create(sinfStream);
sinfStream.close();
assertEquals(131077, sinf.getOSVersion());
InputStream dinfStream = new DocumentInputStream(dinfDoc);
DocumentSummaryInformation dinf = (DocumentSummaryInformation) PropertySetFactory.create(dinfStream);
dinfStream.close();
assertEquals(131077, dinf.getOSVersion());
// Read the properties in there // Check they start as we expect
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME); assertEquals("Reiichiro Hori", sinf.getAuthor());
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME); assertEquals("Microsoft Word 9.0", sinf.getApplicationName());
assertEquals("\u7b2c1\u7ae0", sinf.getTitle());
InputStream sinfStream = new DocumentInputStream(sinfDoc); assertEquals("", dinf.getCompany());
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream); assertNull(dinf.getManager());
sinfStream.close();
assertEquals(131077, sinf.getOSVersion());
InputStream dinfStream = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream);
dinfStream.close();
assertEquals(131077, dinf.getOSVersion());
// Check they start as we expect // Do an in-place replace via an InputStream
assertEquals("Reiichiro Hori", sinf.getAuthor()); assertNotNull(sinfDoc);
assertEquals("Microsoft Word 9.0", sinf.getApplicationName()); assertNotNull(dinfDoc);
assertEquals("\u7b2c1\u7ae0", sinf.getTitle());
assertEquals("", dinf.getCompany()); new POIFSDocument(sinfDoc).replaceContents(sinf.toInputStream());
assertNull(dinf.getManager()); new POIFSDocument(dinfDoc).replaceContents(dinf.toInputStream());
// Do an in-place replace via an InputStream // Check it didn't get changed
assertNotNull(sinfDoc); sinfDoc = (DocumentNode) root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
assertNotNull(dinfDoc); dinfDoc = (DocumentNode) root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
new POIFSDocument(sinfDoc).replaceContents(sinf.toInputStream()); InputStream sinfStream2 = new DocumentInputStream(sinfDoc);
new POIFSDocument(dinfDoc).replaceContents(dinf.toInputStream()); sinf = (SummaryInformation) PropertySetFactory.create(sinfStream2);
sinfStream2.close();
assertEquals(131077, sinf.getOSVersion());
// Check it didn't get changed
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream2 = new DocumentInputStream(sinfDoc);
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream2);
sinfStream2.close();
assertEquals(131077, sinf.getOSVersion());
InputStream dinfStream2 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream2);
dinfStream2.close();
assertEquals(131077, dinf.getOSVersion());
InputStream dinfStream2 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation) PropertySetFactory.create(dinfStream2);
dinfStream2.close();
assertEquals(131077, dinf.getOSVersion());
}
// Start again! // Start again!
fs.close(); try (FileOutputStream out = new FileOutputStream(copy);
inp = _samples.openResourceAsStream("TestShiftJIS.doc"); InputStream inp = _samples.openResourceAsStream("TestShiftJIS.doc")) {
out = new FileOutputStream(copy); IOUtils.copy(inp, out);
IOUtils.copy(inp, out); }
inp.close();
out.close();
fs = new POIFSFileSystem(copy, false); try (POIFSFileSystem fs = new POIFSFileSystem(copy, false)) {
root = fs.getRoot(); DirectoryEntry root = fs.getRoot();
// Read the properties in once more // Read the properties in once more
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME); DocumentNode sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME); DocumentNode dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream3 = new DocumentInputStream(sinfDoc); InputStream sinfStream3 = new DocumentInputStream(sinfDoc);
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream3); SummaryInformation sinf = (SummaryInformation)PropertySetFactory.create(sinfStream3);
sinfStream3.close(); sinfStream3.close();
assertEquals(131077, sinf.getOSVersion()); assertEquals(131077, sinf.getOSVersion());
InputStream dinfStream3 = new DocumentInputStream(dinfDoc); InputStream dinfStream3 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream3); DocumentSummaryInformation dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream3);
dinfStream3.close(); dinfStream3.close();
assertEquals(131077, dinf.getOSVersion()); assertEquals(131077, dinf.getOSVersion());
// Have them write themselves in-place with no changes, as an OutputStream // Have them write themselves in-place with no changes, as an OutputStream
OutputStream soufStream = new DocumentOutputStream(sinfDoc); OutputStream soufStream = new DocumentOutputStream(sinfDoc);
sinf.write(soufStream); sinf.write(soufStream);
soufStream.close(); soufStream.close();
OutputStream doufStream = new DocumentOutputStream(dinfDoc); OutputStream doufStream = new DocumentOutputStream(dinfDoc);
dinf.write(doufStream); dinf.write(doufStream);
doufStream.close(); doufStream.close();
// And also write to some bytes for checking // And also write to some bytes for checking
ByteArrayOutputStream sinfBytes = new ByteArrayOutputStream(); ByteArrayOutputStream sinfBytes = new ByteArrayOutputStream();
sinf.write(sinfBytes); sinf.write(sinfBytes);
ByteArrayOutputStream dinfBytes = new ByteArrayOutputStream(); ByteArrayOutputStream dinfBytes = new ByteArrayOutputStream();
dinf.write(dinfBytes); dinf.write(dinfBytes);
// Check that the filesystem can give us back the same bytes // Check that the filesystem can give us back the same bytes
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME); sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME); dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream4 = new DocumentInputStream(sinfDoc); InputStream sinfStream4 = new DocumentInputStream(sinfDoc);
byte[] sinfData = IOUtils.toByteArray(sinfStream4); byte[] sinfData = IOUtils.toByteArray(sinfStream4);
sinfStream4.close(); sinfStream4.close();
InputStream dinfStream4 = new DocumentInputStream(dinfDoc); InputStream dinfStream4 = new DocumentInputStream(dinfDoc);
byte[] dinfData = IOUtils.toByteArray(dinfStream4); byte[] dinfData = IOUtils.toByteArray(dinfStream4);
dinfStream4.close(); dinfStream4.close();
assertThat(sinfBytes.toByteArray(), equalTo(sinfData)); assertThat(sinfBytes.toByteArray(), equalTo(sinfData));
assertThat(dinfBytes.toByteArray(), equalTo(dinfData)); assertThat(dinfBytes.toByteArray(), equalTo(dinfData));
// Read back in as-is // Read back in as-is
InputStream sinfStream5 = new DocumentInputStream(sinfDoc); InputStream sinfStream5 = new DocumentInputStream(sinfDoc);
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream5); sinf = (SummaryInformation)PropertySetFactory.create(sinfStream5);
sinfStream5.close(); sinfStream5.close();
assertEquals(131077, sinf.getOSVersion()); assertEquals(131077, sinf.getOSVersion());
InputStream dinfStream5 = new DocumentInputStream(dinfDoc); InputStream dinfStream5 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream5); dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream5);
dinfStream5.close(); dinfStream5.close();
assertEquals(131077, dinf.getOSVersion()); assertEquals(131077, dinf.getOSVersion());
assertEquals("Reiichiro Hori", sinf.getAuthor()); assertEquals("Reiichiro Hori", sinf.getAuthor());
assertEquals("Microsoft Word 9.0", sinf.getApplicationName()); assertEquals("Microsoft Word 9.0", sinf.getApplicationName());
assertEquals("\u7b2c1\u7ae0", sinf.getTitle()); assertEquals("\u7b2c1\u7ae0", sinf.getTitle());
assertEquals("", dinf.getCompany()); assertEquals("", dinf.getCompany());
assertNull(dinf.getManager()); assertNull(dinf.getManager());
// Now alter a few of them // Now alter a few of them
sinf.setAuthor("Changed Author"); sinf.setAuthor("Changed Author");
sinf.setTitle("Le titre \u00e9tait chang\u00e9"); sinf.setTitle("Le titre \u00e9tait chang\u00e9");
dinf.setManager("Changed Manager"); dinf.setManager("Changed Manager");
// Save this into the filesystem // Save this into the filesystem
OutputStream soufStream2 = new DocumentOutputStream(sinfDoc); OutputStream soufStream2 = new DocumentOutputStream(sinfDoc);
sinf.write(soufStream2); sinf.write(soufStream2);
soufStream2.close(); soufStream2.close();
OutputStream doufStream2 = new DocumentOutputStream(dinfDoc); OutputStream doufStream2 = new DocumentOutputStream(dinfDoc);
dinf.write(doufStream2); dinf.write(doufStream2);
doufStream2.close(); doufStream2.close();
// Read them back in again // Read them back in again
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME); sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream6 = new DocumentInputStream(sinfDoc); InputStream sinfStream6 = new DocumentInputStream(sinfDoc);
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream6); sinf = (SummaryInformation)PropertySetFactory.create(sinfStream6);
sinfStream6.close(); sinfStream6.close();
assertEquals(131077, sinf.getOSVersion()); assertEquals(131077, sinf.getOSVersion());
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME); dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream dinfStream6 = new DocumentInputStream(dinfDoc); InputStream dinfStream6 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream6); dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream6);
dinfStream6.close(); dinfStream6.close();
assertEquals(131077, dinf.getOSVersion()); assertEquals(131077, dinf.getOSVersion());
assertEquals("Changed Author", sinf.getAuthor()); assertEquals("Changed Author", sinf.getAuthor());
assertEquals("Microsoft Word 9.0", sinf.getApplicationName()); assertEquals("Microsoft Word 9.0", sinf.getApplicationName());
assertEquals("Le titre \u00e9tait chang\u00e9", sinf.getTitle()); assertEquals("Le titre \u00e9tait chang\u00e9", sinf.getTitle());
assertEquals("", dinf.getCompany()); assertEquals("", dinf.getCompany());
assertEquals("Changed Manager", dinf.getManager()); assertEquals("Changed Manager", dinf.getManager());
// Close the whole filesystem, and open it once more // Close the whole filesystem, and open it once more
fs.writeFilesystem(); fs.writeFilesystem();
fs.close(); }
fs = new POIFSFileSystem(copy); try (POIFSFileSystem fs = new POIFSFileSystem(copy)) {
root = fs.getRoot(); DirectoryEntry root = fs.getRoot();
// Re-check on load // Re-check on load
sinfDoc = (DocumentNode)root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME); DocumentNode sinfDoc = (DocumentNode) root.getEntry(SummaryInformation.DEFAULT_STREAM_NAME);
InputStream sinfStream7 = new DocumentInputStream(sinfDoc); InputStream sinfStream7 = new DocumentInputStream(sinfDoc);
sinf = (SummaryInformation)PropertySetFactory.create(sinfStream7); SummaryInformation sinf = (SummaryInformation) PropertySetFactory.create(sinfStream7);
sinfStream7.close(); sinfStream7.close();
assertEquals(131077, sinf.getOSVersion()); assertEquals(131077, sinf.getOSVersion());
dinfDoc = (DocumentNode)root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME); DocumentNode dinfDoc = (DocumentNode) root.getEntry(DocumentSummaryInformation.DEFAULT_STREAM_NAME);
InputStream dinfStream7 = new DocumentInputStream(dinfDoc); InputStream dinfStream7 = new DocumentInputStream(dinfDoc);
dinf = (DocumentSummaryInformation)PropertySetFactory.create(dinfStream7); DocumentSummaryInformation dinf = (DocumentSummaryInformation) PropertySetFactory.create(dinfStream7);
dinfStream7.close(); dinfStream7.close();
assertEquals(131077, dinf.getOSVersion()); assertEquals(131077, dinf.getOSVersion());
assertEquals("Changed Author", sinf.getAuthor()); assertEquals("Changed Author", sinf.getAuthor());
assertEquals("Microsoft Word 9.0", sinf.getApplicationName()); assertEquals("Microsoft Word 9.0", sinf.getApplicationName());
assertEquals("Le titre \u00e9tait chang\u00e9", sinf.getTitle()); assertEquals("Le titre \u00e9tait chang\u00e9", sinf.getTitle());
assertEquals("", dinf.getCompany());
assertEquals("Changed Manager", dinf.getManager());
assertEquals("", dinf.getCompany());
assertEquals("Changed Manager", dinf.getManager());
}
// Tidy up // Tidy up
fs.close(); assertTrue(copy.delete());
//noinspection ResultOfMethodCallIgnored
copy.delete();
} }