mirror of https://github.com/apache/poi.git
code cleanup as suggested in Bugzilla 50446
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1044405 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Yegor Kozlov
parent
574810c8aa
commit
544463463a
|
|
@ -34,6 +34,7 @@
|
|||
|
||||
<changes>
|
||||
<release version="3.8-beta1" date="2010-??-??">
|
||||
<action dev="POI-DEVELOPERS" type="add">50446 - Code cleanup and optimizations to keep some IDE quiet</action>
|
||||
<action dev="POI-DEVELOPERS" type="add">50437 - Support passing ranges to NPV()</action>
|
||||
<action dev="POI-DEVELOPERS" type="add">50409 - Added implementation for IRR()</action>
|
||||
<action dev="poi-developers" type="add">47405 - Improved performance of RowRecordsAggregate.getStartRowNumberForBlock / getEndRowNumberForBlock</action>
|
||||
|
|
|
|||
|
|
@ -38,7 +38,6 @@ final class SSTSerializer {
|
|||
private final int[] bucketAbsoluteOffsets;
|
||||
/** Offsets relative the start of the current SST or continue record */
|
||||
private final int[] bucketRelativeOffsets;
|
||||
int startOfSST, startOfRecord;
|
||||
|
||||
public SSTSerializer( IntMapper<UnicodeString> strings, int numStrings, int numUniqueStrings )
|
||||
{
|
||||
|
|
|
|||
|
|
@ -266,7 +266,7 @@ public class UnicodeString implements Comparable<UnicodeString> { // TODO - make
|
|||
ext.formattingFontIndex = formattingFontIndex;
|
||||
ext.formattingOptions = formattingOptions;
|
||||
ext.numberOfRuns = numberOfRuns;
|
||||
ext.phoneticText = new String(phoneticText);
|
||||
ext.phoneticText = phoneticText;
|
||||
ext.phRuns = new PhRun[phRuns.length];
|
||||
for(int i=0; i<ext.phRuns.length; i++) {
|
||||
ext.phRuns[i] = new PhRun(
|
||||
|
|
|
|||
|
|
@ -308,7 +308,7 @@ public final class EscherGraphics2d extends Graphics2D {
|
|||
|
||||
public void drawString(AttributedCharacterIterator attributedcharacteriterator, int x, int y)
|
||||
{
|
||||
drawString(attributedcharacteriterator, x, y);
|
||||
getEscherGraphics().drawString(attributedcharacteriterator, x, y);
|
||||
}
|
||||
|
||||
public void fill(Shape shape)
|
||||
|
|
|
|||
|
|
@ -57,7 +57,7 @@ public class FontDetails
|
|||
|
||||
public void addChar( char c, int width )
|
||||
{
|
||||
charWidths.put(new Character(c), Integer.valueOf(width));
|
||||
charWidths.put(Character.valueOf(c), Integer.valueOf(width));
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
@ -67,7 +67,7 @@ public class FontDetails
|
|||
*/
|
||||
public int getCharWidth( char c )
|
||||
{
|
||||
Integer widthInteger = charWidths.get(new Character(c));
|
||||
Integer widthInteger = charWidths.get(Character.valueOf(c));
|
||||
if (widthInteger == null && c != 'W') {
|
||||
return getCharWidth('W');
|
||||
}
|
||||
|
|
@ -78,7 +78,7 @@ public class FontDetails
|
|||
{
|
||||
for ( int i = 0; i < characters.length; i++ )
|
||||
{
|
||||
charWidths.put( new Character(characters[i]), Integer.valueOf(widths[i]));
|
||||
charWidths.put( Character.valueOf(characters[i]), Integer.valueOf(widths[i]));
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -123,7 +123,7 @@ public class POIFSHeaderDumper {
|
|||
gbm.setAccessible(true);
|
||||
|
||||
for(int i=0; i<Math.min(16, data_blocks.blockCount()); i++) {
|
||||
ListManagedBlock block = (ListManagedBlock)gbm.invoke(data_blocks, new Integer(i));
|
||||
ListManagedBlock block = (ListManagedBlock)gbm.invoke(data_blocks, Integer.valueOf(i));
|
||||
byte[] data = new byte[Math.min(48, block.getData().length)];
|
||||
System.arraycopy(block.getData(), 0, data, 0, data.length);
|
||||
|
||||
|
|
|
|||
|
|
@ -610,7 +610,7 @@ public abstract class POILogger {
|
|||
|
||||
for (int j = 0; j < array.length; j++)
|
||||
{
|
||||
results.add(new Character(array[ j ]));
|
||||
results.add(Character.valueOf(array[ j ]));
|
||||
}
|
||||
}
|
||||
else if (object instanceof short [])
|
||||
|
|
|
|||
|
|
@ -383,7 +383,7 @@ public final class TestMetaDataIPI extends TestCase{
|
|||
j += 33;
|
||||
// System.out.println(j);
|
||||
sb.append(">");
|
||||
sb.append(new Character(j));
|
||||
sb.append(Character.valueOf(j));
|
||||
sb.append("=");
|
||||
sb.append(umlaute[rand.nextInt(umlaute.length)]);
|
||||
sb.append("<");
|
||||
|
|
@ -509,7 +509,7 @@ public final class TestMetaDataIPI extends TestCase{
|
|||
j += 33;
|
||||
// System.out.println(j);
|
||||
sb.append(">");
|
||||
sb.append(new Character(j));
|
||||
sb.append(Character.valueOf(j));
|
||||
sb.append("=");
|
||||
sb.append(umlaute[rand.nextInt(umlaute.length)]);
|
||||
sb.append("<");
|
||||
|
|
|
|||
|
|
@ -63,7 +63,7 @@ public class NumberRenderingSpreadsheetGenerator {
|
|||
public void addTestRow(long rawBits, String expectedExcelRendering) {
|
||||
writeDataRow(_sheet, _rowIndex++, rawBits, expectedExcelRendering);
|
||||
if(Double.isNaN(Double.longBitsToDouble(rawBits))) {
|
||||
_replacementNaNs.add(new Long(rawBits));
|
||||
_replacementNaNs.add(Long.valueOf(rawBits));
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -37,10 +37,10 @@ public class DummyPOILogger extends POILogger {
|
|||
public void initialize(String cat) {}
|
||||
|
||||
public void log(int level, Object obj1) {
|
||||
logged.add(new String(level + " - " + obj1));
|
||||
logged.add(level + " - " + obj1);
|
||||
}
|
||||
|
||||
public void log(int level, Object obj1, Throwable exception) {
|
||||
logged.add(new String(level + " - " + obj1 + " - " + exception));
|
||||
logged.add(level + " - " + obj1 + " - " + exception);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue