Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

put back the goto - it is terrible but poi-integration tests hang without it 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893604 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2021-09-24 16:43:44 +00:00
parent cabc8a425c
commit 5fc9d20be7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
poi/src/main/java/org/apache/poi/hssf/usermodel/HeaderFooter.java
View File

@ -40,6 +40,10 @@ public abstract class HeaderFooter implements org.apache.poi.ss.usermodel.Header
String _center = "";
String _right = "";
// FIXME: replace outer goto. just eww.
// no unit tests test the goto loop but poi-integration tests hangs if you remove it
// (some file has an edge case header or footer)
outer:
while (text.length() > 1) {
if (text.charAt(0) != '&') {
// Mimics the behaviour of Excel, which would put it in the center.
@ -81,7 +85,7 @@ public abstract class HeaderFooter implements org.apache.poi.ss.usermodel.Header
default:
// Mimics the behaviour of Excel, which would put it in the center.
_center = text;
break;
break outer;
}
}
return new String[] { _left, _center, _right, };
@ -344,4 +348,4 @@ public abstract class HeaderFooter implements org.apache.poi.ss.usermodel.Header
return _occursInPairs;
}
}
}
}