From 69aaedd60f972070f9876cf8ae8c832498dbfbae Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 16 Jul 2020 07:33:31 +0000 Subject: [PATCH] fix some tests git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879927 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java | 2 -- .../xssf/eventusermodel/TestReadOnlySharedStringsTable.java | 3 +-- .../org/apache/poi/xssf/model/TestSharedStringsTable.java | 2 -- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java b/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java index c32c41fa1f..35802f3077 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java @@ -37,8 +37,6 @@ public class TestXSSFBSharedStringsTable { assertEquals(1, parts.size()); XSSFBSharedStringsTable rtbl = new XSSFBSharedStringsTable(parts.get(0)); - //TODO fix - //assertEquals(49, rtbl.getCount()); assertEquals("\u30B3\u30E1\u30F3\u30C8", rtbl.getItemAt(0).getString()); assertEquals("\u65E5\u672C\u30AA\u30E9\u30AF\u30EB", rtbl.getItemAt(3).getString()); diff --git a/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java b/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java index 6f01c8f6ed..05f0295658 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java @@ -58,8 +58,7 @@ public final class TestReadOnlySharedStringsTable { for (int i = 0; i < stbl.getUniqueCount(); i++) { RichTextString i1 = stbl.getItemAt(i); RichTextString i2 = rtbl.getItemAt(i); - //TODO follow up fix - //assertEquals(i1.getString(), i2.getString()); + assertEquals(i1.getString(), i2.getString()); } } } diff --git a/src/ooxml/testcases/org/apache/poi/xssf/model/TestSharedStringsTable.java b/src/ooxml/testcases/org/apache/poi/xssf/model/TestSharedStringsTable.java index cc169c59ba..352b94ba2c 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/model/TestSharedStringsTable.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/model/TestSharedStringsTable.java @@ -109,8 +109,6 @@ public final class TestSharedStringsTable { assertEquals(3, sst.getUniqueCount()); //OK. the sst table is filled, check the contents - //TODO fix - //assertEquals(3, sst.getCount()); assertEquals("Hello, World!", sst.getItemAt(0).toString()); assertEquals("Second string", sst.getItemAt(1).toString()); assertEquals("Second string", sst.getItemAt(2).toString());