Apache/poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2025-02-22 01:55:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

[bug-66532] more performant way to iterate over codepoints.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1908479 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2023-03-18 10:27:37 +00:00
parent ef82364bde
commit 6e244845e5
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
poi/src/main/java/org/apache/poi/ss/format/CellElapsedFormatter.java
View File

@ -166,7 +166,7 @@ public class CellElapsedFormatter extends CellFormatter {
return SEC__FACTOR / Math.pow(10, len);
default:
throw new IllegalArgumentException(
"Uknown elapsed time spec: " + type);
"Unknown elapsed time spec: " + type);
}
}

18
poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java
View File

@ -342,9 +342,6 @@ public class CellFormatPart {
Iterator<String> codePoints = CodepointsUtil.iteratorFor(repl);
if (codePoints.hasNext()) {
String c1 = codePoints.next();
String c2 = null;
if (codePoints.hasNext())
c2 = codePoints.next().toLowerCase(Locale.ROOT);
switch (c1) {
case "@":
@ -368,6 +365,9 @@ public class CellFormatPart {
seenZero = true;
break;
case "[":
String c2 = null;
if (codePoints.hasNext())
c2 = codePoints.next().toLowerCase(Locale.ROOT);
if ("h".equals(c2) || "m".equals(c2) || "s".equals(c2)) {
return CellFormatType.ELAPSED;
}
@ -407,19 +407,21 @@ public class CellFormatPart {
*/
static String quoteSpecial(String repl, CellFormatType type) {
StringBuilder sb = new StringBuilder();
Iterator<String> codePoints = CodepointsUtil.iteratorFor(repl);
PrimitiveIterator.OfInt codePoints = CodepointsUtil.primitiveIterator(repl);
int codepoint;
while (codePoints.hasNext()) {
String ch = codePoints.next();
if ("'".equals(ch) && type.isSpecial('\'')) {
codepoint = codePoints.nextInt();
if (codepoint == '\'' && type.isSpecial('\'')) {
sb.append('\u0000');
continue;
}
boolean special = type.isSpecial(ch.charAt(0));
char[] chars = Character.toChars(codepoint);
boolean special = type.isSpecial(chars[0]);
if (special)
sb.append('\'');
sb.append(ch);
sb.append(chars);
if (special)
sb.append('\'');
}