From 79caf82ae03f92e8a61f0a2c2fca8e998da282a1 Mon Sep 17 00:00:00 2001
From: Andreas Beeker <kiwiwings@apache.org>
Date: Wed, 23 Feb 2022 23:54:45 +0000
Subject: [PATCH] javadoc and forbiddenApis fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898356 13f79535-47bb-0310-9956-ffa450edef68
---
 build.gradle                                               | 2 +-
 .../poi/poifs/crypt/dsig/facets/XAdESSignatureFacet.java   | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/build.gradle b/build.gradle
index 7298484afe..ca2c37b597 100644
--- a/build.gradle
+++ b/build.gradle
@@ -194,7 +194,7 @@ subprojects {
         failOnError = true
         maxMemory = "1024M"
         javadocTool = javaToolchains.javadocToolFor {
-            languageVersion = JavaLanguageVersion.of(11)
+            languageVersion = JavaLanguageVersion.of(Math.max(11,jdkVersion))
         }
 
         doFirst {
diff --git a/poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/dsig/facets/XAdESSignatureFacet.java b/poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/dsig/facets/XAdESSignatureFacet.java
index 0d782b8b04..69ee38fbdd 100644
--- a/poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/dsig/facets/XAdESSignatureFacet.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/dsig/facets/XAdESSignatureFacet.java
@@ -38,6 +38,7 @@ import java.util.Locale;
 import java.util.Map;
 import java.util.TimeZone;
 
+import javax.security.auth.x500.X500Principal;
 import javax.xml.XMLConstants;
 import javax.xml.crypto.XMLStructure;
 import javax.xml.crypto.dom.DOMStructure;
@@ -309,6 +310,7 @@ public class XAdESSignatureFacet implements SignatureFacet {
     protected static void setCertID
         (CertIDType certId, SignatureConfig signatureConfig, boolean issuerNameNoReverseOrder, X509Certificate certificate) {
         X509IssuerSerialType issuerSerial = certId.addNewIssuerSerial();
+        X500Principal issuerPrincipal = certificate.getIssuerX500Principal();
         String issuerName;
         if (issuerNameNoReverseOrder) {
             /*
@@ -319,10 +321,9 @@ public class XAdESSignatureFacet implements SignatureFacet {
              * XXX: not correct according to RFC 4514.
              */
             // TODO: check if issuerName is different on getTBSCertificate
-            // issuerName = PrincipalUtil.getIssuerX509Principal(certificate).getName().replace(",", ", ");
-            issuerName = certificate.getIssuerDN().getName().replace(",", ", ");
+            issuerName = issuerPrincipal.getName().replace(",", ", ");
         } else {
-            issuerName = certificate.getIssuerX500Principal().toString();
+            issuerName = issuerPrincipal.toString();
         }
         issuerSerial.setX509IssuerName(issuerName);
         issuerSerial.setX509SerialNumber(certificate.getSerialNumber());