fix potential input resource leaks (LGTM)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859591 13f79535-47bb-0310-9956-ffa450edef68

src/examples/src/org/apache/poi/hssf/usermodel/examples/EmbeddedObjects.java

@@ -33,8 +33,11 @@ import org.apache.poi.poifs.filesystem.POIFSFileSystem;
 public class EmbeddedObjects {
     @SuppressWarnings("unused")
     public static void main(String[] args) throws Exception {
-        POIFSFileSystem fs = new POIFSFileSystem(new FileInputStream(args[0]));
-        try (HSSFWorkbook workbook = new HSSFWorkbook(fs)) {
+        try (
+            FileInputStream fis = new FileInputStream(args[0]);
+            POIFSFileSystem fs = new POIFSFileSystem(fis);
+            HSSFWorkbook workbook = new HSSFWorkbook(fs)
+        ) {
             for (HSSFObjectData obj : workbook.getAllEmbeddedObjects()) {
                 //the OLE2 Class Name of the object
                 String oleName = obj.getOLE2ClassName();

src/java/org/apache/poi/poifs/dev/POIFSLister.java

@@ -68,10 +68,12 @@ public class POIFSLister {
    }
 
    public static void viewFileOld(final String filename, boolean withSizes) throws IOException {
-      POIFSFileSystem fs = new POIFSFileSystem(new FileInputStream(filename));
+      try (FileInputStream fis = new FileInputStream(filename)) {
+         POIFSFileSystem fs = new POIFSFileSystem(fis);
          displayDirectory(fs.getRoot(), "", withSizes);
          fs.close();
       }
+   }
 
    public static void displayDirectory(DirectoryNode dir, String indent, boolean withSizes) {
       System.out.println(indent + dir.getName() + " -");

src/scratchpad/src/org/apache/poi/hdgf/extractor/VisioTextExtractor.java

@@ -128,8 +128,9 @@ public final class VisioTextExtractor extends POIOLE2TextExtractor {
 			System.exit(1);
 		}
 
+		try (FileInputStream fis = new FileInputStream(args[0])) {
 			VisioTextExtractor extractor =
-			new VisioTextExtractor(new FileInputStream(args[0]));
+				new VisioTextExtractor(fis);
 
 			// Print not PrintLn as already has \n added to it
 			System.out.print(extractor.getText());
@@ -137,3 +138,4 @@ public final class VisioTextExtractor extends POIOLE2TextExtractor {
 			extractor.close();
 		}
 	}
+}

src/scratchpad/src/org/apache/poi/hpbf/dev/PLCDumper.java

@@ -53,13 +53,14 @@ public final class PLCDumper {
 			System.err.println("  PLCDumper <filename>");
 			System.exit(1);
 		}
-		PLCDumper dump = new PLCDumper(
-				new FileInputStream(args[0])
-		);
+
+		try (FileInputStream fis = new FileInputStream(args[0])) {
+			PLCDumper dump = new PLCDumper(fis);
 
 			System.out.println("Dumping " + args[0]);
 			dump.dumpPLC();
 		}
+	}
 
 	private void dumpPLC() {
 		QCBit[] bits = qc.getBits();