sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832067 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andreas Beeker 2018-05-22 22:39:22 +00:00
parent d136eaa778
commit 8c5c92761d
3 changed files with 13 additions and 8 deletions

View File

@ -365,12 +365,16 @@ public class AddDimensionedImage {
anchor.setDx1(0); anchor.setDx1(0);
anchor.setDy1(0); anchor.setDy1(0);
if (colClientAnchorDetail != null) {
anchor.setDx2(colClientAnchorDetail.getInset()); anchor.setDx2(colClientAnchorDetail.getInset());
anchor.setDy2(rowClientAnchorDetail.getInset());
anchor.setCol1(colClientAnchorDetail.getFromIndex()); anchor.setCol1(colClientAnchorDetail.getFromIndex());
anchor.setRow1(rowClientAnchorDetail.getFromIndex());
anchor.setCol2(colClientAnchorDetail.getToIndex()); anchor.setCol2(colClientAnchorDetail.getToIndex());
}
if (rowClientAnchorDetail != null) {
anchor.setDy2(rowClientAnchorDetail.getInset());
anchor.setRow1(rowClientAnchorDetail.getFromIndex());
anchor.setRow2(rowClientAnchorDetail.getToIndex()); anchor.setRow2(rowClientAnchorDetail.getToIndex());
}
// For now, set the anchor type to do not move or resize the // For now, set the anchor type to do not move or resize the
// image as the size of the row/column is adjusted. This could easily // image as the size of the row/column is adjusted. This could easily

View File

@ -56,7 +56,7 @@ public class DrawShape implements Drawable {
*/ */
@Override @Override
public void applyTransform(Graphics2D graphics) { public void applyTransform(Graphics2D graphics) {
if (!(shape instanceof PlaceableShape)) { if (!(shape instanceof PlaceableShape) || graphics == null) {
return; return;
} }

View File

@ -1711,10 +1711,11 @@ public final class FormulaParser {
private int parseErrorLiteral() { private int parseErrorLiteral() {
Match('#'); Match('#');
String part1 = parseUnquotedIdentifier().toUpperCase(Locale.ROOT); String part1 = parseUnquotedIdentifier();
if (part1 == null) { if (part1 == null) {
throw expected("remainder of error constant literal"); throw expected("remainder of error constant literal");
} }
part1 = part1.toUpperCase(Locale.ROOT);
switch(part1.charAt(0)) { switch(part1.charAt(0)) {
case 'V': { case 'V': {