Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add broken (disabled) test to show issue with ISO 8601 format 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891859 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2021-07-28 18:38:21 +00:00
parent 01b94f1817
commit 956d58cfb4
2 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
poi/src/main/java/org/apache/poi/ss/formula/functions/TextFunction.java
View File

@ -352,8 +352,8 @@ public abstract class TextFunction implements Function {
}
try {
// Ask DataFormatter to handle the String for us
String formattedStr = formatter.formatRawCellContents(s0, -1, s1);
// Ask DataFormatter to handle the String for us
String formattedStr = formatter.formatRawCellContents(s0, -1, s1);
return new StringEval(formattedStr);
} catch (Exception e) {
return ErrorEval.VALUE_INVALID;

22
poi/src/test/java/org/apache/poi/ss/formula/functions/TestText.java
View File

@ -29,6 +29,7 @@ import org.apache.poi.ss.formula.eval.NumberEval;
import org.apache.poi.ss.formula.eval.StringEval;
import org.apache.poi.ss.formula.eval.ValueEval;
import org.apache.poi.util.LocaleUtil;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
/**
@ -45,7 +46,7 @@ final class TestText {
}
@Test
void testTextWithDeciamlFormatSecondArg() {
void testTextWithDecimalFormatSecondArg() {
ValueEval numArg = new NumberEval(321321.321);
ValueEval formatArg = new StringEval("#,###.00000");
ValueEval[] args = { numArg, formatArg };
@ -136,4 +137,23 @@ final class TestText {
LocaleUtil.setUserTimeZone(userTZ);
}
}
@Disabled("see https://bz.apache.org/bugzilla/show_bug.cgi?id=65471")
@Test
void testTextWithISODateTimeFormatSecondArg() {
TimeZone userTZ = LocaleUtil.getUserTimeZone();
LocaleUtil.setUserTimeZone(TimeZone.getTimeZone("CET"));
try {
// Test with Java style M=Month
ValueEval numArg = new NumberEval(321.321);
ValueEval formatArg = new StringEval("yyyy-mm-ddThh:MM:ss");
ValueEval[] args = { numArg, formatArg };
ValueEval result = TextFunction.TEXT.evaluate(args, -1, (short)-1);
ValueEval testResult = new StringEval("1900-11-16T07:42:14");
assertEquals(testResult.toString(), result.toString());
} finally {
LocaleUtil.setUserTimeZone(userTZ);
}
}
}