From 96bf53f3fc532e249132e723d22d90fca0dc9839 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Wed, 20 Nov 2019 08:42:27 +0000 Subject: [PATCH] replace some uses of StringBuffer with StringBuilder git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870046 13f79535-47bb-0310-9956-ffa450edef68 --- .../hssf/usermodel/examples/InCellLists.java | 12 ++++++------ .../poi/hssf/view/SVFractionalFormat.java | 8 ++++---- .../src/org/apache/poi/ss/examples/ToCSV.java | 17 ++++++++--------- .../hssf/record/AbstractEscherHolderRecord.java | 2 +- .../org/apache/poi/hssf/record/ArrayRecord.java | 2 +- .../poi/hssf/record/AutoFilterInfoRecord.java | 2 +- .../org/apache/poi/hssf/record/BOFRecord.java | 2 +- .../apache/poi/hssf/record/BackupRecord.java | 2 +- .../org/apache/poi/hssf/record/BlankRecord.java | 2 +- .../apache/poi/hssf/record/BookBoolRecord.java | 2 +- .../poi/hssf/record/BottomMarginRecord.java | 2 +- .../poi/hssf/record/BoundSheetRecord.java | 2 +- .../apache/poi/hssf/record/CFRuleRecord.java | 2 +- .../apache/poi/hssf/record/CRNCountRecord.java | 2 +- .../org/apache/poi/hssf/record/CRNRecord.java | 2 +- .../apache/poi/hssf/record/CalcCountRecord.java | 2 +- .../apache/poi/hssf/record/CalcModeRecord.java | 2 +- .../apache/poi/hssf/record/CodepageRecord.java | 2 +- .../hssf/record/CommonObjectDataSubRecord.java | 2 +- .../apache/poi/hssf/record/ContinueRecord.java | 2 +- .../apache/poi/hssf/record/CountryRecord.java | 2 +- .../apache/poi/hssf/record/DBCellRecord.java | 2 +- .../org/apache/poi/hssf/record/DSFRecord.java | 2 +- .../org/apache/poi/hssf/record/DVALRecord.java | 2 +- .../org/apache/poi/hssf/record/DVRecord.java | 4 ++-- .../poi/hssf/record/DateWindow1904Record.java | 2 +- .../poi/hssf/record/DefaultColWidthRecord.java | 2 +- .../poi/hssf/record/DefaultRowHeightRecord.java | 2 +- .../org/apache/poi/hssf/record/DeltaRecord.java | 2 +- .../poi/hssf/record/DimensionsRecord.java | 2 +- .../poi/hssf/record/DrawingSelectionRecord.java | 4 ++-- .../org/apache/poi/hssf/record/EOFRecord.java | 2 +- .../hssf/record/EmbeddedObjectRefSubRecord.java | 2 +- .../apache/poi/hssf/record/EndSubRecord.java | 2 +- .../apache/poi/hssf/record/ExtSSTRecord.java | 2 +- .../poi/hssf/record/ExternSheetRecord.java | 4 ++-- .../apache/poi/hssf/record/FeatHdrRecord.java | 2 +- .../org/apache/poi/hssf/record/FeatRecord.java | 2 +- .../poi/hssf/record/FileSharingRecord.java | 2 +- .../poi/hssf/record/FnGroupCountRecord.java | 2 +- .../org/apache/poi/hssf/record/FontRecord.java | 2 +- .../apache/poi/hssf/record/FooterRecord.java | 2 +- .../apache/poi/hssf/record/FormatRecord.java | 2 +- .../apache/poi/hssf/record/FtCblsSubRecord.java | 2 +- .../apache/poi/hssf/record/FtCfSubRecord.java | 2 +- .../poi/hssf/record/FtPioGrbitSubRecord.java | 2 +- .../poi/hssf/record/GroupMarkerSubRecord.java | 2 +- .../org/apache/poi/hssf/record/GutsRecord.java | 2 +- .../apache/poi/hssf/record/HeaderRecord.java | 2 +- .../apache/poi/hssf/record/HideObjRecord.java | 2 +- .../apache/poi/hssf/record/HyperlinkRecord.java | 2 +- .../org/apache/poi/hssf/record/IndexRecord.java | 2 +- .../poi/hssf/record/InterfaceHdrRecord.java | 2 +- .../apache/poi/hssf/record/IterationRecord.java | 2 +- .../org/apache/poi/hssf/record/LabelRecord.java | 2 +- .../poi/hssf/record/LbsDataSubRecord.java | 4 ++-- .../poi/hssf/record/LeftMarginRecord.java | 2 +- .../org/apache/poi/hssf/record/MMSRecord.java | 2 +- .../apache/poi/hssf/record/MulBlankRecord.java | 2 +- .../org/apache/poi/hssf/record/MulRKRecord.java | 2 +- .../poi/hssf/record/NameCommentRecord.java | 2 +- .../org/apache/poi/hssf/record/NoteRecord.java | 2 +- .../poi/hssf/record/NoteStructureSubRecord.java | 2 +- .../org/apache/poi/hssf/record/ObjRecord.java | 2 +- .../poi/hssf/record/ObjectProtectRecord.java | 2 +- .../apache/poi/hssf/record/OldSheetRecord.java | 2 +- .../apache/poi/hssf/record/OldStringRecord.java | 2 +- .../apache/poi/hssf/record/PaletteRecord.java | 4 ++-- .../org/apache/poi/hssf/record/PaneRecord.java | 2 +- .../apache/poi/hssf/record/PasswordRecord.java | 2 +- .../poi/hssf/record/PasswordRev4Record.java | 2 +- .../poi/hssf/record/PrintSetupRecord.java | 2 +- .../apache/poi/hssf/record/ProtectRecord.java | 2 +- .../poi/hssf/record/ProtectionRev4Record.java | 2 +- .../apache/poi/hssf/record/RecalcIdRecord.java | 2 +- .../apache/poi/hssf/record/RefModeRecord.java | 2 +- .../poi/hssf/record/RefreshAllRecord.java | 2 +- .../poi/hssf/record/RightMarginRecord.java | 2 +- .../org/apache/poi/hssf/record/RowRecord.java | 2 +- .../org/apache/poi/hssf/record/SCLRecord.java | 2 +- .../poi/hssf/record/ScenarioProtectRecord.java | 2 +- .../org/apache/poi/hssf/record/TabIdRecord.java | 2 +- .../poi/hssf/record/TableStylesRecord.java | 2 +- .../apache/poi/hssf/record/TopMarginRecord.java | 2 +- .../apache/poi/hssf/record/UncalcedRecord.java | 2 +- .../apache/poi/hssf/record/UseSelFSRecord.java | 2 +- .../apache/poi/hssf/record/VCenterRecord.java | 2 +- .../poi/hssf/record/WindowProtectRecord.java | 2 +- .../poi/hssf/record/WriteAccessRecord.java | 2 +- .../poi/hssf/record/WriteProtectRecord.java | 2 +- .../poi/hssf/record/cf/BorderFormatting.java | 2 +- .../hssf/record/cf/ColorGradientFormatting.java | 2 +- .../poi/hssf/record/cf/DataBarFormatting.java | 2 +- .../record/cf/IconMultiStateFormatting.java | 2 +- .../poi/hssf/record/cf/PatternFormatting.java | 2 +- .../apache/poi/hssf/record/cf/Threshold.java | 2 +- .../poi/hssf/record/chart/AreaFormatRecord.java | 2 +- .../poi/hssf/record/chart/AreaRecord.java | 2 +- .../hssf/record/chart/AxisLineFormatRecord.java | 2 +- .../hssf/record/chart/AxisOptionsRecord.java | 2 +- .../poi/hssf/record/chart/AxisParentRecord.java | 2 +- .../poi/hssf/record/chart/AxisRecord.java | 2 +- .../poi/hssf/record/chart/AxisUsedRecord.java | 2 +- .../apache/poi/hssf/record/chart/BarRecord.java | 2 +- .../poi/hssf/record/chart/BeginRecord.java | 2 +- .../poi/hssf/record/chart/CatLabRecord.java | 2 +- .../record/chart/CategorySeriesAxisRecord.java | 2 +- .../hssf/record/chart/ChartEndBlockRecord.java | 2 +- .../hssf/record/chart/ChartEndObjectRecord.java | 2 +- .../hssf/record/chart/ChartFRTInfoRecord.java | 2 +- .../hssf/record/chart/ChartFormatRecord.java | 2 +- .../poi/hssf/record/chart/ChartRecord.java | 2 +- .../record/chart/ChartStartBlockRecord.java | 2 +- .../record/chart/ChartStartObjectRecord.java | 2 +- .../record/chart/ChartTitleFormatRecord.java | 2 +- .../apache/poi/hssf/record/chart/DatRecord.java | 2 +- .../poi/hssf/record/chart/DataFormatRecord.java | 2 +- .../record/chart/DataLabelExtensionRecord.java | 2 +- .../DefaultDataLabelTextPropertiesRecord.java | 2 +- .../apache/poi/hssf/record/chart/EndRecord.java | 2 +- .../poi/hssf/record/chart/FontBasisRecord.java | 2 +- .../poi/hssf/record/chart/FontIndexRecord.java | 2 +- .../poi/hssf/record/chart/FrameRecord.java | 2 +- .../poi/hssf/record/chart/LegendRecord.java | 2 +- .../poi/hssf/record/chart/LineFormatRecord.java | 2 +- .../poi/hssf/record/chart/LinkedDataRecord.java | 2 +- .../record/chart/NumberFormatIndexRecord.java | 2 +- .../poi/hssf/record/chart/ObjectLinkRecord.java | 2 +- .../poi/hssf/record/chart/PlotAreaRecord.java | 2 +- .../poi/hssf/record/chart/PlotGrowthRecord.java | 2 +- .../chart/SeriesChartGroupIndexRecord.java | 2 +- .../hssf/record/chart/SeriesIndexRecord.java | 2 +- .../hssf/record/chart/SeriesLabelsRecord.java | 2 +- .../poi/hssf/record/chart/SeriesListRecord.java | 2 +- .../poi/hssf/record/chart/SeriesRecord.java | 2 +- .../poi/hssf/record/chart/SeriesTextRecord.java | 2 +- .../record/chart/SeriesToChartGroupRecord.java | 2 +- .../record/chart/SheetPropertiesRecord.java | 2 +- .../poi/hssf/record/chart/TextRecord.java | 2 +- .../poi/hssf/record/chart/TickRecord.java | 2 +- .../poi/hssf/record/chart/UnitsRecord.java | 2 +- .../poi/hssf/record/chart/ValueRangeRecord.java | 2 +- .../poi/hssf/record/common/ExtendedColor.java | 2 +- .../poi/hssf/record/common/FeatFormulaErr2.java | 2 +- .../poi/hssf/record/common/FeatProtection.java | 2 +- .../poi/hssf/record/common/FeatSmartTag.java | 2 +- .../poi/hssf/record/common/FtrHeader.java | 2 +- .../hssf/record/pivottable/DataItemRecord.java | 2 +- .../ExtendedPivotTableViewFieldsRecord.java | 2 +- .../hssf/record/pivottable/StreamIDRecord.java | 2 +- .../record/pivottable/ViewDefinitionRecord.java | 2 +- .../record/pivottable/ViewFieldsRecord.java | 2 +- .../record/pivottable/ViewSourceRecord.java | 2 +- .../CollaboratingWorkbooksEnvironment.java | 2 +- .../apache/poi/ss/formula/NameIdentifier.java | 2 +- .../poi/ss/formula/functions/Countif.java | 2 +- .../poi/ss/formula/functions/Replace.java | 2 +- .../apache/poi/ss/formula/functions/Rept.java | 2 +- .../poi/ss/formula/functions/Substitute.java | 6 +++--- .../org/apache/poi/ss/formula/ptg/AddPtg.java | 2 +- .../poi/ss/formula/ptg/Area2DPtgBase.java | 2 +- .../apache/poi/ss/formula/ptg/Area3DPtg.java | 2 +- .../apache/poi/ss/formula/ptg/Area3DPxg.java | 2 +- .../org/apache/poi/ss/formula/ptg/ArrayPtg.java | 4 ++-- .../org/apache/poi/ss/formula/ptg/AttrPtg.java | 2 +- .../apache/poi/ss/formula/ptg/ConcatPtg.java | 2 +- .../apache/poi/ss/formula/ptg/Deleted3DPxg.java | 2 +- .../apache/poi/ss/formula/ptg/DividePtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/EqualPtg.java | 2 +- .../poi/ss/formula/ptg/GreaterEqualPtg.java | 2 +- .../poi/ss/formula/ptg/GreaterThanPtg.java | 2 +- .../poi/ss/formula/ptg/IntersectionPtg.java | 2 +- .../apache/poi/ss/formula/ptg/LessEqualPtg.java | 2 +- .../apache/poi/ss/formula/ptg/LessThanPtg.java | 2 +- .../apache/poi/ss/formula/ptg/MemAreaPtg.java | 2 +- .../apache/poi/ss/formula/ptg/MemFuncPtg.java | 2 +- .../apache/poi/ss/formula/ptg/MultiplyPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/NameXPxg.java | 2 +- .../apache/poi/ss/formula/ptg/NotEqualPtg.java | 2 +- .../apache/poi/ss/formula/ptg/PercentPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/PowerPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/RangePtg.java | 2 +- .../apache/poi/ss/formula/ptg/Ref2DPtgBase.java | 2 +- .../org/apache/poi/ss/formula/ptg/Ref3DPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/Ref3DPxg.java | 2 +- .../poi/ss/formula/ptg/ScalarConstantPtg.java | 2 +- .../apache/poi/ss/formula/ptg/StringPtg.java | 2 +- .../apache/poi/ss/formula/ptg/SubtractPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/TblPtg.java | 2 +- .../poi/ss/formula/ptg/UnaryMinusPtg.java | 2 +- .../apache/poi/ss/formula/ptg/UnaryPlusPtg.java | 2 +- .../org/apache/poi/ss/formula/ptg/UnionPtg.java | 2 +- .../poi/hssf/record/TestStringRecord.java | 2 +- .../poi/ss/formula/functions/TestIrr.java | 2 +- 194 files changed, 217 insertions(+), 218 deletions(-) diff --git a/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java b/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java index 315481b2e2..1b25c1bd8d 100644 --- a/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java +++ b/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java @@ -220,7 +220,7 @@ public class InCellLists { buffer.append(listItem); buffer.append("\n"); } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); @@ -260,7 +260,7 @@ public class InCellLists { buffer.append("\n"); itemNumber += increment; } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); @@ -292,7 +292,7 @@ public class InCellLists { buffer.append(listItem); buffer.append("\n"); } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); @@ -338,7 +338,7 @@ public class InCellLists { } } } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); @@ -409,7 +409,7 @@ public class InCellLists { } highLevelItemNumber += highLevelIncrement; } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); @@ -459,7 +459,7 @@ public class InCellLists { } } } - // The StringBuffer's contents are the source for the contents + // The StringBuilder's contents are the source for the contents // of the cell. cell.setCellValue(new HSSFRichTextString(buffer.toString().trim())); cell.setCellStyle(wrapStyle); diff --git a/src/examples/src/org/apache/poi/hssf/view/SVFractionalFormat.java b/src/examples/src/org/apache/poi/hssf/view/SVFractionalFormat.java index 4884195880..35cedd0ce9 100644 --- a/src/examples/src/org/apache/poi/hssf/view/SVFractionalFormat.java +++ b/src/examples/src/org/apache/poi/hssf/view/SVFractionalFormat.java @@ -140,9 +140,9 @@ public class SVFractionalFormat extends Format { break; } Precision = AllowedError / Diff; - // This calcualtion of Precision does not always provide results within + // This calculation of Precision does not always provide results within // Allowed Error. It compensates for loss of significant digits that occurs. - // It helps to round the inprecise reciprocal values to i. + // It helps to round the imprecise reciprocal values to i. B = A; A = Num; } @@ -161,7 +161,7 @@ public class SVFractionalFormat extends Format { Whole = -Whole; } } - return new StringBuffer().append(Whole).append(" ").append(Num).append("/").append(Den).toString(); + return new StringBuilder().append(Whole).append(" ").append(Num).append("/").append(Den).toString(); } /** This method formats the double in the units specified. @@ -173,7 +173,7 @@ public class SVFractionalFormat extends Format { f -= Whole; long Num = Math.round(f * units); - return new StringBuffer().append(Whole).append(" ").append(Num).append("/").append(units).toString(); + return new StringBuilder().append(Whole).append(" ").append(Num).append("/").append(units).toString(); } public final String format(double val) { diff --git a/src/examples/src/org/apache/poi/ss/examples/ToCSV.java b/src/examples/src/org/apache/poi/ss/examples/ToCSV.java index 8b9ca2822b..af2a1da2fb 100644 --- a/src/examples/src/org/apache/poi/ss/examples/ToCSV.java +++ b/src/examples/src/org/apache/poi/ss/examples/ToCSV.java @@ -428,10 +428,9 @@ public class ToCSV { * @throws java.io.IOException Thrown to indicate and error occurred in the * underylying file system. */ - private void saveCSVFile(File file) - throws FileNotFoundException, IOException { + private void saveCSVFile(File file) throws FileNotFoundException, IOException { ArrayList line; - StringBuffer buffer; + StringBuilder buffer; String csvLineElement; // Open a writer onto the CSV file. @@ -443,20 +442,20 @@ public class ToCSV { // all of the data recovered from the Excel workbooks' sheets, rows // and cells. for(int i = 0; i < this.csvData.size(); i++) { - buffer = new StringBuffer(); + buffer = new StringBuilder(); // Get an element from the ArrayList that contains the data for // the workbook. This element will itself be an ArrayList // containing Strings and each String will hold the data recovered // from a single cell. The for() loop is used to recover elements // from this 'row' ArrayList one at a time and to write the Strings - // away to a StringBuffer thus assembling a single line for inclusion + // away to a StringBuilder thus assembling a single line for inclusion // in the CSV file. If a row was empty or if it was short, then // the ArrayList that contains it's data will also be shorter than // some of the others. Therefore, it is necessary to check within // the for loop to ensure that the ArrayList contains data to be // processed. If it does, then an element will be recovered and - // appended to the StringBuffer. + // appended to the StringBuilder. line = this.csvData.get(i); for(int j = 0; j < this.maxRowWidth; j++) { if(line.size() > j) { @@ -572,7 +571,7 @@ public class ToCSV { * speech mark characters correctly escaped. */ private String escapeEmbeddedCharacters(String field) { - StringBuffer buffer; + StringBuilder buffer; // If the fields contents should be formatted to confrom with Excel's // convention.... @@ -584,7 +583,7 @@ public class ToCSV { // set of speech marks. Thus, "Yes" he said would become // """Yes"" he said" if(field.contains("\"")) { - buffer = new StringBuffer(field.replaceAll("\"", "\\\"\\\"")); + buffer = new StringBuilder(field.replaceAll("\"", "\\\"\\\"")); buffer.insert(0, "\""); buffer.append("\""); } @@ -592,7 +591,7 @@ public class ToCSV { // If the field contains either embedded separator or EOL // characters, then escape the whole field by surrounding it // with speech marks. - buffer = new StringBuffer(field); + buffer = new StringBuilder(field); if((buffer.indexOf(this.separator)) > -1 || (buffer.indexOf("\n")) > -1) { buffer.insert(0, "\""); diff --git a/src/java/org/apache/poi/hssf/record/AbstractEscherHolderRecord.java b/src/java/org/apache/poi/hssf/record/AbstractEscherHolderRecord.java index f97e60e195..b403a0799b 100644 --- a/src/java/org/apache/poi/hssf/record/AbstractEscherHolderRecord.java +++ b/src/java/org/apache/poi/hssf/record/AbstractEscherHolderRecord.java @@ -84,7 +84,7 @@ public abstract class AbstractEscherHolderRecord extends Record implements Clone @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); final String nl = System.getProperty("line.separator"); buffer.append('[' + getRecordName() + ']' + nl); diff --git a/src/java/org/apache/poi/hssf/record/ArrayRecord.java b/src/java/org/apache/poi/hssf/record/ArrayRecord.java index f1f78a2eff..96830cdbce 100644 --- a/src/java/org/apache/poi/hssf/record/ArrayRecord.java +++ b/src/java/org/apache/poi/hssf/record/ArrayRecord.java @@ -79,7 +79,7 @@ public final class ArrayRecord extends SharedValueRecordBase implements Cloneabl } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()).append(" [ARRAY]\n"); sb.append(" range=").append(getRange()).append("\n"); sb.append(" options=").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/AutoFilterInfoRecord.java b/src/java/org/apache/poi/hssf/record/AutoFilterInfoRecord.java index e514dc21be..ae0005bd67 100644 --- a/src/java/org/apache/poi/hssf/record/AutoFilterInfoRecord.java +++ b/src/java/org/apache/poi/hssf/record/AutoFilterInfoRecord.java @@ -68,7 +68,7 @@ public final class AutoFilterInfoRecord extends StandardRecord implements Clonea public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AUTOFILTERINFO]\n"); buffer.append(" .numEntries = ") diff --git a/src/java/org/apache/poi/hssf/record/BOFRecord.java b/src/java/org/apache/poi/hssf/record/BOFRecord.java index aca680cf5e..992ee87220 100644 --- a/src/java/org/apache/poi/hssf/record/BOFRecord.java +++ b/src/java/org/apache/poi/hssf/record/BOFRecord.java @@ -225,7 +225,7 @@ public final class BOFRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BOF RECORD]\n"); buffer.append(" .version = ").append(HexDump.shortToHex(getVersion())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/BackupRecord.java b/src/java/org/apache/poi/hssf/record/BackupRecord.java index 0381b22779..509d8d8dbf 100644 --- a/src/java/org/apache/poi/hssf/record/BackupRecord.java +++ b/src/java/org/apache/poi/hssf/record/BackupRecord.java @@ -69,7 +69,7 @@ public final class BackupRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BACKUP]\n"); buffer.append(" .backup = ") diff --git a/src/java/org/apache/poi/hssf/record/BlankRecord.java b/src/java/org/apache/poi/hssf/record/BlankRecord.java index d465ad3b40..007dd86524 100644 --- a/src/java/org/apache/poi/hssf/record/BlankRecord.java +++ b/src/java/org/apache/poi/hssf/record/BlankRecord.java @@ -117,7 +117,7 @@ public final class BlankRecord extends StandardRecord implements CellValueRecord public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[BLANK]\n"); sb.append(" row= ").append(HexDump.shortToHex(getRow())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/BookBoolRecord.java b/src/java/org/apache/poi/hssf/record/BookBoolRecord.java index 652e2ec038..d40214523d 100644 --- a/src/java/org/apache/poi/hssf/record/BookBoolRecord.java +++ b/src/java/org/apache/poi/hssf/record/BookBoolRecord.java @@ -69,7 +69,7 @@ public final class BookBoolRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BOOKBOOL]\n"); buffer.append(" .savelinkvalues = ") diff --git a/src/java/org/apache/poi/hssf/record/BottomMarginRecord.java b/src/java/org/apache/poi/hssf/record/BottomMarginRecord.java index 104d6a0f2a..36533dab16 100644 --- a/src/java/org/apache/poi/hssf/record/BottomMarginRecord.java +++ b/src/java/org/apache/poi/hssf/record/BottomMarginRecord.java @@ -41,7 +41,7 @@ public final class BottomMarginRecord extends StandardRecord implements Margin, public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( "[BottomMargin]\n" ); buffer.append( " .margin = " ) .append( " (" ).append( getMargin() ).append( " )\n" ); diff --git a/src/java/org/apache/poi/hssf/record/BoundSheetRecord.java b/src/java/org/apache/poi/hssf/record/BoundSheetRecord.java index af6853eb2e..33114f1a73 100644 --- a/src/java/org/apache/poi/hssf/record/BoundSheetRecord.java +++ b/src/java/org/apache/poi/hssf/record/BoundSheetRecord.java @@ -122,7 +122,7 @@ public final class BoundSheetRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BOUNDSHEET]\n"); buffer.append(" .bof = ").append(HexDump.intToHex(getPositionOfBof())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/CFRuleRecord.java b/src/java/org/apache/poi/hssf/record/CFRuleRecord.java index 082b365d14..77e6e96181 100644 --- a/src/java/org/apache/poi/hssf/record/CFRuleRecord.java +++ b/src/java/org/apache/poi/hssf/record/CFRuleRecord.java @@ -136,7 +136,7 @@ public final class CFRuleRecord extends CFRuleBase implements Cloneable { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CFRULE]\n"); buffer.append(" .condition_type =").append(getConditionType()).append("\n"); buffer.append(" OPTION FLAGS=0x").append(Integer.toHexString(getOptions())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/CRNCountRecord.java b/src/java/org/apache/poi/hssf/record/CRNCountRecord.java index 88cebe2703..6037360768 100644 --- a/src/java/org/apache/poi/hssf/record/CRNCountRecord.java +++ b/src/java/org/apache/poi/hssf/record/CRNCountRecord.java @@ -55,7 +55,7 @@ public final class CRNCountRecord extends StandardRecord { public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()).append(" [XCT"); sb.append(" nCRNs=").append(field_1_number_crn_records); sb.append(" sheetIx=").append(field_2_sheet_table_index); diff --git a/src/java/org/apache/poi/hssf/record/CRNRecord.java b/src/java/org/apache/poi/hssf/record/CRNRecord.java index 11921873d3..eddd3425a9 100644 --- a/src/java/org/apache/poi/hssf/record/CRNRecord.java +++ b/src/java/org/apache/poi/hssf/record/CRNRecord.java @@ -52,7 +52,7 @@ public final class CRNRecord extends StandardRecord { public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()).append(" [CRN"); sb.append(" rowIx=").append(field_3_row_index); sb.append(" firstColIx=").append(field_2_first_column_index); diff --git a/src/java/org/apache/poi/hssf/record/CalcCountRecord.java b/src/java/org/apache/poi/hssf/record/CalcCountRecord.java index f416def2f8..f03791d071 100644 --- a/src/java/org/apache/poi/hssf/record/CalcCountRecord.java +++ b/src/java/org/apache/poi/hssf/record/CalcCountRecord.java @@ -68,7 +68,7 @@ public final class CalcCountRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CALCCOUNT]\n"); buffer.append(" .iterations = ") diff --git a/src/java/org/apache/poi/hssf/record/CalcModeRecord.java b/src/java/org/apache/poi/hssf/record/CalcModeRecord.java index 9f74ecf714..6ffb84b0ff 100644 --- a/src/java/org/apache/poi/hssf/record/CalcModeRecord.java +++ b/src/java/org/apache/poi/hssf/record/CalcModeRecord.java @@ -96,7 +96,7 @@ public final class CalcModeRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CALCMODE]\n"); buffer.append(" .calcmode = ") diff --git a/src/java/org/apache/poi/hssf/record/CodepageRecord.java b/src/java/org/apache/poi/hssf/record/CodepageRecord.java index 59f69af61d..11d074817a 100644 --- a/src/java/org/apache/poi/hssf/record/CodepageRecord.java +++ b/src/java/org/apache/poi/hssf/record/CodepageRecord.java @@ -79,7 +79,7 @@ public final class CodepageRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CODEPAGE]\n"); buffer.append(" .codepage = ") diff --git a/src/java/org/apache/poi/hssf/record/CommonObjectDataSubRecord.java b/src/java/org/apache/poi/hssf/record/CommonObjectDataSubRecord.java index 293d55a6ea..6e0b86155f 100644 --- a/src/java/org/apache/poi/hssf/record/CommonObjectDataSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/CommonObjectDataSubRecord.java @@ -95,7 +95,7 @@ public final class CommonObjectDataSubRecord extends SubRecord implements Clonea @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ftCmo]\n"); buffer.append(" .objectType = ") diff --git a/src/java/org/apache/poi/hssf/record/ContinueRecord.java b/src/java/org/apache/poi/hssf/record/ContinueRecord.java index 17a0c51653..0dedc62a63 100644 --- a/src/java/org/apache/poi/hssf/record/ContinueRecord.java +++ b/src/java/org/apache/poi/hssf/record/ContinueRecord.java @@ -53,7 +53,7 @@ public final class ContinueRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CONTINUE RECORD]\n"); buffer.append(" .data = ").append(HexDump.toHex(_data)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/CountryRecord.java b/src/java/org/apache/poi/hssf/record/CountryRecord.java index 44181aa3e8..47020dab1e 100644 --- a/src/java/org/apache/poi/hssf/record/CountryRecord.java +++ b/src/java/org/apache/poi/hssf/record/CountryRecord.java @@ -96,7 +96,7 @@ public final class CountryRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[COUNTRY]\n"); buffer.append(" .defaultcountry = ") diff --git a/src/java/org/apache/poi/hssf/record/DBCellRecord.java b/src/java/org/apache/poi/hssf/record/DBCellRecord.java index ddcc56fe8a..55db860bb8 100644 --- a/src/java/org/apache/poi/hssf/record/DBCellRecord.java +++ b/src/java/org/apache/poi/hssf/record/DBCellRecord.java @@ -77,7 +77,7 @@ public final class DBCellRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DBCELL]\n"); buffer.append(" .rowoffset = ").append(HexDump.intToHex(field_1_row_offset)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/DSFRecord.java b/src/java/org/apache/poi/hssf/record/DSFRecord.java index 8d28562ae6..8dbb534254 100644 --- a/src/java/org/apache/poi/hssf/record/DSFRecord.java +++ b/src/java/org/apache/poi/hssf/record/DSFRecord.java @@ -52,7 +52,7 @@ public final class DSFRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DSF]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/DVALRecord.java b/src/java/org/apache/poi/hssf/record/DVALRecord.java index fd7163a528..f74dedbfea 100644 --- a/src/java/org/apache/poi/hssf/record/DVALRecord.java +++ b/src/java/org/apache/poi/hssf/record/DVALRecord.java @@ -129,7 +129,7 @@ public final class DVALRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DVAL]\n"); buffer.append(" .options = ").append(getOptions()).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/DVRecord.java b/src/java/org/apache/poi/hssf/record/DVRecord.java index 4749e7b51e..4025794d2c 100644 --- a/src/java/org/apache/poi/hssf/record/DVRecord.java +++ b/src/java/org/apache/poi/hssf/record/DVRecord.java @@ -240,7 +240,7 @@ public final class DVRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[DV]\n"); sb.append(" options=").append(Integer.toHexString(_option_flags)); sb.append(" title-prompt=").append(formatTextTitle(_promptTitle)); @@ -274,7 +274,7 @@ public final class DVRecord extends StandardRecord implements Cloneable { return str; } - private static void appendFormula(StringBuffer sb, String label, Formula f) { + private static void appendFormula(StringBuilder sb, String label, Formula f) { sb.append(label); if (f == null) { diff --git a/src/java/org/apache/poi/hssf/record/DateWindow1904Record.java b/src/java/org/apache/poi/hssf/record/DateWindow1904Record.java index 39b47402c0..6eb2e82a6e 100644 --- a/src/java/org/apache/poi/hssf/record/DateWindow1904Record.java +++ b/src/java/org/apache/poi/hssf/record/DateWindow1904Record.java @@ -67,7 +67,7 @@ public final class DateWindow1904Record public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[1904]\n"); buffer.append(" .is1904 = ") diff --git a/src/java/org/apache/poi/hssf/record/DefaultColWidthRecord.java b/src/java/org/apache/poi/hssf/record/DefaultColWidthRecord.java index c2f37b8c4d..e4c416f07b 100644 --- a/src/java/org/apache/poi/hssf/record/DefaultColWidthRecord.java +++ b/src/java/org/apache/poi/hssf/record/DefaultColWidthRecord.java @@ -69,7 +69,7 @@ public final class DefaultColWidthRecord extends StandardRecord implements Clone public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DEFAULTCOLWIDTH]\n"); buffer.append(" .colwidth = ") diff --git a/src/java/org/apache/poi/hssf/record/DefaultRowHeightRecord.java b/src/java/org/apache/poi/hssf/record/DefaultRowHeightRecord.java index 850e895c96..7ba2c64061 100644 --- a/src/java/org/apache/poi/hssf/record/DefaultRowHeightRecord.java +++ b/src/java/org/apache/poi/hssf/record/DefaultRowHeightRecord.java @@ -95,7 +95,7 @@ public final class DefaultRowHeightRecord extends StandardRecord implements Clon public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DEFAULTROWHEIGHT]\n"); buffer.append(" .optionflags = ") diff --git a/src/java/org/apache/poi/hssf/record/DeltaRecord.java b/src/java/org/apache/poi/hssf/record/DeltaRecord.java index 9cc2c071ab..aa3400dde5 100644 --- a/src/java/org/apache/poi/hssf/record/DeltaRecord.java +++ b/src/java/org/apache/poi/hssf/record/DeltaRecord.java @@ -49,7 +49,7 @@ public final class DeltaRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DELTA]\n"); buffer.append(" .maxchange = ").append(getMaxChange()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/DimensionsRecord.java b/src/java/org/apache/poi/hssf/record/DimensionsRecord.java index 1525d58c6d..280e3e1825 100644 --- a/src/java/org/apache/poi/hssf/record/DimensionsRecord.java +++ b/src/java/org/apache/poi/hssf/record/DimensionsRecord.java @@ -144,7 +144,7 @@ public final class DimensionsRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DIMENSIONS]\n"); buffer.append(" .firstrow = ") diff --git a/src/java/org/apache/poi/hssf/record/DrawingSelectionRecord.java b/src/java/org/apache/poi/hssf/record/DrawingSelectionRecord.java index 1433bcbbde..20bba6bc15 100644 --- a/src/java/org/apache/poi/hssf/record/DrawingSelectionRecord.java +++ b/src/java/org/apache/poi/hssf/record/DrawingSelectionRecord.java @@ -57,7 +57,7 @@ public final class DrawingSelectionRecord extends StandardRecord implements Clon } public String debugFormatAsString() { - StringBuffer sb = new StringBuffer(32); + StringBuilder sb = new StringBuilder(32); sb.append("ver+inst=").append(HexDump.shortToHex(_verAndInstance)); sb.append(" type=").append(HexDump.shortToHex(_type)); sb.append(" len=").append(HexDump.intToHex(_length)); @@ -115,7 +115,7 @@ public final class DrawingSelectionRecord extends StandardRecord implements Clon } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[MSODRAWINGSELECTION]\n"); sb.append(" .rh =(").append(_header.debugFormatAsString()).append(")\n"); diff --git a/src/java/org/apache/poi/hssf/record/EOFRecord.java b/src/java/org/apache/poi/hssf/record/EOFRecord.java index 02d734a99f..9d3d6d344f 100644 --- a/src/java/org/apache/poi/hssf/record/EOFRecord.java +++ b/src/java/org/apache/poi/hssf/record/EOFRecord.java @@ -48,7 +48,7 @@ public final class EOFRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[EOF]\n"); buffer.append("[/EOF]\n"); diff --git a/src/java/org/apache/poi/hssf/record/EmbeddedObjectRefSubRecord.java b/src/java/org/apache/poi/hssf/record/EmbeddedObjectRefSubRecord.java index b431223c42..43d764139a 100644 --- a/src/java/org/apache/poi/hssf/record/EmbeddedObjectRefSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/EmbeddedObjectRefSubRecord.java @@ -315,7 +315,7 @@ public final class EmbeddedObjectRefSubRecord extends SubRecord implements Clone } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[ftPictFmla]\n"); sb.append(" .f2unknown = ").append(HexDump.intToHex(field_1_unknown_int)).append("\n"); if (field_2_refPtg == null) { diff --git a/src/java/org/apache/poi/hssf/record/EndSubRecord.java b/src/java/org/apache/poi/hssf/record/EndSubRecord.java index c9e487d592..4999fba6b2 100644 --- a/src/java/org/apache/poi/hssf/record/EndSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/EndSubRecord.java @@ -53,7 +53,7 @@ public final class EndSubRecord extends SubRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ftEnd]\n"); diff --git a/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java b/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java index 2ce2810e62..b56d4ca1a0 100644 --- a/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java +++ b/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java @@ -111,7 +111,7 @@ public final class ExtSSTRecord extends ContinuableRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[EXTSST]\n"); buffer.append(" .dsst = ") diff --git a/src/java/org/apache/poi/hssf/record/ExternSheetRecord.java b/src/java/org/apache/poi/hssf/record/ExternSheetRecord.java index ae429bd87c..5c4e96b70f 100644 --- a/src/java/org/apache/poi/hssf/record/ExternSheetRecord.java +++ b/src/java/org/apache/poi/hssf/record/ExternSheetRecord.java @@ -70,7 +70,7 @@ public class ExternSheetRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("extBook=").append(_extBookIndex); buffer.append(" firstSheet=").append(_firstSheetIndex); buffer.append(" lastSheet=").append(_lastSheetIndex); @@ -127,7 +127,7 @@ public class ExternSheetRecord extends StandardRecord { @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); int nItems = _list.size(); sb.append("[EXTERNSHEET]\n"); sb.append(" numOfRefs = ").append(nItems).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FeatHdrRecord.java b/src/java/org/apache/poi/hssf/record/FeatHdrRecord.java index d12bc8b129..1acb3f05aa 100644 --- a/src/java/org/apache/poi/hssf/record/FeatHdrRecord.java +++ b/src/java/org/apache/poi/hssf/record/FeatHdrRecord.java @@ -84,7 +84,7 @@ public final class FeatHdrRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FEATURE HEADER]\n"); // TODO ... diff --git a/src/java/org/apache/poi/hssf/record/FeatRecord.java b/src/java/org/apache/poi/hssf/record/FeatRecord.java index 404fc24c55..37bb5b1f8f 100644 --- a/src/java/org/apache/poi/hssf/record/FeatRecord.java +++ b/src/java/org/apache/poi/hssf/record/FeatRecord.java @@ -101,7 +101,7 @@ public final class FeatRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SHARED FEATURE]\n"); // TODO ... diff --git a/src/java/org/apache/poi/hssf/record/FileSharingRecord.java b/src/java/org/apache/poi/hssf/record/FileSharingRecord.java index f2698a390a..bf1825730d 100644 --- a/src/java/org/apache/poi/hssf/record/FileSharingRecord.java +++ b/src/java/org/apache/poi/hssf/record/FileSharingRecord.java @@ -100,7 +100,7 @@ public final class FileSharingRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FILESHARING]\n"); buffer.append(" .readonly = ") diff --git a/src/java/org/apache/poi/hssf/record/FnGroupCountRecord.java b/src/java/org/apache/poi/hssf/record/FnGroupCountRecord.java index 5d70aeb7e6..4258df5e1f 100644 --- a/src/java/org/apache/poi/hssf/record/FnGroupCountRecord.java +++ b/src/java/org/apache/poi/hssf/record/FnGroupCountRecord.java @@ -75,7 +75,7 @@ public final class FnGroupCountRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FNGROUPCOUNT]\n"); buffer.append(" .count = ").append(getCount()) diff --git a/src/java/org/apache/poi/hssf/record/FontRecord.java b/src/java/org/apache/poi/hssf/record/FontRecord.java index 1af6142eda..5296d5e3ce 100644 --- a/src/java/org/apache/poi/hssf/record/FontRecord.java +++ b/src/java/org/apache/poi/hssf/record/FontRecord.java @@ -359,7 +359,7 @@ public final class FontRecord extends StandardRecord { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[FONT]\n"); sb.append(" .fontheight = ").append(HexDump.shortToHex(getFontHeight())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FooterRecord.java b/src/java/org/apache/poi/hssf/record/FooterRecord.java index e5e98bb0bf..08ba4f2f13 100644 --- a/src/java/org/apache/poi/hssf/record/FooterRecord.java +++ b/src/java/org/apache/poi/hssf/record/FooterRecord.java @@ -34,7 +34,7 @@ public final class FooterRecord extends HeaderFooterBase implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FOOTER]\n"); buffer.append(" .footer = ").append(getText()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FormatRecord.java b/src/java/org/apache/poi/hssf/record/FormatRecord.java index f16b55d02b..87410618c2 100644 --- a/src/java/org/apache/poi/hssf/record/FormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/FormatRecord.java @@ -84,7 +84,7 @@ public final class FormatRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FORMAT]\n"); buffer.append(" .indexcode = ").append(HexDump.shortToHex(getIndexCode())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FtCblsSubRecord.java b/src/java/org/apache/poi/hssf/record/FtCblsSubRecord.java index 76b4a4ee62..50eb7bf95a 100644 --- a/src/java/org/apache/poi/hssf/record/FtCblsSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/FtCblsSubRecord.java @@ -60,7 +60,7 @@ public final class FtCblsSubRecord extends SubRecord implements Cloneable { */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FtCbls ]").append("\n"); buffer.append(" size = ").append(getDataSize()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java b/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java index 7e202c0831..e2fd02ad7e 100644 --- a/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java @@ -67,7 +67,7 @@ public final class FtCfSubRecord extends SubRecord implements Cloneable { * Used by BiffViewer and other utilities. */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FtCf ]\n"); buffer.append(" size = ").append(length).append("\n"); buffer.append(" flags = ").append(HexDump.toHex(flags)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java b/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java index eaf8a5af29..2215145988 100644 --- a/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java @@ -121,7 +121,7 @@ public final class FtPioGrbitSubRecord extends SubRecord implements Cloneable { * Used by BiffViewer and other utilities. */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FtPioGrbit ]\n"); buffer.append(" size = ").append(length).append("\n"); buffer.append(" flags = ").append(HexDump.toHex(flags)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/GroupMarkerSubRecord.java b/src/java/org/apache/poi/hssf/record/GroupMarkerSubRecord.java index 47395f58bb..62364bc031 100644 --- a/src/java/org/apache/poi/hssf/record/GroupMarkerSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/GroupMarkerSubRecord.java @@ -49,7 +49,7 @@ public final class GroupMarkerSubRecord extends SubRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); String nl = System.getProperty("line.separator"); buffer.append("[ftGmo]" + nl); diff --git a/src/java/org/apache/poi/hssf/record/GutsRecord.java b/src/java/org/apache/poi/hssf/record/GutsRecord.java index 97cc0f7c7a..6f302729db 100644 --- a/src/java/org/apache/poi/hssf/record/GutsRecord.java +++ b/src/java/org/apache/poi/hssf/record/GutsRecord.java @@ -139,7 +139,7 @@ public final class GutsRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[GUTS]\n"); buffer.append(" .leftgutter = ") diff --git a/src/java/org/apache/poi/hssf/record/HeaderRecord.java b/src/java/org/apache/poi/hssf/record/HeaderRecord.java index ec6733c235..11fd873ed6 100644 --- a/src/java/org/apache/poi/hssf/record/HeaderRecord.java +++ b/src/java/org/apache/poi/hssf/record/HeaderRecord.java @@ -37,7 +37,7 @@ public final class HeaderRecord extends HeaderFooterBase implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[HEADER]\n"); buffer.append(" .header = ").append(getText()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/HideObjRecord.java b/src/java/org/apache/poi/hssf/record/HideObjRecord.java index 9f4f1ca3c4..eedcf46051 100644 --- a/src/java/org/apache/poi/hssf/record/HideObjRecord.java +++ b/src/java/org/apache/poi/hssf/record/HideObjRecord.java @@ -77,7 +77,7 @@ public final class HideObjRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[HIDEOBJ]\n"); buffer.append(" .hideobj = ") diff --git a/src/java/org/apache/poi/hssf/record/HyperlinkRecord.java b/src/java/org/apache/poi/hssf/record/HyperlinkRecord.java index 4f51179b01..e7098423e3 100644 --- a/src/java/org/apache/poi/hssf/record/HyperlinkRecord.java +++ b/src/java/org/apache/poi/hssf/record/HyperlinkRecord.java @@ -676,7 +676,7 @@ public final class HyperlinkRecord extends StandardRecord implements Cloneable { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[HYPERLINK RECORD]\n"); buffer.append(" .range = ").append(_range.formatAsString()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/IndexRecord.java b/src/java/org/apache/poi/hssf/record/IndexRecord.java index fcb57cbd28..0e8997dc19 100644 --- a/src/java/org/apache/poi/hssf/record/IndexRecord.java +++ b/src/java/org/apache/poi/hssf/record/IndexRecord.java @@ -107,7 +107,7 @@ public final class IndexRecord extends StandardRecord implements Cloneable { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[INDEX]\n"); buffer.append(" .firstrow = ") diff --git a/src/java/org/apache/poi/hssf/record/InterfaceHdrRecord.java b/src/java/org/apache/poi/hssf/record/InterfaceHdrRecord.java index afd7705343..eda3cd1f0c 100644 --- a/src/java/org/apache/poi/hssf/record/InterfaceHdrRecord.java +++ b/src/java/org/apache/poi/hssf/record/InterfaceHdrRecord.java @@ -44,7 +44,7 @@ public final class InterfaceHdrRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[INTERFACEHDR]\n"); buffer.append(" .codepage = ").append(HexDump.shortToHex(_codepage)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/IterationRecord.java b/src/java/org/apache/poi/hssf/record/IterationRecord.java index 8a7595ce4b..ca018c3e78 100644 --- a/src/java/org/apache/poi/hssf/record/IterationRecord.java +++ b/src/java/org/apache/poi/hssf/record/IterationRecord.java @@ -64,7 +64,7 @@ public final class IterationRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ITERATION]\n"); buffer.append(" .flags = ").append(HexDump.shortToHex(_flags)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/LabelRecord.java b/src/java/org/apache/poi/hssf/record/LabelRecord.java index 532941e929..42fb7be829 100644 --- a/src/java/org/apache/poi/hssf/record/LabelRecord.java +++ b/src/java/org/apache/poi/hssf/record/LabelRecord.java @@ -145,7 +145,7 @@ public final class LabelRecord extends Record implements CellValueRecordInterfac @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[LABEL]\n"); sb.append(" .row = ").append(HexDump.shortToHex(getRow())).append("\n"); sb.append(" .column = ").append(HexDump.shortToHex(getColumn())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/LbsDataSubRecord.java b/src/java/org/apache/poi/hssf/record/LbsDataSubRecord.java index 2a07eefb9e..1f564677bb 100644 --- a/src/java/org/apache/poi/hssf/record/LbsDataSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/LbsDataSubRecord.java @@ -266,7 +266,7 @@ public class LbsDataSubRecord extends SubRecord { @Override public String toString() { - StringBuffer sb = new StringBuffer(256); + StringBuilder sb = new StringBuilder(256); sb.append("[ftLbsData]\n"); sb.append(" .unknownShort1 =").append(HexDump.shortToHex(_cbFContinued)).append("\n"); @@ -404,7 +404,7 @@ public class LbsDataSubRecord extends SubRecord { @Override public String toString(){ - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[LbsDropData]\n"); sb.append(" ._wStyle: ").append(_wStyle).append('\n'); sb.append(" ._cLine: ").append(_cLine).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/LeftMarginRecord.java b/src/java/org/apache/poi/hssf/record/LeftMarginRecord.java index 6e8cb8fbba..a2c00b07d6 100644 --- a/src/java/org/apache/poi/hssf/record/LeftMarginRecord.java +++ b/src/java/org/apache/poi/hssf/record/LeftMarginRecord.java @@ -35,7 +35,7 @@ public final class LeftMarginRecord extends StandardRecord implements Margin, Cl public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( "[LeftMargin]\n" ); buffer.append( " .margin = " ).append( " (" ).append( getMargin() ).append( " )\n" ); buffer.append( "[/LeftMargin]\n" ); diff --git a/src/java/org/apache/poi/hssf/record/MMSRecord.java b/src/java/org/apache/poi/hssf/record/MMSRecord.java index cc28f94d4c..e016ef4581 100644 --- a/src/java/org/apache/poi/hssf/record/MMSRecord.java +++ b/src/java/org/apache/poi/hssf/record/MMSRecord.java @@ -93,7 +93,7 @@ public final class MMSRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[MMS]\n"); buffer.append(" .addMenu = ") diff --git a/src/java/org/apache/poi/hssf/record/MulBlankRecord.java b/src/java/org/apache/poi/hssf/record/MulBlankRecord.java index cbdcd2a93b..de5f1e1141 100644 --- a/src/java/org/apache/poi/hssf/record/MulBlankRecord.java +++ b/src/java/org/apache/poi/hssf/record/MulBlankRecord.java @@ -100,7 +100,7 @@ public final class MulBlankRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[MULBLANK]\n"); buffer.append("row = ").append(Integer.toHexString(getRow())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/MulRKRecord.java b/src/java/org/apache/poi/hssf/record/MulRKRecord.java index ce1727bbe7..30aa1e2a28 100644 --- a/src/java/org/apache/poi/hssf/record/MulRKRecord.java +++ b/src/java/org/apache/poi/hssf/record/MulRKRecord.java @@ -102,7 +102,7 @@ public final class MulRKRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[MULRK]\n"); buffer.append(" .row = ").append(HexDump.shortToHex(getRow())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/NameCommentRecord.java b/src/java/org/apache/poi/hssf/record/NameCommentRecord.java index 63705cc7f8..270440f665 100644 --- a/src/java/org/apache/poi/hssf/record/NameCommentRecord.java +++ b/src/java/org/apache/poi/hssf/record/NameCommentRecord.java @@ -112,7 +112,7 @@ public final class NameCommentRecord extends StandardRecord { @Override public String toString() { - final StringBuffer sb = new StringBuffer(); + final StringBuilder sb = new StringBuilder(); sb.append("[NAMECMT]\n"); sb.append(" .record type = ").append(HexDump.shortToHex(field_1_record_type)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/NoteRecord.java b/src/java/org/apache/poi/hssf/record/NoteRecord.java index f4c81976cb..39992bbdbc 100644 --- a/src/java/org/apache/poi/hssf/record/NoteRecord.java +++ b/src/java/org/apache/poi/hssf/record/NoteRecord.java @@ -125,7 +125,7 @@ public final class NoteRecord extends StandardRecord implements Cloneable { * Used by BiffViewer and other utilities. */ public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[NOTE]\n"); buffer.append(" .row = ").append(field_1_row).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/NoteStructureSubRecord.java b/src/java/org/apache/poi/hssf/record/NoteStructureSubRecord.java index 4f651b7c55..e226b344d0 100644 --- a/src/java/org/apache/poi/hssf/record/NoteStructureSubRecord.java +++ b/src/java/org/apache/poi/hssf/record/NoteStructureSubRecord.java @@ -68,7 +68,7 @@ public final class NoteStructureSubRecord extends SubRecord implements Cloneable @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ftNts ]").append("\n"); buffer.append(" size = ").append(getDataSize()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/ObjRecord.java b/src/java/org/apache/poi/hssf/record/ObjRecord.java index bddd89ce2c..ee786da95d 100644 --- a/src/java/org/apache/poi/hssf/record/ObjRecord.java +++ b/src/java/org/apache/poi/hssf/record/ObjRecord.java @@ -135,7 +135,7 @@ public final class ObjRecord extends Record implements Cloneable { @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[OBJ]\n"); if(subrecords != null) { // there are special cases where this can be, see comments in constructor above diff --git a/src/java/org/apache/poi/hssf/record/ObjectProtectRecord.java b/src/java/org/apache/poi/hssf/record/ObjectProtectRecord.java index 06aab44853..22d548f09a 100644 --- a/src/java/org/apache/poi/hssf/record/ObjectProtectRecord.java +++ b/src/java/org/apache/poi/hssf/record/ObjectProtectRecord.java @@ -73,7 +73,7 @@ public final class ObjectProtectRecord extends StandardRecord implements Cloneab public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SCENARIOPROTECT]\n"); buffer.append(" .protect = ").append(getProtect()) diff --git a/src/java/org/apache/poi/hssf/record/OldSheetRecord.java b/src/java/org/apache/poi/hssf/record/OldSheetRecord.java index 8ccb3cf9d3..195d9319cf 100644 --- a/src/java/org/apache/poi/hssf/record/OldSheetRecord.java +++ b/src/java/org/apache/poi/hssf/record/OldSheetRecord.java @@ -74,7 +74,7 @@ public final class OldSheetRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BOUNDSHEET]\n"); buffer.append(" .bof = ").append(HexDump.intToHex(getPositionOfBof())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/OldStringRecord.java b/src/java/org/apache/poi/hssf/record/OldStringRecord.java index e99313ee19..2d611929f7 100644 --- a/src/java/org/apache/poi/hssf/record/OldStringRecord.java +++ b/src/java/org/apache/poi/hssf/record/OldStringRecord.java @@ -92,7 +92,7 @@ public final class OldStringRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[OLD STRING]\n"); buffer.append(" .string = ") diff --git a/src/java/org/apache/poi/hssf/record/PaletteRecord.java b/src/java/org/apache/poi/hssf/record/PaletteRecord.java index 9ec1c4708b..72b5639581 100644 --- a/src/java/org/apache/poi/hssf/record/PaletteRecord.java +++ b/src/java/org/apache/poi/hssf/record/PaletteRecord.java @@ -54,7 +54,7 @@ public final class PaletteRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PALETTE]\n"); buffer.append(" numcolors = ").append(_colors.size()).append('\n'); @@ -233,7 +233,7 @@ public final class PaletteRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" red = ").append(_red & 0xff).append('\n'); buffer.append(" green = ").append(_green & 0xff).append('\n'); buffer.append(" blue = ").append(_blue & 0xff).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/PaneRecord.java b/src/java/org/apache/poi/hssf/record/PaneRecord.java index 69b94feb1d..4b0610aba7 100644 --- a/src/java/org/apache/poi/hssf/record/PaneRecord.java +++ b/src/java/org/apache/poi/hssf/record/PaneRecord.java @@ -54,7 +54,7 @@ public final class PaneRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PANE]\n"); buffer.append(" .x = ") diff --git a/src/java/org/apache/poi/hssf/record/PasswordRecord.java b/src/java/org/apache/poi/hssf/record/PasswordRecord.java index c80e8c82c6..211ddcbe58 100644 --- a/src/java/org/apache/poi/hssf/record/PasswordRecord.java +++ b/src/java/org/apache/poi/hssf/record/PasswordRecord.java @@ -57,7 +57,7 @@ public final class PasswordRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PASSWORD]\n"); buffer.append(" .password = ").append(HexDump.shortToHex(field_1_password)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/PasswordRev4Record.java b/src/java/org/apache/poi/hssf/record/PasswordRev4Record.java index 16ef49a6f5..ed8f4ff970 100644 --- a/src/java/org/apache/poi/hssf/record/PasswordRev4Record.java +++ b/src/java/org/apache/poi/hssf/record/PasswordRev4Record.java @@ -47,7 +47,7 @@ public final class PasswordRev4Record extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PROT4REVPASSWORD]\n"); buffer.append(" .password = ").append(HexDump.shortToHex(field_1_password)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/PrintSetupRecord.java b/src/java/org/apache/poi/hssf/record/PrintSetupRecord.java index 9ab4fe1a68..6ab28c2369 100644 --- a/src/java/org/apache/poi/hssf/record/PrintSetupRecord.java +++ b/src/java/org/apache/poi/hssf/record/PrintSetupRecord.java @@ -279,7 +279,7 @@ public final class PrintSetupRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PRINTSETUP]\n"); buffer.append(" .papersize = ").append(getPaperSize()) diff --git a/src/java/org/apache/poi/hssf/record/ProtectRecord.java b/src/java/org/apache/poi/hssf/record/ProtectRecord.java index dca418e07e..9058026ad9 100644 --- a/src/java/org/apache/poi/hssf/record/ProtectRecord.java +++ b/src/java/org/apache/poi/hssf/record/ProtectRecord.java @@ -66,7 +66,7 @@ public final class ProtectRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PROTECT]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/ProtectionRev4Record.java b/src/java/org/apache/poi/hssf/record/ProtectionRev4Record.java index 6a9ca300f8..ba51b6df38 100644 --- a/src/java/org/apache/poi/hssf/record/ProtectionRev4Record.java +++ b/src/java/org/apache/poi/hssf/record/ProtectionRev4Record.java @@ -64,7 +64,7 @@ public final class ProtectionRev4Record extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PROT4REV]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/RecalcIdRecord.java b/src/java/org/apache/poi/hssf/record/RecalcIdRecord.java index e890b43f93..933c5a9698 100644 --- a/src/java/org/apache/poi/hssf/record/RecalcIdRecord.java +++ b/src/java/org/apache/poi/hssf/record/RecalcIdRecord.java @@ -68,7 +68,7 @@ public final class RecalcIdRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[RECALCID]\n"); buffer.append(" .reserved = ").append(HexDump.shortToHex(_reserved0)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/RefModeRecord.java b/src/java/org/apache/poi/hssf/record/RefModeRecord.java index ef1316e488..987da8f768 100644 --- a/src/java/org/apache/poi/hssf/record/RefModeRecord.java +++ b/src/java/org/apache/poi/hssf/record/RefModeRecord.java @@ -74,7 +74,7 @@ public final class RefModeRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[REFMODE]\n"); buffer.append(" .mode = ") diff --git a/src/java/org/apache/poi/hssf/record/RefreshAllRecord.java b/src/java/org/apache/poi/hssf/record/RefreshAllRecord.java index a6e547fea8..ebe1c7ea3e 100644 --- a/src/java/org/apache/poi/hssf/record/RefreshAllRecord.java +++ b/src/java/org/apache/poi/hssf/record/RefreshAllRecord.java @@ -65,7 +65,7 @@ public final class RefreshAllRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[REFRESHALL]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/RightMarginRecord.java b/src/java/org/apache/poi/hssf/record/RightMarginRecord.java index 09b1d9684a..4a8f1b33f2 100644 --- a/src/java/org/apache/poi/hssf/record/RightMarginRecord.java +++ b/src/java/org/apache/poi/hssf/record/RightMarginRecord.java @@ -35,7 +35,7 @@ public final class RightMarginRecord extends StandardRecord implements Margin { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( "[RightMargin]\n" ); buffer.append( " .margin = " ).append( " (" ).append( getMargin() ).append( " )\n" ); buffer.append( "[/RightMargin]\n" ); diff --git a/src/java/org/apache/poi/hssf/record/RowRecord.java b/src/java/org/apache/poi/hssf/record/RowRecord.java index 20951cb9f9..2987e042ed 100644 --- a/src/java/org/apache/poi/hssf/record/RowRecord.java +++ b/src/java/org/apache/poi/hssf/record/RowRecord.java @@ -366,7 +366,7 @@ public final class RowRecord extends StandardRecord { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[ROW]\n"); sb.append(" .rownumber = ").append(Integer.toHexString(getRowNumber())) diff --git a/src/java/org/apache/poi/hssf/record/SCLRecord.java b/src/java/org/apache/poi/hssf/record/SCLRecord.java index 5b360937f8..c4dbfb0a53 100644 --- a/src/java/org/apache/poi/hssf/record/SCLRecord.java +++ b/src/java/org/apache/poi/hssf/record/SCLRecord.java @@ -44,7 +44,7 @@ public final class SCLRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SCL]\n"); buffer.append(" .numerator = ") diff --git a/src/java/org/apache/poi/hssf/record/ScenarioProtectRecord.java b/src/java/org/apache/poi/hssf/record/ScenarioProtectRecord.java index 37605c6996..20e10945c0 100644 --- a/src/java/org/apache/poi/hssf/record/ScenarioProtectRecord.java +++ b/src/java/org/apache/poi/hssf/record/ScenarioProtectRecord.java @@ -76,7 +76,7 @@ public final class ScenarioProtectRecord public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SCENARIOPROTECT]\n"); buffer.append(" .protect = ").append(getProtect()) diff --git a/src/java/org/apache/poi/hssf/record/TabIdRecord.java b/src/java/org/apache/poi/hssf/record/TabIdRecord.java index acc6a05958..833357029e 100644 --- a/src/java/org/apache/poi/hssf/record/TabIdRecord.java +++ b/src/java/org/apache/poi/hssf/record/TabIdRecord.java @@ -52,7 +52,7 @@ public final class TabIdRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[TABID]\n"); buffer.append(" .elements = ").append(_tabids.length).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/TableStylesRecord.java b/src/java/org/apache/poi/hssf/record/TableStylesRecord.java index 27bd8a71f8..df15ac2355 100644 --- a/src/java/org/apache/poi/hssf/record/TableStylesRecord.java +++ b/src/java/org/apache/poi/hssf/record/TableStylesRecord.java @@ -76,7 +76,7 @@ public final class TableStylesRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[TABLESTYLES]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/TopMarginRecord.java b/src/java/org/apache/poi/hssf/record/TopMarginRecord.java index 2dfa32b46d..99d7d49021 100644 --- a/src/java/org/apache/poi/hssf/record/TopMarginRecord.java +++ b/src/java/org/apache/poi/hssf/record/TopMarginRecord.java @@ -38,7 +38,7 @@ public final class TopMarginRecord extends StandardRecord implements Margin { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( "[TopMargin]\n" ); buffer.append( " .margin = " ).append( " (" ).append( getMargin() ).append( " )\n" ); buffer.append( "[/TopMargin]\n" ); diff --git a/src/java/org/apache/poi/hssf/record/UncalcedRecord.java b/src/java/org/apache/poi/hssf/record/UncalcedRecord.java index 2ae3e03e79..9310766aac 100644 --- a/src/java/org/apache/poi/hssf/record/UncalcedRecord.java +++ b/src/java/org/apache/poi/hssf/record/UncalcedRecord.java @@ -45,7 +45,7 @@ public final class UncalcedRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[UNCALCED]\n"); buffer.append(" _reserved: ").append(_reserved).append('\n'); buffer.append("[/UNCALCED]\n"); diff --git a/src/java/org/apache/poi/hssf/record/UseSelFSRecord.java b/src/java/org/apache/poi/hssf/record/UseSelFSRecord.java index 19fdf35f06..c8d6691300 100644 --- a/src/java/org/apache/poi/hssf/record/UseSelFSRecord.java +++ b/src/java/org/apache/poi/hssf/record/UseSelFSRecord.java @@ -49,7 +49,7 @@ public final class UseSelFSRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[USESELFS]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/VCenterRecord.java b/src/java/org/apache/poi/hssf/record/VCenterRecord.java index f14845c7e4..2439a9a42d 100644 --- a/src/java/org/apache/poi/hssf/record/VCenterRecord.java +++ b/src/java/org/apache/poi/hssf/record/VCenterRecord.java @@ -63,7 +63,7 @@ public final class VCenterRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[VCENTER]\n"); buffer.append(" .vcenter = ").append(getVCenter()) diff --git a/src/java/org/apache/poi/hssf/record/WindowProtectRecord.java b/src/java/org/apache/poi/hssf/record/WindowProtectRecord.java index a360bc4b06..12d471c385 100644 --- a/src/java/org/apache/poi/hssf/record/WindowProtectRecord.java +++ b/src/java/org/apache/poi/hssf/record/WindowProtectRecord.java @@ -65,7 +65,7 @@ public final class WindowProtectRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[WINDOWPROTECT]\n"); buffer.append(" .options = ").append(HexDump.shortToHex(_options)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/WriteAccessRecord.java b/src/java/org/apache/poi/hssf/record/WriteAccessRecord.java index 7d3a2b9eb1..e6d62ca4ff 100644 --- a/src/java/org/apache/poi/hssf/record/WriteAccessRecord.java +++ b/src/java/org/apache/poi/hssf/record/WriteAccessRecord.java @@ -117,7 +117,7 @@ public final class WriteAccessRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[WRITEACCESS]\n"); buffer.append(" .name = ").append(field_1_username).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/WriteProtectRecord.java b/src/java/org/apache/poi/hssf/record/WriteProtectRecord.java index e958adb5eb..edd4962569 100644 --- a/src/java/org/apache/poi/hssf/record/WriteProtectRecord.java +++ b/src/java/org/apache/poi/hssf/record/WriteProtectRecord.java @@ -44,7 +44,7 @@ public final class WriteProtectRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[WRITEPROTECT]\n"); buffer.append("[/WRITEPROTECT]\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/BorderFormatting.java b/src/java/org/apache/poi/hssf/record/cf/BorderFormatting.java index 41f465357f..b612a5ee3e 100644 --- a/src/java/org/apache/poi/hssf/record/cf/BorderFormatting.java +++ b/src/java/org/apache/poi/hssf/record/cf/BorderFormatting.java @@ -430,7 +430,7 @@ public final class BorderFormatting implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Border Formatting]\n"); buffer.append(" .lftln = ").append(Integer.toHexString(getBorderLeft())).append("\n"); buffer.append(" .rgtln = ").append(Integer.toHexString(getBorderRight())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java b/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java index 02bfa33676..ea781a8062 100644 --- a/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java +++ b/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java @@ -119,7 +119,7 @@ public final class ColorGradientFormatting implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Color Gradient Formatting]\n"); buffer.append(" .clamp = ").append(isClampToCurve()).append("\n"); buffer.append(" .background= ").append(isAppliesToBackground()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java b/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java index 60c1a521fc..2e5cb7252b 100644 --- a/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java +++ b/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java @@ -119,7 +119,7 @@ public final class DataBarFormatting implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Data Bar Formatting]\n"); buffer.append(" .icon_only= ").append(isIconOnly()).append("\n"); buffer.append(" .reversed = ").append(isReversed()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/IconMultiStateFormatting.java b/src/java/org/apache/poi/hssf/record/cf/IconMultiStateFormatting.java index f2cf009666..b388296180 100644 --- a/src/java/org/apache/poi/hssf/record/cf/IconMultiStateFormatting.java +++ b/src/java/org/apache/poi/hssf/record/cf/IconMultiStateFormatting.java @@ -97,7 +97,7 @@ public final class IconMultiStateFormatting implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Icon Formatting]\n"); buffer.append(" .icon_set = ").append(iconSet).append("\n"); buffer.append(" .icon_only= ").append(isIconOnly()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/PatternFormatting.java b/src/java/org/apache/poi/hssf/record/cf/PatternFormatting.java index 3e18eace9b..1294e43d16 100644 --- a/src/java/org/apache/poi/hssf/record/cf/PatternFormatting.java +++ b/src/java/org/apache/poi/hssf/record/cf/PatternFormatting.java @@ -156,7 +156,7 @@ public final class PatternFormatting implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Pattern Formatting]\n"); buffer.append(" .fillpattern= ").append(Integer.toHexString(getFillPattern())).append("\n"); buffer.append(" .fgcoloridx= ").append(Integer.toHexString(getFillForegroundColor())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/cf/Threshold.java b/src/java/org/apache/poi/hssf/record/cf/Threshold.java index 946c181660..71df40b9c0 100644 --- a/src/java/org/apache/poi/hssf/record/cf/Threshold.java +++ b/src/java/org/apache/poi/hssf/record/cf/Threshold.java @@ -102,7 +102,7 @@ public abstract class Threshold { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [CF Threshold]\n"); buffer.append(" .type = ").append(Integer.toHexString(type)).append("\n"); buffer.append(" .formula = ").append(Arrays.toString(formula.getTokens())).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/AreaFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/AreaFormatRecord.java index 9c8ba326c5..afda4669a6 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AreaFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AreaFormatRecord.java @@ -61,7 +61,7 @@ public final class AreaFormatRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AREAFORMAT]\n"); buffer.append(" .foregroundColor = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AreaRecord.java b/src/java/org/apache/poi/hssf/record/chart/AreaRecord.java index 4e15d22ba1..77746d40a1 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AreaRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AreaRecord.java @@ -50,7 +50,7 @@ public final class AreaRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AREA]\n"); buffer.append(" .formatFlags = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AxisLineFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/AxisLineFormatRecord.java index af9c943826..7996aa99c7 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AxisLineFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AxisLineFormatRecord.java @@ -48,7 +48,7 @@ public final class AxisLineFormatRecord extends StandardRecord implements Clonea public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AXISLINEFORMAT]\n"); buffer.append(" .axisType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AxisOptionsRecord.java b/src/java/org/apache/poi/hssf/record/chart/AxisOptionsRecord.java index 463340616d..b08fdb29e6 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AxisOptionsRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AxisOptionsRecord.java @@ -72,7 +72,7 @@ public final class AxisOptionsRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AXCEXT]\n"); buffer.append(" .minimumCategory = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AxisParentRecord.java b/src/java/org/apache/poi/hssf/record/chart/AxisParentRecord.java index b809d227e8..8eda4ba2d2 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AxisParentRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AxisParentRecord.java @@ -54,7 +54,7 @@ public final class AxisParentRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AXISPARENT]\n"); buffer.append(" .axisType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AxisRecord.java b/src/java/org/apache/poi/hssf/record/chart/AxisRecord.java index 3c363eab36..e418119b19 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AxisRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AxisRecord.java @@ -55,7 +55,7 @@ public final class AxisRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AXIS]\n"); buffer.append(" .axisType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/AxisUsedRecord.java b/src/java/org/apache/poi/hssf/record/chart/AxisUsedRecord.java index 1725059e3a..1c4f4eeb43 100644 --- a/src/java/org/apache/poi/hssf/record/chart/AxisUsedRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/AxisUsedRecord.java @@ -44,7 +44,7 @@ public final class AxisUsedRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AXISUSED]\n"); buffer.append(" .numAxis = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/BarRecord.java b/src/java/org/apache/poi/hssf/record/chart/BarRecord.java index ad53d145dd..58c3af30e3 100644 --- a/src/java/org/apache/poi/hssf/record/chart/BarRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/BarRecord.java @@ -56,7 +56,7 @@ public final class BarRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BAR]\n"); buffer.append(" .barSpace = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/BeginRecord.java b/src/java/org/apache/poi/hssf/record/chart/BeginRecord.java index 10e4bd4f88..e50db00367 100644 --- a/src/java/org/apache/poi/hssf/record/chart/BeginRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/BeginRecord.java @@ -45,7 +45,7 @@ public final class BeginRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[BEGIN]\n"); buffer.append("[/BEGIN]\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/CatLabRecord.java b/src/java/org/apache/poi/hssf/record/chart/CatLabRecord.java index 22c159635c..5404d8e371 100644 --- a/src/java/org/apache/poi/hssf/record/chart/CatLabRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/CatLabRecord.java @@ -75,7 +75,7 @@ public final class CatLabRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CATLAB]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/CategorySeriesAxisRecord.java b/src/java/org/apache/poi/hssf/record/chart/CategorySeriesAxisRecord.java index 45e1c65724..79574286d8 100644 --- a/src/java/org/apache/poi/hssf/record/chart/CategorySeriesAxisRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/CategorySeriesAxisRecord.java @@ -57,7 +57,7 @@ public final class CategorySeriesAxisRecord extends StandardRecord implements Cl public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CATSERRANGE]\n"); buffer.append(" .crossingPoint = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartEndBlockRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartEndBlockRecord.java index 04c8558183..cbb092c4f8 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartEndBlockRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartEndBlockRecord.java @@ -73,7 +73,7 @@ public final class ChartEndBlockRecord extends StandardRecord implements Cloneab @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ENDBLOCK]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartEndObjectRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartEndObjectRecord.java index 49de2394ff..e097ce0ad9 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartEndObjectRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartEndObjectRecord.java @@ -71,7 +71,7 @@ public final class ChartEndObjectRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ENDOBJECT]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartFRTInfoRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartFRTInfoRecord.java index 83b135c3cb..f3680f3bfb 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartFRTInfoRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartFRTInfoRecord.java @@ -91,7 +91,7 @@ public final class ChartFRTInfoRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CHARTFRTINFO]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartFormatRecord.java index 326e4053da..5599f63697 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartFormatRecord.java @@ -57,7 +57,7 @@ public final class ChartFormatRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CHARTFORMAT]\n"); buffer.append(" .xPosition = ").append(getXPosition()).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartRecord.java index 8a4deeb8ba..33590ece50 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartRecord.java @@ -58,7 +58,7 @@ public final class ChartRecord extends StandardRecord implements Cloneable { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[CHART]\n"); sb.append(" .x = ").append(getX()).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartStartBlockRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartStartBlockRecord.java index 80ef481813..fb98a7cf82 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartStartBlockRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartStartBlockRecord.java @@ -69,7 +69,7 @@ public final class ChartStartBlockRecord extends StandardRecord implements Clone public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[STARTBLOCK]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartStartObjectRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartStartObjectRecord.java index aa2ed5f4f1..5ddaecc117 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartStartObjectRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartStartObjectRecord.java @@ -66,7 +66,7 @@ public final class ChartStartObjectRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[STARTOBJECT]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/ChartTitleFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/ChartTitleFormatRecord.java index f98891db01..09229072da 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ChartTitleFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ChartTitleFormatRecord.java @@ -102,7 +102,7 @@ public class ChartTitleFormatRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[CHARTTITLEFORMAT]\n"); buffer.append(" .format_runs = ").append(_formats.length).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/DatRecord.java b/src/java/org/apache/poi/hssf/record/chart/DatRecord.java index 18d07bf028..4d7d29f328 100644 --- a/src/java/org/apache/poi/hssf/record/chart/DatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/DatRecord.java @@ -50,7 +50,7 @@ public final class DatRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DAT]\n"); buffer.append(" .options = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/DataFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/DataFormatRecord.java index 7151608523..2c7d5c23b2 100644 --- a/src/java/org/apache/poi/hssf/record/chart/DataFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/DataFormatRecord.java @@ -53,7 +53,7 @@ public final class DataFormatRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DATAFORMAT]\n"); buffer.append(" .pointNumber = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/DataLabelExtensionRecord.java b/src/java/org/apache/poi/hssf/record/chart/DataLabelExtensionRecord.java index abda36e5b8..64f29efc44 100644 --- a/src/java/org/apache/poi/hssf/record/chart/DataLabelExtensionRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/DataLabelExtensionRecord.java @@ -57,7 +57,7 @@ public final class DataLabelExtensionRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DATALABEXT]\n"); buffer.append(" .rt =").append(HexDump.shortToHex(rt)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/DefaultDataLabelTextPropertiesRecord.java b/src/java/org/apache/poi/hssf/record/chart/DefaultDataLabelTextPropertiesRecord.java index 48c6d6c2b6..b26f39b1e2 100644 --- a/src/java/org/apache/poi/hssf/record/chart/DefaultDataLabelTextPropertiesRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/DefaultDataLabelTextPropertiesRecord.java @@ -45,7 +45,7 @@ public final class DefaultDataLabelTextPropertiesRecord extends StandardRecord i public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[DEFAULTTEXT]\n"); buffer.append(" .categoryDataType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/EndRecord.java b/src/java/org/apache/poi/hssf/record/chart/EndRecord.java index 238c5ae11a..bb539c21d8 100644 --- a/src/java/org/apache/poi/hssf/record/chart/EndRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/EndRecord.java @@ -46,7 +46,7 @@ public final class EndRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[END]\n"); buffer.append("[/END]\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/FontBasisRecord.java b/src/java/org/apache/poi/hssf/record/chart/FontBasisRecord.java index 65be2378f7..6b24869bfe 100644 --- a/src/java/org/apache/poi/hssf/record/chart/FontBasisRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/FontBasisRecord.java @@ -50,7 +50,7 @@ public final class FontBasisRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FBI]\n"); buffer.append(" .xBasis = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/FontIndexRecord.java b/src/java/org/apache/poi/hssf/record/chart/FontIndexRecord.java index 167e8e07b2..cd3f08ffc2 100644 --- a/src/java/org/apache/poi/hssf/record/chart/FontIndexRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/FontIndexRecord.java @@ -44,7 +44,7 @@ public final class FontIndexRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FONTX]\n"); buffer.append(" .fontIndex = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/FrameRecord.java b/src/java/org/apache/poi/hssf/record/chart/FrameRecord.java index 6515d4a7e7..f78574a674 100644 --- a/src/java/org/apache/poi/hssf/record/chart/FrameRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/FrameRecord.java @@ -52,7 +52,7 @@ public final class FrameRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[FRAME]\n"); buffer.append(" .borderType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/LegendRecord.java b/src/java/org/apache/poi/hssf/record/chart/LegendRecord.java index 04e3de1e45..2a4a3ba98b 100644 --- a/src/java/org/apache/poi/hssf/record/chart/LegendRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/LegendRecord.java @@ -73,7 +73,7 @@ public final class LegendRecord extends StandardRecord implements Cloneable { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[LEGEND]\n"); buffer.append(" .xAxisUpperLeft = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/LineFormatRecord.java b/src/java/org/apache/poi/hssf/record/chart/LineFormatRecord.java index d21a564b2e..e0acece3ba 100644 --- a/src/java/org/apache/poi/hssf/record/chart/LineFormatRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/LineFormatRecord.java @@ -71,7 +71,7 @@ public final class LineFormatRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[LINEFORMAT]\n"); buffer.append(" .lineColor = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/LinkedDataRecord.java b/src/java/org/apache/poi/hssf/record/chart/LinkedDataRecord.java index efc3c05d67..96c8501d33 100644 --- a/src/java/org/apache/poi/hssf/record/chart/LinkedDataRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/LinkedDataRecord.java @@ -66,7 +66,7 @@ public final class LinkedDataRecord extends StandardRecord implements Cloneable } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[AI]\n"); buffer.append(" .linkType = ").append(HexDump.byteToHex(getLinkType())).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/NumberFormatIndexRecord.java b/src/java/org/apache/poi/hssf/record/chart/NumberFormatIndexRecord.java index 99f609f541..9ba2a27b16 100644 --- a/src/java/org/apache/poi/hssf/record/chart/NumberFormatIndexRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/NumberFormatIndexRecord.java @@ -42,7 +42,7 @@ public final class NumberFormatIndexRecord extends StandardRecord implements Clo public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[IFMT]\n"); buffer.append(" .formatIndex = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/ObjectLinkRecord.java b/src/java/org/apache/poi/hssf/record/chart/ObjectLinkRecord.java index d21387c955..c179f2603f 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ObjectLinkRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ObjectLinkRecord.java @@ -52,7 +52,7 @@ public final class ObjectLinkRecord extends StandardRecord implements Cloneable public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[OBJECTLINK]\n"); buffer.append(" .anchorId = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/PlotAreaRecord.java b/src/java/org/apache/poi/hssf/record/chart/PlotAreaRecord.java index e33e479ca5..920fbc2e66 100644 --- a/src/java/org/apache/poi/hssf/record/chart/PlotAreaRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/PlotAreaRecord.java @@ -43,7 +43,7 @@ public final class PlotAreaRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PLOTAREA]\n"); diff --git a/src/java/org/apache/poi/hssf/record/chart/PlotGrowthRecord.java b/src/java/org/apache/poi/hssf/record/chart/PlotGrowthRecord.java index aa326aca05..d538a9b44f 100644 --- a/src/java/org/apache/poi/hssf/record/chart/PlotGrowthRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/PlotGrowthRecord.java @@ -45,7 +45,7 @@ public final class PlotGrowthRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[PLOTGROWTH]\n"); buffer.append(" .horizontalScale = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesChartGroupIndexRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesChartGroupIndexRecord.java index 18f428ab52..6d095149c5 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesChartGroupIndexRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesChartGroupIndexRecord.java @@ -42,7 +42,7 @@ public final class SeriesChartGroupIndexRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SERTOCRT]\n"); buffer.append(" .chartGroupIndex = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesIndexRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesIndexRecord.java index 08efc7fa9a..09d8c65b4f 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesIndexRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesIndexRecord.java @@ -42,7 +42,7 @@ public final class SeriesIndexRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SINDEX]\n"); buffer.append(" .index = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesLabelsRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesLabelsRecord.java index 27b0914b70..66a49188a7 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesLabelsRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesLabelsRecord.java @@ -53,7 +53,7 @@ public final class SeriesLabelsRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[ATTACHEDLABEL]\n"); buffer.append(" .formatFlags = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesListRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesListRecord.java index 5d101f9039..5457702ee6 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesListRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesListRecord.java @@ -50,7 +50,7 @@ public final class SeriesListRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SERIESLIST]\n"); buffer.append(" .seriesNumbers= ").append(" (").append( Arrays.toString(getSeriesNumbers()) ).append(" )"); diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesRecord.java index 0ff5564ac5..6ebef9abd4 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesRecord.java @@ -65,7 +65,7 @@ public final class SeriesRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SERIES]\n"); buffer.append(" .categoryDataType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesTextRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesTextRecord.java index 7e349895a6..f6b0de4f29 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesTextRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesTextRecord.java @@ -53,7 +53,7 @@ public final class SeriesTextRecord extends StandardRecord { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("[SERIESTEXT]\n"); sb.append(" .id =").append(HexDump.shortToHex(getId())).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/SeriesToChartGroupRecord.java b/src/java/org/apache/poi/hssf/record/chart/SeriesToChartGroupRecord.java index fcb73e84f1..17e6134bcf 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SeriesToChartGroupRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SeriesToChartGroupRecord.java @@ -44,7 +44,7 @@ public final class SeriesToChartGroupRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SeriesToChartGroup]\n"); buffer.append(" .chartGroupIndex = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/SheetPropertiesRecord.java b/src/java/org/apache/poi/hssf/record/chart/SheetPropertiesRecord.java index d264459f8d..cc79df93d7 100644 --- a/src/java/org/apache/poi/hssf/record/chart/SheetPropertiesRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/SheetPropertiesRecord.java @@ -56,7 +56,7 @@ public final class SheetPropertiesRecord extends StandardRecord { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SHTPROPS]\n"); buffer.append(" .flags = ").append(HexDump.shortToHex(field_1_flags)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/chart/TextRecord.java b/src/java/org/apache/poi/hssf/record/chart/TextRecord.java index 28fb653187..ce447694cb 100644 --- a/src/java/org/apache/poi/hssf/record/chart/TextRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/TextRecord.java @@ -109,7 +109,7 @@ public final class TextRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[TEXT]\n"); buffer.append(" .horizontalAlignment = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/TickRecord.java b/src/java/org/apache/poi/hssf/record/chart/TickRecord.java index e77b3f3f41..9080a22e24 100644 --- a/src/java/org/apache/poi/hssf/record/chart/TickRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/TickRecord.java @@ -76,7 +76,7 @@ public final class TickRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[TICK]\n"); buffer.append(" .majorTickType = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/UnitsRecord.java b/src/java/org/apache/poi/hssf/record/chart/UnitsRecord.java index cab88c0776..c1823554f0 100644 --- a/src/java/org/apache/poi/hssf/record/chart/UnitsRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/UnitsRecord.java @@ -43,7 +43,7 @@ public final class UnitsRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[UNITS]\n"); buffer.append(" .units = ") diff --git a/src/java/org/apache/poi/hssf/record/chart/ValueRangeRecord.java b/src/java/org/apache/poi/hssf/record/chart/ValueRangeRecord.java index e098011a6c..73d810ea54 100644 --- a/src/java/org/apache/poi/hssf/record/chart/ValueRangeRecord.java +++ b/src/java/org/apache/poi/hssf/record/chart/ValueRangeRecord.java @@ -66,7 +66,7 @@ public final class ValueRangeRecord extends StandardRecord { public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[VALUERANGE]\n"); buffer.append(" .minimumAxisValue = ") diff --git a/src/java/org/apache/poi/hssf/record/common/ExtendedColor.java b/src/java/org/apache/poi/hssf/record/common/ExtendedColor.java index a4defe8dde..2d8ba002d0 100644 --- a/src/java/org/apache/poi/hssf/record/common/ExtendedColor.java +++ b/src/java/org/apache/poi/hssf/record/common/ExtendedColor.java @@ -136,7 +136,7 @@ public final class ExtendedColor implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [Extended Color]\n"); buffer.append(" .type = ").append(type).append("\n"); buffer.append(" .tint = ").append(tint).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/common/FeatFormulaErr2.java b/src/java/org/apache/poi/hssf/record/common/FeatFormulaErr2.java index 8ab9936320..e798337f82 100644 --- a/src/java/org/apache/poi/hssf/record/common/FeatFormulaErr2.java +++ b/src/java/org/apache/poi/hssf/record/common/FeatFormulaErr2.java @@ -58,7 +58,7 @@ public final class FeatFormulaErr2 implements SharedFeature { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [FEATURE FORMULA ERRORS]\n"); buffer.append(" checkCalculationErrors = "); buffer.append(" checkEmptyCellRef = "); diff --git a/src/java/org/apache/poi/hssf/record/common/FeatProtection.java b/src/java/org/apache/poi/hssf/record/common/FeatProtection.java index f61d5ae3e4..2e6e94008a 100644 --- a/src/java/org/apache/poi/hssf/record/common/FeatProtection.java +++ b/src/java/org/apache/poi/hssf/record/common/FeatProtection.java @@ -65,7 +65,7 @@ public final class FeatProtection implements SharedFeature { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [FEATURE PROTECTION]\n"); buffer.append(" Self Relative = " + fSD); buffer.append(" Password Verifier = " + passwordVerifier); diff --git a/src/java/org/apache/poi/hssf/record/common/FeatSmartTag.java b/src/java/org/apache/poi/hssf/record/common/FeatSmartTag.java index f2e9cc69f7..c8e2b29542 100644 --- a/src/java/org/apache/poi/hssf/record/common/FeatSmartTag.java +++ b/src/java/org/apache/poi/hssf/record/common/FeatSmartTag.java @@ -46,7 +46,7 @@ public final class FeatSmartTag implements SharedFeature { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [FEATURE SMART TAGS]\n"); buffer.append(" [/FEATURE SMART TAGS]\n"); return buffer.toString(); diff --git a/src/java/org/apache/poi/hssf/record/common/FtrHeader.java b/src/java/org/apache/poi/hssf/record/common/FtrHeader.java index eecc541caf..5d08211c0a 100644 --- a/src/java/org/apache/poi/hssf/record/common/FtrHeader.java +++ b/src/java/org/apache/poi/hssf/record/common/FtrHeader.java @@ -48,7 +48,7 @@ public final class FtrHeader implements Cloneable { } public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(" [FUTURE HEADER]\n"); buffer.append(" Type " + recordType); buffer.append(" Flags " + grbitFrt); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/DataItemRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/DataItemRecord.java index 936747579b..d104540082 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/DataItemRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/DataItemRecord.java @@ -75,7 +75,7 @@ public final class DataItemRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXDI]\n"); buffer.append(" .isxvdData = ").append(HexDump.shortToHex(isxvdData)).append("\n"); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/ExtendedPivotTableViewFieldsRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/ExtendedPivotTableViewFieldsRecord.java index 87baf1492d..0a1bb11cd3 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/ExtendedPivotTableViewFieldsRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/ExtendedPivotTableViewFieldsRecord.java @@ -111,7 +111,7 @@ public final class ExtendedPivotTableViewFieldsRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXVDEX]\n"); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/StreamIDRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/StreamIDRecord.java index 034070fe15..70c82f0a33 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/StreamIDRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/StreamIDRecord.java @@ -53,7 +53,7 @@ public final class StreamIDRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXIDSTM]\n"); buffer.append(" .idstm =").append(HexDump.shortToHex(idstm)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/ViewDefinitionRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/ViewDefinitionRecord.java index c14403ece0..afda2ac001 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/ViewDefinitionRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/ViewDefinitionRecord.java @@ -128,7 +128,7 @@ public final class ViewDefinitionRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXVIEW]\n"); buffer.append(" .rwFirst =").append(HexDump.shortToHex(rwFirst)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/ViewFieldsRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/ViewFieldsRecord.java index 2003c9419f..8c761ea8ff 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/ViewFieldsRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/ViewFieldsRecord.java @@ -103,7 +103,7 @@ public final class ViewFieldsRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXVD]\n"); buffer.append(" .sxaxis = ").append(HexDump.shortToHex(_sxaxis)).append('\n'); buffer.append(" .cSub = ").append(HexDump.shortToHex(_cSub)).append('\n'); diff --git a/src/java/org/apache/poi/hssf/record/pivottable/ViewSourceRecord.java b/src/java/org/apache/poi/hssf/record/pivottable/ViewSourceRecord.java index c956bb44bf..b4fb2815b9 100644 --- a/src/java/org/apache/poi/hssf/record/pivottable/ViewSourceRecord.java +++ b/src/java/org/apache/poi/hssf/record/pivottable/ViewSourceRecord.java @@ -53,7 +53,7 @@ public final class ViewSourceRecord extends StandardRecord { @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("[SXVS]\n"); buffer.append(" .vs =").append(HexDump.shortToHex(vs)).append('\n'); diff --git a/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java b/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java index 57b13bf426..926a0a1854 100644 --- a/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java +++ b/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java @@ -175,7 +175,7 @@ public final class CollaboratingWorkbooksEnvironment { } WorkbookEvaluator result = _evaluatorsByName.get(workbookName); if (result == null) { - StringBuffer sb = new StringBuffer(256); + StringBuilder sb = new StringBuilder(256); sb.append("Could not resolve external workbook name '").append(workbookName).append("'."); if (_evaluators.length < 1) { sb.append(" Workbook environment has not been set up."); diff --git a/src/java/org/apache/poi/ss/formula/NameIdentifier.java b/src/java/org/apache/poi/ss/formula/NameIdentifier.java index 341a9605da..4245afff18 100644 --- a/src/java/org/apache/poi/ss/formula/NameIdentifier.java +++ b/src/java/org/apache/poi/ss/formula/NameIdentifier.java @@ -32,7 +32,7 @@ public class NameIdentifier { return _isQuoted; } public String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()); sb.append(" ["); if (_isQuoted) { diff --git a/src/java/org/apache/poi/ss/formula/functions/Countif.java b/src/java/org/apache/poi/ss/formula/functions/Countif.java index 04328d28d1..4ae0874eb0 100644 --- a/src/java/org/apache/poi/ss/formula/functions/Countif.java +++ b/src/java/org/apache/poi/ss/formula/functions/Countif.java @@ -138,7 +138,7 @@ public final class Countif extends Fixed2ArgFunction { } @Override public String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()); sb.append(" [").append(_representation).append("]"); return sb.toString(); diff --git a/src/java/org/apache/poi/ss/formula/functions/Replace.java b/src/java/org/apache/poi/ss/formula/functions/Replace.java index 4045d92603..5b4eeabef2 100644 --- a/src/java/org/apache/poi/ss/formula/functions/Replace.java +++ b/src/java/org/apache/poi/ss/formula/functions/Replace.java @@ -58,7 +58,7 @@ public final class Replace extends Fixed4ArgFunction { if (startNum < 1 || numChars < 0) { return ErrorEval.VALUE_INVALID; } - StringBuffer strBuff = new StringBuffer(oldStr); + StringBuilder strBuff = new StringBuilder(oldStr); // remove any characters that should be replaced if (startNum <= oldStr.length() && numChars != 0) { strBuff.delete(startNum - 1, startNum - 1 + numChars); diff --git a/src/java/org/apache/poi/ss/formula/functions/Rept.java b/src/java/org/apache/poi/ss/formula/functions/Rept.java index d448a35b9c..50dc559fab 100644 --- a/src/java/org/apache/poi/ss/formula/functions/Rept.java +++ b/src/java/org/apache/poi/ss/formula/functions/Rept.java @@ -60,7 +60,7 @@ public class Rept extends Fixed2ArgFunction { } int numberOfTimeInt = (int)numberOfTime; - StringBuffer strb = new StringBuffer(strText1.length() * numberOfTimeInt); + StringBuilder strb = new StringBuilder(strText1.length() * numberOfTimeInt); for(int i = 0; i < numberOfTimeInt; i++) { strb.append(strText1); } diff --git a/src/java/org/apache/poi/ss/formula/functions/Substitute.java b/src/java/org/apache/poi/ss/formula/functions/Substitute.java index e6b55c0d12..3f17557c99 100644 --- a/src/java/org/apache/poi/ss/formula/functions/Substitute.java +++ b/src/java/org/apache/poi/ss/formula/functions/Substitute.java @@ -64,9 +64,9 @@ public final class Substitute extends Var3or4ArgFunction { } private static String replaceAllOccurrences(String oldStr, String searchStr, String newStr) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); int startIndex = 0; - int nextMatch = -1; + int nextMatch; while (true) { nextMatch = oldStr.indexOf(searchStr, startIndex); if (nextMatch < 0) { @@ -96,7 +96,7 @@ public final class Substitute extends Var3or4ArgFunction { } count++; if (count == instanceNumber) { - StringBuffer sb = new StringBuffer(oldStr.length() + newStr.length()); + StringBuilder sb = new StringBuilder(oldStr.length() + newStr.length()); sb.append(oldStr, 0, nextMatch); sb.append(newStr); sb.append(oldStr.substring(nextMatch + searchStr.length())); diff --git a/src/java/org/apache/poi/ss/formula/ptg/AddPtg.java b/src/java/org/apache/poi/ss/formula/ptg/AddPtg.java index e275d8c439..b18bf3a335 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/AddPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/AddPtg.java @@ -44,7 +44,7 @@ public final class AddPtg extends ValueOperatorPtg { /** implementation of method from OperationsPtg*/ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(ADD); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Area2DPtgBase.java b/src/java/org/apache/poi/ss/formula/ptg/Area2DPtgBase.java index 59324f8097..b356591b73 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Area2DPtgBase.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Area2DPtgBase.java @@ -54,7 +54,7 @@ public abstract class Area2DPtgBase extends AreaPtgBase { } public final String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); sb.append(formatReferenceAsString()); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Area3DPtg.java b/src/java/org/apache/poi/ss/formula/ptg/Area3DPtg.java index 3eeddadc7d..823a1462fe 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Area3DPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Area3DPtg.java @@ -65,7 +65,7 @@ public final class Area3DPtg extends AreaPtgBase implements WorkbookDependentFor @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); sb.append("sheetIx=").append(getExternSheetIndex()); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Area3DPxg.java b/src/java/org/apache/poi/ss/formula/ptg/Area3DPxg.java index 41bea0c950..9c7a5da0d5 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Area3DPxg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Area3DPxg.java @@ -61,7 +61,7 @@ public final class Area3DPxg extends AreaPtgBase implements Pxg3D { @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); if (externalWorkbookNumber >= 0) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/ArrayPtg.java b/src/java/org/apache/poi/ss/formula/ptg/ArrayPtg.java index e7e300e5a3..66072bdd3d 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/ArrayPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/ArrayPtg.java @@ -107,7 +107,7 @@ public final class ArrayPtg extends Ptg { } public String toString() { - StringBuffer sb = new StringBuffer("[ArrayPtg]\n"); + StringBuilder sb = new StringBuilder("[ArrayPtg]\n"); sb.append("nRows = ").append(getRowCount()).append("\n"); sb.append("nCols = ").append(getColumnCount()).append("\n"); @@ -167,7 +167,7 @@ public final class ArrayPtg extends Ptg { } public String toFormulaString() { - StringBuffer b = new StringBuffer(); + StringBuilder b = new StringBuilder(); b.append("{"); for (int y = 0; y < _nRows; y++) { if (y > 0) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/AttrPtg.java b/src/java/org/apache/poi/ss/formula/ptg/AttrPtg.java index c145dfad36..0af61b897f 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/AttrPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/AttrPtg.java @@ -168,7 +168,7 @@ public final class AttrPtg extends ControlPtg { } public String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()).append(" ["); if(isSemiVolatile()) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/ConcatPtg.java b/src/java/org/apache/poi/ss/formula/ptg/ConcatPtg.java index eb11f8fc3b..a4c0ec9187 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/ConcatPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/ConcatPtg.java @@ -42,7 +42,7 @@ public final class ConcatPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(CONCAT); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Deleted3DPxg.java b/src/java/org/apache/poi/ss/formula/ptg/Deleted3DPxg.java index 84e4a0de16..01cbe455a0 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Deleted3DPxg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Deleted3DPxg.java @@ -38,7 +38,7 @@ public final class Deleted3DPxg extends OperandPtg implements Pxg { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); if (externalWorkbookNumber >= 0) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/DividePtg.java b/src/java/org/apache/poi/ss/formula/ptg/DividePtg.java index 66e6913bcb..f1dfbdd27e 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/DividePtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/DividePtg.java @@ -40,7 +40,7 @@ public final class DividePtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append("/"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/EqualPtg.java b/src/java/org/apache/poi/ss/formula/ptg/EqualPtg.java index 164ce981c1..54db3f3f35 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/EqualPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/EqualPtg.java @@ -39,7 +39,7 @@ public final class EqualPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); diff --git a/src/java/org/apache/poi/ss/formula/ptg/GreaterEqualPtg.java b/src/java/org/apache/poi/ss/formula/ptg/GreaterEqualPtg.java index eafbeba6fd..54ae3f7dcc 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/GreaterEqualPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/GreaterEqualPtg.java @@ -42,7 +42,7 @@ public final class GreaterEqualPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); diff --git a/src/java/org/apache/poi/ss/formula/ptg/GreaterThanPtg.java b/src/java/org/apache/poi/ss/formula/ptg/GreaterThanPtg.java index dabdab6655..8f8152b07a 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/GreaterThanPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/GreaterThanPtg.java @@ -51,7 +51,7 @@ public final class GreaterThanPtg extends ValueOperatorPtg { */ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(GREATERTHAN); diff --git a/src/java/org/apache/poi/ss/formula/ptg/IntersectionPtg.java b/src/java/org/apache/poi/ss/formula/ptg/IntersectionPtg.java index ed2f327bae..1927cb9754 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/IntersectionPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/IntersectionPtg.java @@ -48,7 +48,7 @@ public final class IntersectionPtg extends OperationPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[0]); buffer.append(" "); diff --git a/src/java/org/apache/poi/ss/formula/ptg/LessEqualPtg.java b/src/java/org/apache/poi/ss/formula/ptg/LessEqualPtg.java index ce70ae79db..305c4ef2e8 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/LessEqualPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/LessEqualPtg.java @@ -44,7 +44,7 @@ public final class LessEqualPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( operands[0] ); buffer.append("<="); buffer.append( operands[1] ); diff --git a/src/java/org/apache/poi/ss/formula/ptg/LessThanPtg.java b/src/java/org/apache/poi/ss/formula/ptg/LessThanPtg.java index 51455c5204..b86854f9cf 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/LessThanPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/LessThanPtg.java @@ -55,7 +55,7 @@ public final class LessThanPtg extends ValueOperatorPtg { */ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(LESSTHAN); buffer.append(operands[ 1 ]); diff --git a/src/java/org/apache/poi/ss/formula/ptg/MemAreaPtg.java b/src/java/org/apache/poi/ss/formula/ptg/MemAreaPtg.java index 6c4568e664..9ebca5061b 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/MemAreaPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/MemAreaPtg.java @@ -65,7 +65,7 @@ public final class MemAreaPtg extends OperandPtg { @Override public final String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()).append(" [len="); sb.append(field_2_subex_len); sb.append("]"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/MemFuncPtg.java b/src/java/org/apache/poi/ss/formula/ptg/MemFuncPtg.java index 1837382f18..077cfe485b 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/MemFuncPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/MemFuncPtg.java @@ -66,7 +66,7 @@ public final class MemFuncPtg extends OperandPtg { } @Override public final String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()).append(" [len="); sb.append(field_1_len_ref_subexpression); sb.append("]"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/MultiplyPtg.java b/src/java/org/apache/poi/ss/formula/ptg/MultiplyPtg.java index ce251c82b0..fb4f468e3c 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/MultiplyPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/MultiplyPtg.java @@ -40,7 +40,7 @@ public final class MultiplyPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append("*"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/NameXPxg.java b/src/java/org/apache/poi/ss/formula/ptg/NameXPxg.java index 9da79beec8..0b098ba768 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/NameXPxg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/NameXPxg.java @@ -45,7 +45,7 @@ public final class NameXPxg extends OperandPtg implements Pxg { } public String toString(){ - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); if (externalWorkbookNumber >= 0) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/NotEqualPtg.java b/src/java/org/apache/poi/ss/formula/ptg/NotEqualPtg.java index 2c91b9cd82..c6c557a349 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/NotEqualPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/NotEqualPtg.java @@ -40,7 +40,7 @@ public final class NotEqualPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append( operands[0] ); diff --git a/src/java/org/apache/poi/ss/formula/ptg/PercentPtg.java b/src/java/org/apache/poi/ss/formula/ptg/PercentPtg.java index 12eabcaa6d..f27fb33574 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/PercentPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/PercentPtg.java @@ -43,7 +43,7 @@ public final class PercentPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(PERCENT); diff --git a/src/java/org/apache/poi/ss/formula/ptg/PowerPtg.java b/src/java/org/apache/poi/ss/formula/ptg/PowerPtg.java index 3f240f40c4..6f5e8158e3 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/PowerPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/PowerPtg.java @@ -40,7 +40,7 @@ public final class PowerPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); diff --git a/src/java/org/apache/poi/ss/formula/ptg/RangePtg.java b/src/java/org/apache/poi/ss/formula/ptg/RangePtg.java index 1ab4cf1b8c..6918f78ab9 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/RangePtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/RangePtg.java @@ -55,7 +55,7 @@ public final class RangePtg extends OperationPtg { /** implementation of method from OperationsPtg*/ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(":"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Ref2DPtgBase.java b/src/java/org/apache/poi/ss/formula/ptg/Ref2DPtgBase.java index 06af02a52a..81a4b381f3 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Ref2DPtgBase.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Ref2DPtgBase.java @@ -63,7 +63,7 @@ abstract class Ref2DPtgBase extends RefPtgBase { @Override public final String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); sb.append(formatReferenceAsString()); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Ref3DPtg.java b/src/java/org/apache/poi/ss/formula/ptg/Ref3DPtg.java index 1366d2d353..e5506f3668 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Ref3DPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Ref3DPtg.java @@ -55,7 +55,7 @@ public final class Ref3DPtg extends RefPtgBase implements WorkbookDependentFormu } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); sb.append("sheetIx=").append(getExternSheetIndex()); diff --git a/src/java/org/apache/poi/ss/formula/ptg/Ref3DPxg.java b/src/java/org/apache/poi/ss/formula/ptg/Ref3DPxg.java index 12e7e54eda..8ff8c7effc 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/Ref3DPxg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/Ref3DPxg.java @@ -59,7 +59,7 @@ public final class Ref3DPxg extends RefPtgBase implements Pxg3D { } public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getClass().getName()); sb.append(" ["); if (externalWorkbookNumber >= 0) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/ScalarConstantPtg.java b/src/java/org/apache/poi/ss/formula/ptg/ScalarConstantPtg.java index f916c38720..210d887df4 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/ScalarConstantPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/ScalarConstantPtg.java @@ -33,7 +33,7 @@ public abstract class ScalarConstantPtg extends Ptg { } public final String toString() { - StringBuffer sb = new StringBuffer(64); + StringBuilder sb = new StringBuilder(64); sb.append(getClass().getName()).append(" ["); sb.append(toFormulaString()); sb.append("]"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/StringPtg.java b/src/java/org/apache/poi/ss/formula/ptg/StringPtg.java index 836ca0feac..c9b8e53546 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/StringPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/StringPtg.java @@ -91,7 +91,7 @@ public final class StringPtg extends ScalarConstantPtg { public String toFormulaString() { String value = field_3_string; int len = value.length(); - StringBuffer sb = new StringBuffer(len + 4); + StringBuilder sb = new StringBuilder(len + 4); sb.append(FORMULA_DELIMITER); for (int i = 0; i < len; i++) { diff --git a/src/java/org/apache/poi/ss/formula/ptg/SubtractPtg.java b/src/java/org/apache/poi/ss/formula/ptg/SubtractPtg.java index f06e60496d..5ae6ec7a9f 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/SubtractPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/SubtractPtg.java @@ -40,7 +40,7 @@ public final class SubtractPtg extends ValueOperatorPtg { } public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append("-"); diff --git a/src/java/org/apache/poi/ss/formula/ptg/TblPtg.java b/src/java/org/apache/poi/ss/formula/ptg/TblPtg.java index 5ab5558ff2..b8a2109b56 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/TblPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/TblPtg.java @@ -72,7 +72,7 @@ public final class TblPtg extends ControlPtg { } public String toString() { - StringBuffer buffer = new StringBuffer("[Data Table - Parent cell is an interior cell in a data table]\n"); + StringBuilder buffer = new StringBuilder("[Data Table - Parent cell is an interior cell in a data table]\n"); buffer.append("top left row = ").append(getRow()).append("\n"); buffer.append("top left col = ").append(getColumn()).append("\n"); return buffer.toString(); diff --git a/src/java/org/apache/poi/ss/formula/ptg/UnaryMinusPtg.java b/src/java/org/apache/poi/ss/formula/ptg/UnaryMinusPtg.java index 9079150eb0..54b423e82f 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/UnaryMinusPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/UnaryMinusPtg.java @@ -43,7 +43,7 @@ public final class UnaryMinusPtg extends ValueOperatorPtg { /** implementation of method from OperationsPtg*/ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(MINUS); buffer.append(operands[ 0]); return buffer.toString(); diff --git a/src/java/org/apache/poi/ss/formula/ptg/UnaryPlusPtg.java b/src/java/org/apache/poi/ss/formula/ptg/UnaryPlusPtg.java index 1596c67355..be6ba540d6 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/UnaryPlusPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/UnaryPlusPtg.java @@ -43,7 +43,7 @@ public final class UnaryPlusPtg extends ValueOperatorPtg { /** implementation of method from OperationsPtg*/ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(ADD); buffer.append(operands[ 0]); return buffer.toString(); diff --git a/src/java/org/apache/poi/ss/formula/ptg/UnionPtg.java b/src/java/org/apache/poi/ss/formula/ptg/UnionPtg.java index fcc2ae5a2d..45042df0f9 100644 --- a/src/java/org/apache/poi/ss/formula/ptg/UnionPtg.java +++ b/src/java/org/apache/poi/ss/formula/ptg/UnionPtg.java @@ -54,7 +54,7 @@ public final class UnionPtg extends OperationPtg { /** implementation of method from OperationsPtg*/ public String toFormulaString(String[] operands) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(operands[ 0 ]); buffer.append(","); diff --git a/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java b/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java index c73493cb32..e113837a2a 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java @@ -67,7 +67,7 @@ public final class TestStringRecord { int MAX_BIFF_DATA = RecordInputStream.MAX_RECORD_DATA_SIZE; int TEXT_LEN = MAX_BIFF_DATA + 1000; // deliberately over-size String textChunk = "ABCDEGGHIJKLMNOP"; // 16 chars - StringBuffer sb = new StringBuffer(16384); + StringBuilder sb = new StringBuilder(16384); while (sb.length() < TEXT_LEN) { sb.append(textChunk); } diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java index 4fecae4528..cde8f30fb7 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java @@ -90,7 +90,7 @@ public final class TestIrr extends TestCase { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("IrrNpvTestCaseData.xls"); HSSFSheet sheet = wb.getSheet("IRR-NPV"); HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); - StringBuffer failures = new StringBuffer(); + StringBuilder failures = new StringBuilder(); int failureCount = 0; // TODO YK: Formulas in rows 16 and 17 operate with ArrayPtg which isn't yet supported // FormulaEvaluator as of r1041407 throws "Unexpected ptg class (org.apache.poi.ss.formula.ptg.ArrayPtg)"