Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HSSFComment: note a final field 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-01-31 12:33:00 +00:00
parent 4c82305d3d
commit 996c2d53ab
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/java/org/apache/poi/hssf/usermodel/HSSFComment.java
View File

@ -53,11 +53,11 @@ public class HSSFComment extends HSSFTextbox implements Comment {
* It seems like HSSFRow should manage a collection of local HSSFComments
*/
private NoteRecord _note;
private final NoteRecord _note;
public HSSFComment(EscherContainerRecord spContainer, ObjRecord objRecord, TextObjectRecord textObjectRecord, NoteRecord _note) {
public HSSFComment(EscherContainerRecord spContainer, ObjRecord objRecord, TextObjectRecord textObjectRecord, NoteRecord note) {
super(spContainer, objRecord, textObjectRecord);
this._note = _note;
_note = note;
}
/**
@ -67,8 +67,12 @@ public class HSSFComment extends HSSFTextbox implements Comment {
* @param anchor defines position of this anchor in the sheet
*/
public HSSFComment(HSSFShape parent, HSSFAnchor anchor) {
this(parent, anchor, createNoteRecord());
}
private HSSFComment(HSSFShape parent, HSSFAnchor anchor, NoteRecord note) {
super(parent, anchor);
_note = createNoteRecord();
_note = note;
//default color for comments
setFillColor(0x08000050);
@ -80,8 +84,7 @@ public class HSSFComment extends HSSFTextbox implements Comment {
}
protected HSSFComment(NoteRecord note, TextObjectRecord txo) {
this(null, new HSSFClientAnchor());
_note = note;
this(null, new HSSFClientAnchor(), note);
}
@Override
@ -120,7 +123,7 @@ public class HSSFComment extends HSSFTextbox implements Comment {
return obj;
}
private NoteRecord createNoteRecord(){
private static NoteRecord createNoteRecord() {
NoteRecord note = new NoteRecord();
note.setFlags(NoteRecord.NOTE_HIDDEN);
note.setAuthor("");