Sonar fixes

JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885325 13f79535-47bb-0310-9956-ffa450edef68

src/testcases/org/apache/poi/TestJDK12.java

@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
  *
  * Should be fixed in JDK 12-ea+29 and JDK 13-ea+5
  */
-public class TestJDK12 {
+class TestJDK12 {
     @Test
     void test() {
         assertDoesNotThrow(() -> {

src/testcases/org/apache/poi/ddf/TestEscherClientAnchorRecord.java

@@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump;
 import org.apache.poi.util.HexRead;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherClientAnchorRecord {
+class TestEscherClientAnchorRecord {
     @Test
     void testSerialize() {
         EscherClientAnchorRecord r = createRecord();

src/testcases/org/apache/poi/ddf/TestEscherClientDataRecord.java

@@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump;
 import org.apache.poi.util.HexRead;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherClientDataRecord {
+class TestEscherClientDataRecord {
     @Test
     void testSerialize() {
         EscherClientDataRecord r = createRecord();

src/testcases/org/apache/poi/ddf/TestEscherDump.java

@@ -36,7 +36,7 @@ import org.apache.poi.util.IOUtils;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherDump {
+class TestEscherDump {
     private static final String recordData =
         "H4sIAAAAAAAAAL2UaVCSWxjHX0SBChABLRXM1FxSEzXTzHK7dpVIcMmwxXCP9KaGTaWlGYLrtGmGmYEmYmqF2qIt4ppmjNG+" +
         "2dWulUtOUdq1NHjva8v90HT7eM+Z5znP/M9/zpk5v3mONgAoc5AANBDKeVDW0gQAjZkVCti3mKnpAExpB/m8AKTyEiTCNd2J" +

src/testcases/org/apache/poi/ddf/TestEscherProperty.java

@@ -24,7 +24,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 import org.junit.jupiter.api.Test;
 
 
-public class TestEscherProperty {
+class TestEscherProperty {
     /**
      * assure that EscherProperty.getName() returns correct name for complex properties
      * See Bugzilla 50401

src/testcases/org/apache/poi/ddf/TestEscherPropertyFactory.java

@@ -25,7 +25,7 @@ import org.apache.poi.util.HexDump;
 import org.apache.poi.util.HexRead;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherPropertyFactory {
+class TestEscherPropertyFactory {
     @Test
     void testCreateProperties() {
         String dataStr = "41 C1 " +     // propid, complex ind

src/testcases/org/apache/poi/ddf/TestEscherSpRecord.java

@@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump;
 import org.apache.poi.util.HexRead;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherSpRecord {
+class TestEscherSpRecord {
     @Test
     void testSerialize() {
         EscherSpRecord r = createRecord();

src/testcases/org/apache/poi/hpsf/TestVariantSupport.java

@@ -32,7 +32,7 @@ import org.apache.poi.poifs.storage.RawDataUtil;
 import org.apache.poi.util.LittleEndianByteArrayInputStream;
 import org.junit.jupiter.api.Test;
 
-public class TestVariantSupport {
+class TestVariantSupport {
     @Test
     void test52337() throws Exception {
         // document summary stream   from test1-excel.doc attached to Bugzilla 52337

src/testcases/org/apache/poi/hpsf/basic/TestReadAllFiles.java

@@ -51,7 +51,7 @@ import org.junit.jupiter.params.provider.MethodSource;
  * in the "data" directory. If you want to ensure HPSF can deal with a certain
  * OLE2 file, just add it to the "data" directory and run this test case.
  */
-public class TestReadAllFiles {
+class TestReadAllFiles {
     private static final POIDataSamples _samples = POIDataSamples.getHPSFInstance();
 
     public static Stream<Arguments> files() {

src/testcases/org/apache/poi/hpsf/basic/TestUnicode.java

@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests whether Unicode string can be read from a DocumentSummaryInformation.
  */
-public class TestUnicode {
+class TestUnicode {
 
     static final String POI_FS = "TestUnicode.xls";
     static final String[] POI_FILES =  {

src/testcases/org/apache/poi/hpsf/basic/TestWrite.java

@@ -79,7 +79,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests HPSF's writing functionality
  */
-public class TestWrite {
+class TestWrite {
     private static final POIDataSamples _samples = POIDataSamples.getHPSFInstance();
     private static final int CODEPAGE_DEFAULT = -1;
 

src/testcases/org/apache/poi/hpsf/basic/TestWriteWellKnown.java

@@ -58,7 +58,7 @@ import org.junit.jupiter.api.Test;
  * <p>Tests HPSF's high-level writing functionality for the well-known property
  * set "SummaryInformation" and "DocumentSummaryInformation".</p>
  */
-public class TestWriteWellKnown {
+class TestWriteWellKnown {
 
     private static final String POI_FS = "TestWriteWellKnown.doc";
 

src/testcases/org/apache/poi/hssf/dev/TestBiffDrawingToXml.java

@@ -27,7 +27,7 @@ import org.apache.poi.util.NullOutputStream;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.BeforeAll;
 
-public class TestBiffDrawingToXml extends BaseTestIteratingXLS {
+class TestBiffDrawingToXml extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java

@@ -29,7 +29,7 @@ import org.apache.poi.util.NullOutputStream;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.BeforeAll;
 
-public class TestBiffViewer extends BaseTestIteratingXLS {
+class TestBiffViewer extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java

@@ -27,7 +27,7 @@ import org.apache.poi.util.NullPrintStream;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.BeforeAll;
 
-public class TestEFBiffViewer extends BaseTestIteratingXLS {
+class TestEFBiffViewer extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java

@@ -28,7 +28,7 @@ import org.apache.poi.util.NullPrintStream;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.BeforeAll;
 
-public class TestFormulaViewer extends BaseTestIteratingXLS {
+class TestFormulaViewer extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/dev/TestReSave.java

@@ -31,7 +31,7 @@ import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-public class TestReSave extends BaseTestIteratingXLS {
+class TestReSave extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java

@@ -25,7 +25,7 @@ import org.apache.poi.util.NullPrintStream;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.BeforeAll;
 
-public class TestRecordLister extends BaseTestIteratingXLS {
+class TestRecordLister extends BaseTestIteratingXLS {
     @BeforeAll
     public static void setup() {
         EXCLUDED.clear();

src/testcases/org/apache/poi/hssf/model/TestDrawingAggregate.java

@@ -60,7 +60,7 @@ import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
-public class TestDrawingAggregate {
+class TestDrawingAggregate {
     /**
      *  information about drawing aggregate in a worksheet
      */

src/testcases/org/apache/poi/hssf/model/TestDrawingShapes.java

@@ -68,7 +68,7 @@ import org.junit.jupiter.api.Test;
  *
  * optionally the system setting "poi.deserialize.escher" can be set to {@code true}
  */
-public class TestDrawingShapes {
+class TestDrawingShapes {
     /**
      * HSSFShape tree bust be built correctly
      * Check file with such records structure:

src/testcases/org/apache/poi/hssf/model/TestEscherRecordFactory.java

@@ -40,7 +40,7 @@ import org.apache.poi.hssf.usermodel.HSSFTestHelper;
 import org.apache.poi.hssf.usermodel.HSSFWorkbook;
 import org.junit.jupiter.api.Test;
 
-public class TestEscherRecordFactory {
+class TestEscherRecordFactory {
 
     private static byte[] toByteArray(List<RecordBase> records) {
         ByteArrayOutputStream out = new ByteArrayOutputStream();

src/testcases/org/apache/poi/hssf/model/TestHSSFAnchor.java

@@ -41,7 +41,7 @@ import org.apache.poi.hssf.usermodel.HSSFWorkbook;
 import org.apache.poi.ss.usermodel.ClientAnchor.AnchorType;
 import org.junit.jupiter.api.Test;
 
-public class TestHSSFAnchor {
+class TestHSSFAnchor {
 
     @Test
     void testDefaultValues(){

src/testcases/org/apache/poi/hssf/record/TestDConRefRecord.java

@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Unit tests for DConRefRecord class.
  */
-public class TestDConRefRecord {
+class TestDConRefRecord {
     /**
      * record of a proper single-byte external 'volume'-style path with multiple parts and a sheet
      * name.

src/testcases/org/apache/poi/hssf/usermodel/TestCryptoAPI.java

@@ -26,7 +26,7 @@ import org.apache.poi.hssf.extractor.ExcelExtractor;
 import org.apache.poi.hssf.record.crypto.Biff8EncryptionKey;
 import org.junit.jupiter.api.Test;
 
-public class TestCryptoAPI {
+class TestCryptoAPI {
     final HSSFITestDataProvider ssTests = HSSFITestDataProvider.instance;
 
     @Test

src/testcases/org/apache/poi/hssf/usermodel/TestEmbeddedObjects.java

@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests for the embedded object fetching support in HSSF
  */
-public class TestEmbeddedObjects {
+class TestEmbeddedObjects {
     @Test
     void testReadExistingObject() throws IOException {
         try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls")) {

src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java

@@ -27,7 +27,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples;
 import org.apache.poi.ss.usermodel.CellType;
 import org.junit.jupiter.api.Test;
 
-public class TestExternalReferenceChange {
+class TestExternalReferenceChange {
 
 	private static final String MAIN_WORKBOOK_FILENAME = "52575_main.xls";
 	private static final String SOURCE_DUMMY_WORKBOOK_FILENAME = "source_dummy.xls";

src/testcases/org/apache/poi/hssf/usermodel/TestHSSFColumnShifting.java

@@ -21,7 +21,7 @@ package org.apache.poi.hssf.usermodel;
 import org.apache.poi.hssf.usermodel.helpers.HSSFColumnShifter;
 import org.apache.poi.ss.usermodel.BaseTestColumnShifting;
 
-public class TestHSSFColumnShifting extends BaseTestColumnShifting {
+class TestHSSFColumnShifting extends BaseTestColumnShifting {
     public TestHSSFColumnShifting() {
         super(); 
         wb = new HSSFWorkbook();

src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDateUtil.java

@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class TestHSSFDateUtil
  */
-public class TestHSSFDateUtil {
+class TestHSSFDateUtil {
 
     static TimeZone userTimeZone;
 

src/testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java

@@ -29,7 +29,7 @@ import org.apache.poi.ss.usermodel.BaseTestXEvaluationSheet;
 import org.apache.poi.ss.usermodel.Sheet;
 import org.junit.jupiter.api.Test;
 
-public class TestHSSFEvaluationSheet extends BaseTestXEvaluationSheet {
+class TestHSSFEvaluationSheet extends BaseTestXEvaluationSheet {
     @Override
     protected Map.Entry<Sheet, EvaluationSheet> getInstance() {
         HSSFSheet sheet = new HSSFWorkbook().createSheet();

src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRangeCopier.java

@@ -24,7 +24,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples;
 import org.apache.poi.ss.usermodel.BaseTestRangeCopier;
 import org.junit.jupiter.api.BeforeEach;
 
-public class TestHSSFRangeCopier extends BaseTestRangeCopier {
+class TestHSSFRangeCopier extends BaseTestRangeCopier {
 
     public TestHSSFRangeCopier() {
         super();

src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftColumns.java

@@ -27,7 +27,7 @@ import org.apache.poi.ss.usermodel.Workbook;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-public class TestHSSFSheetShiftColumns extends BaseTestSheetShiftColumns {
+class TestHSSFSheetShiftColumns extends BaseTestSheetShiftColumns {
     public TestHSSFSheetShiftColumns() {
         super();
         workbook = new HSSFWorkbook();

src/testcases/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java

@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Old-style setting of POIFS properties doesn't work with POI 3.0.2
  */
-public class TestPOIFSProperties {
+class TestPOIFSProperties {
     private static final String title = "Testing POIFS properties";
 
     @Test

src/testcases/org/apache/poi/hssf/usermodel/TestPatriarch.java

@@ -27,7 +27,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples;
 import org.apache.poi.hssf.record.EscherAggregate;
 import org.junit.jupiter.api.Test;
 
-public class TestPatriarch {
+class TestPatriarch {
     @Test
     void testGetPatriarch(){
         HSSFWorkbook wb = new HSSFWorkbook();

src/testcases/org/apache/poi/hssf/usermodel/TestPolygon.java

@@ -31,7 +31,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples;
 import org.apache.poi.hssf.record.ObjRecord;
 import org.junit.jupiter.api.Test;
 
-public class TestPolygon {
+class TestPolygon {
     @Test
     void testResultEqualsToAbstractShape() throws IOException {
         HSSFWorkbook wb = new HSSFWorkbook();

src/testcases/org/apache/poi/hssf/usermodel/TestShapeGroup.java

@@ -30,7 +30,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples;
 import org.apache.poi.hssf.record.EscherAggregate;
 import org.junit.jupiter.api.Test;
 
-public class TestShapeGroup {
+class TestShapeGroup {
 
     @Test
     void testSetGetCoordinates() throws IOException {

src/testcases/org/apache/poi/hssf/usermodel/TestText.java

@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
  * @author Evgeniy Berlog
  * @date 25.06.12
  */
-public class TestText {
+class TestText {
 
     @Test
     void testResultEqualsToNonExistingAbstractShape() throws IOException {

src/testcases/org/apache/poi/poifs/crypt/TestCipherAlgorithm.java

@@ -23,7 +23,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
 import org.apache.poi.EncryptedDocumentException;
 import org.junit.jupiter.api.Test;
 
-public class TestCipherAlgorithm {
+class TestCipherAlgorithm {
     @Test
     void validInputs() {
         assertEquals(128, CipherAlgorithm.aes128.defaultKeySize);

src/testcases/org/apache/poi/poifs/crypt/TestXorEncryption.java

@@ -36,7 +36,7 @@ import org.apache.poi.util.HexRead;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-public class TestXorEncryption {
+class TestXorEncryption {
 
     private static final HSSFTestDataSamples samples = new HSSFTestDataSamples();
 

src/testcases/org/apache/poi/poifs/crypt/binaryrc4/TestBinaryRC4.java

@@ -30,7 +30,7 @@ import org.apache.poi.poifs.crypt.EncryptionInfo;
 import org.apache.poi.poifs.crypt.EncryptionMode;
 import org.junit.jupiter.api.Test;
 
-public class TestBinaryRC4 {
+class TestBinaryRC4 {
     @Test
     void createKeyDigest() {
         byte[] docIdData = readFromString("17 F6 D1 6B 09 B1 5F 7B 4C 9D 03 B4 81 B5 B4 4A");

src/testcases/org/apache/poi/poifs/filesystem/TestDocument.java

@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class to test POIFSDocument functionality
  */
-public class TestDocument {
+class TestDocument {
 
     /**
      * Integration test -- really about all we can do

src/testcases/org/apache/poi/poifs/filesystem/TestEntryUtils.java

@@ -32,7 +32,7 @@ import java.util.List;
 
 import org.junit.jupiter.api.Test;
 
-public class TestEntryUtils {
+class TestEntryUtils {
     private static final byte[] dataSmallA = new byte[] { 12, 42, 11, -12, -121 };
     private static final byte[] dataSmallB = new byte[] { 11, 73, 21, -92, -103 };
 

src/testcases/org/apache/poi/poifs/filesystem/TestFileMagic.java

@@ -39,7 +39,7 @@ import org.apache.poi.POIDataSamples;
 import org.apache.poi.util.TempFile;
 import org.junit.jupiter.api.Test;
 
-public class TestFileMagic {
+class TestFileMagic {
     @Test
     void testFileMagic() {
         assertEquals(FileMagic.XML, FileMagic.valueOf("XML"));

src/testcases/org/apache/poi/poifs/filesystem/TestNotOLE2Exception.java

@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
  *  formats. See also {@link TestOfficeXMLException} for OOXML
  *  checks
  */
-public class TestNotOLE2Exception {
+class TestNotOLE2Exception {
 	private static InputStream openXLSSampleStream(String sampleFileName) {
 		return HSSFTestDataSamples.openSampleFileStream(sampleFileName);
 	}

src/testcases/org/apache/poi/poifs/filesystem/TestOfficeXMLException.java

@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
  * Class to test that POIFS complains when given an Office 2003 XML
  * of Office Open XML (OOXML, 2007+) document
  */
-public class TestOfficeXMLException {
+class TestOfficeXMLException {
 
     private static InputStream openSampleStream(String sampleFileName) {
         return HSSFTestDataSamples.openSampleFileStream(sampleFileName);

src/testcases/org/apache/poi/poifs/filesystem/TestOle10Native.java

@@ -36,7 +36,7 @@ import org.apache.poi.util.IOUtils;
 import org.apache.poi.util.RecordFormatException;
 import org.junit.jupiter.api.Test;
 
-public class TestOle10Native {
+class TestOle10Native {
     private static final POIDataSamples dataSamples = POIDataSamples.getPOIFSInstance();
 
     @Test

src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java

@@ -37,7 +37,7 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
-public class TestVBAMacroReader {
+class TestVBAMacroReader {
     private static final Map<POIDataSamples, String> expectedMacroContents;
 
     private static String readVBA(POIDataSamples poiDataSamples) {

src/testcases/org/apache/poi/poifs/nio/TestDataSource.java

@@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests for the datasource implementations
  */
-public class TestDataSource {
+class TestDataSource {
     private static final POIDataSamples data = POIDataSamples.getPOIFSInstance();
 
     @Test

src/testcases/org/apache/poi/sl/draw/geom/TestFormulaParser.java

@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Yegor Kozlov
  */
-public class TestFormulaParser {
+class TestFormulaParser {
     @Test
     void testParse(){
 

src/testcases/org/apache/poi/sl/draw/geom/TestPresetGeometries.java

@@ -30,7 +30,7 @@ import java.util.Enumeration;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-public class TestPresetGeometries {
+class TestPresetGeometries {
     @Test
     void testRead(){
         PresetGeometries shapes = PresetGeometries.getInstance();

src/testcases/org/apache/poi/ss/format/TestCellFormat.java

@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-public class TestCellFormat {
+class TestCellFormat {
 
     private static TimeZone userTimeZone;
 

src/testcases/org/apache/poi/ss/format/TestCellFormatCondition.java

@@ -21,7 +21,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.junit.jupiter.api.Test;
 
-public class TestCellFormatCondition {
+class TestCellFormatCondition {
     @Test
     void testSVConditions() {
         CellFormatCondition lt = CellFormatCondition.getInstance("<", "1.5");

src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java

@@ -22,7 +22,7 @@ import java.awt.Color;
 
 import org.junit.jupiter.api.Test;
 
-public class TestCellFormatResult {
+class TestCellFormatResult {
 
     @Test
     void testNullTextRaisesException() {

src/testcases/org/apache/poi/ss/formula/TestCellCacheEntry.java

@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Tests {@link org.apache.poi.ss.formula.CellCacheEntry}.
  */
-public class TestCellCacheEntry {
+class TestCellCacheEntry {
 
 	@Test
 	void testBasic() {

src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java

@@ -59,7 +59,7 @@ import org.junit.jupiter.api.Test;
  * values are used.  Also checks that changing cell values causes the correct (minimal) set of
  * dependent cached values to be cleared.
  */
-public class TestEvaluationCache {
+class TestEvaluationCache {
 
 	private static final class FormulaCellCacheEntryComparer implements Comparator<ICacheEntry> {
 

src/testcases/org/apache/poi/ss/formula/TestFunctionRegistry.java

@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestMethodOrder;
 
 @TestMethodOrder(MethodOrderer.MethodName.class)
-public class TestFunctionRegistry {
+class TestFunctionRegistry {
 
     HSSFWorkbook wb;
     HSSFSheet sheet;

src/testcases/org/apache/poi/ss/formula/TestPlainCellCache.java

@@ -27,7 +27,7 @@ import org.apache.poi.ss.formula.PlainCellCache.Loc;
 import org.apache.poi.ss.formula.eval.NumberEval;
 import org.junit.jupiter.api.Test;
 
-public class TestPlainCellCache {
+class TestPlainCellCache {
 
     @Test
     void testLoc(){

src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java

@@ -57,7 +57,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Josh Micich
  */
-public class TestWorkbookEvaluator {
+class TestWorkbookEvaluator {
 
     private static final double EPSILON = 0.0000001;
 

src/testcases/org/apache/poi/ss/formula/atp/TestIfError.java

@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Testcase for 'Analysis Toolpak' function IFERROR()
  */
-public class TestIfError {
+class TestIfError {
 
     /**
      * =IFERROR(210/35,\"Error in calculation\")"  Divides 210 by 35 and returns 6.0

src/testcases/org/apache/poi/ss/formula/atp/TestMRound.java

@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Testcase for 'Analysis Toolpak' function MROUND()
  */
-public class TestMRound {
+class TestMRound {
 
     /**
         =MROUND(10, 3) 	Rounds 10 to a nearest multiple of 3 (9)

src/testcases/org/apache/poi/ss/formula/atp/TestNetworkdaysFunction.java

@@ -33,7 +33,7 @@ import org.apache.poi.ss.formula.eval.StringEval;
 import org.apache.poi.ss.formula.eval.ValueEval;
 import org.junit.jupiter.api.Test;
 
-public class TestNetworkdaysFunction {
+class TestNetworkdaysFunction {
 
     private static final String STARTING_DATE = "2008/10/01";
     private static final String END_DATE = "2009/03/01";

src/testcases/org/apache/poi/ss/formula/atp/TestPercentile.java

@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Testcase for Excel function PERCENTILE()
  */
-public class TestPercentile {
+class TestPercentile {
 
     private static ValueEval invokePercentile(ValueEval[] args, ValueEval percentile) {
         AreaEval aeA = EvalFactory.createAreaEval("A1:A" + args.length, args);

src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java

@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Testcase for 'Analysis Toolpak' function RANDBETWEEN()
  */
-public class TestRandBetween {
+class TestRandBetween {
 
 	private FormulaEvaluator evaluator;
 	private Cell bottomValueCell;

src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayCalculator.java

@@ -27,7 +27,7 @@ import org.apache.poi.ss.usermodel.DateUtil;
 import org.apache.poi.util.LocaleUtil;
 import org.junit.jupiter.api.Test;
 
-public class TestWorkdayCalculator {
+class TestWorkdayCalculator {
 
     @Test
     void testCalculateWorkdaysShouldReturnJustWeekdaysWhenNoWeekend() {

src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java

@@ -38,7 +38,7 @@ import org.apache.poi.ss.usermodel.DateUtil;
 import org.apache.poi.util.LocaleUtil;
 import org.junit.jupiter.api.Test;
 
-public class TestWorkdayFunction {
+class TestWorkdayFunction {
 
     private static final String STARTING_DATE      = "2008/10/01";
     private static final String FIRST_HOLIDAY      = "2008/11/26";

src/testcases/org/apache/poi/ss/formula/functions/TestBooleanFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests boolean functions as loaded from a test data spreadsheet.<p>
  */
-public class TestBooleanFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestBooleanFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestBooleanFunctionsFromSpreadsheet.class, "BooleanFunctionsTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestCode.java

@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author cedric dot walter @ gmail dot com
  */
-public class TestCode {
+class TestCode {
     private static ValueEval invokeValue(String number1) {
         ValueEval[] args = new ValueEval[]{new StringEval(number1),};
         return new Code().evaluate(args, -1, -1);

src/testcases/org/apache/poi/ss/formula/functions/TestCodeFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests CODE() as loaded from a test data spreadsheet.<p>
  */
-public class TestCodeFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestCodeFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestCodeFunctionsFromSpreadsheet.class, "CodeFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestComplex.java

@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author cedric dot walter @ gmail dot com
  */
-public class TestComplex {
+class TestComplex {
     private static ValueEval invokeValue(String real_num, String i_num, String suffix) {
         ValueEval[] args = new ValueEval[]{new StringEval(real_num), new StringEval(i_num), new StringEval(suffix)};
         return new Complex().evaluate(args, -1, -1);

src/testcases/org/apache/poi/ss/formula/functions/TestComplexFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests COMPLEX() as loaded from a test data spreadsheet.<p>
  */
-public class TestComplexFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestComplexFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestComplexFunctionsFromSpreadsheet.class, "ComplexFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestDGetFunctionsFromSpreadsheet.java

@@ -23,7 +23,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
 * Tests DGET() as loaded from a test data spreadsheet.
 */
-public class TestDGetFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestDGetFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestDGetFunctionsFromSpreadsheet.class, "DGet.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestDStarFunctionsFromSpreadsheet.java

@@ -23,7 +23,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
 * Tests D*() functions as loaded from a test data spreadsheet.
 */
-public class TestDStarFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestDStarFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestDStarFunctionsFromSpreadsheet.class, "DStar.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestDateTimeToNumberFromSpreadsheet.java

@@ -21,7 +21,7 @@ import java.util.stream.Stream;
 
 import org.junit.jupiter.params.provider.Arguments;
 
-public class TestDateTimeToNumberFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestDateTimeToNumberFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestDateTimeToNumberFromSpreadsheet.class, "DateTimeToNumberTestCases.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestDeltaFunctionsFromSpreadsheet.java

@@ -23,7 +23,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests DELTA() as loaded from a test data spreadsheet.<p>
  */
-public class TestDeltaFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestDeltaFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestDeltaFunctionsFromSpreadsheet.class, "DeltaFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestEDate.java

@@ -32,7 +32,7 @@ import org.apache.poi.ss.usermodel.FormulaError;
 import org.apache.poi.util.LocaleUtil;
 import org.junit.jupiter.api.Test;
 
-public class TestEDate {
+class TestEDate {
 
     @Test
     void testEDateProperValues() {

src/testcases/org/apache/poi/ss/formula/functions/TestEOMonth.java

@@ -34,7 +34,7 @@ import org.apache.poi.ss.usermodel.FormulaError;
 import org.apache.poi.util.LocaleUtil;
 import org.junit.jupiter.api.Test;
 
-public class TestEOMonth {
+class TestEOMonth {
 
     private static final double BAD_DATE = -1.0;
 

src/testcases/org/apache/poi/ss/formula/functions/TestFactDoubleFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests FactDouble() as loaded from a test data spreadsheet.<p>
  */
-public class TestFactDoubleFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestFactDoubleFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestFactDoubleFunctionsFromSpreadsheet.class, "FactDoubleFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestFinanceLib.java

@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
  * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
  *
  */
-public class TestFinanceLib extends BaseTestNumeric {
+class TestFinanceLib extends BaseTestNumeric {
 
     @Test
     void testFv() {

src/testcases/org/apache/poi/ss/formula/functions/TestFixedFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests FIXED() as loaded from a test data spreadsheet.
  */
-public class TestFixedFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestFixedFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestFixedFunctionsFromSpreadsheet.class, "57003-FixedFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestFrequency.java

@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Yegor Kozlov
  */
-public class TestFrequency {
+class TestFrequency {
 
     @Test
     void testHistogram() {

src/testcases/org/apache/poi/ss/formula/functions/TestGeomean.java

@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
  * Remarks:
  * Actually, 5. is not true. If an error is encountered before a 0 value, the error is returned.
  */
-public class TestGeomean {
+class TestGeomean {
     @Test
     void acceptanceTest() {
         Function geomean = getInstance();

src/testcases/org/apache/poi/ss/formula/functions/TestIFFunctionFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests IF() as loaded from a test data spreadsheet.<p>
  */
-public class TestIFFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestIFFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestIFFunctionFromSpreadsheet.class, "IfFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestImRealFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests ImReal() as loaded from a test data spreadsheet.<p>
  */
-public class TestImRealFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestImRealFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestImRealFunctionsFromSpreadsheet.class, "ImRealFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestImaginaryFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests Imaginary() as loaded from a test data spreadsheet.<p>
  */
-public class TestImaginaryFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestImaginaryFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestImaginaryFunctionsFromSpreadsheet.class, "ImaginaryFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestLeftRight.java

@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
  * @author Brendan Nolan
  *
  */
-public class TestLeftRight {
+class TestLeftRight {
 
 	private static final NumberEval NEGATIVE_OPERAND = new NumberEval(-1.0);
 	private static final StringEval ANY_STRING_VALUE = new StringEval("ANYSTRINGVALUE");

src/testcases/org/apache/poi/ss/formula/functions/TestLogicalFunction.java

@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
 /**
  * LogicalFunction unit tests.
  */
-public class TestLogicalFunction {
+class TestLogicalFunction {
 
     private FormulaEvaluator evaluator;
     private Row row3;

src/testcases/org/apache/poi/ss/formula/functions/TestLogicalFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests for logical ISxxx functions as loaded from a test data spreadsheet.<p>
  */
-public class TestLogicalFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestLogicalFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestLogicalFunctionsFromSpreadsheet.class, "LogicalFunctionsTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestMultiOperandNumericFunction.java

@@ -27,7 +27,7 @@ import org.apache.poi.ss.formula.eval.NumberEval;
 import org.apache.poi.ss.formula.eval.ValueEval;
 import org.junit.jupiter.api.Test;
 
-public class TestMultiOperandNumericFunction {
+class TestMultiOperandNumericFunction {
 
     @Test
     void testSettings() {

src/testcases/org/apache/poi/ss/formula/functions/TestPoisson.java

@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
  * Tests for Excel function POISSON(x,mean,cumulative)
  * @author Kalpesh Parmar
  */
-public class TestPoisson {
+class TestPoisson {
 
     private static final double DELTA = 1E-15;
 

src/testcases/org/apache/poi/ss/formula/functions/TestProduct.java

@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class TestProduct {
+class TestProduct {
     @Test
     void missingArgsAreIgnored() {
         ValueEval result = getInstance().evaluate(new ValueEval[]{new NumberEval(2.0), MissingArgEval.instance}, 0, 0);

src/testcases/org/apache/poi/ss/formula/functions/TestQuotient.java

@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author cedric dot walter @ gmail dot com
  */
-public class TestQuotient {
+class TestQuotient {
     private static ValueEval invokeValue(String numerator, String denominator) {
         ValueEval[] args = new ValueEval[]{new StringEval(numerator), new StringEval(denominator)};
         return new Quotient().evaluate(args, -1, -1);

src/testcases/org/apache/poi/ss/formula/functions/TestQuotientFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests QUOTIENT() as loaded from a test data spreadsheet.<p>
  */
-public class TestQuotientFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestQuotientFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestQuotientFunctionsFromSpreadsheet.class, "QuotientFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestRelationalOperations.java

@@ -27,7 +27,7 @@ import org.apache.poi.ss.formula.eval.StringEval;
 import org.apache.poi.ss.formula.eval.ValueEval;
 import org.junit.jupiter.api.Test;
 
-public class TestRelationalOperations {
+class TestRelationalOperations {
 
     /**
      *  (1, 1)(1, 1) = 1

src/testcases/org/apache/poi/ss/formula/functions/TestReptFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests REPT() as loaded from a test data spreadsheet.<p>
  */
-public class TestReptFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestReptFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestReptFunctionsFromSpreadsheet.class, "ReptFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestRomanFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests Roman() as loaded from a test data spreadsheet.<p>
  */
-public class TestRomanFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestRomanFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestRomanFunctionsFromSpreadsheet.class, "RomanFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestStatsLib.java

@@ -30,7 +30,7 @@ import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 
-public class TestStatsLib extends BaseTestNumeric {
+class TestStatsLib extends BaseTestNumeric {
 
     @Test
     void testDevsq() {

src/testcases/org/apache/poi/ss/formula/functions/TestSubstitute.java

@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-public class TestSubstitute {
+class TestSubstitute {
     @Test
     void testSubstitute() {
         Substitute fun = new Substitute();

src/testcases/org/apache/poi/ss/formula/functions/TestTrendFunctionsFromSpreadsheet.java

@@ -23,7 +23,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
 * Tests TREND() as loaded from a test data spreadsheet.
 */
-public class TestTrendFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestTrendFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestTrendFunctionsFromSpreadsheet.class, "Trend.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestTwoOperandNumericFunctionsFromSpreadsheet.java

@@ -25,7 +25,7 @@ import org.junit.jupiter.params.provider.Arguments;
  * Tests for numeric functions with two arguments such aqs +, -, *, POWER
  * as loaded from a test data spreadsheet.
  */
-public class TestTwoOperandNumericFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestTwoOperandNumericFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestTwoOperandNumericFunctionsFromSpreadsheet.class, "TwoOperandNumericFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestWeekNumFunctionsFromSpreadsheet.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests WeekNum() as loaded from a test data spreadsheet.<p>
  */
-public class TestWeekNumFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
+class TestWeekNumFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         return data(TestWeekNumFunctionsFromSpreadsheet.class, "WeekNumFunctionTestCaseData.xls");
     }

src/testcases/org/apache/poi/ss/formula/functions/TestWeekNumFunctionsFromSpreadsheet2013.java

@@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments;
 /**
  * Tests WeekNum() as loaded from a test data 2013 excel spreadsheet.<p>
  */
-public class TestWeekNumFunctionsFromSpreadsheet2013 extends BaseTestFunctionsFromSpreadsheet {
+class TestWeekNumFunctionsFromSpreadsheet2013 extends BaseTestFunctionsFromSpreadsheet {
     public static Stream<Arguments> data() throws Exception {
         //Only open this file with Excel 2013 to keep binary specific to that version
         return data(TestWeekNumFunctionsFromSpreadsheet2013.class, "WeekNumFunctionTestCaseData2013.xls");