Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

support gcd function 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1900408 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2022-04-29 22:44:57 +00:00
parent 34d047108e
commit 9ced6d1712
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
poi/src/main/java/org/apache/poi/ss/formula/functions/Gcd.java
View File

@ -30,6 +30,8 @@ public class Gcd implements FreeRefFunction {
public static final Gcd instance = new Gcd(); public static final Gcd instance = new Gcd();
private static final long MAX_INPUT = (long)Math.pow(2, 53);
@Override @Override
public ValueEval evaluate(ValueEval[] args, OperationEvaluationContext ec) { public ValueEval evaluate(ValueEval[] args, OperationEvaluationContext ec) {
if (args.length < 1) { if (args.length < 1) {
@ -37,11 +39,11 @@ public class Gcd implements FreeRefFunction {
} else if (args.length == 1) { } else if (args.length == 1) {
try { try {
ValueEval v1 = OperandResolver.getSingleValue(args[0], ec.getRowIndex(), ec.getColumnIndex()); ValueEval v1 = OperandResolver.getSingleValue(args[0], ec.getRowIndex(), ec.getColumnIndex());
long l = (long)OperandResolver.coerceValueToDouble(v1); double d = OperandResolver.coerceValueToDouble(v1);
if (l < 0) { if (isInvalidInput(d)) {
return ErrorEval.NUM_ERROR; return ErrorEval.NUM_ERROR;
} }
return new NumberEval(l); return new NumberEval((long)d);
} catch (EvaluationException ee) { } catch (EvaluationException ee) {
return ErrorEval.VALUE_INVALID; return ErrorEval.VALUE_INVALID;
} }
@ -50,11 +52,11 @@ public class Gcd implements FreeRefFunction {
ArrayList<Long> evals = new ArrayList<>(); ArrayList<Long> evals = new ArrayList<>();
for (int i = 0; i < args.length; i++) { for (int i = 0; i < args.length; i++) {
ValueEval ve = OperandResolver.getSingleValue(args[i], ec.getRowIndex(), ec.getColumnIndex()); ValueEval ve = OperandResolver.getSingleValue(args[i], ec.getRowIndex(), ec.getColumnIndex());
long l = (long)OperandResolver.coerceValueToDouble(ve); double d = OperandResolver.coerceValueToDouble(ve);
if (l < 0) { if (isInvalidInput(d)) {
return ErrorEval.NUM_ERROR; return ErrorEval.NUM_ERROR;
} }
evals.add(l); evals.add((long)d);
} }
long result = evals.get(0); long result = evals.get(0);
for (int i = 1; i < evals.size(); i++) { for (int i = 1; i < evals.size(); i++) {
@ -66,4 +68,8 @@ public class Gcd implements FreeRefFunction {
} }
} }
} }
private boolean isInvalidInput(double d) {
return (d < 0 || d > MAX_INPUT);
}
} }

2
poi/src/test/java/org/apache/poi/ss/formula/functions/TestGcd.java
View File

@ -54,12 +54,14 @@ final class TestGcd {
confirmValue(Arrays.asList(5, 0), 5.0); confirmValue(Arrays.asList(5, 0), 5.0);
confirmValue(Arrays.asList(10, 5, 0), 5.0); confirmValue(Arrays.asList(10, 5, 0), 5.0);
confirmValue(Arrays.asList(10.9, 5, 0), 5.0); confirmValue(Arrays.asList(10.9, 5, 0), 5.0);
confirmValue(Arrays.asList(Math.pow(2, 53), 2.0), 2.0);
} }
@Test @Test
void testNumError() { void testNumError() {
confirmNumError(Arrays.asList(-1)); confirmNumError(Arrays.asList(-1));
confirmNumError(Arrays.asList(10, -1)); confirmNumError(Arrays.asList(10, -1));
confirmNumError(Arrays.asList(Math.pow(2, 54), 2.0));
} }
@Test @Test