Switch to parameterized test and add some more information to try to find

out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2019-03-19 21:55:33 +00:00
parent 40f8d119c7
commit bb73949f7b
1 changed files with 35 additions and 13 deletions

View File

@ -16,28 +16,50 @@
==================================================================== */ ==================================================================== */
package org.apache.poi.hwpf.usermodel; package org.apache.poi.hwpf.usermodel;
import junit.framework.TestCase;
import org.apache.poi.hwpf.HWPFDocument; import org.apache.poi.hwpf.HWPFDocument;
import org.apache.poi.hwpf.HWPFTestDataSamples; import org.apache.poi.hwpf.HWPFTestDataSamples;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import static org.junit.Assert.assertTrue;
/** /**
* Bug 47563 - Exception when working with table * Bug 47563 - Exception when working with table
*/ */
public class TestBug47563 extends TestCase { @RunWith(Parameterized.class)
public class TestBug47563 {
public void test() throws Exception { @Parameterized.Parameter()
test(1, 5); public int rows;
test(1, 6); @Parameterized.Parameter(1)
test(5, 1); public int columns;
test(6, 1);
test(2, 2); @Parameterized.Parameters(name="rows: {0}, columns: {1}")
test(3, 2); public static Collection<Object[]> data() {
test(2, 3); List<Object[]> data = new ArrayList<>();
test(3, 3);
data.add(new Object[] {1, 5});
data.add(new Object[] {1, 6});
data.add(new Object[] {5, 1});
data.add(new Object[] {6, 1});
data.add(new Object[] {2, 2});
data.add(new Object[] {3, 2});
data.add(new Object[] {2, 3});
data.add(new Object[] {3, 3});
return data;
} }
private void test(int rows, int columns) throws Exception { @Test
public void test() throws Exception {
System.out.println();
System.out.println("Testing with rows: " + rows + ", columns: " + columns);
// POI apparently can't create a document from scratch, // POI apparently can't create a document from scratch,
// so we need an existing empty dummy document // so we need an existing empty dummy document
HWPFDocument doc = HWPFTestDataSamples.openSampleFile("empty.doc"); HWPFDocument doc = HWPFTestDataSamples.openSampleFile("empty.doc");