Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2015-10-26 20:48:32 +00:00
parent a15fcb1806
commit c776dff7a5
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRichTextString.java
View File

@ -315,7 +315,7 @@ public class XSSFRichTextString implements RichTextString {
if(st.sizeOfRArray() == 0) {
return utfDecode(st.getT());
}
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
for(CTRElt r : st.getRArray()){
buf.append(r.getT());
}
@ -502,7 +502,7 @@ public class XSSFRichTextString implements RichTextString {
static String utfDecode(String value){
if(value == null) return null;
StringBuffer buf = new StringBuffer();
StringBuilder buf = new StringBuilder();
Matcher m = utfPtrn.matcher(value);
int idx = 0;
while(m.find()) {
@ -517,6 +517,13 @@ public class XSSFRichTextString implements RichTextString {
idx = m.end();
}
// small optimization: don't go via StringBuilder if not necessary,
// the encodings are very rare, so we should almost always go via this shortcut.
if(idx == 0) {
return value;
}
buf.append(value.substring(idx));
return buf.toString();
}