Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use Collections.singletonList and Collections.emptyList where appropriate 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777056 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2017-01-03 03:52:58 +00:00
parent 7fff690fa1
commit d45616031e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/scratchpad/src/org/apache/poi/hwpf/usermodel/Picture.java
View File

@ -21,7 +21,7 @@ import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
import java.io.IOException; import java.io.IOException;
import java.io.OutputStream; import java.io.OutputStream;
import java.util.Arrays; import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.zip.InflaterInputStream; import java.util.zip.InflaterInputStream;
@ -85,7 +85,7 @@ public final class Picture
private PICF _picf; private PICF _picf;
private PICFAndOfficeArtData _picfAndOfficeArtData; private PICFAndOfficeArtData _picfAndOfficeArtData;
private List<? extends EscherRecord> _blipRecords; private final List<? extends EscherRecord> _blipRecords;
private byte[] content; private byte[] content;
private int dataBlockStartOfsset; private int dataBlockStartOfsset;
@ -100,7 +100,7 @@ public final class Picture
*/ */
public Picture( EscherBlipRecord blipRecord ) public Picture( EscherBlipRecord blipRecord )
{ {
this._blipRecords = Arrays.asList(new EscherBlipRecord[] {blipRecord}); this._blipRecords = Collections.singletonList(blipRecord);
} }
/** /**
@ -115,7 +115,9 @@ public final class Picture
this.dataBlockStartOfsset = dataBlockStartOfsset; this.dataBlockStartOfsset = dataBlockStartOfsset;
if ( _picfAndOfficeArtData != null && _picfAndOfficeArtData.getBlipRecords() != null) { if ( _picfAndOfficeArtData != null && _picfAndOfficeArtData.getBlipRecords() != null) {
_blipRecords = _picfAndOfficeArtData.getBlipRecords(); _blipRecords = _picfAndOfficeArtData.getBlipRecords();
} else {
_blipRecords = Collections.emptyList();
} }
if ( fillBytes ) { if ( fillBytes ) {