Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

try to remove goto 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893596 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2021-09-24 14:32:26 +00:00
parent 3f6a7285fb
commit d457298316
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
poi/src/main/java/org/apache/poi/hssf/usermodel/HeaderFooter.java
View File

@ -40,8 +40,6 @@ public abstract class HeaderFooter implements org.apache.poi.ss.usermodel.Header
String _center = ""; String _center = "";
String _right = ""; String _right = "";
// FIXME: replace outer goto. just eww.
outer:
while (text.length() > 1) { while (text.length() > 1) {
if (text.charAt(0) != '&') { if (text.charAt(0) != '&') {
// Mimics the behaviour of Excel, which would put it in the center. // Mimics the behaviour of Excel, which would put it in the center.
@ -59,7 +57,7 @@ outer:
} }
_left = text.substring(2, pos); _left = text.substring(2, pos);
text = text.substring(pos); text = text.substring(pos);
break; return new String[] { _left, _center, _right, };
case 'C': case 'C':
if (text.contains("&L")) { if (text.contains("&L")) {
pos = Math.min(pos, text.indexOf("&L")); pos = Math.min(pos, text.indexOf("&L"));
@ -69,7 +67,7 @@ outer:
} }
_center = text.substring(2, pos); _center = text.substring(2, pos);
text = text.substring(pos); text = text.substring(pos);
break; return new String[] { _left, _center, _right, };
case 'R': case 'R':
if (text.contains("&C")) { if (text.contains("&C")) {
pos = Math.min(pos, text.indexOf("&C")); pos = Math.min(pos, text.indexOf("&C"));
@ -79,14 +77,14 @@ outer:
} }
_right = text.substring(2, pos); _right = text.substring(2, pos);
text = text.substring(pos); text = text.substring(pos);
break; return new String[] { _left, _center, _right, };
default: default:
// Mimics the behaviour of Excel, which would put it in the center. // Mimics the behaviour of Excel, which would put it in the center.
_center = text; _center = text;
break outer; break;
} }
} }
return new String[] { _left, _center, _right, }; return null;
} }
/** /**