Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[github-596] Change cast logic in HSSFChart. Thanks to Ruby Hartono. This closes #596 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915881 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2024-02-19 20:11:45 +00:00
parent 23ed93817f
commit d59d6b7d7d
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
View File

@ -113,7 +113,7 @@ public final class HSSFChart {
public void createBarChart( HSSFWorkbook workbook, HSSFSheet parentSheet )
{
List<org.apache.poi.hssf.record.Record> records = new ArrayList<>();
List<Record> records = new ArrayList<>();
records.add( createMSDrawingObjectRecord() );
records.add( createOBJRecord() );
records.add( createBOFRecord() );
@ -227,7 +227,7 @@ public final class HSSFChart {
} else if(r instanceof ValueRangeRecord){
lastChart.valueRanges.add((ValueRangeRecord)r);
} else if (r instanceof Record) {
Record record = (org.apache.poi.hssf.record.Record) r;
Record record = (Record) r;
for (HSSFChartType type : HSSFChartType.values()) {
if (type == HSSFChartType.Unknown) {
continue;
@ -440,7 +440,7 @@ public final class HSSFChart {
return new UnknownRecord((short)0x00EC, data);
}
private void createAxisRecords( List<org.apache.poi.hssf.record.Record> records )
private void createAxisRecords( List<Record> records )
{
records.add( createAxisParentRecord() );
records.add( createBeginRecord() );
@ -1221,30 +1221,30 @@ public final class HSSFChart {
} else if (record instanceof EndRecord) {
newRecord = new EndRecord();
} else if (record instanceof SeriesRecord) {
SeriesRecord seriesRecord = (SeriesRecord) ((SeriesRecord)record).copy();
SeriesRecord seriesRecord = ((SeriesRecord) record).copy();
newSeries = new HSSFSeries(seriesRecord);
newRecord = seriesRecord;
} else if (record instanceof LinkedDataRecord) {
LinkedDataRecord linkedDataRecord = ((LinkedDataRecord)record).copy();
LinkedDataRecord linkedDataRecord = ((LinkedDataRecord) record).copy();
if (newSeries != null) {
newSeries.insertData(linkedDataRecord);
}
newRecord = linkedDataRecord;
} else if (record instanceof DataFormatRecord) {
DataFormatRecord dataFormatRecord = ((DataFormatRecord)record).copy();
DataFormatRecord dataFormatRecord = ((DataFormatRecord) record).copy();
dataFormatRecord.setSeriesIndex((short)seriesIdx) ;
dataFormatRecord.setSeriesNumber((short)seriesIdx) ;
dataFormatRecord.setSeriesIndex((short) seriesIdx) ;
dataFormatRecord.setSeriesNumber((short) seriesIdx) ;
newRecord = dataFormatRecord;
} else if (record instanceof SeriesTextRecord) {
SeriesTextRecord seriesTextRecord = (SeriesTextRecord) ((SeriesTextRecord)record).copy();
SeriesTextRecord seriesTextRecord = ((SeriesTextRecord) record).copy();
if (newSeries != null) {
newSeries.setSeriesTitleText(seriesTextRecord);
}
newRecord = seriesTextRecord;
} else if (record instanceof Record) {
newRecord = (org.apache.poi.hssf.record.Record) ((org.apache.poi.hssf.record.Record)record).copy();
newRecord = ((Record) record).copy();
}
if (newRecord != null)