Commit Graph

4435 Commits

Author SHA1 Message Date
Dominik Stadler 0942712715 Bug 49940: Apply patch to avoid XmlValueDisconnectedException when
saving a file twice and enable reproducing unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535938 13f79535-47bb-0310-9956-ffa450edef68
2013-10-26 07:31:47 +00:00
Dominik Stadler c856b750ae Add a number of tests for the dev-tools. The tests iterate over all .xls
files that are found under test-data, any newly added file or
code-change which breaks one of the dev-tools will cause the tests to
fail in the future. Known broken files can be excluded.

Also fixes two points where some files could cause BiffViewer to fail.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535885 13f79535-47bb-0310-9956-ffa450edef68
2013-10-25 21:57:48 +00:00
Yegor Kozlov ea257d494a Patch 55612 - Performance improvement in HSSFCellStyle.getDataFormatString()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535810 13f79535-47bb-0310-9956-ffa450edef68
2013-10-25 18:41:24 +00:00
Dominik Stadler 3c13ee8f28 Fix some Eclipse warnings, remove trailing whitespaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535517 13f79535-47bb-0310-9956-ffa450edef68
2013-10-24 19:58:19 +00:00
Nick Burch ccb7cc6015 Have HSSFWorkbook check for an encrypted .xlsx file when opening, and give a helpful error if found, plus tests. Fixes #55692
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534967 13f79535-47bb-0310-9956-ffa450edef68
2013-10-23 09:43:28 +00:00
Nick Burch ff1699658c Patch from bug #55650 from Andrej - Avoid AIOOBE if a non-existant Xfs is requested for a styleAvoid AIOOBE if a non-existant Xfs is requested for a style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534818 13f79535-47bb-0310-9956-ffa450edef68
2013-10-22 22:04:16 +00:00
Dominik Stadler c35b61e1fc Bug 55369: Add support for collapsing rows in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533932 13f79535-47bb-0310-9956-ffa450edef68
2013-10-20 18:04:08 +00:00
Yegor Kozlov e5387b1e72 Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533768 13f79535-47bb-0310-9956-ffa450edef68
2013-10-19 14:12:15 +00:00
Yegor Kozlov dc40d3599c Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533764 13f79535-47bb-0310-9956-ffa450edef68
2013-10-19 13:53:19 +00:00
Dominik Stadler 34209b8661 Bug 55658: don't fail in SXSSF if a numeric cell is overwritten with a string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532873 13f79535-47bb-0310-9956-ffa450edef68
2013-10-16 19:47:21 +00:00
Dominik Stadler 5bc1aa8038 Change from having actual zero bytes in java code to java-string notation for unicode-zero to avoid trouble with this file in Sonar when using PostgreSQL (which seems to fall over binary data in text files). The resulting test should be the same with the \u0000 notation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532037 13f79535-47bb-0310-9956-ffa450edef68
2013-10-14 19:44:30 +00:00
Yegor Kozlov f6cb7f14ac Bugzilla 55578 - Support embedding OLE1.0 packages in HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531623 13f79535-47bb-0310-9956-ffa450edef68
2013-10-13 07:39:40 +00:00
Yegor Kozlov 1ffc66625a Bugzilla 49658 - Support embedding EMF/WMF pictures in HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531622 13f79535-47bb-0310-9956-ffa450edef68
2013-10-13 07:20:36 +00:00
Cédric Walter 64dd75bc67 Bug 55036: fixed red build (Dec2Hex)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531506 13f79535-47bb-0310-9956-ffa450edef68
2013-10-12 06:28:51 +00:00
Cédric Walter 8b76575e62 Bug 55036: patch for missing function Dec2HEx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531395 13f79535-47bb-0310-9956-ffa450edef68
2013-10-11 19:16:43 +00:00
Cédric Walter 7809ede62e Bug 55057: patch for missing function Hex2Dec
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531393 13f79535-47bb-0310-9956-ffa450edef68
2013-10-11 19:06:33 +00:00
Cédric Walter f7f52a98e5 Bug 55116: patch for missing function Dec2Bin
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531390 13f79535-47bb-0310-9956-ffa450edef68
2013-10-11 18:49:19 +00:00
Cédric Walter 80d588f8c6 Bug 55055: patch for missing function Bin2Dec
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531386 13f79535-47bb-0310-9956-ffa450edef68
2013-10-11 18:39:22 +00:00
Cédric Walter c7fecc7c21 Bug 55649: WORKDAY Function returns incorrect date when spanning a weekend, or the start date is a weekend
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531124 13f79535-47bb-0310-9956-ffa450edef68
2013-10-10 21:54:52 +00:00
Nick Burch b34a3eefa7 Fix #55647 - When creating a temp file, ensure the name isn't already taken
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531040 13f79535-47bb-0310-9956-ffa450edef68
2013-10-10 16:20:07 +00:00
Cédric Walter 793791ece8 Bug 55058: patch for missing function FactDouble
Returns the double factorial of a number: FACTDOUBLE(number)

Number     is the value for which to return the double factorial. If number is not an integer, it is truncated.

Remarks
If number is nonnumeric, FACTDOUBLE returns the #VALUE! error value.
If number is negative, FACTDOUBLE returns the #NUM! error value.

Has  a cache for more speed of previously calculated factorial
Add additional sanity check/integration test FormulaEvalTestData.xls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530907 13f79535-47bb-0310-9956-ffa450edef68
2013-10-10 10:10:54 +00:00
Cédric Walter f9fc754611 Bug 55081: patch for missing function WEEKNUM
Add simple spreadsheet with Excel 2003, and another with 2013 (both fresh files)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530256 13f79535-47bb-0310-9956-ffa450edef68
2013-10-08 12:54:35 +00:00
Cédric Walter 805d583bab Bug 55037: patch for missing function DELTA
Add missing TestDeltaFunctionsFromSpreadsheet and register Delta in AnalysisToolPak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1529809 13f79535-47bb-0310-9956-ffa450edef68
2013-10-07 09:42:38 +00:00
Dominik Stadler 927dc0ce1d Apply patch from bug 55341
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527397 13f79535-47bb-0310-9956-ffa450edef68
2013-09-29 20:23:20 +00:00
Tim Allison 49fc2a7a1c Potential NPE in PPExtractor; found while working on TIKA-1171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527041 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 19:35:14 +00:00
Tim Allison 6e50bfa19d POI-54722 table text in ppt files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1526960 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 15:45:55 +00:00
Nick Burch 5adfec1810 Support more hashing formats for OOXML protected documents, for bug #55544
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1522074 13f79535-47bb-0310-9956-ffa450edef68
2013-09-11 22:22:30 +00:00
Dominik Stadler f81c3cb9cb Remove Eclipse warnings, remove duplicate test, rename tests to also run tests in base class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521015 13f79535-47bb-0310-9956-ffa450edef68
2013-09-09 09:41:31 +00:00
Dominik Stadler 425ab7b6dc Bug 53798: Add fix for XmlValueDisconnectException during shifting rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521012 13f79535-47bb-0310-9956-ffa450edef68
2013-09-09 09:24:05 +00:00
Dominik Stadler 8693b4f997 Bug 54524: Fix border case in FormulaShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517676 13f79535-47bb-0310-9956-ffa450edef68
2013-08-26 20:09:19 +00:00
Dominik Stadler d3bfcda99e Fix regression introduced by r1516969
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517180 13f79535-47bb-0310-9956-ffa450edef68
2013-08-24 18:33:00 +00:00
Dominik Stadler 77d75dd32a Exclude TestUnfixedBugs from OOXMLLite to avoid confusing output in ant-build of ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517179 13f79535-47bb-0310-9956-ffa450edef68
2013-08-24 18:32:45 +00:00
Nick Burch 0c44c5fec7 More unit tests for column conversion, and avoid the use of Math.pow based on the suggestion from github-6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516983 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 19:00:01 +00:00
Dominik Stadler 57de5b995d Tried to reproduce Bug 47090, but seems to be fixed now.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516982 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:56:32 +00:00
Dominik Stadler f06e06ef12 Add testcase which tries to reproduce Bug 48495, but seems to be fixed
now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516981 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:56:11 +00:00
Dominik Stadler fb90b50dbf Some Eclipse warnings removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516980 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:54:05 +00:00
Nick Burch fa39b0e791 Add some explicit tests for column letter to/from number conversion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516978 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:52:18 +00:00
Nick Burch c46f0ec2aa Remove some @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516975 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:42:57 +00:00
Nick Burch 2cac6664cf Start to remove @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516973 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:36:41 +00:00
Nick Burch 106b8f3da8 Inspired by github pull-6, use a StringBuilder for quicker string appending
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516969 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:30:01 +00:00
Dominik Stadler 5a067c6b97 fix some Eclipse warnings, adjust some unit tests slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516818 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 10:44:39 +00:00
Dominik Stadler cb6ca3554d Fix unit test for Bug 50298 some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516320 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:57:26 +00:00
Dominik Stadler da0b4d1b3a Adjust test for Bug 50298 to not leave a temporary file behind and
enhance the test with some more cases of moving/changing/removing sheet
order/names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516314 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:19:58 +00:00
Dominik Stadler 324a36e170 Bug 50298: Fix corruption of Workbook when setting sheet order. The
boundssheets themselves were adjusted, but not the corresponding
records.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516313 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:08:20 +00:00
Dominik Stadler d415bf5d06 Also fix some Eclipse warnings while hunting Bugs: Generics, unused
variables, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516312 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:06:07 +00:00
Nick Burch b7db2fceef Push the fix for bug #55248 up to the Sheet interface (was XSSF only before)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 09:41:15 +00:00
Dominik Stadler 51a7f3e333 Bug 52233: try to fix this without breaking the format of xlsx-files.
The set to null is necessary to not have an empty <cols/> element in the
xlsx, however later on stuff breaks if no colsArray is availalbe,
therefore we now re-create the empty cols array if we did remove it
before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515916 13f79535-47bb-0310-9956-ffa450edef68
2013-08-20 18:44:44 +00:00
Dominik Stadler 70dc3d38ca Revert changes from rev. 1513916 as it severly broke writing valid xlsx files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515842 13f79535-47bb-0310-9956-ffa450edef68
2013-08-20 15:03:18 +00:00
Cédric Walter f75f0ec612 Bug 55043: patch for missing function QUOTIENT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514847 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:54:35 +00:00
Cédric Walter ce4501452f Bug 55082: patch for missing function ROMAN
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514834 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:28:18 +00:00
Cédric Walter 906aafbc59 Bug 55080: patch for missing function IMREAL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514830 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:13:40 +00:00
Cédric Walter 828ce7281b Bug 55079: patch for missing function IMAGINARY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514824 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:59:01 +00:00
Cédric Walter 1d2f94829e Bug 54720: Support for Row/Col Area Range like 8:8 or H:H
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514812 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:35:16 +00:00
Cédric Walter 1b795e34f7 Bug 54723: Support for percentage in VALUE() function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514799 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:15:47 +00:00
Dominik Stadler 04e0efdbd5 Bug 54786: Fix missing quoting in date formatting, add a number of unit
tests which verify the new formatting options.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514632 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 09:38:47 +00:00
Tim Allison 0c35aa60e1 55419 and refactor SimpleFraction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514123 13f79535-47bb-0310-9956-ffa450edef68
2013-08-15 01:46:25 +00:00
Dominik Stadler 8efac247db Bug 52233: Do not make the XSSFSheet invalid during write(), I could not find out why the ColsArray was set to null in the write() method. By removing this the writing of the sheet does not invalidate the Workbook any more and makes the test case work fine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513916 13f79535-47bb-0310-9956-ffa450edef68
2013-08-14 14:57:44 +00:00
Dominik Stadler 607521c2df Various small Eclipse warning fixes,
also ensure close() of stream in Ant-Task, although WorkbookFactory usually takes care of this, however in exception-cases it could be missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513764 13f79535-47bb-0310-9956-ffa450edef68
2013-08-14 08:25:51 +00:00
Dominik Stadler 5ce60e1140 Bug 55195: use interface instead of implementation for
NumericValueEval and others.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513247 13f79535-47bb-0310-9956-ffa450edef68
2013-08-12 20:27:08 +00:00
Dominik Stadler 0b5244e619 Bug 55380: Fix endless loop in CellRangeUtil.mergeCellRanges() by not trying to merge overlapping regions any more, the implementation is buggy and even tagged TODO - unit test missing. The code is hard to understand and bug-free-ness is better than catching all possible merges imho.
Also add many cases to the unit tests and reformat code slightly as well
as fixing some Generics-Warnings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513225 13f79535-47bb-0310-9956-ffa450edef68
2013-08-12 19:13:10 +00:00
Tim Allison 8f68884358 55347 - integrate textbox text extraction with Excel extractors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1511789 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 14:04:07 +00:00
Tim Allison 9ddef1c083 POI 55361 trigger to load CTMoveBookmark in TestXWPFParagraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1511777 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 13:42:01 +00:00
Tim Allison e4ba611f12 POI-55294 and 52186
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510587 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 16:17:17 +00:00
Dominik Stadler cb5ff8f4cf Adjust build.xml to run JaCoCo coverage when running unit tests when
flag coverage.enabled is set to true, download necessary jars, add jacoco:coverage
to junit targets and a testcoveragereport target which produces the coverage report.
Also fix a test that is affected by JaCoCo and add slightly more coverage in another test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510243 13f79535-47bb-0310-9956-ffa450edef68
2013-08-04 16:38:01 +00:00
Tim Allison cd3b2e42e9 POI-55292 with added files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508692 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 00:21:04 +00:00
Tim Allison da070049dd POI-55292
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508691 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 00:19:07 +00:00
Tim Allison 62e7e01f6c added ratted out Apache license to HPSFPropertiesOnlyDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508190 13f79535-47bb-0310-9956-ffa450edef68
2013-07-29 19:36:24 +00:00
Nick Burch e1cf345671 Ensure the interface and implementation javadocs share the same warnings, and paragraph-ise to look nicer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1503491 13f79535-47bb-0310-9956-ffa450edef68
2013-07-15 21:45:21 +00:00
Dominik Stadler 11ceaebac6 Bug 55248: Add methods for showInPane() using int and unit test to verify it can handle more than 32767 rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502749 13f79535-47bb-0310-9956-ffa450edef68
2013-07-13 05:37:41 +00:00
Dominik Stadler 97d6444cb0 Add more unit tests to cover more of HSSFWorkbook and HSSFSheet, check one more case of IndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502661 13f79535-47bb-0310-9956-ffa450edef68
2013-07-12 19:21:12 +00:00
Dominik Stadler d6da9dd94b Add reproducing unit tests to TestUnfixedBugs for Bug 53798 and Bug 54071
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1501263 13f79535-47bb-0310-9956-ffa450edef68
2013-07-09 13:55:54 +00:00
Nick Burch 4ac189421a Refactor to avoid logic duplication on the property value -> string conversion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499329 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:36:11 +00:00
Nick Burch b3608a4cfa Fix bug #55191 - Avoid a ClassCastException if a HPSF string property isn't directly stored as a string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499326 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:24:01 +00:00
Dominik Stadler 6d772a851e Fix build broken by previous checkin by creating a TestUnfixedBugs for ooxml as well and excluding the new test-class in test-ooxml similar to the main tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498280 13f79535-47bb-0310-9956-ffa450edef68
2013-07-01 08:03:40 +00:00
Dominik Stadler 4a85927e98 Bug 54084: Add testcase which reproduces the bug, no fix available yet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498190 13f79535-47bb-0310-9956-ffa450edef68
2013-06-30 22:47:26 +00:00
Nick Burch ea1bb016a9 Add a test to show that bug #53150 has been fixed by the recent fraction work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497084 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 20:40:26 +00:00
Nick Burch 2d0241181a Have MAPIMessage try the codepage properties to get the ascii encoding, before falling back to the existing logic around content type parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497038 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:46:37 +00:00
Nick Burch 4110133f8e HSMF generally wants Java Lang style encoding names, which HPSF has always worked with Java NIO ones, so add a flag to CodePageUtil to let you select which style to return
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497037 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:44:51 +00:00
Nick Burch 401dcb864d Deprecate the old HPSF codepage Constants list, and change the code to use the new CodePageUtil class instead for their codepage work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497035 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:20:37 +00:00
Nick Burch 182b941b2c Bring the numeric CodePage support from HPSF (constants and converters) out to a new Util class, so that HSMF can later use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497032 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:18:21 +00:00
Nick Burch 14e2a5be28 More unit tests for the HSMF fixed sized property values (a few still remain to be fixed though)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497023 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:45:57 +00:00
Nick Burch daea88523a Make the fixed sized properties parser more flexible in the face of slightly duff data
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497006 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:03:26 +00:00
Nick Burch 35493f04fe Dig out the normal type for some more common properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497004 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:58:11 +00:00
Nick Burch 14b262b831 Support decoding a few more property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496988 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:17:00 +00:00
Nick Burch 0b1750bea0 More friendly output of byte arrays for property values in HSMFDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496982 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:03:09 +00:00
Nick Burch 459e35426f Fix inconsistent whitespace in HSMF test files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496969 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:28:25 +00:00
Nick Burch 141bd7f85f Fix inconsistent whitespace in HSMF files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:23:29 +00:00
Nick Burch 2a1726144d Ensure the indenting is consistent within the file, and then make some minor updates to the JavaDocs (language, clarity etc)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496952 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 14:57:36 +00:00
Nick Burch 3fa0d18132 Fix JavaDoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496701 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:56:28 +00:00
Nick Burch 6d63c0d32e Convert classes with a assertContains method to using the new POITestCase common parent class, which has it there
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496697 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:49:41 +00:00
Nick Burch 0339745131 Add disabled unit test for bug #54916
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496696 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:45:18 +00:00
Nick Burch 853ac73ce1 New parent test class, which includes the common assertContains pattern
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496695 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:44:35 +00:00
Nick Burch 3c5ab9160e JavaDoc fix - missing >
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:21:40 +00:00
Nick Burch 85cca5bc2d Add a write method to HPSFPropertiesOnlyDocument, and use this to finish the unit tests for bug #54233
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496683 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:18:41 +00:00
Nick Burch b8fe46ca9e Pull the Properties-Only document type out to a superclass, so other places (eg unit tests) can use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496680 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:10:43 +00:00
Nick Burch 80677e58b3 Fix bug #54233 - Some HPSF documents require UnicodeStrings to be 4-byte aligned, spot these from the otherwise invalid length
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496675 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:49:24 +00:00
Nick Burch 7105816a1e Fix to have consistent whitespace, and add javadoc deprecated entries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496673 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:34:22 +00:00
Nick Burch 546b1e7171 Fix to have consistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496671 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:30:37 +00:00
Nick Burch 9eb644c546 Remove the executable flag from a number of files that aren't executables so shouldn't have it set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496656 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:12:48 +00:00
Nick Burch 41665ca038 Add missing license headers, and a few javadoc tweaks while working on those files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496652 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:04:49 +00:00
Nick Burch fe58c66883 Sanity check the length, logging and truncating if too long, to avoid a StringIndexOutOfBoundsException (bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496520 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:49:45 +00:00
Nick Burch ad8825dc52 Fix the indenting to be consistent throughout the file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496519 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:44:36 +00:00
Nick Burch fe017f6437 Add another record type to the "don't warn" list, and tidy up the code a little bit (see bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496518 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:40:05 +00:00
Nick Burch 7067e87b8b Fix from Florian Hopf from bug #54564 - Fix error message text
for a workbook with no sheets when a sheet operation is performed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496516 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:19:56 +00:00
Nick Burch 4f6728ccd4 Fix indenting to be consistent, and correct the setIncludeCellComments javadoc to match the long standing default (#54871)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496510 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:05:27 +00:00
Nick Burch 882bf2cfe8 Patch from Andrew Novikov from bug #53972 - Presence of PLV record shouldn't affect HSSF Data Validation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496499 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 14:48:16 +00:00
Nick Burch 3c379bbcde Patch from Tim Allison from bug #55142 - Not all XWPF SDT block
s need newlines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496458 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 13:09:08 +00:00
Dominik Stadler 5d40529d6a Bug 54920: do not set column and row separatedely, but use a reference
for newComment(), keep previous method as deprecated. Adjust all places
where newComment() is used and add unit test covering the bug.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1495894 13f79535-47bb-0310-9956-ffa450edef68
2013-06-23 21:31:15 +00:00
Nick Burch f9c9def944 Patch and unit test from Tim Allen from bug #54686 - Improve how DataFormatter handles fractions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494986 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 13:37:26 +00:00
Nick Burch 5f7a1597e4 Patch from Tim Allen from bug #55066 - unit test to show that we no longer load XWPF footnotes twice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 12:51:30 +00:00
Nick Burch 0591f0edbe Avoid a NPE if no password was given - use the default office one instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494571 13f79535-47bb-0310-9956-ffa450edef68
2013-06-19 11:56:21 +00:00
Nick Burch b1e02dea83 Fix the footnote doubling, and then enable the rest of the SDT tests from Tim Allison from bug #54849
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494379 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:39:31 +00:00
Nick Burch 28981c3069 Remove tab indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494378 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:38:25 +00:00
Nick Burch 8465abf932 Patch from Tim Allison from bug #54849 - Controlled content/Form (Std/StdBlock) content
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494376 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:35:11 +00:00
Dominik Stadler d1a21260ca Bug 54607: Add unit test and fix NPE for getTopRow() and getLeftCol()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493686 13f79535-47bb-0310-9956-ffa450edef68
2013-06-17 09:06:39 +00:00
Dominik Stadler fa19777476 Bug 54982: Add a close() interface to POITextExtractor which can be used to free resources later.
Implement close() where necessary so resources are closed. Add close()
to tests and run existing unit tests also against the Extractor that is
built via the Factory. Also add a small test-suite to quickly execute
all extractor-related tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493669 13f79535-47bb-0310-9956-ffa450edef68
2013-06-17 07:53:59 +00:00
Nick Burch 8b4cc4c474 Patch from Trejkaz from GitHub Pull 2 - HSSFWorkbook.getAllEmbeddedObjects() needs to recurse into container Shapes (with new unit test)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493001 13f79535-47bb-0310-9956-ffa450edef68
2013-06-14 08:53:29 +00:00
Nick Burch d246052993 Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492818 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:52:03 +00:00
Nick Burch abd6675bcf Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492804 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:34:54 +00:00
Nick Burch d323b0054c Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492802 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:29:08 +00:00
Nick Burch 19ade4ae64 Fix the javadoc, correct the indenting, and add the new test file from bug #54849
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492796 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:18:19 +00:00
Nick Burch 9228ac464d Patch from akhikhl from github pull #4 - Expose from XWPFParagraph the number level and format, if applied
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492312 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 18:04:16 +00:00
Nick Burch 7341e677fb Patch from akhikhl from github pull #3 - Extract references from XWPF footnotes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492308 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 17:54:39 +00:00
Nick Burch 38691d40ab JavaDoc fixes from #54731 from Dominik Stadler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492267 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 16:32:24 +00:00
Yegor Kozlov 63b0cd2802 fixed compatibility issues with JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1489685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-05 02:03:07 +00:00
Yegor Kozlov c69739c288 removed @Override to keep javac on JDK 1.5 happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488823 13f79535-47bb-0310-9956-ffa450edef68
2013-06-03 01:05:28 +00:00
Yegor Kozlov 9fd5fb147d Bug 55047: REPT formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488811 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:39:41 +00:00
Yegor Kozlov 0b7dc0f2ca missing tests for Bug 55041 - CODE formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488810 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:32:24 +00:00
Yegor Kozlov 43011d3a3b added missing tests for Bug 55042: patch for missing function COMPLEX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488809 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:25:33 +00:00
Yegor Kozlov 782fd29471 added missing tests for Bug 55042: patch for missing function COMPLEX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488808 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:25:07 +00:00
Yegor Kozlov 24967623a9 Bugzilla 55043 and 55042: initial support for Complex and Quotient functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488734 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 16:08:17 +00:00
Yegor Kozlov bf443142c7 Bugzilla 55041: CODE function support, also removed @Override from interfaces to stay compatible with JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488733 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:58:41 +00:00
Yegor Kozlov aad5f66735 Bugzilla 55037: DELTA function support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488730 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:30:58 +00:00
Yegor Kozlov d1a6ade582 Bugzilla 55036 - Dec2HEx formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488729 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:13:47 +00:00
Nick Burch c225df5b71 Unit test for bugs #54880 & #55030 - seems ok so far
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488403 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 21:17:55 +00:00
Nick Burch 8476be0735 Fix bug #55001 - check for unicode text too (plus fix indents)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488329 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 17:30:29 +00:00
Nick Burch ea27681eab Stub out the unit tests needed for bug #55026, and add the sample file from that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487657 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 22:23:51 +00:00
Nick Burch 1a2591a8c1 More on bug #54682 - check for the end offset overflowing too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487558 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:31:50 +00:00
Nick Burch 25bc679244 Fix bug #54682 - UnhandledDataStructure should sanity check before allocating, not after
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487555 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:25:40 +00:00
Nick Burch a5c69d394b Where possible, allow fetching of the size of the OPC Package Part (-1 if not)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1482647 13f79535-47bb-0310-9956-ffa450edef68
2013-05-15 00:27:59 +00:00
Nick Burch f8ccd5d014 Fix #54891 - correct javadoc on HSSF + SS (XSSF was correct) for Row.createCell(int,int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1479639 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 16:53:04 +00:00
Yegor Kozlov 4d2be80806 Bug 54673 - [PATCH] Simple wildcard support in HLOOKUP, VOOLKUP, MATCH, COUNTIF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1457243 13f79535-47bb-0310-9956-ffa450edef68
2013-03-16 12:33:08 +00:00
Yegor Kozlov 0f299e5b5f Bugzilla 54625 - Register user-defined functions in instance scope instead of static
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1452060 13f79535-47bb-0310-9956-ffa450edef68
2013-03-03 16:16:12 +00:00
Yegor Kozlov ec930fd66a Bugzilla 54469 - Support for financial functions IPMT and PPMT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451886 13f79535-47bb-0310-9956-ffa450edef68
2013-03-02 13:17:53 +00:00
Yegor Kozlov 38774b82a8 Bugzilla 54436: Fixed metadata for GETPIVOTDATA function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451875 13f79535-47bb-0310-9956-ffa450edef68
2013-03-02 11:38:09 +00:00
Nick Burch 22f30ab168 Fix bug #54579 - Handle milliseconds in date formats eg ss.000
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1447798 13f79535-47bb-0310-9956-ffa450edef68
2013-02-19 16:28:40 +00:00
Nick Burch f0ca7d2899 Fix bug #54557 - Don't mis-detect format patterns like .000 as dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1445725 13f79535-47bb-0310-9956-ffa450edef68
2013-02-13 16:45:03 +00:00
Nick Burch c5b2f7dc7f Fix bug #54506 - Add "BOOK" to the list of unusual-but-largely-ok Workbook directory entry names list, alongside WORKBOOK, plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1443745 13f79535-47bb-0310-9956-ffa450edef68
2013-02-07 21:53:07 +00:00
Nick Burch 76edd0fc3f Fix 1.6ism from original patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442521 13f79535-47bb-0310-9956-ffa450edef68
2013-02-05 10:00:43 +00:00
Nick Burch 3460c45bc3 EDate function implementation from Detlef Brendle from bug #54508
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442392 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 22:01:55 +00:00