Commit Graph

8215 Commits

Author SHA1 Message Date
Dominik Stadler 734d6911d8 Do not use a WeakReference for the parent-link in HWPF-Ranges
Some unit-tests show sporadic failures and it seems functionality is actually
broken if the WeakReference is garbage-collected. Not sure why a
WeakReference was used here anyway.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1866054 13f79535-47bb-0310-9956-ffa450edef68
2019-08-29 05:15:57 +00:00
Dominik Stadler d81b74ba67 Adjust JavaDoc and code formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1866053 13f79535-47bb-0310-9956-ffa450edef68
2019-08-29 05:15:50 +00:00
PJ Fanning 3623bea505 [bug-63664] do not use DocumentBuilderFactory directly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1865720 13f79535-47bb-0310-9956-ffa450edef68
2019-08-22 21:57:50 +00:00
Dominik Stadler a3298f9c16 Bug 63657: Optimize onDocumentWrite() to not do the full re-assignment
if not necessary at all, also use getCArray() instead of getCList() as
access-operations are much quicker this way

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1865209 13f79535-47bb-0310-9956-ffa450edef68
2019-08-15 07:55:06 +00:00
Dominik Stadler ba66108653 Close file-resources in unit-tests, fix IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1865208 13f79535-47bb-0310-9956-ffa450edef68
2019-08-15 07:54:58 +00:00
Dominik Stadler 0619e7ebfb Bug 63657: Rework the for bug #62130 to not use up twice as much memory when writing documents.
Unfortunately XMLBeans is very tricky to use here, mainly the fact that setCArray does not replace the internal objects, but copies the content into the currently held objects makes it rather hard to do this right.

Therefore we now try to keep the existing objects and only replace the content as required to
have a stable ordering of cells in the row-XML structure.

This also fixes removing cells from rows to avoid invalid situations and
correctly free CTCellImpl instances.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1864977 13f79535-47bb-0310-9956-ffa450edef68
2019-08-12 16:42:46 +00:00
PJ Fanning 958f72caae add some missing classes to poi-ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863753 13f79535-47bb-0310-9956-ffa450edef68
2019-07-25 17:26:21 +00:00
PJ Fanning 9bd1a6348a add some missing classes to poi-ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863752 13f79535-47bb-0310-9956-ffa450edef68
2019-07-25 17:04:23 +00:00
Andreas Beeker ec2951bece Bug 60656 - fix image dimensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863602 13f79535-47bb-0310-9956-ffa450edef68
2019-07-22 21:31:58 +00:00
Andreas Beeker e18eef07b1 Refactor alpha handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863601 13f79535-47bb-0310-9956-ffa450edef68
2019-07-22 21:30:12 +00:00
Andreas Beeker 58eb1a8070 Bug 63580 - Fix texture paint handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863600 13f79535-47bb-0310-9956-ffa450edef68
2019-07-22 21:29:55 +00:00
PJ Fanning 21ed5240e7 try to fix NPE in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863516 13f79535-47bb-0310-9956-ffa450edef68
2019-07-21 08:39:56 +00:00
PJ Fanning cf1eb05304 missing @since annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863476 13f79535-47bb-0310-9956-ffa450edef68
2019-07-20 12:11:07 +00:00
PJ Fanning 4fbad5c3f7 [github-150] XWPFPicture: easy access to width and depth. Thanks to Thibaut Cuvelier. This closes #150
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863434 13f79535-47bb-0310-9956-ffa450edef68
2019-07-19 21:05:15 +00:00
PJ Fanning ea58359b7c [github-153] XWPFParagraph: easier way to create a link. Thanks to Thibaut Cuvelier. This closes #153
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863433 13f79535-47bb-0310-9956-ffa450edef68
2019-07-19 20:49:48 +00:00
PJ Fanning 10b5a462dc [github-157] add setters for ExtendedProperties. Thanks to Thibaut Cuvelier. This closes #157
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863432 13f79535-47bb-0310-9956-ffa450edef68
2019-07-19 19:48:14 +00:00
PJ Fanning 65c4aafe3e [github-156] add setKeepNext to XWPFParagraph. Thanks to Thibaut Cuvelier.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863182 13f79535-47bb-0310-9956-ffa450edef68
2019-07-16 21:00:49 +00:00
Tim Allison c7bcd70d54 Bug 63542 -- bump min record limit for TNEFAttribute
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1862895 13f79535-47bb-0310-9956-ffa450edef68
2019-07-10 20:02:59 +00:00
PJ Fanning 0d323ec9b0 [bug-63533] fix javadoc that refers to horisontalPdi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1862382 13f79535-47bb-0310-9956-ffa450edef68
2019-07-01 14:07:16 +00:00
Andreas Beeker dd6d090969 fix rendering of xslf shapes with no/external blip part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861958 13f79535-47bb-0310-9956-ffa450edef68
2019-06-23 23:13:15 +00:00
Andreas Beeker 0df618c109 omit png output on test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861953 13f79535-47bb-0310-9956-ffa450edef68
2019-06-23 22:26:24 +00:00
Andreas Beeker 861988bac3 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861952 13f79535-47bb-0310-9956-ffa450edef68
2019-06-23 22:21:15 +00:00
Dominik Stadler 9cde034ab9 Bug 62906 and 63401: Ensure tables have an initial name which does not conflict with
existing names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861819 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 06:12:19 +00:00
Dominik Stadler 16779b96e5 Fix IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861818 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 06:12:12 +00:00
Dominik Stadler 50874d9d0d Bug 63509: Allow to format a CellReference without sheet-name for ignoredErrors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861817 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 06:12:05 +00:00
PJ Fanning 0cd5834661 [bug-57342] Excel compatible Zip64 implementation. Thanks to Krzysztof Rzymkowski. This closes #154
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861196 13f79535-47bb-0310-9956-ffa450edef68
2019-06-12 21:34:39 +00:00
PJ Fanning 25d3f3527d tidy up some int casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861176 13f79535-47bb-0310-9956-ffa450edef68
2019-06-12 18:14:22 +00:00
PJ Fanning d20bc98f70 [bug-63498] NPE when calling getShapeName on XSLFTableCell. Thanks to Mate Borcsok.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861172 13f79535-47bb-0310-9956-ffa450edef68
2019-06-12 17:30:52 +00:00
Andreas Beeker 27c20b0e9a Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860732 13f79535-47bb-0310-9956-ffa450edef68
2019-06-06 22:32:41 +00:00
Dominik Stadler 8808bf7b72 ExcelComparator: Adjust iterating rows/columns
Run this sample as part of the integration tests
Open the files read-only to not re-write them with changed content
Add null-checks and use toString() to prevent exceptions with certain files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860688 13f79535-47bb-0310-9956-ffa450edef68
2019-06-05 20:28:07 +00:00
Dominik Stadler d3b794de7a Add helper class for mass-regression-tests which scans a directory and provides
the matching FileHandlers for each found file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860686 13f79535-47bb-0310-9956-ffa450edef68
2019-06-05 20:27:54 +00:00
PJ Fanning 5e33bd4b29 [github-151] XWPFRun: allow style retrieval. This closes #151
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860464 13f79535-47bb-0310-9956-ffa450edef68
2019-06-01 01:09:40 +00:00
PJ Fanning 8638dbf9b8 [bug-63463] ignore forbiddenapis in new testcase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860422 13f79535-47bb-0310-9956-ffa450edef68
2019-05-31 00:13:37 +00:00
PJ Fanning 680d655435 [bug-63463] add tests fix issue with shifting rows (failing tests ignored). Thanks to David Gauntt.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860419 13f79535-47bb-0310-9956-ffa450edef68
2019-05-30 20:59:14 +00:00
PJ Fanning 7ef085af37 [bug-63463] fix issue with shifting rows. Thanks to David Gauntt.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860384 13f79535-47bb-0310-9956-ffa450edef68
2019-05-30 07:56:33 +00:00
Alain Béarez dcb6d534fd remove code smells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860311 13f79535-47bb-0310-9956-ffa450edef68
2019-05-29 01:05:26 +00:00
PJ Fanning 0ccbf4671d fix forbidden api issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860160 13f79535-47bb-0310-9956-ffa450edef68
2019-05-27 20:00:04 +00:00
PJ Fanning 2343919656 try to fix integration tests (by ignoring some new msg files)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860155 13f79535-47bb-0310-9956-ffa450edef68
2019-05-27 17:46:41 +00:00
PJ Fanning f74a8f9abb [github-149] improve MAPIMessage.guess7BitEncoding, improve MAPIMessage.getHtmlBody. Thanks to Dominik Hölzl. This closes #149
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 09:43:59 +00:00
PJ Fanning 3d5671ac5e remove some tab indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859758 13f79535-47bb-0310-9956-ffa450edef68
2019-05-22 22:59:12 +00:00
Alain Béarez 9995e178e3 code inspired from Axel Richter on StackOverflow
closes #139
closes #144

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859676 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 23:28:15 +00:00
Alain Béarez e3df15d773 fix missing space in string literal (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859596 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:14:15 +00:00
Alain Béarez 928e6937f4 fix result of multiplication cast to wider type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859595 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:14:12 +00:00
Alain Béarez 906c52d81d fix whitespace contradicts operator precedence
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859594 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:59 +00:00
Alain Béarez 5d376c8696 fix boxed variable is never null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859593 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:56 +00:00
Alain Béarez a59ed12ecf fix potential output resource leaks (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859592 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:51 +00:00
Alain Béarez 8784d6d6d7 fix potential input resource leaks (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859591 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:47 +00:00
Alain Béarez 093cbcfcca code cleanup plus fix for bug 63153
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859590 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:40 +00:00
Alain Béarez af1dacfe2c Added more chart supports.
fixed bug while creating chart with bar and line series.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859589 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:28 +00:00
Dominik Stadler 217a7caae6 Use TempFile to avoid problems with temporary directories in Maven builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859575 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 17:35:54 +00:00
Dominik Stadler 1a3e69fe16 Include actual found type in exception when encountering unexpected type of file in ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859565 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 14:42:39 +00:00
Dominik Stadler b2130769b6 FileMagic now has patterns with up to 12 bytes (JPG)
Avoid exception if a very short file is encountered
Add more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859564 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 14:42:31 +00:00
Dominik Stadler f4a3d3bb89 Refine JavaDoc of WorkbookFactory slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859368 13f79535-47bb-0310-9956-ffa450edef68
2019-05-16 11:40:38 +00:00
Tim Allison b3da2d5e8a Bug 63431 -- unbug ChunkedCipherInputStream's read()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859251 13f79535-47bb-0310-9956-ffa450edef68
2019-05-15 00:56:15 +00:00
PJ Fanning 2ae5198ff7 [github-145] issue in PackagingURIHelper.encode. Thanks to @greedbell. This closes #145
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859160 13f79535-47bb-0310-9956-ffa450edef68
2019-05-12 20:59:27 +00:00
Andreas Beeker d6ee139b39 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859159 13f79535-47bb-0310-9956-ffa450edef68
2019-05-12 19:50:04 +00:00
Andreas Beeker 049baa86d7 #59004 - HSLF rendering - adjust values for presetShapeDefinition differs in HSLF/XSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859102 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 20:55:24 +00:00
Andreas Beeker 4e663c4b5d Don't fallback to master shape properties, if master shape is not assigned
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859101 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 20:54:57 +00:00
PJ Fanning 8d9378a867 [bug-63404] add description to assemble target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858773 13f79535-47bb-0310-9956-ffa450edef68
2019-05-06 10:12:40 +00:00
Andreas Beeker 6b69baf2e1 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858628 13f79535-47bb-0310-9956-ffa450edef68
2019-05-05 01:05:58 +00:00
Andreas Beeker ea0e01acc1 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858625 13f79535-47bb-0310-9956-ffa450edef68
2019-05-04 23:01:53 +00:00
PJ Fanning dfbf788201 [bug-62906] ensure table display name is always set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858179 13f79535-47bb-0310-9956-ffa450edef68
2019-04-26 07:48:26 +00:00
Dominik Stadler abc7359c8f Make compilation work in Eclipse 2019.03 again by working around a
limitation of the Eclipse Java Compiler regarding casting/generics

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858117 13f79535-47bb-0310-9956-ffa450edef68
2019-04-25 12:27:04 +00:00
Dominik Stadler bd8fab1196 Close more file-handles in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858024 13f79535-47bb-0310-9956-ffa450edef68
2019-04-23 20:28:21 +00:00
Dominik Stadler 37ec3380ae Bug 63371: addMergedRegion does not update CTMergeCells.getCount
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858022 13f79535-47bb-0310-9956-ffa450edef68
2019-04-23 20:27:53 +00:00
Dominik Stadler cd52566c98 Bug 63073: Adjust returned index of merged regions and verify all calls in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858021 13f79535-47bb-0310-9956-ffa450edef68
2019-04-23 20:27:39 +00:00
Andreas Beeker 103b011b4a #github-143 - MAPIType.isFixedLength: not true in case of length > 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857708 13f79535-47bb-0310-9956-ffa450edef68
2019-04-17 20:18:29 +00:00
Andreas Beeker e2cd384259 #54803 - Error opening XLSX after saving with a Drawing using POI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857663 13f79535-47bb-0310-9956-ffa450edef68
2019-04-16 21:27:30 +00:00
PJ Fanning cf5b72bc00 some more checks for int overflows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857609 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 23:10:04 +00:00
PJ Fanning c56ebe15af use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857596 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 16:02:53 +00:00
PJ Fanning 3c7bb45e54 use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857594 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 15:45:59 +00:00
Dominik Stadler 8823c1a9ab Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857483 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 17:19:05 +00:00
PJ Fanning 924b2c546b [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857462 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:08:55 +00:00
PJ Fanning bdc3b391fd [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857461 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:03:02 +00:00
PJ Fanning fb5d21b1bb adjust formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857452 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 08:08:36 +00:00
Tim Allison cf76af521d Bug 63330 -- use skipfully instead of hoping skip() works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857277 13f79535-47bb-0310-9956-ffa450edef68
2019-04-10 19:11:02 +00:00
Greg Woolsey 362a99a60b Update site source for 4.1.0, prep build for 4.1.1 (via ant task)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857217 13f79535-47bb-0310-9956-ffa450edef68
2019-04-09 15:57:25 +00:00
Andreas Beeker 3a6c933020 Remove invalid import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857141 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 21:09:55 +00:00
Tim Allison a5278ccad9 bug 63327 allow retrieval of wmf data embedded in emf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857136 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:53:21 +00:00
Tim Allison ad11a5d363 Bug 63323 -- improve handling of multibyte characters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857135 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:51:16 +00:00
Dominik Stadler 6119c0ecec Fix a flaky test, it seems if the document is not closed, the automatic
closing of file-handles interferes with subsequent tests, by closing the
document this flakiness seems to be gone.

Flakiness could be reproduced locally by continuously running test with IntelliJ
"run until failure" run-config option and after aprox. 17,000 test-executions!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857068 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:47 +00:00
Dominik Stadler b88c6b12e5 Improve error message slightly and verify error when a File is passed in
as "Object"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857067 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:41 +00:00
Dominik Stadler 9b726e88b7 Close more file-handles in tests and convert some more tests to junit-4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857066 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:34 +00:00
PJ Fanning b523186038 try to fix javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856994 13f79535-47bb-0310-9956-ffa450edef68
2019-04-05 09:18:26 +00:00
Dominik Stadler e6c3dd9350 Fix some IDE warnings and enable commented test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856691 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:52 +00:00
Dominik Stadler 0e69c64a62 Add some more variants of HTML with preceding newline which we see frequently
in the large regression test corpus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856689 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:42 +00:00
Dominik Stadler 097fd7a5e2 Close more file-handles in tests, convert junit3 tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856688 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:34 +00:00
PJ Fanning 9576ab77f9 replace version number 4.0.2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 08:54:44 +00:00
Greg Woolsey 48ac6b4d02 fix a condition not seen until a recent expansion of the stress test. Gracefully ignore missing/invalid external sheet references in one more path (there were several already with comments like "this seems to be what Excel does in this case")
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856655 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 03:49:16 +00:00
Greg Woolsey 389946bb31 fix unit test that I merged wrong.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856653 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 01:12:10 +00:00
Greg Woolsey 6b76706ef7 #61700 getForceFormulaRecalculation() returns wrong value
changed to use the proper OOXML attribute instead of a hack about calculation engine version ID.  Reporter was right, the behavior was wrong in some cases, but it turns out the fix was a bit more.  See issue for details.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856652 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 01:00:05 +00:00
PJ Fanning b9101138bd [bug-61700] getForceFormulaRecalculation() returns wrong value. Fix thanks to Kai G
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856650 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 23:59:19 +00:00
PJ Fanning 5d580f48e6 fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 21:57:50 +00:00
Greg Woolsey 67aad69757 #63292 1904 date windowing flag not used for some format cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 20:13:24 +00:00
Greg Woolsey 0d22749477 #63291 CellFormat global cache isn't thread-safe
move date format synchronization down to where the problem instance is held. 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 19:33:02 +00:00
Greg Woolsey 30851e44a6 #63302 Formula evaluation of names with offset or row function is incorrect
thanks to John Lincoln White for the patch, including new unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 18:14:14 +00:00
PJ Fanning 2a9390d683 [bug-63291] support concurrent date formatting with same DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 23:04:40 +00:00
PJ Fanning 80dc4b34c9 add test for concurrent use of DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856439 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 21:24:25 +00:00
PJ Fanning 905c53794c [github-142] issue in ExcelComparator example. Thanks to chirkovmail. This close #142
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856053 13f79535-47bb-0310-9956-ffa450edef68
2019-03-22 13:38:05 +00:00
PJ Fanning 259d5a234f upgrade xmlsec, slf4j, batik
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855990 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 13:43:19 +00:00
PJ Fanning d66873a765 upgrade bouncycastle and curvesapi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855978 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 10:23:05 +00:00
PJ Fanning c18b7245e9 possible npe in test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855969 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:20:00 +00:00
PJ Fanning 92232b921a remove unncessary synchronization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855956 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:41:29 +00:00
PJ Fanning 895b251367 some javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
PJ Fanning cb9d33d53d use xmlbeans-3.0.3 rc version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855952 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:16:13 +00:00
Dominik Stadler bb73949f7b Switch to parameterized test and add some more information to try to find
out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:33 +00:00
Dominik Stadler 40f8d119c7 Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning f2d9c1a927 [bug-63268] fix issue where CellUtil.setFont is adding unnecessary styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 05:59:00 +00:00
Greg Woolsey edd1f4c75e pre-release maintenance:
* add my key to the KEYS file
* update year in NOTICE (first release of 2019)
* remove svn:executable flag from random test data files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855799 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 00:35:09 +00:00
Greg Woolsey 1dbcef88f9 Fix a unit test that changed with the implementation of another function.
Didn't fail for me because I hadn't noticed the Eclipse classpath was out of date wrt some dependency versions, and therefore my local code was not compiling properly, meaning my test run ran old code and passed this one when it should have failed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855792 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 22:05:34 +00:00
Greg Woolsey 82f9c29258 #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker 19005a4e63 Fix forbidden apis error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Andreas Beeker aa438b6f2d Use JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:13:55 +00:00
Yegor Kozlov 6ef332b48e Bug 61472: Convert date/time strings to numbers when evaluating formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey ee83ce5fcd Handle possible invalid date value (#61652)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey 8225326b56 #63264 Conditional Format rule evaluation calculates relative references incorrectly
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning 126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler 7f12edf416 Fix URL for test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:13:02 +00:00
Dominik Stadler ef369931e2 Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:12:57 +00:00
Dominik Stadler 5329f25b0a Adjust test to not fail with Xerces XML Parser, fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 08:18:54 +00:00
PJ Fanning d6b5e936e9 [bug-63240] make SAXHelper.newXMLReader non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 19:17:22 +00:00
PJ Fanning 0786ae5b57 [bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 18:36:12 +00:00
Dominik Stadler 302228dc24 Close more file-handles in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854718 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:50 +00:00
Dominik Stadler 4c017a0e27 Fix a regression test failure, toString() should never return null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:40 +00:00
Dominik Stadler a9b2a8b2bd Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 12:28:19 +00:00
Dominik Stadler 53a30d796e Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:19:45 +00:00
Dominik Stadler 6a93b3a9ed Close file-handles for slideshows also when construction fails or when dual-storage is used
Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:24 +00:00
Dominik Stadler 98b620889b Remove some remnants of NFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:06 +00:00
Dominik Stadler 8c6e95f597 Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:57 +00:00
Dominik Stadler 34d6410bc1 Adjust BaseIntegrationTest some more to better handle invalid file extensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854189 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:48 +00:00
Yegor Kozlov cafa57cbdd Bug 60980: Fix parsing formulas with intersections in functions args
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68
2019-02-21 11:00:40 +00:00
PJ Fanning bf4396b375 [bug-63151] handle NPE in UnicodeString
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853859 13f79535-47bb-0310-9956-ffa450edef68
2019-02-19 06:27:04 +00:00
PJ Fanning 37ff2b7fb2 [bug-63187] fix typos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853787 13f79535-47bb-0310-9956-ffa450edef68
2019-02-18 09:56:11 +00:00
Yegor Kozlov 8350124e9b Bug 63029: revert handling NotOfficeXmlFileException in ZipPackage as this change broke the build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853474 13f79535-47bb-0310-9956-ffa450edef68
2019-02-13 06:45:14 +00:00
Yegor Kozlov caef630c70 Bug 63029: OPCPackage Potentially clobbers files on close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853454 13f79535-47bb-0310-9956-ffa450edef68
2019-02-12 16:55:13 +00:00
Yegor Kozlov c438465b08 Bug 62980: Make D* functions ignore case in headings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853268 13f79535-47bb-0310-9956-ffa450edef68
2019-02-09 13:00:09 +00:00
Vladislav Galas 0a299339f7 removed accidentally added release-notes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852283 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 10:18:26 +00:00
Dominik Stadler b7862cfe45 Add reproducing test-case for a bug we found newly introduced in JDK 12-ea+28
and fixed again in JDK 12-ea+29

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852281 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:58:08 +00:00
Dominik Stadler 60a98da8e8 Fix some IDE warnings and better output in unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852280 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:58:02 +00:00
Dominik Stadler e8ed5e3a8c Adjust handling of some exceptions in regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852278 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:49 +00:00
Dominik Stadler c376d662f9 Bug 60405: Add initial support for cetab functions so some macros can be
parsed
Add some function-definitions for Excel 4 Macros and missing functions
found in regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852277 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:39 +00:00
Vladislav Galas a08b69df80 pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:20:07 +00:00
Vladislav Galas 53eee01b5d pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:59 +00:00
Vladislav Galas 5da229797f pulled *Cell.setCellValue(double) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:53 +00:00
Vladislav Galas 70b4b88a3a pulled *Cell.getCellTypeEnum() to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:47 +00:00
Vladislav Galas bc30eceb02 pulled *Cell.getAddress to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:41 +00:00
Vladislav Galas a8a0cb56f7 purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:36 +00:00
Vladislav Galas 39d963aa33 made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:25 +00:00
Vladislav Galas 19bf8b23d5 purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:10 +00:00
Vladislav Galas d60cb3a18c added Cell.setBlank() - as an alias, for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:40:56 +00:00
Vladislav Galas 1253a29571 setCellFormula: blank cell gets value 0, non-blank value is preserved
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 10:09:13 +00:00
Dominik Stadler b5fe208770 Fix some IDE warnings and JVM deprecations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:00:01 +00:00
Yegor Kozlov 698d8eb006 follow-up to Bug 62904. More tests and improved evaluation of IF in array mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68
2019-01-14 14:48:21 +00:00
Dominik Stadler 8c18d93a66 Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:31 +00:00
Dominik Stadler db14c353fc Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Dominik Stadler 068c820ef4 Bug 62810: AreaReference ctor looses sheet name if rows or columns swapped
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:05 +00:00
Dominik Stadler 88b9e48287 Add reproducer for bug 60355
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:13:57 +00:00
Dominik Stadler 32c43c068c IDE and JavaDoc fixes, move/remove some unfixed tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:05 +00:00
Dominik Stadler a1a1797299 Add one more test for bug 62828 and fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:30:44 +00:00
Greg Woolsey 8b69fcc642 Bug #60977 writing XSSF with custom properties twice corrupts output
turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 18:20:03 +00:00
Yegor Kozlov b85437ee88 Bug 63054: improved evaluation of array formulas with error in arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 12:54:39 +00:00
Vladislav Galas f64aef7417 unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 19:10:19 +00:00
Yegor Kozlov 81033fbad0 Bug 62904: Support array arguments in IF and logical IS*** functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 14:34:19 +00:00
PJ Fanning 0849bbc614 throw IllegalArgumnetException if null directory specified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 16:07:53 +00:00
Vladislav Galas 6d87e36227 Fixed build (explicitly specified charset for new String(byte[]))
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 14:25:11 +00:00
Vladislav Galas 1f9b858ae5 Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 10:10:30 +00:00
Vladislav Galas 8600f64890 Improved test coverage for *Cell classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 09:17:48 +00:00
Vladislav Galas 3b8055baa0 Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-03 00:08:52 +00:00
Vladislav Galas e501d4015d Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 22:08:38 +00:00
Vladislav Galas 3aec436a34 Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 20:45:52 +00:00
Dominik Stadler 59a7919af6 Add missing revert() in OPCPackage to close Zip-streams always
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:58 +00:00
Dominik Stadler fa24471916 Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:51 +00:00
PJ Fanning bfecad39e5 fix since annotation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 14:27:32 +00:00
Andreas Beeker d71a65c388 #63047 - Make POILogger subclassable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 12:07:37 +00:00
Dominik Stadler dfb613a059 Adjust test for bug 60460 to also run fine on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 09:05:05 +00:00
Dominik Stadler 85d6f81076 Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:40 +00:00
Dominik Stadler faf53dcdb4 IDE and JavaDoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:29 +00:00
Dominik Stadler b416d97de5 Bug 60845: Apply patch and adjust tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 10:07:52 +00:00
Dominik Stadler d942e2042d IDE and JavaDoc fixes, make base test classes abstract
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 10:07:42 +00:00
Andreas Beeker c039da1b94 #63028 - Provide font embedding for slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:43:31 +00:00
Andreas Beeker a78bd71fc1 Add Enum method to help identifying unknown records with POI-Visualizer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:57 +00:00
Andreas Beeker 83d4d4169f Fix Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849896 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:44 +00:00
Andreas Beeker ab3f2a0e50 Zero out garbage bytes in FontEntityAtom
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849895 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:31 +00:00
Dominik Stadler 22bdfcf399 Run Cell-tests on HSSF as well and make handling of null-values consistent across implementations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849881 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:53:13 +00:00
Dominik Stadler 2b8200f7d7 Bug 61532: Fix setting values/types during formula evaluation for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:53:03 +00:00
Dominik Stadler 3c99c70acf Add test which verifies that bug 61605 is already fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849878 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:52:46 +00:00
Dominik Stadler 825418d520 Adjust test to not require src/documentation to be available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849837 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 11:17:52 +00:00
Dominik Stadler a6e9421d18 Adjust/enhance tests for bug 62275 some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849836 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 11:17:46 +00:00
Dominik Stadler d3dc9b0338 Bug 62629: Allow to handle files with invalid content types for pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:48 +00:00
Dominik Stadler 7de8c2eaec Re-instate two dev-tools that we lost in some refactoring,
at least OOXMLPrettyPrint is still very useful for comparing ooxml-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:38 +00:00
Dominik Stadler ae3d6944db IDE and JavaDoc fixes, close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:31 +00:00
Dominik Stadler c218c3cbc4 Add some simple coverage of HSLF-Dev-Tools
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:32 +00:00
Dominik Stadler 5b62dcd379 Bug 62839: Adjust MathX.floor() to handle negative values the same
way as Excel/LibreOffice

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849764 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:17 +00:00
Dominik Stadler 6f2f283db8 Fix various IDE warnings and some JavaDoc adjustments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:10 +00:00
Dominik Stadler d40eb6f37f Fix incorrect constant for pict-files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:56 +00:00
Dominik Stadler 235f3e059c Remove unnecesssary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:50 +00:00
Dominik Stadler f6eab84243 Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:35 +00:00
Dominik Stadler accfb5a678 JavaDoc fixes/additions and some IDE warnings removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849718 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 10:00:21 +00:00
Dominik Stadler 49f4ad6aba Bug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849717 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 10:00:07 +00:00
Dominik Stadler 19884d0ca3 Code-style: Unify how arrays are specified from C-style to normal Java-style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 09:59:58 +00:00
Andreas Beeker 6486fb7c2d fix old xerces errors because of not available disallow-doctype parser feature
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849336 13f79535-47bb-0310-9956-ffa450edef68
2018-12-19 19:14:55 +00:00
Dominik Stadler 4199a2f0a3 Rework test somewhat and enable logger to better indicate if the test is
failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68
2018-12-19 10:22:01 +00:00
Andreas Beeker 6c5a2de640 #62886 - Regression extracting text from corrupted docx files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849252 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:55:58 +00:00
PJ Fanning 5344049a98 fix index check in HemfDraw
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:26:49 +00:00
Andreas Beeker 422d3a75f9 #63017 - Remove rows from a XSLFTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849248 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:13:59 +00:00
Andreas Beeker 9eea29da5b #63017 - Remove rows from a XSLFTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849244 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 22:52:36 +00:00
PJ Fanning 2dea9797ce [github-137] solves/unifies blank/missing value colection for PRODUCT/MDETERM/GEOMEAN. Thanks to gallonfizik. This closes #137
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849237 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 21:16:25 +00:00
PJ Fanning 1a25ff4dce [bug-63013] add XWPFRun setLang method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849152 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 08:12:42 +00:00
Andreas Beeker 9f3c99c25c only refactorings to break up the long method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849130 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 22:29:03 +00:00
PJ Fanning 17a7cb609b [bug-63005] ignore openxml4j/ContentTypeHasEntities.ooxml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849128 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 20:57:52 +00:00
PJ Fanning 1aeadee8c4 lgtm issues: potential index out of bounds exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849127 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 20:41:38 +00:00
PJ Fanning d1400559f8 [bug-63005] disable the reading of DTDs altogether
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849123 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 19:06:31 +00:00
Andreas Beeker 3452ea963d changed to bouncer pattern - to match also the rest of the code
see https://softwareengineering.stackexchange.com/questions/18454/should-i-return-from-a-function-early-or-use-an-if-statement

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849074 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 10:36:22 +00:00
PJ Fanning bb7ffebe0f add null check in XLSFPictureShape
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849069 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 09:17:29 +00:00
PJ Fanning 9f7520e86f use spaces for indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849067 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 09:11:06 +00:00
Andreas Beeker 458b9e3aed fix junit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849047 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 21:25:57 +00:00
Andreas Beeker 150a00654e #62365 - SVG image support in XSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849046 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 21:02:01 +00:00
PJ Fanning 8e37e00054 fix findbugs issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849044 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 20:07:23 +00:00
PJ Fanning 35dad08568 add missing license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849043 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 19:50:59 +00:00
PJ Fanning e399507710 Implemented GEOMEAN function. Thanks to gallonfizik. This closes #136
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849042 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 18:51:09 +00:00
Andreas Beeker 8d51a39edd fix constructor after its delegated now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849041 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 18:40:47 +00:00
Andreas Beeker e896d921a4 #60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849040 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 18:17:21 +00:00
Andreas Beeker abe662db86 merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1849036 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 16:51:08 +00:00
Andreas Beeker d45ec541cd #62365 - SVG image support in XSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849030 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 14:55:23 +00:00
Andreas Beeker 2a84c1fa16 ignore keystore files on integration test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848975 13f79535-47bb-0310-9956-ffa450edef68
2018-12-15 01:24:27 +00:00
Andreas Beeker 17ce79b69c #63011 - Multiple digital signature in excel file broke first signature
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848974 13f79535-47bb-0310-9956-ffa450edef68
2018-12-15 00:51:10 +00:00
Andreas Beeker fce876b4ef merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1848906 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 00:44:40 +00:00
Andreas Beeker 71027990ca #62999 - IBM JDK JIT causes AIOOBE in TexturePaintContext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848601 13f79535-47bb-0310-9956-ffa450edef68
2018-12-10 16:18:49 +00:00
PJ Fanning cce4189e59 [bug-62996]try suggested test change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848591 13f79535-47bb-0310-9956-ffa450edef68
2018-12-10 15:45:47 +00:00
Andreas Beeker 28085415f5 #62994 - IBM JCE workarounds
add policy restriction exemption

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848539 13f79535-47bb-0310-9956-ffa450edef68
2018-12-09 22:33:30 +00:00
Andreas Beeker 397e568656 #62994 - IBM JCE workarounds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848538 13f79535-47bb-0310-9956-ffa450edef68
2018-12-09 21:45:47 +00:00
Andreas Beeker fba0181413 #62966 - init presetShapeDefinitions.xml fail under IBM jdk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848494 13f79535-47bb-0310-9956-ffa450edef68
2018-12-09 02:08:50 +00:00
Andreas Beeker dc3c437d14 #62953 - Rendering of FreeformShapes with formula fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848492 13f79535-47bb-0310-9956-ffa450edef68
2018-12-09 01:06:15 +00:00
PJ Fanning 740a756a3f lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848438 13f79535-47bb-0310-9956-ffa450edef68
2018-12-08 08:13:36 +00:00
Alain Béarez ef75a6d2d2 create chart from scratch by sandeeptiwari32
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848432 13f79535-47bb-0310-9956-ffa450edef68
2018-12-08 02:44:22 +00:00
PJ Fanning 3c313a7f66 [bug-57342] add SXSSFWorkbook setZip64Mode method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1848179 13f79535-47bb-0310-9956-ffa450edef68
2018-12-04 21:51:56 +00:00
Dominik Stadler 2f6911a8ae Fix TestFileMagic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847454 13f79535-47bb-0310-9956-ffa450edef68
2018-11-26 06:28:17 +00:00
Andreas Beeker aad955d3bf Fix exception for old powerpoint documents without the usual stream name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847442 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 23:01:54 +00:00
Andreas Beeker e96aae8be4 #60713 - (S)XSSFWorkbook/POIXMLDocument.write(OutputStream) closes the OutputStream
regression

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847438 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 22:05:02 +00:00
Dominik Stadler d28720afd0 Add test for FileMagic
JavaDoc warning fixes
Remove some IDE warnings
Reformat code of sample application

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847437 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 21:56:43 +00:00
Andreas Beeker 283ebe0e08 #62951 - FileMagic not correctly identified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847429 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 20:50:13 +00:00
Andreas Beeker d2cf03d353 #62949 - SlideShow rendering - keyframe fractions must be increasing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847428 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 19:25:35 +00:00
PJ Fanning 30dd835629 fixed escaping of sheet names. Thanks to gallonfizik. This closes #134
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847418 13f79535-47bb-0310-9956-ffa450edef68
2018-11-25 16:13:17 +00:00
Tim Allison 8e427c1806 bug 60316 -- skip the glossary document, not the template document.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847263 13f79535-47bb-0310-9956-ffa450edef68
2018-11-23 13:32:22 +00:00
Andreas Beeker 11cbe34ee5 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1847209 13f79535-47bb-0310-9956-ffa450edef68
2018-11-23 02:08:28 +00:00
PJ Fanning 34ef20ac82 add missing classes to poi-ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847083 13f79535-47bb-0310-9956-ffa450edef68
2018-11-21 09:10:19 +00:00
Andreas Beeker 30d4934edc merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1847069 13f79535-47bb-0310-9956-ffa450edef68
2018-11-20 22:24:26 +00:00
PJ Fanning c199dfc3b6 tidy up code formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847012 13f79535-47bb-0310-9956-ffa450edef68
2018-11-20 14:31:49 +00:00
PJ Fanning 96308eb512 [bug-62929] add null check for blip fill. Thanks to Mate Borcsok
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1847004 13f79535-47bb-0310-9956-ffa450edef68
2018-11-20 14:15:14 +00:00
Andreas Beeker fa5e01e391 Remove commented out System.out calls / Move DummyGraphics2d to testcase area, as it's not used by production code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846946 13f79535-47bb-0310-9956-ffa450edef68
2018-11-19 20:48:10 +00:00