Commit Graph

10917 Commits

Author SHA1 Message Date
Marius Volkhart 12857e68ac Add documentation for HWPF FileInformationBlock DggInfo methods
This documentation comes from [MS-DOC] - v20191119.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886998 13f79535-47bb-0310-9956-ffa450edef68
2021-02-28 15:08:39 +00:00
Marius Volkhart cfee75c9b6 Revert "Replace magic constant with reference" changes
Reverts r1886986, r1886987 and r1886988. Incorrect conversion between int and shorts led to incorrect logic.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886989 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 19:08:49 +00:00
Marius Volkhart 66e08f08d3 Replace magic constant use of Escher Blip End type ID with reference
Instead of referring to the magic constant 0xF117, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886988 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 18:33:56 +00:00
Marius Volkhart b9bbac0005 Replace magic constant use of Escher Blip Start type ID with reference
Instead of referring to the magic constant 0xF018, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886987 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 18:26:36 +00:00
Marius Volkhart d543e89185 Replace magic constant use of EscherBSERecord type ID with reference
Instead of referring to the magic constant 0xF007, reference the value in the EscherRecordTypes enum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886986 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 18:22:33 +00:00
PJ Fanning 16561e85c7 add missing license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886965 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 01:29:21 +00:00
Marius Volkhart 50757bca8e Fix bug with record indexes for HSSF Workbooks
We have encountered workbooks that do not have a TabIdRecord (see 55982.xls). However, the WorkbookRecordList#updateRecordPos() method would still increment the position of the TabIdRecord for such workbooks. Changing the default position of the record from 0 to -1 indicates that the record position has now been set.

This bug was discovered while adding support for editing pictures in HSSF documents.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886963 13f79535-47bb-0310-9956-ffa450edef68
2021-02-27 00:43:56 +00:00
Marius Volkhart 451684aa91 Enable running more integration tests from Gradle.
This is particularly relevant for developers who import the Gradle project into their IDE and run tests using the Gradle test runner. Those developers were previously unable to debug integration tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886962 13f79535-47bb-0310-9956-ffa450edef68
2021-02-26 22:14:17 +00:00
Marius Volkhart 0fbf8f2e58 Remove the integrationTest task from the Gradle integrationtest project
This task adds no additional configuration over the regular test task.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886961 13f79535-47bb-0310-9956-ffa450edef68
2021-02-26 22:07:14 +00:00
Marius Volkhart a49347e8d0 Remove the test exclusion for RecordStresser and RecordsStresser from Gradle integration tests
These classes don't exist.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886960 13f79535-47bb-0310-9956-ffa450edef68
2021-02-26 22:05:16 +00:00
Marius Volkhart 6fe733c92a Enable parallel tests from Gradle
Parallel tests are already enabled from Ant. This does the same for Gradle users.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886959 13f79535-47bb-0310-9956-ffa450edef68
2021-02-26 21:15:12 +00:00
PJ Fanning 7a10b863f6 xmlsec version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886893 13f79535-47bb-0310-9956-ffa450edef68
2021-02-24 21:42:01 +00:00
PJ Fanning bba9aa2b66 missing ooxml-schemas-lite classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886892 13f79535-47bb-0310-9956-ffa450edef68
2021-02-24 21:26:33 +00:00
Andreas Beeker 72ad5857f4 include batik in poi-bin artifact
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886863 13f79535-47bb-0310-9956-ffa450edef68
2021-02-23 22:29:51 +00:00
Andreas Beeker 6470765bbe add batik to forbidden-apis-check classpath
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886862 13f79535-47bb-0310-9956-ffa450edef68
2021-02-23 21:59:56 +00:00
Marius Volkhart 3c9f29a8c2 [bug-63046] Fix Java 16 build
org.apache.santuario:xmlsec:2.2.0 has a dependency on SLF4J. We use this in SignatureInfo.java.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886811 13f79535-47bb-0310-9956-ffa450edef68
2021-02-22 18:27:14 +00:00
Andreas Beeker eb30f2e1c8 Use upcoming XmlBeans 5.0.0 (working version 4.0.1)
Make batik optional as it doesn't work on the module-path
Use sub-components of batik as batik-all references them all again resulting in duplicated entries (maven poms haven't been migrated yet ...)
Remove SLF4j dependency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886777 13f79535-47bb-0310-9956-ffa450edef68
2021-02-22 00:18:37 +00:00
Marius Volkhart 259c9967ef [bug-63046] Use Log4j 2 for logging
This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today.

Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project.

Closes #224

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886770 13f79535-47bb-0310-9956-ffa450edef68
2021-02-21 20:57:25 +00:00
Andreas Beeker 6d10f26718 Use UTF-8 when writing SVG files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886768 13f79535-47bb-0310-9956-ffa450edef68
2021-02-21 18:52:23 +00:00
PJ Fanning 62bfbd3c90 try re-eanbling xml entity config
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886766 13f79535-47bb-0310-9956-ffa450edef68
2021-02-21 18:31:49 +00:00
Dominik Stadler 297c16f1f0 FinanceLib: Simplify code and add a few more tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886658 13f79535-47bb-0310-9956-ffa450edef68
2021-02-18 10:00:13 +00:00
Alain Béarez b20ca985b8 Manipulate individual data point properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886642 13f79535-47bb-0310-9956-ffa450edef68
2021-02-17 22:05:18 +00:00
Marius Volkhart 36277f9e54 Code cleanup AbstractEscherHolderRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886623 13f79535-47bb-0310-9956-ffa450edef68
2021-02-17 15:41:22 +00:00
Marius Volkhart 26f3db7e14 Documentation for some EscherRecordTypes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886620 13f79535-47bb-0310-9956-ffa450edef68
2021-02-17 15:10:17 +00:00
Marius Volkhart 5d9dcdf3df Add documentation for DrawingGroupRecord
Documentation adapted from [MS-XLS].pdf v20190618.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886619 13f79535-47bb-0310-9956-ffa450edef68
2021-02-17 14:48:30 +00:00
Alain Béarez bcf413f68a [bug-63902] reference cloned sheet in cloned chart data series
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886605 13f79535-47bb-0310-9956-ffa450edef68
2021-02-16 23:39:19 +00:00
PJ Fanning 0df893124a allow subclassing of code to gen comments table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886547 13f79535-47bb-0310-9956-ffa450edef68
2021-02-15 21:48:26 +00:00
PJ Fanning 0ce6ceb3ea add method to test for strict ooxml format
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886545 13f79535-47bb-0310-9956-ffa450edef68
2021-02-15 21:05:57 +00:00
Dominik Stadler 37d2d474dc Do not fail test which compares two documents if the timestamp in the ZIP header field is different
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886532 13f79535-47bb-0310-9956-ffa450edef68
2021-02-15 15:23:49 +00:00
Dominik Stadler 7a8f21b989 Do not require NullPointerException to have a null-message on JDK < 16
It seems depending on the exact JDK some Exceptions have failure messages populated

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886527 13f79535-47bb-0310-9956-ffa450edef68
2021-02-15 13:17:18 +00:00
PJ Fanning 92134f34b1 add test for reading core properties from ooxml strict file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886514 13f79535-47bb-0310-9956-ffa450edef68
2021-02-15 00:34:12 +00:00
PJ Fanning 1f50c10ab0 add missing CTPhoneticRun
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886511 13f79535-47bb-0310-9956-ffa450edef68
2021-02-14 20:25:59 +00:00
PJ Fanning c23381076e fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886497 13f79535-47bb-0310-9956-ffa450edef68
2021-02-14 00:05:02 +00:00
PJ Fanning e47a48283b small refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886495 13f79535-47bb-0310-9956-ffa450edef68
2021-02-13 23:33:24 +00:00
PJ Fanning 49fe3ba330 allo XSSFReader to be sublclassed with implementation that allows OOXMl Strict files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886493 13f79535-47bb-0310-9956-ffa450edef68
2021-02-13 19:43:07 +00:00
PJ Fanning 79a9cf3692 batik 1.14
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886491 13f79535-47bb-0310-9956-ffa450edef68
2021-02-13 14:49:40 +00:00
Marius Volkhart 25dc09b041 Fix GitHub Action yaml for Gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886449 13f79535-47bb-0310-9956-ffa450edef68
2021-02-11 22:27:46 +00:00
Alain Béarez 4cf6b5b071 Import slide notes when importing slide content
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886338 13f79535-47bb-0310-9956-ffa450edef68
2021-02-08 20:34:14 +00:00
Marius Volkhart db962309b9 [github-219] Add GitHub Action to verify Gradle wrapper
Thanks to Valery Yatsynovich. This closes #219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886276 13f79535-47bb-0310-9956-ffa450edef68
2021-02-07 11:03:01 +00:00
Marius Volkhart 7e32be6895 Cache Gradle wrapper & caches during GitHub Actions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886266 13f79535-47bb-0310-9956-ffa450edef68
2021-02-07 00:30:41 +00:00
Marius Volkhart 0e6f8573f3 Cache Maven repo during GitHub Actions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886257 13f79535-47bb-0310-9956-ffa450edef68
2021-02-06 15:23:11 +00:00
PJ Fanning 4fcd98573f remove accidental commit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886144 13f79535-47bb-0310-9956-ffa450edef68
2021-02-02 21:14:16 +00:00
PJ Fanning d7eb8e949a [bug-65120] PartAlreadyExistsException when creating cell comments (after some comments removed). Thanks to Raúl Wegmann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886143 13f79535-47bb-0310-9956-ffa450edef68
2021-02-02 21:13:32 +00:00
Marius Volkhart 7a0cc6e7e5 Fix inconsistent logging statement
The conditions check for max, but the logging was copy/pasted and still uses the minimum.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886089 13f79535-47bb-0310-9956-ffa450edef68
2021-02-01 01:02:26 +00:00
Alain Béarez e367148e09 Clone only content of imported chart
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886087 13f79535-47bb-0310-9956-ffa450edef68
2021-02-01 00:46:25 +00:00
Andreas Beeker aa9ec651ea Sonar fixes
add asserts to tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886070 13f79535-47bb-0310-9956-ffa450edef68
2021-01-30 22:58:14 +00:00
Dominik Stadler caf2d32393 Bug 65099: Fix incorrect handling of styles in XWPFStyle.getUsedStyleList
Closes github #216

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886063 13f79535-47bb-0310-9956-ffa450edef68
2021-01-30 18:42:14 +00:00
Dominik Stadler 6449c03a53 Adjust integration-test slightly for running mass-regression-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886062 13f79535-47bb-0310-9956-ffa450edef68
2021-01-30 18:42:08 +00:00
Dominik Stadler a10ca15627 Apply IDE suggestions, add toString(), adjust JavaDoc and simplify code slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886061 13f79535-47bb-0310-9956-ffa450edef68
2021-01-30 18:42:05 +00:00
Dominik Stadler 615de587f7 Enable storing an SXSSF workbook twice
Verify this via a unit-test for all types of workbooks
Add a test to verify the contents is byte-for-byte equal
Also remove an overwritten test which works the same now for all three workbook-types

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886060 13f79535-47bb-0310-9956-ffa450edef68
2021-01-30 18:41:57 +00:00