Commit Graph

10154 Commits

Author SHA1 Message Date
Alain Béarez fbf12935d3 Fix JavaDoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872361 13f79535-47bb-0310-9956-ffa450edef68
2020-01-05 23:54:06 +00:00
Andreas Beeker d66af200eb Sonar fixes - Tests should include assertions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872302 13f79535-47bb-0310-9956-ffa450edef68
2020-01-03 23:30:36 +00:00
Dominik Stadler 4aa8334e3b Fix some additional file-handle-leaks reported by unit-tests via an enhanced version of the file-leak-detector
Also add a test for Bug 64045

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872287 13f79535-47bb-0310-9956-ffa450edef68
2020-01-03 13:11:41 +00:00
PJ Fanning 578d78da37 [bug-64045] close resources if we throw exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872284 13f79535-47bb-0310-9956-ffa450edef68
2020-01-03 11:27:01 +00:00
PJ Fanning 4a7aee8b1f remove unnecessary close
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872283 13f79535-47bb-0310-9956-ffa450edef68
2020-01-03 11:24:12 +00:00
PJ Fanning 8b389fdd4b [bug-64045] close resources if we throw exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872270 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 21:10:54 +00:00
PJ Fanning 7510f408dc [bug-64045] close resources if we throw exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872265 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 20:53:42 +00:00
PJ Fanning 22266e209a [bug-64045] close resources if we throw exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872264 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 20:45:31 +00:00
PJ Fanning 781ef0c754 [bug-64044] setCellValue(LocalDate) does not support nulls properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872247 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 15:20:04 +00:00
PJ Fanning 5ec079072a [bug-64044] setCellValue(LocalDate) does not support nulls properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872246 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 14:58:30 +00:00
Andreas Beeker adb8424bc1 Fix Visio compression
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872223 13f79535-47bb-0310-9956-ffa450edef68
2020-01-01 22:44:42 +00:00
Dominik Stadler 07b5bc667c Bug 63788: Remove AbstractNum by abstractNumId, not list index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872187 13f79535-47bb-0310-9956-ffa450edef68
2020-01-01 19:22:30 +00:00
Dominik Stadler 9f35db4f51 Bug 63940: Avoid endless loop/out of memory on string-replace with empty search string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872145 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 16:52:55 +00:00
Dominik Stadler 821e164041 Bug 63700: Make D* functions work with numeric result column
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872136 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 10:41:43 +00:00
Dominik Stadler 3cc54a8dff Bug 63960: Write pre-evaluated string-values in formula cells with the correct type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872130 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 06:34:51 +00:00
Dominik Stadler bc0dcdf369 Fix bug 63984: AND / OR should treat missing parameters as FALSE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872125 13f79535-47bb-0310-9956-ffa450edef68
2019-12-30 19:57:11 +00:00
Andreas Beeker 71338b958c Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872092 13f79535-47bb-0310-9956-ffa450edef68
2019-12-30 00:08:24 +00:00
Andreas Beeker a0770034fc #64036 - remove reflective calls in Workbook- and SlideShowFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872066 13f79535-47bb-0310-9956-ffa450edef68
2019-12-28 22:39:26 +00:00
Andreas Beeker c66575c1e7 Migrate all junit tests to Junit 4
get rid of references to junit.framework
don't throw AssertionFailedErrors, but use Assert.fail instead
add try-with-resources where it was missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872041 13f79535-47bb-0310-9956-ffa450edef68
2019-12-27 23:00:13 +00:00
PJ Fanning 37282aae8f try to find issue in test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872001 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 12:55:49 +00:00
PJ Fanning d240fb1378 [github-163] Add set level numbering on XWPFParagraph. Thanks to Mi Guoliang. This closes #163
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871999 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 11:55:41 +00:00
PJ Fanning 40da053a4a fix spelling of OutlookTextExtractor class name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871995 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 09:28:06 +00:00
PJ Fanning 91017547ae fix spelling of OutlookTextExtractor class name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871994 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 09:27:51 +00:00
PJ Fanning ceef7e2611 fix spelling of Usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871987 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 06:16:21 +00:00
PJ Fanning 25a82d8c55 fix spelling of OutlookTextExtractor class name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871986 13f79535-47bb-0310-9956-ffa450edef68
2019-12-26 06:12:56 +00:00
Andreas Beeker 7493473a8e Replace internal GUID class with ClassID
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871944 13f79535-47bb-0310-9956-ffa450edef68
2019-12-24 19:48:22 +00:00
Andreas Beeker 03fe2ded64 #64004 - Replace clone() with copy constructor - mainly HWPF classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871938 13f79535-47bb-0310-9956-ffa450edef68
2019-12-24 11:56:42 +00:00
PJ Fanning 93a7b81ed9 convert some tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871921 13f79535-47bb-0310-9956-ffa450edef68
2019-12-23 09:18:38 +00:00
Andreas Beeker 66471836f5 Replace custom hashCode code with Objects.hash() / Arrays.deepHashCode()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871913 13f79535-47bb-0310-9956-ffa450edef68
2019-12-23 00:15:55 +00:00
Andreas Beeker ba6152503e #64004 - Replace clone() with copy constructor - mainly HSSF classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871911 13f79535-47bb-0310-9956-ffa450edef68
2019-12-22 21:44:45 +00:00
Dominik Stadler ecb42bd78d Remove exception-handling code in ZipPackage that was never reached
Here e.getMessage() and e.toString() were compared, which never match

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871594 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:54:03 +00:00
Dominik Stadler 921259fd36 Add more information to assertion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871593 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:59 +00:00
Dominik Stadler 030eb8203f Add some more tests for IOUtils
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871592 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:55 +00:00
Dominik Stadler 5e394a5e10 Let IntelliJ simplify some assertions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871591 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:46 +00:00
Dominik Stadler 1a5cec89d8 Replace manual close with try-with-resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871590 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:11 +00:00
Dominik Stadler 2748844549 Bug 63749; Make getLastRowNum() and getFirstRow() return -1 instead of 0 on empty Sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871589 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:52:45 +00:00
Dominik Stadler 57e5e87e58 Add MemoryVerifier to enable memory leak checking in unit-tests and add
an initial test which verifies some things for XSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871588 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:52:37 +00:00
Andreas Beeker 3fb5e79490 #64004 - Replace clone() with copy constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871563 13f79535-47bb-0310-9956-ffa450edef68
2019-12-14 23:44:26 +00:00
Dominik Stadler 129b8215ce Ensure that the temporary directory does exist before using it in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871507 13f79535-47bb-0310-9956-ffa450edef68
2019-12-14 13:10:21 +00:00
Dominik Stadler befd31663f Bug 63569: Adjust handling of check for max allocation of byte array
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871506 13f79535-47bb-0310-9956-ffa450edef68
2019-12-14 13:10:17 +00:00
Dominik Stadler 57b0576f63 Adjust some JavaDoc and fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871505 13f79535-47bb-0310-9956-ffa450edef68
2019-12-14 13:10:12 +00:00
PJ Fanning 4c034f0e20 [github-164] Fix Bug in XSSFTable.setCellReferences when table is single cell. Thanks to Travis Russell. This closes #164
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871185 13f79535-47bb-0310-9956-ffa450edef68
2019-12-11 20:07:25 +00:00
PJ Fanning f12a414662 [github-164] Fix Bug in XSSFTable.setCellReferences when table is single cell. Thanks to Travis Russell. This closes #164
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871184 13f79535-47bb-0310-9956-ffa450edef68
2019-12-11 20:07:01 +00:00
Alain Béarez 6602cb2cfb Fix initialization of text body when used in XSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871150 13f79535-47bb-0310-9956-ffa450edef68
2019-12-11 00:10:09 +00:00
Andreas Beeker 37a5888565 fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871121 13f79535-47bb-0310-9956-ffa450edef68
2019-12-10 07:18:21 +00:00
Alain Béarez 091eb161ec Correctly initialize text shapes' first paragraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871112 13f79535-47bb-0310-9956-ffa450edef68
2019-12-10 00:10:52 +00:00
Andreas Beeker cd38079247 Provide XAdES schemas locally, because of connection timeouts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871111 13f79535-47bb-0310-9956-ffa450edef68
2019-12-09 23:56:13 +00:00
Andreas Beeker b5d6afa0a1 Provide XAdES schemas locally, because of connection timeouts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871110 13f79535-47bb-0310-9956-ffa450edef68
2019-12-09 22:53:14 +00:00
Andreas Beeker b0b16846fe Ignore "IIO Can't create cache file" errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871109 13f79535-47bb-0310-9956-ffa450edef68
2019-12-09 22:51:11 +00:00
Andreas Beeker 4c4a33c5de Remove POIBrowser and SViewer and remove references to it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871102 13f79535-47bb-0310-9956-ffa450edef68
2019-12-09 20:56:52 +00:00