Commit Graph

6591 Commits

Author SHA1 Message Date
Javen O'Neal 4405fb4ffe bug 57843: add failing unit test: Word 6.0 (1993) fails with ArrayIndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761873 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 09:24:48 +00:00
Javen O'Neal 3300d54179 bug 59687: correctly delete comments from rows when removing a row and the workbook contains empty rows above the deleted row; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761861 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 07:50:33 +00:00
Javen O'Neal 1d9f92b8dd bug 59687: add failing unit test showing that comments when the row that contains the comment is deleted; patch and file contributed by Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761860 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 07:36:52 +00:00
Javen O'Neal 67e242cb12 check column outline level for bug 55076
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761847 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:37:04 +00:00
Javen O'Neal 7ffff18433 add failing unit test for bug 55076: collapsing column groups only hides the first column
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761846 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:24:22 +00:00
Javen O'Neal c6f365f4e4 fix NPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761844 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:02:56 +00:00
Javen O'Neal 5b6d4546c2 use equalsIgnoreCase for case-insensitive string comparisons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:48:49 +00:00
Javen O'Neal aed1cdcac1 add comment for purpose of test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761842 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:37:09 +00:00
Javen O'Neal 786b7ce4dd bug 45565: add failing unit test for bug 45565
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761841 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:29:00 +00:00
Dominik Stadler e6a2d46800 Compiler/IDE warnings, unnecessary keywords,
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:45:57 +00:00
Javen O'Neal 55897d8815 replace @Ignore with POITestCase.skipTest/testPassesNow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761674 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:32:26 +00:00
Javen O'Neal 244c3a65ed bug 59983: add failing unit test demonstrating formula shifting is apply twice to shared formulas; patch from Luca Martini
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761673 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:20:36 +00:00
Javen O'Neal 4b5f88d791 add fixturing for notifying us when a previously failing unit test passes (better than @Ignore)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761672 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:03:57 +00:00
Javen O'Neal d7a55deec0 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761669 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:57:22 +00:00
Javen O'Neal 50c59c09c9 bug 60153: move flushSheets out to its own method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761668 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:31:15 +00:00
Javen O'Neal 5b9c304148 bug 57200,59788: be more specific why a temporary directory could not be created
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761667 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:19:31 +00:00
Javen O'Neal af39a06544 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761665 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:45:39 +00:00
Javen O'Neal 705938741b javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761664 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:43:55 +00:00
Javen O'Neal c7cf4cbeb0 bug 59933: demote accessibility of NullLogger methods to the same level as POILogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761662 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:12:54 +00:00
Javen O'Neal f7dfffd0c6 make POILogFactory _loggers cache final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761660 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:05:58 +00:00
Javen O'Neal 766fb6b657 bug 59933: override POILogger#log(int, Object...) in NullLogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761657 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:41:54 +00:00
Javen O'Neal c7c7012409 fix copy-paste error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761655 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:15:39 +00:00
Javen O'Neal 8c2df4753f include class of caught exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761654 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:14:26 +00:00
Javen O'Neal 3d953b0065 bug 60158: add failing test cases for AIOOBE on VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761652 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:03:12 +00:00
Dominik Stadler 406bc9c6c1 Adjust handling of ByteBuffer some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 20:24:54 +00:00
Javen O'Neal 8b0f8ab57e bug 59853: exclude BaseTestXSSFPivotTable from ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761545 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 09:59:01 +00:00
Javen O'Neal a287a5a05a bug 59853: support PivotTables with named structured references; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761537 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 07:55:13 +00:00
Javen O'Neal 36d73d88fe bug 59705: consolidate bounds checking of column index into a helper method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 00:32:40 +00:00
Tim Allison 1265c3a9a7 POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68
2016-09-15 00:19:52 +00:00
Javen O'Neal 7cfaa16489 sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760814 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:43:08 +00:00
Javen O'Neal 99e672d078 make sure workbook can be written out and read back for all TestXSSFPivotTable tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760811 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:11:14 +00:00
Javen O'Neal 44eaeb0c4d convert TestXSSFPivotTable to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760806 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:01:11 +00:00
Javen O'Neal c9f8d51f5c declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760798 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:44:06 +00:00
Javen O'Neal 0240538370 declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:32:34 +00:00
Javen O'Neal c3586917af bug 60128: remove forbidden-api Exception.printStackTrace()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760744 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 19:24:49 +00:00
Javen O'Neal d21ca60982 bug 60128: exclude openxml4j/invalid.xlsx from additional integration (stress) tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760743 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 18:41:21 +00:00
Javen O'Neal 54a26fddea bug 60128: add test-data/openxml4j/invalid.xlsx to expected failures for integration test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760735 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:48:00 +00:00
Javen O'Neal a50efd2d51 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760733 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:25:03 +00:00
Javen O'Neal ee27829d79 bug 60128: make code Java 6 compatible. Throwable#addSuppressed not available until Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760732 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:21:31 +00:00
Nick Burch ec55aceeca Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 15:01:57 +00:00
Nick Burch 2f0230acd1 Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 14:59:00 +00:00
Javen O'Neal 1a210230dc make logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760711 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:56:03 +00:00
Javen O'Neal d3fb773843 bug 60128: close opened resources to avoid leaks; add exception as cause where available for more context for raised exceptions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760710 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:55:39 +00:00
Javen O'Neal 475f7ee866 give more helpful exceptions rather than returning null when zip file cannot be opened
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760708 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:28:27 +00:00
Javen O'Neal db1fd20584 bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:57:39 +00:00
Nick Burch 84c8f60992 Unit test for bug #60128, showing that calling close on a broken package cleans up file or stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760693 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:35:34 +00:00
Javen O'Neal de6c83cb47 move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:53:58 +00:00
Javen O'Neal a394090969 move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:33:20 +00:00
Javen O'Neal d5e450f353 bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:42:20 +00:00
Javen O'Neal 5368c7008a bug 59791: add deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:22:38 +00:00