Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
12,965 Commits 24 Branches 101 Tags 246 MiB
Commit Graph

593 Commits

Author SHA1 Message Date
Dominik Stadler 5c2a89412b Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Fixes https://oss-fuzz.com/testcase-detail/4959857092198400

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912157 13f79535-47bb-0310-9956-ffa450edef68
 2023-09-07 08:35:23 +00:00
Dominik Stadler 5d073e3586 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912139 13f79535-47bb-0310-9956-ffa450edef68
 2023-09-06 14:48:58 +00:00
Dominik Stadler 24bf8c33f2 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912138 13f79535-47bb-0310-9956-ffa450edef68
 2023-09-06 14:33:59 +00:00
Dominik Stadler b801711afe Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62059

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912127 13f79535-47bb-0310-9956-ffa450edef68
 2023-09-06 10:38:51 +00:00
Dominik Stadler 4b03c24ec8 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62074

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912125 13f79535-47bb-0310-9956-ffa450edef68
 2023-09-06 09:48:21 +00:00
Dominik Stadler cdb2ba1398 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61441

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911890 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-24 08:48:45 +00:00
Dominik Stadler e4ba9822cc Bug 66425: Avoid a NullPointerException found via oss-fuzz 
ArrayIndexOutOfBoundsException has different message depending on JDK

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911864 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-23 10:00:16 +00:00
Dominik Stadler 0654bf9d87 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61520

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911863 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-23 09:30:00 +00:00
Dominik Stadler fd29772be6 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61578

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911860 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-23 08:26:27 +00:00
Dominik Stadler 9ae14ef6f0 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61400

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911618 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-12 17:37:14 +00:00
Dominik Stadler 733d3d10ea Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61390

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911615 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-12 14:53:58 +00:00
Dominik Stadler f034ca26b9 Bug 66425: Avoid a NullPointerException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61372

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911603 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-11 14:46:04 +00:00
Dominik Stadler 80264d5648 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61330

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911586 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-10 06:14:44 +00:00
Dominik Stadler 107def2e65 Bug 66425: Avoid a StackOverflowException found via oss-fuzz 
We try to avoid causing StackOverflow, but it was possible
to trigger one here with a specially crafted input-file.

This puts a limit on the number of nested children in place
and logs a warning when the Stream is not fully parsed.

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61256

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911577 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-09 16:16:49 +00:00
Dominik Stadler ccec6c4bf8 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61306

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911573 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-09 10:09:16 +00:00
Dominik Stadler b757cf607e Try to adjust for strange null-message for ArrayIndexOutOfBoundsException 
Some CI runs seem to throw the exception with an empty message instead of 
the expected text.

I could not reproduce this consistently and so we only can disable a
check in this case.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911572 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-09 09:53:54 +00:00
Dominik Stadler fdeae16b0c Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61317

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911565 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-09 07:23:04 +00:00
Dominik Stadler 2e8afc0c01 Bug 66425: Avoid a StackOverflowException found via oss-fuzz 
We try to avoid causing StackOverflow, but it was possible
to trigger one here with a specially crafted input-file.

This puts a limit on the number of nested properties in place
and logs a warning when the StyleSheet is not fully parsed.

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61252

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911563 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-09 05:45:21 +00:00
Dominik Stadler e706f37170 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61276

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911536 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-08 08:48:13 +00:00
Dominik Stadler 1b7613329e Bug 66425: Add memory-safeguard in one more place 
We try to generally avoid overly large allocations in places
where arrays are allocated. 

We add one more such check for pictures in HSLF.

We might need to increase the used value of 10MB if users report 
larger files being used frequently. 

Overriding this check via IOUtils is possible.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911525 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 20:35:59 +00:00
Dominik Stadler 163ff25594 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61266

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911523 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 20:01:19 +00:00
Dominik Stadler 8e40aabb18 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61259

Also fix handling of NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911517 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 16:18:46 +00:00
Dominik Stadler 5efa428ca0 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61242

Also enhance output of some test-failures and allow an empty exception message

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911515 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 15:15:38 +00:00
Dominik Stadler 2c5264277a Bug 66425: Avoid an AssertionError found via oss-fuzz 
We try to avoid throwing AssertionError to be triggered by input data, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61251

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911514 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 14:32:11 +00:00
Dominik Stadler f6b1435db1 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61243

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911507 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 12:09:31 +00:00
Dominik Stadler a8b31c37a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
Add exception details and fix expected exceptions to make tests run again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911503 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 11:11:08 +00:00
Dominik Stadler 31fd087a48 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61249

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911501 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-07 09:42:17 +00:00
Dominik Stadler 6f054ddce1 Fix expected exception text and print out which FileHandler failed in integration-tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911495 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-06 17:13:46 +00:00
Dominik Stadler 1e8e95c3a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Also rework test a bit to use try-with-resources and proper formatting

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61221

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911494 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-06 14:57:47 +00:00
Dominik Stadler 57d746827f Bug 66425: Avoid a ClassCastException found via oss-fuzz 
We try to avoid throwing ClassCastException but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61162

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911459 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-05 12:13:13 +00:00
PJ Fanning dd1b0b1128 [bug-66827] add test case (that passes) - so issue is nor reproduced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911399 13f79535-47bb-0310-9956-ffa450edef68
 2023-08-01 20:49:26 +00:00
PJ Fanning 1f446e0aef undo last change due to broken test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911233 13f79535-47bb-0310-9956-ffa450edef68
 2023-07-24 12:00:17 +00:00
PJ Fanning cd2dcd3940 [github-487] Round up seconds in CellElapsedFormatter. Thanks to Anthony Schott. This closes #487 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911228 13f79535-47bb-0310-9956-ffa450edef68
 2023-07-24 10:12:46 +00:00
PJ Fanning fa8650fbe3 [bug-66682] fix xslb reading support for formula cells of boolean type. This closes #485 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910951 13f79535-47bb-0310-9956-ffa450edef68
 2023-07-12 22:26:41 +00:00
PJ Fanning e1bb2a73c8 [bug-66675] fix issue with writing xlsx (core properties being added twice) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910949 13f79535-47bb-0310-9956-ffa450edef68
 2023-07-12 12:25:01 +00:00
PJ Fanning 04442923f3 [bug-62181] try to handle file where shared string loading is happening twice 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910759 13f79535-47bb-0310-9956-ffa450edef68
 2023-07-03 20:54:56 +00:00
PJ Fanning b5153f1395 [bug-66612] get macrosheet xml (test) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1909994 13f79535-47bb-0310-9956-ffa450edef68
 2023-05-22 16:00:10 +00:00
PJ Fanning 02efb8f802 revert: [bug-66503] Add flag for Excel 4 macros in composite documents. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1908462 13f79535-47bb-0310-9956-ffa450edef68
 2023-03-18 00:59:29 +00:00
PJ Fanning c12ed0dd1b [bug-66503] Add flag for Excel 4 macros in composite documents. Thanks to M. P. Halpin 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1908461 13f79535-47bb-0310-9956-ffa450edef68
 2023-03-18 00:30:58 +00:00
Dominik Stadler acdf2ec981 Bug 62272: Include alpha/transparency value when setting a color-value for a font 
Use method with returns 4 bytes to use an ARGB value instead of only RGB

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907105 13f79535-47bb-0310-9956-ffa450edef68
 2023-01-30 12:19:24 +00:00
PJ Fanning 60872927bd [bug-66433] Boolean functions should blank cells. Thanks to Patrick Böker 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906836 13f79535-47bb-0310-9956-ffa450edef68
 2023-01-20 12:03:52 +00:00
PJ Fanning 968dabd462 [bug-65543] HSSF: fix issue with incomplete SSTs. Thanks to Simon Carter. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906434 13f79535-47bb-0310-9956-ffa450edef68
 2023-01-06 23:50:54 +00:00
PJ Fanning 693c59574c [bug-66319] do not create HSSF patriarch to find comments (only use one that pre-exists) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905943 13f79535-47bb-0310-9956-ffa450edef68
 2022-12-12 21:09:09 +00:00
PJ Fanning 5a6df66b07 untidy hack for shared string counts that are higher than Integer.MAX_VALUE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905940 13f79535-47bb-0310-9956-ffa450edef68
 2022-12-12 18:43:44 +00:00
PJ Fanning efc032babc [bug-66365] rework XSSFCell getRichStringCellValue and getStringCellValue to better support array formula results. Thanks to Espen Amble Kolstad. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905571 13f79535-47bb-0310-9956-ffa450edef68
 2022-11-28 13:05:45 +00:00
PJ Fanning 30a0a4362a test for TIKA-3163 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903775 13f79535-47bb-0310-9956-ffa450edef68
 2022-08-30 11:10:46 +00:00
PJ Fanning 3184a18b40 [bug-66216] fix issue where pivotTable.getPivotCacheDefinition() returns null 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903442 13f79535-47bb-0310-9956-ffa450edef68
 2022-08-15 19:20:13 +00:00
PJ Fanning ed67d48d96 [bug-66215] add test case (that shows we have issues and need fixes) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903440 13f79535-47bb-0310-9956-ffa450edef68
 2022-08-15 18:40:25 +00:00
PJ Fanning 7301e841c7 [bug-66211] add test case 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903393 13f79535-47bb-0310-9956-ffa450edef68
 2022-08-13 15:09:18 +00:00
PJ Fanning 266619f363 revert: github ci perms 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903174 13f79535-47bb-0310-9956-ffa450edef68
 2022-08-01 17:27:45 +00:00
Andreas Beeker c41176f207 #66115 - Some Password protected XLS files are not read 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901996 13f79535-47bb-0310-9956-ffa450edef68
 2022-06-16 22:56:47 +00:00
PJ Fanning 3f414c760c [bug-66087] make DStar functions case insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901229 13f79535-47bb-0310-9956-ffa450edef68
 2022-05-25 10:31:07 +00:00
Dominik Stadler f8e27ee19b Prevent an overly large allocation when using HPSF 
Add a sample document from fuzzing which contains invalid/oversized values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899749 13f79535-47bb-0310-9956-ffa450edef68
 2022-04-11 13:51:31 +00:00
PJ Fanning a8f1e7acd1 [github-321] Fix issue with rounding in DataFormatter. Thanks to Colin Wang. This closes #321 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899680 13f79535-47bb-0310-9956-ffa450edef68
 2022-04-09 12:02:55 +00:00
PJ Fanning 05e8a16543 [github-321] add test case 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899667 13f79535-47bb-0310-9956-ffa450edef68
 2022-04-08 13:08:10 +00:00
PJ Fanning 56b4313997 [bug-64536] add getDimension on XSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899091 13f79535-47bb-0310-9956-ffa450edef68
 2022-03-20 21:41:31 +00:00
PJ Fanning 935c8ab06a add xssf test (width/height) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898944 13f79535-47bb-0310-9956-ffa450edef68
 2022-03-15 09:40:48 +00:00
Dominik Stadler 7283d7ed64 Make all text-extractors always return a non-null String 
This changes the expected exception of some test-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897319 13f79535-47bb-0310-9956-ffa450edef68
 2022-01-22 06:58:43 +00:00
Dominik Stadler 729d78cda6 Limit allocated elements in the PlfLfo structure for word documents 
Use large allocation-detection here as well,
otherwise some documents can try to allocate too much memory.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896744 13f79535-47bb-0310-9956-ffa450edef68
 2022-01-06 11:10:00 +00:00
Dominik Stadler 1d630a94fc Bug 52447: Allow HyperLinkRecord to appear as part of the RowRecordsAggregate 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896552 13f79535-47bb-0310-9956-ffa450edef68
 2021-12-30 23:03:16 +00:00
PJ Fanning 837590024f [bug-65741] rework previous change 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895881 13f79535-47bb-0310-9956-ffa450edef68
 2021-12-13 13:12:32 +00:00
PJ Fanning a24820e629 add data-formatter test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895706 13f79535-47bb-0310-9956-ffa450edef68
 2021-12-08 19:27:09 +00:00
PJ Fanning 50bab16ece add xlookup test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895613 13f79535-47bb-0310-9956-ffa450edef68
 2021-12-06 10:10:16 +00:00
PJ Fanning 7475b1f609 [bug-65706] ignore trash parts in OOXML files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895370 13f79535-47bb-0310-9956-ffa450edef68
 2021-11-27 10:15:39 +00:00
Dominik Stadler 7a5bc4227b Do not fail on different count of categories and points and fix cloning charts 
We see many cases where documents have charts with a difference here, so
downgrade the exception to a warning for now

Also handle cloning charts in workbooks where the parts have unexpected names
by making sure that the chosen part-name is not yet taken.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894676 13f79535-47bb-0310-9956-ffa450edef68
 2021-11-02 13:17:53 +00:00
Dominik Stadler 0727874584 Avoid NullPointerException when cloning sheets where there is no drawing patriarch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894450 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-21 14:17:31 +00:00
PJ Fanning 69eb168051 scaling issue 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894367 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-18 23:01:34 +00:00
PJ Fanning 005810640d [bug-65638] Remove escaping of ampersand from headers and footers created by Excel. Thanks to Viru. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894357 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-18 17:15:04 +00:00
PJ Fanning b906b72d29 [bug-59388] Set comment with option isVisible in .xlsx. Thanks to ryoii. This closes #239 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894347 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-18 10:48:04 +00:00
PJ Fanning 2514e4d0ab [bug-65452] fix issue where WorkbookFactory.create(File, ...) returns null if file type not recognised 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894097 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-10 09:58:02 +00:00
PJ Fanning 7d47c205e9 [bug-65306] issue with shift rows that remove rows and how shared formulas are affected 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894089 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-10 06:39:56 +00:00
PJ Fanning 08a1f9af22 [bug-65268] issue reading shared formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894064 13f79535-47bb-0310-9956-ffa450edef68
 2021-10-09 12:26:21 +00:00
PJ Fanning bd1ea63abe [github-254] Implement XSSFWorkbook linkExternalWorkbook. Thanks to @aspojo. This closes #254 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893728 13f79535-47bb-0310-9956-ffa450edef68
 2021-09-29 16:16:32 +00:00
PJ Fanning abe22ef8f7 [bug-65595] Strip colour formatting in headers and footers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893599 13f79535-47bb-0310-9956-ffa450edef68
 2021-09-24 15:05:10 +00:00
PJ Fanning f591073698 add test for broken file (5.0.1-RC1 issues) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893442 13f79535-47bb-0310-9956-ffa450edef68
 2021-09-19 12:45:26 +00:00
PJ Fanning 7bcf6d5a6d add support for reading hyperlinks that have cell refs that are area references (very limited update or write support as yet) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892141 13f79535-47bb-0310-9956-ffa450edef68
 2021-08-09 21:57:40 +00:00
PJ Fanning cd7b6b7197 [bug-65467] support IFNA() function. Thanks to Ross Patterson 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891876 13f79535-47bb-0310-9956-ffa450edef68
 2021-07-29 16:57:03 +00:00
PJ Fanning 3aa03459a7 [bug-65464] fix issue where shared formulas can be corrupted 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891849 13f79535-47bb-0310-9956-ffa450edef68
 2021-07-28 09:36:37 +00:00
PJ Fanning a6b9f5c006 update stress.xls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891729 13f79535-47bb-0310-9956-ffa450edef68
 2021-07-22 17:23:00 +00:00
PJ Fanning 0678b16f14 right to left xlsx test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891682 13f79535-47bb-0310-9956-ffa450edef68
 2021-07-20 12:43:52 +00:00
Dominik Stadler f71833e1d9 Do not return null for POITextExtractor.getMetadataTextExtractor() for old Excel files 
To adhere to the JavaDoc of the POITextExtractor interface which does not document a
possible null return.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889205 13f79535-47bb-0310-9956-ffa450edef68
 2021-04-26 15:12:32 +00:00
PJ Fanning 50cfe3c10e [github-235] Fix date formatting for number cell values. Thanks to Anthony Schott. This close #235 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889179 13f79535-47bb-0310-9956-ffa450edef68
 2021-04-25 17:16:05 +00:00
PJ Fanning e7a2df7dda [github-234] Ensure the hours position is correct. Thanks to Anthony Schott. This closes #234 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888804 13f79535-47bb-0310-9956-ffa450edef68
 2021-04-15 22:13:09 +00:00
Dominik Stadler 4027d8ac67 Allow negative numbers in conditional part of format string 
Closes #229

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887802 13f79535-47bb-0310-9956-ffa450edef68
 2021-03-19 09:40:10 +00:00
Nick Burch 82b5113ba9 Implement CONCAT function #65185 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887656 13f79535-47bb-0310-9956-ffa450edef68
 2021-03-14 22:53:27 +00:00
Marius Volkhart d1c9a07860 Add the ability to edit HSLFPictureData contents 
Pictures can now be edited by calling HSLFPictureData#setData(byte[]). The byte[] should contain the image data as an image viewer might read it.

To enable this functionality, a tighter coupling between the EscherBSERecords of the slideshow and the HSLFPictureData was required. This ensures that changes in image data size are accurately recorded in the records.

In the course of coupling the records and the HSLFPictureData, various scenarios arose where a mapping of records to pictures was non-trivial. Accordingly, the HSLFSlideShowImpl#matchPicturesAndRecords(...) function was added to perform a more sophisticated matching pass. This function is heavily exercised by org.apache.poi.hslf.usermodel.TestBugs.testFile[5] and PPTX2PNG.render[2], as well as the new TestPictures#testSlideshowWithIncorrectOffsets().

Closes #225

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887017 13f79535-47bb-0310-9956-ffa450edef68
 2021-02-28 23:16:14 +00:00
PJ Fanning 4013ffa220 [bug-65096] XLSX Streaming XML not correctly reading multiple inline Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885770 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-21 21:04:24 +00:00
Alain Béarez 825bebdbd1 Bug 65016 - Creating a chart throws exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885700 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-19 21:33:38 +00:00
Andreas Beeker 8f2c722fd3 Integration tests - try to fix Oracle/OpenJDK vs IBM-JDK error message differences on XXE files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885625 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-17 21:20:05 +00:00
Andreas Beeker 8d0e84f257 integration tests: ignore hsmf/lots-of-recipients.msg because of concurrent test errors - also takes too long to process 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885603 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-17 15:51:41 +00:00
Andreas Beeker 44efecf42e integration tests: Fix handling of NullPointerExceptions for Java 16+ (again ...) 
Refactor TestAllFiles to provide an API for mass testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885576 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-16 15:51:00 +00:00
Andreas Beeker 5e110d7216 integration tests: NullPointerExceptions contain now a description in Java 16+ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885549 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-16 09:55:42 +00:00
Andreas Beeker 309e657b0d #65046 - Simplify integration tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885538 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-15 23:50:42 +00:00
Andreas Beeker fb2a96a048 Sonar fixes 
Fixed offset of compare picture in resize_compare.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885280 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-08 22:56:05 +00:00
Dominik Stadler 622574f5f4 Bug 64450: Allow to parse a file where the relationship-id is an empty string 
Also improve exception reporting by including more information and not
"hiding" the actual exception-cause in a log-statement.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885056 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-03 11:49:51 +00:00
Dominik Stadler 685af351d1 Bug 64750: Do not use CTDataValidations.getCount(), instead only rely on getDataValidationArray 
Field "count" seems to be optional according
to the schema, so by using only the array
Apache POI can read data validations from
workbooks that do not populate the
"count" field properly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885011 13f79535-47bb-0310-9956-ffa450edef68
 2021-01-01 15:51:19 +00:00
Dominik Stadler b231366fb6 Bug 64986: Support missing or blank match_type for function Match 
Excel and LibreOffice use the default value in this case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884959 13f79535-47bb-0310-9956-ffa450edef68
 2020-12-30 21:40:12 +00:00
Dominik Stadler 42c4e7d89a Add unfixed test for bug 64759 and make the ones fail which depend on manual opening of files in Microsoft Excel for verification 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884957 13f79535-47bb-0310-9956-ffa450edef68
 2020-12-30 21:40:01 +00:00
Dominik Stadler a7c1d84c5d Improve the speed of the styles-optimiser when there are many styles in a Workbook 
Profiling showed that the call to isUserDefined() took most of the time,
so we now fetch this only once for each style and remember the result and
use it in the inner loop.

The attached sample-file took aprox. 1m30s on a decent machine, now it is down
to around 2s.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884917 13f79535-47bb-0310-9956-ffa450edef68
 2020-12-29 19:29:22 +00:00
Dominik Stadler 352f5a034c Fix bug 64238: Make LOOKUP functions deal with empty last arg correctly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882827 13f79535-47bb-0310-9956-ffa450edef68
 2020-10-25 07:21:45 +00:00