Commit Graph

150 Commits

Author SHA1 Message Date
Dominik Stadler 5724a77cf2 Avoid some NullPointerExceptions and ClassCastExceptions found when fuzzing Apache POI
This mostly only makes thrown exceptions a bit more consistent
or may allow some broken documents to be still read.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906322 13f79535-47bb-0310-9956-ffa450edef68
2023-01-01 15:59:32 +00:00
PJ Fanning 37994bf3e2 [github-409] Textruns not honouring highlight. Thans to gffloodg. This closes #409
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906248 13f79535-47bb-0310-9956-ffa450edef68
2022-12-28 17:45:21 +00:00
PJ Fanning 78516f50dc try to get rid of cached module-info classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906232 13f79535-47bb-0310-9956-ffa450edef68
2022-12-27 18:45:15 +00:00
PJ Fanning 5e212e4a33 doesn't matter what jdk vendor is used to build module-info classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906212 13f79535-47bb-0310-9956-ffa450edef68
2022-12-26 10:05:10 +00:00
PJ Fanning 8898d2d15a try to fix build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906208 13f79535-47bb-0310-9956-ffa450edef68
2022-12-26 00:24:29 +00:00
PJ Fanning edee60d87a rebuild module-info.class files even if Java8 used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906207 13f79535-47bb-0310-9956-ffa450edef68
2022-12-25 23:56:32 +00:00
PJ Fanning 1494812da8 try to build sboms
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906146 13f79535-47bb-0310-9956-ffa450edef68
2022-12-21 17:52:29 +00:00
PJ Fanning b8d4597ea4 cyclonedx per module
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906134 13f79535-47bb-0310-9956-ffa450edef68
2022-12-21 11:23:43 +00:00
PJ Fanning a0abaf205a license issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905063 13f79535-47bb-0310-9956-ffa450edef68
2022-11-04 09:44:37 +00:00
PJ Fanning c838c6cd6c [bug-66335] apply rest of fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905062 13f79535-47bb-0310-9956-ffa450edef68
2022-11-04 09:13:05 +00:00
PJ Fanning c4a0266cb3 [bug-66335] add test case for issue and add some of the code from purported fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905061 13f79535-47bb-0310-9956-ffa450edef68
2022-11-04 08:33:38 +00:00
PJ Fanning 52968d92da update javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905029 13f79535-47bb-0310-9956-ffa450edef68
2022-11-02 19:26:57 +00:00
PJ Fanning 933948a846 [bug-66301] Add a method to properly write the header necessary for a MSG attachment. Thanks to Lyn Evans.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904685 13f79535-47bb-0310-9956-ffa450edef68
2022-10-18 19:10:32 +00:00
PJ Fanning 6e7f6dad21 try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904065 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 09:54:24 +00:00
PJ Fanning 7235ff9036 try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904051 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 01:32:10 +00:00
PJ Fanning 59b16f025b try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904050 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 01:12:38 +00:00
PJ Fanning 34601b5377 some lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904048 13f79535-47bb-0310-9956-ffa450edef68
2022-09-13 23:38:12 +00:00
PJ Fanning 913d1eecf5 [bug-63576] support capitalized text in WordExtractor (HWPF)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903738 13f79535-47bb-0310-9956-ffa450edef68
2022-08-28 14:16:01 +00:00
PJ Fanning deffaacd0f sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903686 13f79535-47bb-0310-9956-ffa450edef68
2022-08-25 18:52:27 +00:00
PJ Fanning 03a39fd9dc more int narrowing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903562 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 09:31:14 +00:00
PJ Fanning 9d7d2f26e0 more int narrowing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903560 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 09:02:15 +00:00
PJ Fanning 114f8b8fde test issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903555 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 07:56:55 +00:00
PJ Fanning b8cd360300 some int narrowing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903551 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 02:21:15 +00:00
PJ Fanning f6a320770b remove unnecessary l
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903266 13f79535-47bb-0310-9956-ffa450edef68
2022-08-07 09:21:30 +00:00
PJ Fanning d7d13a11c1 [github-367] use uppercase L for longs. Thanks to Arturo Bernal. This closes #367
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903265 13f79535-47bb-0310-9956-ffa450edef68
2022-08-07 09:16:24 +00:00
PJ Fanning bbfd7b9ec8 [github-365] use lambdas. Thanks to Arturo Bernal. This closes #365
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903258 13f79535-47bb-0310-9956-ffa450edef68
2022-08-06 21:12:49 +00:00
PJ Fanning eaa27548fa [github-366] remove unnecessary local vars. Thanks to Arturo Bernal. This closes #366
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903257 13f79535-47bb-0310-9956-ffa450edef68
2022-08-06 21:06:50 +00:00
PJ Fanning 3247a4160e [github-364] use Math.min/max. Thanks to Arturo Bernal. This closes #364
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903256 13f79535-47bb-0310-9956-ffa450edef68
2022-08-06 20:51:57 +00:00
PJ Fanning 9626dd0661 update some module-info classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903003 13f79535-47bb-0310-9956-ffa450edef68
2022-07-25 11:22:08 +00:00
PJ Fanning 32069e6f5a [github-353] Use printf. Thanks to XenoAmess. This closes #353
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902802 13f79535-47bb-0310-9956-ffa450edef68
2022-07-17 09:07:07 +00:00
PJ Fanning 50c40b61f7 [github-354] Add extra methods to StringUtil and refactor some code to use them. Thanks to XenoAmess. This closes #354
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902801 13f79535-47bb-0310-9956-ffa450edef68
2022-07-17 08:45:38 +00:00
PJ Fanning c589f0ee7a [github-339] Add extra methods to StringUtil and refactor some code to use them. Thanks to XenoAmess. This closes #339
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902789 13f79535-47bb-0310-9956-ffa450edef68
2022-07-17 01:53:18 +00:00
PJ Fanning 46b14041bf java 17 compile issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902783 13f79535-47bb-0310-9956-ffa450edef68
2022-07-16 20:12:56 +00:00
PJ Fanning 22badcef27 [github-342] Use foreach. Thanks to XenoAmess. This closes #342
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902778 13f79535-47bb-0310-9956-ffa450edef68
2022-07-16 18:08:50 +00:00
PJ Fanning 4f54f29a2d [github-345] Use switch instead of if. Thanks to XenoAmess. This closes #345
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902772 13f79535-47bb-0310-9956-ffa450edef68
2022-07-16 10:13:18 +00:00
PJ Fanning b0400647a9 java 17 compile issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902761 13f79535-47bb-0310-9956-ffa450edef68
2022-07-16 01:17:15 +00:00
PJ Fanning ce3371e92e [github-341] Remove unused imports. Thanks to XenoAmess. This closes #341
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902760 13f79535-47bb-0310-9956-ffa450edef68
2022-07-15 23:23:34 +00:00
PJ Fanning 01f14a7548 [github-361] reuse regex pattern instances. Thanks to XenoAmess. This closes #361
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902756 13f79535-47bb-0310-9956-ffa450edef68
2022-07-15 22:45:56 +00:00
PJ Fanning 87ee700d04 [github-340] make more use of StandardCharsets. Thanks to XenoAmess. This closes #340
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902755 13f79535-47bb-0310-9956-ffa450edef68
2022-07-15 21:52:32 +00:00
PJ Fanning 186ad50d18 [github-351] make test loop more efficient
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902752 13f79535-47bb-0310-9956-ffa450edef68
2022-07-15 21:24:53 +00:00
PJ Fanning b4c92e4ae5 [bug-65634] NotOLE2FileException not thrown in POI 5.0.0 by opening an XML-RAW File with SlideShowFactory.create()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902395 13f79535-47bb-0310-9956-ffa450edef68
2022-07-01 16:30:15 +00:00
Dominik Stadler bfd2266779 Fix issues found when fuzzing Apache POI via Jazzer
Do not assert when the next line will throw a proper exception anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899162 13f79535-47bb-0310-9956-ffa450edef68
2022-03-24 04:42:34 +00:00
PJ Fanning a1463e32e5 increase max size of hwmf picture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899135 13f79535-47bb-0310-9956-ffa450edef68
2022-03-22 14:58:47 +00:00
PJ Fanning d013349052 use spaces for indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899082 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 10:26:05 +00:00
Dominik Stadler 9949242022 Remove unused imports, remove unnecessary boxing of int-value and apply some other IDE suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899076 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 08:20:00 +00:00
Dominik Stadler d648c6d652 Fix issues found when fuzzing Apache POI via Jazzer
Throw RecordFormatException instead of NPE or assertion for
cases that can be triggered by a malformed document

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899073 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:51 +00:00
Dominik Stadler 9df7e2d847 Prevent one more case of allocating endlessly on invalid TNEF/HMEF/MAPI files
Limit the number of attributes to 10,000 by default

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899072 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:47 +00:00
Dominik Stadler a7810011c7 Fix issues found when fuzzing Apache POI via Jazzer
Replace assertions with actual checks when input-data
can trigger them. We would not handle such
input-data properly otherwise.
Sometimes logging seems a better option if the issue
is not blocking us from parsing the document anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899070 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:38 +00:00
Dominik Stadler 116c3e91ad Add/update some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898385 13f79535-47bb-0310-9956-ffa450edef68
2022-02-24 18:12:39 +00:00
Andreas Beeker b59dbbd076 Use gradle toolchain to specify the jdk version and vendor, e.g.
> gradle -no-build-cache -PjdkVersion=16 -PjdkVendor=oracle clean check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898288 13f79535-47bb-0310-9956-ffa450edef68
2022-02-21 22:57:03 +00:00