Commit Graph

3174 Commits

Author SHA1 Message Date
Yegor Kozlov 968c6493a5 1. important algorithmic improvements of XSSFRow and XSSFSheet, removed LinkedList in favor of TreeMap, that allowed O(Log(N)) performance instead of O(N) when adding new rows and cells2. Revised cell value accessors in XSSFCell. Now both HSSF and XSSF handle various cell types equally. The same exceptions are thrown in case of type mismatch, same behaviour when setting nulls, etc.
3. Moved FormulaError codes out of the Cell interface into enum. Interface isn't a proper place for it
4. Finally finished javadoc on XSSFRow and XSSFCell


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@707445 13f79535-47bb-0310-9956-ffa450edef68
2008-10-23 18:57:28 +00:00
Josh Micich 50b9bb8d01 Fix for bug 46053 - fixed evaluation cache dependency analysis when changing blank cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@706772 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 21:25:50 +00:00
Yegor Kozlov c63434df63 1. implemented XSSFSheet.autosizeColumn(), for now mostly duplicated HSSF code, will be refactored in future.2. fixed bug #45974: XSSFCell.getCellStyle can return null3. more code cleanup and reaftoring, removed usages of obsolete XSSFCell.getCellNum() in favor of XSSFCell.getColumnIndex(), also more javadoc in core classes
4. fixed a blocker: calling XSSFSheet.getNumMergedRegions() resulted in unreadable workbook, this methods structurally modified worksheet and added unnecessary data 

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706691 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 17:56:34 +00:00
Yegor Kozlov 56fb91e62a updated release version on the index page, started a new section in the change log
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@706540 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 06:47:35 +00:00
Yegor Kozlov 6d185ee425 cleanup of POIXMLDocument constructors and related sub-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706032 13f79535-47bb-0310-9956-ffa450edef68
2008-10-19 15:31:28 +00:00
Yegor Kozlov 90afc5eb5c more code cleanup and refactoring: (a) removed references to ooxml schemas from XSSF enums, they should not depend on ooxml-schemas.jar
(b) removed "for testing only" constructors, the goal is to have a single, maximum 2 constructors for objects inherited from POIXMLDocumentPart
(c) more javadocs 


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706003 13f79535-47bb-0310-9956-ffa450edef68
2008-10-19 12:54:40 +00:00
Yegor Kozlov 6e94780280 applied patch #46003 by Gisella Bronzetti
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705701 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 18:43:37 +00:00
Yegor Kozlov b03f77865d applied patches #46004 and #46006 submitted by Gisella Bronzetti
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705684 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 17:44:53 +00:00
Yegor Kozlov d70887d566 should have been included in r705638
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705662 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 16:21:05 +00:00
Yegor Kozlov f160dd1e7b more progress on SpreadsheetML drawing layer;finished XSSFPicture, auto-sizing is supported; implemented initial support for shape groups. Common HSSF-XSSF drawing interfaces are still TODO.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705638 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 15:14:00 +00:00
Yegor Kozlov e308696df9 refactored POIXMLFactory and related classes; simplified XSSFRelation - now it's just a set of definitions of XSSF relations, all read/load stuff is not used anymore and was removed. Also, removed Workbook.getCustomPallete() - it's OLE-specific
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703814 13f79535-47bb-0310-9956-ffa450edef68
2008-10-12 13:10:30 +00:00
Yegor Kozlov bff1825f78 applied patch #45967 by Gisella Bronzetti: support for XSSFPrintSetup object
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703778 13f79535-47bb-0310-9956-ffa450edef68
2008-10-12 10:25:58 +00:00
Yegor Kozlov 1b3dc1ab13 set trunk version.id=3.3-alpha1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703651 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 12:01:42 +00:00
Yegor Kozlov aa88dedea9 fixed error in eval.xml: use &lt; instead of '<'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703645 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 10:31:24 +00:00
Josh Micich e75bd50c65 fix for bug 45866 - allowed for change of unicode compression across Continue records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703620 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 01:11:05 +00:00
Josh Micich 25f26a82f7 Made RecordInputStream final (major clean-up in test cases and BiffViewer)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703596 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 22:59:14 +00:00
Yegor Kozlov b4e74b306c Initial support for SpreadsheetML drawings,implemented XSSFPicture, added ability to add pictures to workbook, refactored XSSFPictureData to be a subclass of POIXMLDocumentPart. Also refactored misc odds and ends in order to produce xml better compatible with what MS Office produces
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703490 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 14:54:32 +00:00
Josh Micich 91c8480933 Fix for bug 45964 - support for link formulas in Text Objects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703302 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 00:40:58 +00:00
Josh Micich 69b99aa672 Should have been submitted with r703100 (changes to Ptg)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703197 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 16:10:39 +00:00
Josh Micich 0c16154ed0 Removed last occurrences of storing Ptg arrays in Stacks. Some related clean-up.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703100 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 08:33:54 +00:00
Josh Micich 91d6061c07 Merged revisions 703092 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r703092 | josh | 2008-10-09 00:44:37 -0700 (Thu, 09 Oct 2008) | 1 line
  
  converted short HSSFCell.getCellNum to int getColumnIndex
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703096 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 08:03:43 +00:00
Josh Micich 9561f4037b converted short HSSFCell.getCellNum to int getColumnIndex
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703092 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 07:44:37 +00:00
Josh Micich b3959ec237 Merged revisions 703063 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r703063 | josh | 2008-10-08 23:07:36 -0700 (Wed, 08 Oct 2008) | 1 line
  
  Performance optimisation for EvaluationCache.  Changed to use HSSFCell as key into cache entry map.  Reduced dependency information storage for blank cells.  Introduced EvaluationSheet and EvaluationCell interfaces.  Modified HSSFFormulaEvaluator API to have simpler notify~ methods
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703083 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 07:20:46 +00:00
Josh Micich eb12a8716f Merged revisions 701756,702231 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r701756 | josh | 2008-10-05 00:22:12 -0700 (Sun, 05 Oct 2008) | 1 line
  
  Fixing comments and formatting inside Record subclasses
........
  r702231 | josh | 2008-10-06 12:13:41 -0700 (Mon, 06 Oct 2008) | 1 line
  
  Fix for 43354 - made the formula evaluator capable of handling missing function arguments
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703070 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:46:17 +00:00
Josh Micich f55bd82eef Merged revisions 700479,700493,700916,701302,701569,701598,701747 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r700479 | yegor | 2008-09-30 07:32:37 -0700 (Tue, 30 Sep 2008) | 1 line
  
  reverted the change made in r693085 , see bug #45859
........
  r700493 | yegor | 2008-09-30 08:11:26 -0700 (Tue, 30 Sep 2008) | 1 line
  
  initial support for creating hyperlinks in HSLF, units test are still to do
........
  r700916 | josh | 2008-10-01 13:56:21 -0700 (Wed, 01 Oct 2008) | 1 line
  
  Fixed bug in CellCacheEntry (support for caching blank evaluation results)
........
  r701302 | yegor | 2008-10-02 22:27:06 -0700 (Thu, 02 Oct 2008) | 1 line
  
  fixed bug #45889:rrayIndexOutOfBoundsException when constructing HSLF Table with a single row
........
  r701569 | josh | 2008-10-03 16:50:22 -0700 (Fri, 03 Oct 2008) | 1 line
  
  Fix for bug 45912 - ArrayIndexOutOfBoundsException in EmbeddedObjectRefSubRecord
........
  r701598 | josh | 2008-10-03 21:59:26 -0700 (Fri, 03 Oct 2008) | 1 line
  
  changed workbook reference to index in CellLocation
........
  r701747 | josh | 2008-10-04 21:43:48 -0700 (Sat, 04 Oct 2008) | 1 line
  
  Better bounds checking in RecordInputStream. Removed rarely used methods readShortArray and putShortArray
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703069 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:38:50 +00:00
Josh Micich d467f76254 Performance optimisation for EvaluationCache. Changed to use HSSFCell as key into cache entry map. Reduced dependency information storage for blank cells. Introduced EvaluationSheet and EvaluationCell interfaces. Modified HSSFFormulaEvaluator API to have simpler notify~ methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703063 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:07:36 +00:00
Josh Micich 3a2feafaa6 Fix for 43354 - made the formula evaluator capable of handling missing function arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@702231 13f79535-47bb-0310-9956-ffa450edef68
2008-10-06 19:13:41 +00:00
Yegor Kozlov a9f18bad9d applied patch #45492 submitted by Gisella Bronzetti,also performed major cleanup of StylesTable and its components, the goal was to ensure that StylesTable works as a cache of styling components, not just a regular store of fill patterns and cell styles.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@701797 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 13:56:28 +00:00
Josh Micich f9adf67cff Fixing comments and formatting inside Record subclasses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701756 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 07:22:12 +00:00
Josh Micich 794d4051bb Better bounds checking in RecordInputStream. Removed rarely used methods readShortArray and putShortArray
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701747 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 04:43:48 +00:00
Josh Micich 0e8dd31f05 changed workbook reference to index in CellLocation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701598 13f79535-47bb-0310-9956-ffa450edef68
2008-10-04 04:59:26 +00:00
Josh Micich dfc67205b9 Fix for bug 45912 - ArrayIndexOutOfBoundsException in EmbeddedObjectRefSubRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701569 13f79535-47bb-0310-9956-ffa450edef68
2008-10-03 23:50:22 +00:00
Yegor Kozlov 301a0f834c fixed bug #45889:rrayIndexOutOfBoundsException when constructing HSLF Table with a single row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701302 13f79535-47bb-0310-9956-ffa450edef68
2008-10-03 05:27:06 +00:00
Josh Micich 3d3c4958d2 Fixed bug in CellCacheEntry (support for caching blank evaluation results)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700916 13f79535-47bb-0310-9956-ffa450edef68
2008-10-01 20:56:21 +00:00
Yegor Kozlov 54f56d99ba applied patches provided by Gisella Bronzetti in bugs #45918, #45917 and #45920
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700844 13f79535-47bb-0310-9956-ffa450edef68
2008-10-01 17:15:02 +00:00
Yegor Kozlov 190f1cc40a iterator over sheet data in XSSFReader returns sheets in logical order, i.e. as they are defined in workbook.xml (was in physical order, as they were stored in the relationship table)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700821 13f79535-47bb-0310-9956-ffa450edef68
2008-10-01 16:14:39 +00:00
Yegor Kozlov 2822f208fa initial support for creating hyperlinks in HSLF, units test are still to do
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700493 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 15:11:26 +00:00
Yegor Kozlov 5f5df9d519 reverted the change made in r693085 , see bug #45859
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700479 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 14:32:37 +00:00
Yegor Kozlov 0c4ee58c9f refactored POIXMLDocument to be a composite of POIXMLDocumentPart, this way XSSFWorkbook is a root of a tree: XSSFSheets are children, XSSFDrawings are children of worksheets, etc,
Also, performed major cleanup of core XSSF classes and test cases

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700472 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 13:57:36 +00:00
Josh Micich 7c40d2c9b0 Merged revisions 700280,700304,700327,700356 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r700280 | josh | 2008-09-29 15:04:20 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Fix for bug 45876 - allowed BoundSheetRecord to take sheet names longer than 31 chars
........
  r700304 | josh | 2008-09-29 16:12:53 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Updated formula evaluator documentation due to bugzilla 45768
........
  r700327 | josh | 2008-09-29 19:30:53 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Removed validateSid method from Record classes
........
  r700356 | josh | 2008-09-29 23:18:44 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Refactored fillFields() method into constructor in Record class hierarchy
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700359 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 06:42:27 +00:00
Josh Micich 15e0710fec Refactored fillFields() method into constructor in Record class hierarchy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700356 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 06:18:44 +00:00
Josh Micich 3e3cbd997d Removed validateSid method from Record classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700327 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 02:30:53 +00:00
Josh Micich ae3ce0ae5d Updated formula evaluator documentation due to bugzilla 45768
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700304 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 23:12:53 +00:00
Josh Micich d14991ed02 Fix for bug 45876 - allowed BoundSheetRecord to take sheet names longer than 31 chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700280 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 22:04:20 +00:00
Josh Micich 8befcb660a Merged revisions 700005,700203-700204 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r700005 | josh | 2008-09-29 00:27:14 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Fix for bug 45890 - made HSSFSheet.shiftRows also update conditional formats
........
  r700203 | josh | 2008-09-29 11:43:53 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Refactoring row-blocks record reading logic in Sheet
........
  r700204 | josh | 2008-09-29 11:48:43 -0700 (Mon, 29 Sep 2008) | 1 line
  
  Should have been submitted with c700203 (Refactoring row-blocks record reading logic in Sheet)
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700243 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 20:38:55 +00:00
Josh Micich 8bfd149414 Merged revisions 699178,699487,699489,699761 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r699178 | josh | 2008-09-25 21:49:20 -0700 (Thu, 25 Sep 2008) | 1 line
  
  Changed HSSFEvaluationWorkbook to avoid re-parsing cell formulas during execution. (working towards fix for bug 45865)
........
  r699487 | josh | 2008-09-26 13:25:45 -0700 (Fri, 26 Sep 2008) | 1 line
  
  Fix formula parser to properly support the range operator. Small fixes to parsing of sheet names and full column references.
........
  r699489 | josh | 2008-09-26 13:32:06 -0700 (Fri, 26 Sep 2008) | 1 line
  
  Code cleanup in junit
........
  r699761 | josh | 2008-09-27 19:04:31 -0700 (Sat, 27 Sep 2008) | 1 line
  
  Bug 45865 - modified Formula Parser/Evaluator to handle cross-worksheet formulas
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@700234 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 20:09:09 +00:00
Josh Micich 857ead338e Should have been submitted with c700203 (Refactoring row-blocks record reading logic in Sheet)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700204 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 18:48:43 +00:00
Josh Micich d374eb628d Refactoring row-blocks record reading logic in Sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700203 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 18:43:53 +00:00
Josh Micich 7f5b525a56 Fix for bug 45890 - made HSSFSheet.shiftRows also update conditional formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700005 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 07:27:14 +00:00
Josh Micich 7c8d6be5bc Cleaned up test code
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@699991 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 05:46:06 +00:00