Commit Graph

228 Commits

Author SHA1 Message Date
Dominik Stadler 9fa33b2b7e Fix issues found when fuzzing Apache POI via Jazzer
Add some additional allocation limits to avoid OOM in
some more cases with some broken input files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895922 13f79535-47bb-0310-9956-ffa450edef68
2021-12-13 19:22:34 +00:00
PJ Fanning 837590024f [bug-65741] rework previous change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895881 13f79535-47bb-0310-9956-ffa450edef68
2021-12-13 13:12:32 +00:00
Dominik Stadler 1e9efb5562 Fix issues found when fuzzing Apache POI via Jazzer
Add some null-checks and report more meaningful exceptions
This provides a bit more information than simple NullPointExceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895600 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 17:34:44 +00:00
Dominik Stadler f0e7cc0881 Fix issues found when fuzzing Apache POI via Jazzer
Check for negative array allocation size or access and report a more meaningful exception

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895599 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 17:34:19 +00:00
Dominik Stadler d5538d24d8 Apply IDE suggestions, adjust tests, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895596 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 15:33:39 +00:00
PJ Fanning a18a52316a remove unfinished test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895458 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:58:22 +00:00
PJ Fanning 6c3fe307f5 fix merge issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895457 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:57:10 +00:00
PJ Fanning c8d61cbfe3 code formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895454 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:49:25 +00:00
PJ Fanning add71cb80a spelling of embedded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895452 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:33:25 +00:00
PJ Fanning 43438ee6ef [bug-65715] fix bug in getDrawingPatriarch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895447 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 08:49:03 +00:00
Andreas Beeker d9b0e2ebfa Fix date format differences Java 8 vs 9+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895383 13f79535-47bb-0310-9956-ffa450edef68
2021-11-27 23:07:15 +00:00
PJ Fanning 5022f30c4b tidy up gradle scripts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895321 13f79535-47bb-0310-9956-ffa450edef68
2021-11-25 10:31:50 +00:00
PJ Fanning a3f0121147 saxon test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895319 13f79535-47bb-0310-9956-ffa450edef68
2021-11-25 10:05:00 +00:00
Andreas Beeker d3ff953cf7 #65694 - HSLF - handle date/time fields and formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895248 13f79535-47bb-0310-9956-ffa450edef68
2021-11-22 00:01:31 +00:00
PJ Fanning d96869c870 some incorrect uses of
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895151 13f79535-47bb-0310-9956-ffa450edef68
2021-11-18 13:17:24 +00:00
PJ Fanning 9d765c755c javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895077 13f79535-47bb-0310-9956-ffa450edef68
2021-11-16 00:30:15 +00:00
PJ Fanning 8365ee1611 [github-278] Resolve all SpotBugs P1 issues in Main and Test. Thanks to Andreas Reichel. This closes #278
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895016 13f79535-47bb-0310-9956-ffa450edef68
2021-11-14 10:18:40 +00:00
PJ Fanning 161f02ad9e javadoc typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894858 13f79535-47bb-0310-9956-ffa450edef68
2021-11-09 10:16:58 +00:00
Dominik Stadler 761a78b49f Use append(char) instead of string where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894814 13f79535-47bb-0310-9956-ffa450edef68
2021-11-07 15:00:03 +00:00
Dominik Stadler 034c95ec55 Add some more forbidden-apis to prefer core JDK classes over Guava and commons-codec
Also prevent java logging from being used inadvertently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894810 13f79535-47bb-0310-9956-ffa450edef68
2021-11-07 14:59:40 +00:00
PJ Fanning 567b8fde92 try to add LICENSE and NOTICE to sources jars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894567 13f79535-47bb-0310-9956-ffa450edef68
2021-10-26 00:38:50 +00:00
PJ Fanning a826e8e32d try to add LICENSE and NOTICE to sources jars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894566 13f79535-47bb-0310-9956-ffa450edef68
2021-10-26 00:37:27 +00:00
PJ Fanning 90b8a0c36d try to add LICENSE and NOTICE to sources jars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894565 13f79535-47bb-0310-9956-ffa450edef68
2021-10-25 22:50:03 +00:00
PJ Fanning e66486bc8a try to add LICENSE and NOTICE to javadoc jars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894564 13f79535-47bb-0310-9956-ffa450edef68
2021-10-25 22:29:10 +00:00
Andreas Beeker 4b230fa142 #65653 - HSLF FillType for texture and background color fills ignored
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894538 13f79535-47bb-0310-9956-ffa450edef68
2021-10-24 22:07:59 +00:00
PJ Fanning 977a870899 configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894526 13f79535-47bb-0310-9956-ffa450edef68
2021-10-24 09:37:50 +00:00
PJ Fanning 6a12c6cb25 [bug-65650] use image/x-pict mime type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894507 13f79535-47bb-0310-9956-ffa450edef68
2021-10-23 10:49:18 +00:00
PJ Fanning 732d640c41 remove deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894496 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 22:50:59 +00:00
PJ Fanning c0cc881114 more support for configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894494 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 21:08:53 +00:00
PJ Fanning 5b554e7534 more support for configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894493 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 20:53:54 +00:00
PJ Fanning e216997950 make max record sizes configurable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894454 13f79535-47bb-0310-9956-ffa450edef68
2021-10-21 18:42:11 +00:00
PJ Fanning 04c130b8d5 make max record sizes configurable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894453 13f79535-47bb-0310-9956-ffa450edef68
2021-10-21 17:34:29 +00:00
PJ Fanning dbc6576da4 make max record sizes configurable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894452 13f79535-47bb-0310-9956-ffa450edef68
2021-10-21 16:52:09 +00:00
PJ Fanning f454cfa63a [bug-65639] add doc about lack of thread saftey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894439 13f79535-47bb-0310-9956-ffa450edef68
2021-10-21 10:14:10 +00:00
PJ Fanning fa00e7d472 [bug-65639] increase max size of HSLF font data and try to cache the FontHeader instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894438 13f79535-47bb-0310-9956-ffa450edef68
2021-10-21 10:08:35 +00:00
PJ Fanning 9fe3944e8e get proper xmlbeans 5.0.2 release
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894428 13f79535-47bb-0310-9956-ffa450edef68
2021-10-20 23:54:34 +00:00
Andreas Beeker 3c3154ea8c sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894365 13f79535-47bb-0310-9956-ffa450edef68
2021-10-18 22:35:17 +00:00
PJ Fanning ba08e1a46c [bug-65255] add test case but cannot reproduce issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894363 13f79535-47bb-0310-9956-ffa450edef68
2021-10-18 20:32:02 +00:00
Andreas Beeker 611f5273fd sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894360 13f79535-47bb-0310-9956-ffa450edef68
2021-10-18 17:40:47 +00:00
Andreas Beeker 87a764956c sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894331 13f79535-47bb-0310-9956-ffa450edef68
2021-10-17 20:44:36 +00:00
Andreas Beeker dfbab3ff6a #64036 - Replace reflection calls in factories for Java 9+
use ServiceLoader for HSLF Metro Shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894298 13f79535-47bb-0310-9956-ffa450edef68
2021-10-16 00:00:50 +00:00
PJ Fanning 7987d913f3 xmlbeans 5.0.2 (temporarily from a pre-release location)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894212 13f79535-47bb-0310-9956-ffa450edef68
2021-10-13 22:15:22 +00:00
Andreas Beeker 6583f68d2f #64716 - wmf display error
update heuristic to respect location of bounding box

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894206 13f79535-47bb-0310-9956-ffa450edef68
2021-10-13 20:39:01 +00:00
Andreas Beeker 24b3dac0c0 #64716 - wmf display error
add anothger heuristic - cumulate the bounding box of the shape records and compare it to window, viewport and emfbounds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894176 13f79535-47bb-0310-9956-ffa450edef68
2021-10-12 22:30:30 +00:00
PJ Fanning 700ecc461f [bug-62215] add test case for sxssf formulas - issue was already fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894128 13f79535-47bb-0310-9956-ffa450edef68
2021-10-11 10:45:59 +00:00
PJ Fanning 4f39cced7a build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894046 13f79535-47bb-0310-9956-ffa450edef68
2021-10-08 21:48:17 +00:00
PJ Fanning b2f0d5fc5a make array into immutable collection (spotbugs issue)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893862 13f79535-47bb-0310-9956-ffa450edef68
2021-10-03 22:01:52 +00:00
PJ Fanning 875e921f86 lgtm javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893850 13f79535-47bb-0310-9956-ffa450edef68
2021-10-03 10:57:02 +00:00
PJ Fanning acadd84b53 sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893847 13f79535-47bb-0310-9956-ffa450edef68
2021-10-03 09:11:35 +00:00
Marius Volkhart 9994a4286d Replace explicit close with try-with-resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893778 13f79535-47bb-0310-9956-ffa450edef68
2021-10-01 11:57:12 +00:00
PJ Fanning 4fbadb0cfd tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893576 13f79535-47bb-0310-9956-ffa450edef68
2021-09-23 19:03:06 +00:00
Andreas Beeker d6806c3365 rework BitmapImageRenderer
refactor TestPPTX2PNG code to support archives

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893451 13f79535-47bb-0310-9956-ffa450edef68
2021-09-19 19:52:20 +00:00
PJ Fanning ac83ff11f4 add test for broken file (5.0.1-RC1 issues)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893444 13f79535-47bb-0310-9956-ffa450edef68
2021-09-19 13:05:04 +00:00
Andreas Beeker 596db31170 XmlSec/BouncyCastle and Batik are now optional
disable SonarQube build based on ant
remove sonar and maven directory, because POMs are now created via Gradle
remove maven section from seed-build

fix duplicated maven dependencies on POM export

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1893289 13f79535-47bb-0310-9956-ffa450edef68
2021-09-12 20:31:43 +00:00
Andreas Beeker f63f3ff09d update to release 5.1.0
fix ooxml-lite build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892887 13f79535-47bb-0310-9956-ffa450edef68
2021-09-03 21:13:36 +00:00
Andreas Beeker 1eace7a0c4 update module-info.classes for next release
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892829 13f79535-47bb-0310-9956-ffa450edef68
2021-09-02 20:47:20 +00:00
Andreas Beeker f71cebcce5 sonar fixes
close resources in tests
fix gradle warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892683 13f79535-47bb-0310-9956-ffa450edef68
2021-08-28 23:48:48 +00:00
Andreas Beeker bb202a7b37 try to fix path issues in Windows build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892479 13f79535-47bb-0310-9956-ffa450edef68
2021-08-20 19:46:26 +00:00
Andreas Beeker d9238f2490 try to fix concurrent issues in excelant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892478 13f79535-47bb-0310-9956-ffa450edef68
2021-08-20 17:07:36 +00:00
PJ Fanning 5d65f68136 try to fix issue with building in windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891467 13f79535-47bb-0310-9956-ffa450edef68
2021-07-12 02:28:36 +00:00
PJ Fanning d7d18d9093 add commons-compress to module-info
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1891362 13f79535-47bb-0310-9956-ffa450edef68
2021-07-07 13:28:33 +00:00
PJ Fanning 33f6381c43 convert tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1890122 13f79535-47bb-0310-9956-ffa450edef68
2021-05-22 21:37:08 +00:00
Andreas Beeker 7eaca60a1a activate javadoc lint and fix errors
add signing and checksum generation
add slf4j-bridge for tests
add dependencies to ooxml-lite
fix complex enum classes
add override annotations
move gradle logic to root build
generate javadoc in its own dist directory, because JPMS complains about duplicate modules otherwise

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1890089 13f79535-47bb-0310-9956-ffa450edef68
2021-05-21 21:22:40 +00:00
PJ Fanning f260abab3b use commons-io StringBuilderWriter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889874 13f79535-47bb-0310-9956-ffa450edef68
2021-05-14 02:24:48 +00:00
Andreas Beeker 0614835c55 #65304 - Add commons-io as a dependency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889871 13f79535-47bb-0310-9956-ffa450edef68
2021-05-14 00:37:50 +00:00
Dominik Stadler 41ff8bb20c Start moving some bits to the main Gradle file
Use a common definition of some constants
Gradle plugins are in the main file already anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889839 13f79535-47bb-0310-9956-ffa450edef68
2021-05-13 12:11:35 +00:00
Andreas Beeker 0b0bcce7ac #64844 - Incorrect sizes of images in SVG
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889686 13f79535-47bb-0310-9956-ffa450edef68
2021-05-08 21:56:06 +00:00
Tim Allison b3f53ff0bc Bug 65293 -- npe in HwmfFont
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889636 13f79535-47bb-0310-9956-ffa450edef68
2021-05-07 15:43:04 +00:00
Andreas Beeker 053ae3618d #65085 - LineRect shall throw more specific exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889428 13f79535-47bb-0310-9956-ffa450edef68
2021-05-02 22:03:02 +00:00
Andreas Beeker 32c2de2325 Fix Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888939 13f79535-47bb-0310-9956-ffa450edef68
2021-04-18 23:15:45 +00:00
Andreas Beeker 9392b464e3 Fix Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888935 13f79535-47bb-0310-9956-ffa450edef68
2021-04-18 22:10:38 +00:00
Andreas Beeker 7ab1c9c0fd fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888805 13f79535-47bb-0310-9956-ffa450edef68
2021-04-15 22:28:11 +00:00
Dominik Stadler 0484610a9c Junit 5: Run some tests which change static BYTE_ARRAY_MAX_OVERRIDE in isolation
Otherwise many other tests can become flaky if the value is set very low

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888792 13f79535-47bb-0310-9956-ffa450edef68
2021-04-15 14:25:44 +00:00
Dominik Stadler 930e576659 Gradle: Synchronize the code in the different build-scripts across the projects
No actual change in behavior expected
Mostly moved parts to make it easier to compare the build files with each other

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888791 13f79535-47bb-0310-9956-ffa450edef68
2021-04-15 14:25:38 +00:00
Andreas Beeker bb5d321b79 fix javadocs - remove @author tags (http://apache-poi.1045710.n5.nabble.com/Javadocs-clean-up-remove-author-tags-tp5737663.html)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888780 13f79535-47bb-0310-9956-ffa450edef68
2021-04-14 22:53:33 +00:00
Andreas Beeker 7c67bba960 :poi-ooxml - fix javadocs - link to dependent/external project javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888747 13f79535-47bb-0310-9956-ffa450edef68
2021-04-13 22:46:12 +00:00
Andreas Beeker 088d1dd197 :poi-scratchpad - fix javadocs - link to dependent/external project javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888746 13f79535-47bb-0310-9956-ffa450edef68
2021-04-13 21:37:33 +00:00
Andreas Beeker b6aee1ef6d 65206 - Migrate ant / maven to gradle build
compile / jar / test of mrJars
don't include ants build.xml anymore
rename directories to match project and maven artifact names
refactor artifacts - so each project has one artifact
replace static references in hssf/dev tests with junit5 constructs, which had problems in parallel tests
increase gradle heap to 4gb because of OOM - maybe less would also work

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888488 13f79535-47bb-0310-9956-ffa450edef68
2021-04-07 21:40:33 +00:00