Apache
/
poi
mirror of https://github.com/apache/poi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,080 Commits 29 Branches 101 Tags 246 MiB
Commit Graph

394 Commits

Author SHA1 Message Date
Yegor Kozlov 0ad8c53743 Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-18 15:54:50 +00:00
Greg Woolsey 50ffe0de32 Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference 
test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-11 17:33:00 +00:00
Greg Woolsey 8f26e2721d Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference 
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-06 00:15:51 +00:00
Greg Woolsey 8572d4b71c Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions 
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types

fixed, with unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-15 08:35:17 +00:00
Dominik Stadler d4ad2ffd53 Add test-case which shows that bug 55814 is fixed already by other changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 13:45:12 +00:00
PJ Fanning 06ea018e03 add test case for bug 61701 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-31 09:51:51 +00:00
Dominik Stadler 88b3286345 Add test which shows that bug 51262 is fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-09 19:35:32 +00:00
PJ Fanning 23ecb9a172 Numeric Array Formula and Matrix Function [from Bob95132] This closes #69 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-13 23:54:36 +00:00
Greg Woolsey d68912db25 Fixes bug #61468, caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-29 17:14:52 +00:00
Dominik Stadler 8f8f41a7c2 Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-19 16:31:45 +00:00
Greg Woolsey c73a4570f8 Bug 61431 - Conditional formatting evaluation ignores undefined cells 
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.

Added unit test based on previously failing file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-16 23:52:27 +00:00
Greg Woolsey 3cea90e7c4 Fix data validation value list evaluation 
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.

However, data validation list formulas explicitly are expected to return a 2D ValueEval.  This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.

This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.

There is room for discussion over how it is implemented, but this works for me.

Includes the failing workbook we had as a new unit test.

While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 22:19:58 +00:00
Tim Allison d320b2ea4a bug 61300 -- prevent really long (infinite?) loop on corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801989 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 20:47:40 +00:00
Tim Allison 5a9d05487d bug 61286/bug 61287 -- allow WriteProtectRecord to have 2 bytes, and allow for HeaderFooter to be empty. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801966 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 13:54:06 +00:00
Tim Allison 34cb860998 bug 61294 -- prevent infinite loop in IOUtils' skipFully. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801844 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 16:20:28 +00:00
PJ Fanning 6de159d232 [Bug-61281] guard against index out of bounds in XSSFExportToXml column mapping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801634 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-11 16:38:49 +00:00
Greg Woolsey 3e6d942b95 Add file that failed regression tests as a unit test. 
Adjust table style processing to allow for AlternateContent wrappers for table element style definitions.  


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799733 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 05:55:45 +00:00
Tim Allison 153821e443 bug 61045 -- allow for (and log!) extra bytes in FormatRecord. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 18:11:34 +00:00
Dominik Stadler eb417057c4 Don't try to clone a chart, this makes integration-tests work for a few more documents, also the one added via bug 56557 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799037 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-18 05:59:25 +00:00
Dominik Stadler 334a7b87b4 Add missing file for test for bug 56557 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798926 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-16 13:26:50 +00:00
Nick Burch 9907b69401 XSSFTable should format numeric/date cells when used as Column Header names as Excel does, see https://stackoverflow.com/questions/44407111/apache-poi-cant-format-filled-cells-as-numeric 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797914 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-07 12:39:41 +00:00
Greg Woolsey c844803b66 Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color 
teach XSSFColor and most things that create instances about indexed colors.

Null is a valid value for IndexedColorMap instances - the existing built-in default colors are used.

Whenever a workbook style is accessible in the call hierarchy its color mappings are passed down now.

Thanks for the unit test in the issue, it now passes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796359 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-26 23:14:48 +00:00
Dominik Stadler 05a6cf3263 Bug 61063: Add a RefListEval to handle UnionPtg and implement it for Rank(), may be missing for other functions where ArrayEval is currently handled 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795963 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-23 21:13:02 +00:00
Andreas Beeker 965860b116 removed invalid test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795122 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-14 22:24:07 +00:00
Greg Woolsey 674d6ac2c9 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68 2017-05-12 18:01:32 +00:00
Greg Woolsey 530dd0e083 61060 - teach DataFormatter about conditional formatting rules with number formats 
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-05 17:44:58 +00:00
Javen O'Neal acd2fa8de1 bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets. 
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-29 17:27:17 +00:00
Greg Woolsey f60ca16829 Issue #60971, handle formula chart titles 
implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-11 20:27:23 +00:00
Andreas Beeker 1f113bc64a Fix AIOOBE while extracting hssf pictures which are externally linked 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-10 21:43:22 +00:00
Dominik Stadler 84e0fc5e42 Test for another type of xml-bomb 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-06 21:50:03 +00:00
Dominik Stadler 2254ad2ac3 Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-06 21:49:53 +00:00
Tim Allison 8366c8737a 60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-20 20:47:15 +00:00
Dominik Stadler 2f2c994410 60823: DGET function, correct behavior with multiple result entries but only one non-blank 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-19 20:29:55 +00:00
Tim Allison e6ff9b74f4 60826 -- add initial support for streaming reading of xlsb files. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-16 18:37:13 +00:00
Greg Woolsey 03d9c873df Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822. 
Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786954 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-14 21:40:32 +00:00
Dominik Stadler 38f23e4c0e Add tests from bug 45353 to show that this now works fine 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-10 20:14:00 +00:00
Tim Allison 396cd26693 51519 -- allow users to ignore or include the <rPh> (phonetic run) element in the ReadOnlySharedStringsTable used in the SAX/streaming xlsx reader. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785965 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-08 13:41:07 +00:00
Greg Woolsey 161facc089 Bug #56822 fix COUNTIFS() 
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:05:49 +00:00
Greg Woolsey 99390a5759 Add evaluation of data validation rules and conditional formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-13 22:51:30 +00:00
Javen O'Neal 2a0c4cdde4 bug 59983: correctly update shared formulas when shifting rows. Thanks to Luca Martini for the initial failing unit test with test file and Chiara Marcheschi for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782111 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 07:20:31 +00:00
Tim Allison 5750c85be9 Bug 60570 - Add rudimentary EMF read-only capability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-19 16:22:29 +00:00
Javen O'Neal bdc2e2fe04 bug 60260: parse unicode sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-12 10:39:26 +00:00
Andreas Beeker 6a44282608 #60519 - Extractor for *SSF embeddings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:50:47 +00:00
Dominik Stadler 2d7f4100bd Bug 60512: Add missing XSSFRelation.CUSTOM_PROPERTY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776606 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 16:55:19 +00:00
Dominik Stadler 7cc4c90b70 Bug 59026: Add two null-checks to make exporting XLSX to XML work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767057 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-28 18:24:04 +00:00
Dominik Stadler 8b69cfda06 Bug 60289: Fix handling of unicode escapes with lowercase hex-chars 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766065 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-21 16:31:51 +00:00
Tim Allison 489bebba0e BUG-60285 avoid NPE if missing relationship id 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765861 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 18:45:03 +00:00
Tim Allison 126c6c93a8 BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 15:13:16 +00:00
Tim Allison 8e3a70d4b1 BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 18:24:39 +00:00
Tim Allison 1ec787c356 BUG 59830 -- incorrect reading of unicode stream name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 15:47:38 +00:00