Commit Graph

7859 Commits

Author SHA1 Message Date
Dominik Stadler 88b9e48287 Add reproducer for bug 60355
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:13:57 +00:00
Dominik Stadler 32c43c068c IDE and JavaDoc fixes, move/remove some unfixed tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:05 +00:00
Dominik Stadler a1a1797299 Add one more test for bug 62828 and fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:30:44 +00:00
Greg Woolsey 8b69fcc642 Bug #60977 writing XSSF with custom properties twice corrupts output
turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 18:20:03 +00:00
Yegor Kozlov b85437ee88 Bug 63054: improved evaluation of array formulas with error in arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 12:54:39 +00:00
Vladislav Galas f64aef7417 unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 19:10:19 +00:00
Yegor Kozlov 81033fbad0 Bug 62904: Support array arguments in IF and logical IS*** functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 14:34:19 +00:00
PJ Fanning 0849bbc614 throw IllegalArgumnetException if null directory specified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 16:07:53 +00:00
Vladislav Galas 6d87e36227 Fixed build (explicitly specified charset for new String(byte[]))
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 14:25:11 +00:00
Vladislav Galas 1f9b858ae5 Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 10:10:30 +00:00
Vladislav Galas 8600f64890 Improved test coverage for *Cell classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 09:17:48 +00:00
Vladislav Galas 3b8055baa0 Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-03 00:08:52 +00:00
Vladislav Galas e501d4015d Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 22:08:38 +00:00
Vladislav Galas 3aec436a34 Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 20:45:52 +00:00
Dominik Stadler 59a7919af6 Add missing revert() in OPCPackage to close Zip-streams always
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:58 +00:00
Dominik Stadler fa24471916 Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:51 +00:00
PJ Fanning bfecad39e5 fix since annotation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 14:27:32 +00:00
Andreas Beeker d71a65c388 #63047 - Make POILogger subclassable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 12:07:37 +00:00
Dominik Stadler dfb613a059 Adjust test for bug 60460 to also run fine on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 09:05:05 +00:00
Dominik Stadler 85d6f81076 Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:40 +00:00
Dominik Stadler faf53dcdb4 IDE and JavaDoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:29 +00:00
Dominik Stadler b416d97de5 Bug 60845: Apply patch and adjust tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 10:07:52 +00:00
Dominik Stadler d942e2042d IDE and JavaDoc fixes, make base test classes abstract
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 10:07:42 +00:00
Andreas Beeker c039da1b94 #63028 - Provide font embedding for slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:43:31 +00:00
Andreas Beeker a78bd71fc1 Add Enum method to help identifying unknown records with POI-Visualizer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:57 +00:00
Andreas Beeker 83d4d4169f Fix Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849896 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:44 +00:00
Andreas Beeker ab3f2a0e50 Zero out garbage bytes in FontEntityAtom
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849895 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:31 +00:00
Dominik Stadler 22bdfcf399 Run Cell-tests on HSSF as well and make handling of null-values consistent across implementations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849881 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:53:13 +00:00
Dominik Stadler 2b8200f7d7 Bug 61532: Fix setting values/types during formula evaluation for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:53:03 +00:00
Dominik Stadler 3c99c70acf Add test which verifies that bug 61605 is already fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849878 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:52:46 +00:00
Dominik Stadler 825418d520 Adjust test to not require src/documentation to be available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849837 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 11:17:52 +00:00
Dominik Stadler a6e9421d18 Adjust/enhance tests for bug 62275 some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849836 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 11:17:46 +00:00
Dominik Stadler d3dc9b0338 Bug 62629: Allow to handle files with invalid content types for pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:48 +00:00
Dominik Stadler 7de8c2eaec Re-instate two dev-tools that we lost in some refactoring,
at least OOXMLPrettyPrint is still very useful for comparing ooxml-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:38 +00:00
Dominik Stadler ae3d6944db IDE and JavaDoc fixes, close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68
2018-12-27 20:51:31 +00:00
Dominik Stadler c218c3cbc4 Add some simple coverage of HSLF-Dev-Tools
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:32 +00:00
Dominik Stadler 5b62dcd379 Bug 62839: Adjust MathX.floor() to handle negative values the same
way as Excel/LibreOffice

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849764 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:17 +00:00
Dominik Stadler 6f2f283db8 Fix various IDE warnings and some JavaDoc adjustments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:10 +00:00
Dominik Stadler d40eb6f37f Fix incorrect constant for pict-files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:56 +00:00
Dominik Stadler 235f3e059c Remove unnecesssary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:50 +00:00
Dominik Stadler f6eab84243 Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:35 +00:00
Dominik Stadler accfb5a678 JavaDoc fixes/additions and some IDE warnings removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849718 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 10:00:21 +00:00
Dominik Stadler 49f4ad6aba Bug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849717 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 10:00:07 +00:00
Dominik Stadler 19884d0ca3 Code-style: Unify how arrays are specified from C-style to normal Java-style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 09:59:58 +00:00
Andreas Beeker 6486fb7c2d fix old xerces errors because of not available disallow-doctype parser feature
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849336 13f79535-47bb-0310-9956-ffa450edef68
2018-12-19 19:14:55 +00:00
Dominik Stadler 4199a2f0a3 Rework test somewhat and enable logger to better indicate if the test is
failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68
2018-12-19 10:22:01 +00:00
Andreas Beeker 6c5a2de640 #62886 - Regression extracting text from corrupted docx files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849252 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:55:58 +00:00
PJ Fanning 5344049a98 fix index check in HemfDraw
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:26:49 +00:00
Andreas Beeker 422d3a75f9 #63017 - Remove rows from a XSLFTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849248 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:13:59 +00:00
Andreas Beeker 9eea29da5b #63017 - Remove rows from a XSLFTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849244 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 22:52:36 +00:00