PJ Fanning
913d6bc086
use codepoint iterator in a few places
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 01:07:24 +00:00
PJ Fanning
acc7b356ee
add forbidden api checks for non-Locale toLowerCase and toUpperCase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 22:10:48 +00:00
PJ Fanning
936f29af69
add forbidden api checks for non-Locale toLowerCase and toUpperCase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:33:51 +00:00
PJ Fanning
d0ddfa9402
remove more uses of Character.toUpperCase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:11:07 +00:00
Dominik Stadler
731d089005
Try to set java.io.tmpdir for tests to avoid the strange permission errors that we see in CI-builds
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 17:32:48 +00:00
Dominik Stadler
4bc4e1f4e9
Ensure that no old version of commons-codec is lingering around and causes hard to find build errors locally
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:29:01 +00:00
Dominik Stadler
dcd40982f3
Try if using a local temporary directory avoids the permission errors in unit tests in the Maven runs:
...
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:28:07 +00:00
PJ Fanning
bb40ff4fd3
[bug-61792] basic test
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:58:13 +00:00
PJ Fanning
2d8c9cbc9a
[bug-61792] some changes to avoid iterating over chars of Strings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:35:36 +00:00
PJ Fanning
18f87a1c18
upgrade to commons-codec 1.11
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 20:46:16 +00:00
Dominik Stadler
a872c3495e
Handle case where the JaCoCo zip file is available, but the extracted files are missing, not sure how that happens, but we see it on some CI machines...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 19:53:44 +00:00
Mark Murphy
9d0010088b
javadocs and Quick page improvements for XSSF Header/Footer
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 01:35:07 +00:00
Greg Woolsey
83a1430887
add Locale awareness to case insensitive conditional comparisons in formatting rule logic. Needed anyway, and removes forbidden API issues.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68
2017-11-16 01:22:52 +00:00
Greg Woolsey
8caf25f718
ignore a unit test that snuck in. It was created to investigate an open bug report. It fails, as expected, which broke the build.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 16:34:14 +00:00
Greg Woolsey
8572d4b71c
Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions
...
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types
fixed, with unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 08:35:17 +00:00
Dominik Stadler
59d8adf5b8
Fix setting a font-color if no previous color is defined for the font
...
Add unit-test to verify this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:46:04 +00:00
Dominik Stadler
a08aa73916
Fix tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:44:50 +00:00
Javen O'Neal
6f44566f0a
bug 61745: remove String#toString() usage found by forbidden apis check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 00:51:41 +00:00
Javen O'Neal
d96f9ce495
bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 21:48:41 +00:00
Javen O'Neal
622b84c633
+svn:eol-style native *.java
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:52:38 +00:00
Javen O'Neal
defe020128
github #81 : sheet names are case insensitive
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:14:43 +00:00
Javen O'Neal
4cf3b2bee2
XWPFTable#getRows() should return an unmodifiable list unless the method can correctly update xmlbeans in response to modifying the list
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:34:52 +00:00
Javen O'Neal
1938207e59
make tableRows final; initialize where defined rather than in constructor.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:32:43 +00:00
Javen O'Neal
145b69b1c6
deprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since 2008 when this class was first authored. (Unrelated: This closes #82 on github).
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:30:42 +00:00
Mark Murphy
25c25ea8ac
Surface XSSF Header/Footer Attributes (60887)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 13f79535-47bb-0310-9956-ffa450edef68
2017-11-11 14:18:24 +00:00
Dominik Stadler
76d11ac37e
Some JavaDoc adjustments, typos, IntelliJ warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
2017-11-08 14:59:08 +00:00
Javen O'Neal
888a08b98d
bug 61730: remove asSet function from unit test
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:26:48 +00:00
Javen O'Neal
8a6d6c8cba
bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:21:24 +00:00
Javen O'Neal
9d8df29cf1
bug 61730: add javadoc
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 01:54:25 +00:00
Javen O'Neal
cbb82add8f
bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 00:29:09 +00:00
Javen O'Neal
ca53a08a90
bug 61727: make TestCellRangeUtil unit tests more explicit
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 22:19:06 +00:00
Dominik Stadler
0577afdff8
Enhance unit-test to Verify that bug 58785 is already via via some other change
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814440 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 20:26:32 +00:00
Javen O'Neal
471e711025
bug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for the patch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814432 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 19:51:41 +00:00
Dominik Stadler
d73e72d060
Adjust some tests to properly close resources
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814374 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 20:33:35 +00:00
Dominik Stadler
ce77cd6270
Bug #57517 : Fix various things in HSSFOptimiser to make many more cases work fine: Column styles, row styles, user defined styles, ...
...
Also call optimise in integration-tests and handle some cases of invalid content in files.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814373 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 20:33:28 +00:00
Dominik Stadler
d4ad2ffd53
Add test-case which shows that bug 55814 is fixed already by other changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:12 +00:00
Dominik Stadler
b7f7ff71b4
Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods
...
Adjust tests slighlty, close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:04 +00:00
Javen O'Neal
3e1ee0afeb
bug 61474, github #81 : add ShiftMode#ColumnCopy for FormulaShifter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814268 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 10:11:20 +00:00
Javen O'Neal
11b5e066e7
bug 61474, github #81 : add shiftMergedRegions to BaseRowColShifter interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814264 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:32:05 +00:00
Javen O'Neal
dcd3993146
bug 61474, github #81 : bump visibility of abstract methods in BaseRowColShifter abstract class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814262 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:17:09 +00:00
Javen O'Neal
37ee513fc9
bug 61474, github #81 : pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:07:32 +00:00
Javen O'Neal
890d6e70e6
bug 61474, github #81 : remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 08:54:20 +00:00
Javen O'Neal
0f14370c21
bug 61474, github #81 : implement updateConditionalFormatting for ColumnShifter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:58:41 +00:00
Javen O'Neal
2d7e44db5a
bug 61474, github #81 : implement updateNamedRanges for ColumnShifter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:42:33 +00:00
Javen O'Neal
9f03e0bc08
bug 61474, github #81 : fix ColumnShifter#removalNeeded to use columns instead of rows
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:29:53 +00:00
Javen O'Neal
6ceee17033
bug 61474, github #81 : add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:17:44 +00:00
Javen O'Neal
25b94af3bb
bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 05:48:18 +00:00
Javen O'Neal
69408a69e5
bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 05:29:52 +00:00
Javen O'Neal
31daa180c6
github-81: extract routines in HSSFRow#shiftRows
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 04:29:45 +00:00
Javen O'Neal
4e744a5739
rename ambiguous variable name shifter -> formulaShifter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 02:57:01 +00:00