Commit Graph

391 Commits

Author SHA1 Message Date
Dominik Stadler 9c288abff0 Bug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run with unsynchronized XmlBeans
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819417 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 10:53:40 +00:00
PJ Fanning 819eac1f82 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:23:52 +00:00
Greg Woolsey f90801d366 Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:30:04 +00:00
PJ Fanning 37a349dc19 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 22:31:59 +00:00
Alain Béarez 3b8f806850 XDDF usermodel for Charts closes #68 on GitHub
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 14:03:01 +00:00
Andreas Beeker cbfb179254 #61809 - Infinite loop in SectionIDMap.get() and .put()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68
2017-11-24 01:02:20 +00:00
PJ Fanning 61cad2865e use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 19:28:36 +00:00
PJ Fanning e52d29df16 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:03:33 +00:00
PJ Fanning 2cd8c7bc65 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:45:35 +00:00
Javen O'Neal 2a0aac8ea5 cleanup for r1812470: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:40:56 +00:00
Javen O'Neal 59277965a2 convert "".equals(string) to string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:22:51 +00:00
Javen O'Neal 117f08049b string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:45:53 +00:00
PJ Fanning e4fc2670d5 Make public static members final [thanks to Kui Liu]. This close #78.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:50:58 +00:00
Dominik Stadler 8f324b99fa Fix some Sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 15:10:40 +00:00
Dominik Stadler ee993f163d Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 14:45:14 +00:00
Dominik Stadler 4b5c908180 Fix compiling Examples after adding new interface-method, fix compiler warnings and adjust some broken Javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809388 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:26:27 +00:00
Dominik Stadler c05129144f More IntelliJ warnings fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 07:38:01 +00:00
Dominik Stadler ad5232f8f8 Adjust many examples for Java 8: try-with-resource, multi-catch and other code cleanup.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809354 13f79535-47bb-0310-9956-ffa450edef68
2017-09-22 21:16:09 +00:00
Tim Allison 53b55eb4c3 Bug 61349 -- add more sanity checks when allocating byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
2017-09-21 14:52:59 +00:00
PJ Fanning e95a5295e8 Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808946 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 21:21:37 +00:00
Javen O'Neal 7d8f31d4a4 bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808817 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:27:40 +00:00
Javen O'Neal af6b013697 bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808816 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:26:20 +00:00
PJ Fanning 38650a6d2f use non-deprecated versions of getCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:31:55 +00:00
PJ Fanning 1e8ecbec04 change HyperLink getType to return HyperlinkType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 15:55:48 +00:00
PJ Fanning 6382370552 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:58:55 +00:00
PJ Fanning e3ddb77bc1 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:38:07 +00:00
Dominik Stadler 467053d91c Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:23 +00:00
Dominik Stadler 399381da8d Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler 0cfa1ede4c Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler 32370cfd1c Remove unnecessary initialization of members
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:22:59 +00:00
PJ Fanning deb0aca6ac remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:44:47 +00:00
Nick Burch 299f33b8d8 Add an example of trying multiple passwords against an OOXML file. More a demo than anything, GPU enabled tools are much faster!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804667 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 12:43:16 +00:00
PJ Fanning 52d3ea57f4 javadoc: replace invalid self enclosing elements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 08:24:24 +00:00
PJ Fanning 0dff17384f Remove more deprecated code (BorderFormatting constants)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800385 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 12:18:13 +00:00
PJ Fanning 95d9bec68b Remove more deprecated code (especially from Spreadsheet Cell classes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 11:48:23 +00:00
PJ Fanning 48643ad880 remove some unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:55:35 +00:00
PJ Fanning 0b758698a5 Remove old XSSFPaswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:10:32 +00:00
PJ Fanning 5d4a4a7f28 Ensure SpreadsheetVersion is set for AreaReferences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
PJ Fanning b68b916d08 Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
Dominik Stadler 902124a5fd Move one testcase with incorrect source location
remove some junit dependencies in example-code
build: do not pass junit-jar to normal compile targets to avoid introducing it as dependency again 
Reformat code, fix warnings, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798202 13f79535-47bb-0310-9956-ffa450edef68
2017-06-09 12:49:01 +00:00
Nick Burch e9a9259a30 Update the CreateTable example to reduce the use of the raw CT classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797923 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 13:35:20 +00:00
Andreas Beeker 89dbc5c79b SonarQube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796962 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 00:31:53 +00:00
Andreas Beeker 98b10cf684 #52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Andreas Beeker 3c69708b20 test integration fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793733 13f79535-47bb-0310-9956-ffa450edef68
2017-05-04 01:13:48 +00:00
Andreas Beeker 1481ca75a1 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 22:16:26 +00:00
Andreas Beeker b4e44585b6 HPSF: Add CopyCompare to IntegrationTests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:29:19 +00:00
Greg Woolsey ba17ef1448 Add conditional formatting evaluation example code and output results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792102 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 18:05:50 +00:00
Dominik Stadler 5ca0b239bf Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Dominik Stadler c88569baf1 Fix some Sonar issues in sample "HSSFReadWrite"
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 14:09:27 +00:00
Javen O'Neal 9330f2ac74 bug 59893: commit the changes from attachment 34068 that were unrelated to available()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 08:39:05 +00:00