Commit Graph

9394 Commits

Author SHA1 Message Date
Javen O'Neal cb28546f50 github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 10:17:38 +00:00
PJ Fanning 06ea018e03 add test case for bug 61701
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:51:51 +00:00
PJ Fanning d6f261473d add test case for bug 61701 and use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:48:23 +00:00
Javen O'Neal b3cb1211a4 github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:38:03 +00:00
Javen O'Neal b4ee3da44f consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 01:45:03 +00:00
Javen O'Neal 179fa31242 bump the Eclipse compile source to Java 1.8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813840 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 01:08:43 +00:00
Javen O'Neal 98c6f2ba1f bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68
2017-10-26 18:10:09 +00:00
Javen O'Neal a2f30cd63a remove test-hssf ant target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813351 13f79535-47bb-0310-9956-ffa450edef68
2017-10-25 20:19:23 +00:00
Javen O'Neal fa8314e8dc remove test-ss and test-ooxml-ss ant targets, as these were causing problems with the build/ooxml-testokfile.txt being written, requiring test-ooxml to be rerun on subsequent ant calls even if had previously completed successfully and not modifications to the ooxml source had been made.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813342 13f79535-47bb-0310-9956-ffa450edef68
2017-10-25 18:59:54 +00:00
Javen O'Neal 5eaf1d582d bug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630 comment 15, attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813332 13f79535-47bb-0310-9956-ffa450edef68
2017-10-25 18:19:12 +00:00
Javen O'Neal 91fbf5db4f bug 61630: revert r1813240, which failed the integration test with org.apache.poi.stress.XSSFFileHandler on test-data/spreadsheet/59025.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813243 13f79535-47bb-0310-9956-ffa450edef68
2017-10-24 23:44:21 +00:00
Javen O'Neal 4e782652dc bug 61630: further XSSFExportToXML performance improvements from Daniel (comment 9, bug 61630 attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813240 13f79535-47bb-0310-9956-ffa450edef68
2017-10-24 23:00:12 +00:00
PJ Fanning 7dce661861 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 21:17:49 +00:00
PJ Fanning e2e3b52013 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813092 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:39:27 +00:00
PJ Fanning 707f266eef Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813085 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:27:47 +00:00
PJ Fanning 5ecf32781d Introduce new BorderFormatting methods to expose border styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812917 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:53:42 +00:00
PJ Fanning e52d29df16 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:03:33 +00:00
PJ Fanning 2cd8c7bc65 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:45:35 +00:00
PJ Fanning dffa1ccd9c Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:07:14 +00:00
Dominik Stadler 63bf8e8ba5 Add getter/setter for ReadingOrder to XSSF, closes issue #73
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812558 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 18:26:41 +00:00
Nick Burch 112a7c1480 Bump up the Eclipse JVM version to 8 to match Ant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812557 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 18:21:29 +00:00
Nick Burch 72ad57fe43 Bump up the Eclipse JVM version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812556 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 18:16:48 +00:00
Javen O'Neal 9a27ae194f bug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812546 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 16:04:06 +00:00
Javen O'Neal 2a0aac8ea5 cleanup for r1812470: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:40:56 +00:00
Javen O'Neal 3a7e3846d5 fix compile error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:40:05 +00:00
Javen O'Neal fb854a6f34 cleanup for r1812475: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:29:56 +00:00
Javen O'Neal fac34b6740 cleanup for r1812476: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:08:43 +00:00
Javen O'Neal 2ef3af567c replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:41:42 +00:00
Javen O'Neal b8de369f2c prefer literal.equals(variable) over variable.equals(literal)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:41:25 +00:00
Javen O'Neal 59277965a2 convert "".equals(string) to string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:22:51 +00:00
Javen O'Neal 8300528aad simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:10:36 +00:00
Javen O'Neal 129db08b91 fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:47:25 +00:00
Javen O'Neal 117f08049b string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:45:53 +00:00
Javen O'Neal f786b16f7f for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:33:07 +00:00
Javen O'Neal 63b3a4e491 IntelliJ: simplify boolean logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 07:43:41 +00:00
Javen O'Neal b722b42139 remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 07:10:25 +00:00
Javen O'Neal 44b4a6548b ignore gradle/, gradlew, and gradlew.bat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812351 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 06:13:09 +00:00
Dustin Spicuzza c2db4ae5fb Bug 61584: Fix XDGFPage variable typo causing crash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 01:35:31 +00:00
Javen O'Neal a66725fa94 github-79: add String.toString() to forbidden API's
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 01:34:13 +00:00
PJ Fanning e4fc2670d5 Make public static members final [thanks to Kui Liu]. This close #78.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:50:58 +00:00
PJ Fanning 0b5a0a077f Remove unnecessary toString calls [thanks to Kui Liu]. This close #79.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:34:10 +00:00
PJ Fanning 67e6ad9c47 Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:25:33 +00:00
Dominik Stadler 1b171e8642 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 09:40:22 +00:00
Dominik Stadler 9d064f746e Fix aparent copy/paste error in XSSFBorderFormatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:32:13 +00:00
Dominik Stadler acb78e74c4 Bug 58068: Add a method to pass the actual Color to StylesTable.findFont().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:32:01 +00:00
Dominik Stadler 2dc64ebbcc adjust tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:31:34 +00:00
Dominik Stadler d9a818dc22 Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 05:32:05 +00:00
Dominik Stadler b4fd20dafa Add more output to the pre-check to help in analysis some strange build-failures in CI, e.g. INFRA-15244
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811597 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 19:35:43 +00:00
Dominik Stadler ceba27fa2c Fix target compile-ooxml-ss, it needs the crypt-code now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811596 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 19:35:39 +00:00
Dominik Stadler 88b3286345 Add test which shows that bug 51262 is fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 19:35:32 +00:00