Commit Graph

1969 Commits

Author SHA1 Message Date
Tim Allison cf76af521d Bug 63330 -- use skipfully instead of hoping skip() works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857277 13f79535-47bb-0310-9956-ffa450edef68
2019-04-10 19:11:02 +00:00
Andreas Beeker 3a6c933020 Remove invalid import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857141 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 21:09:55 +00:00
Tim Allison a5278ccad9 bug 63327 allow retrieval of wmf data embedded in emf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857136 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:53:21 +00:00
Tim Allison ad11a5d363 Bug 63323 -- improve handling of multibyte characters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857135 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:51:16 +00:00
Dominik Stadler 6119c0ecec Fix a flaky test, it seems if the document is not closed, the automatic
closing of file-handles interferes with subsequent tests, by closing the
document this flakiness seems to be gone.

Flakiness could be reproduced locally by continuously running test with IntelliJ
"run until failure" run-config option and after aprox. 17,000 test-executions!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857068 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:47 +00:00
PJ Fanning 895b251367 some javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
Dominik Stadler bb73949f7b Switch to parameterized test and add some more information to try to find
out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:33 +00:00
Dominik Stadler 40f8d119c7 Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning 126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler 6a93b3a9ed Close file-handles for slideshows also when construction fails or when dual-storage is used
Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:24 +00:00
Dominik Stadler b7862cfe45 Add reproducing test-case for a bug we found newly introduced in JDK 12-ea+28
and fixed again in JDK 12-ea+29

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852281 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:58:08 +00:00
Dominik Stadler db14c353fc Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Andreas Beeker c039da1b94 #63028 - Provide font embedding for slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:43:31 +00:00
Andreas Beeker a78bd71fc1 Add Enum method to help identifying unknown records with POI-Visualizer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 23:42:57 +00:00
Dominik Stadler c218c3cbc4 Add some simple coverage of HSLF-Dev-Tools
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:32 +00:00
Dominik Stadler 6f2f283db8 Fix various IDE warnings and some JavaDoc adjustments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:28:10 +00:00
Dominik Stadler f6eab84243 Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 13:27:35 +00:00
Dominik Stadler 19884d0ca3 Code-style: Unify how arrays are specified from C-style to normal Java-style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
2018-12-25 09:59:58 +00:00
PJ Fanning 5344049a98 fix index check in HemfDraw
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 23:26:49 +00:00
PJ Fanning 1aeadee8c4 lgtm issues: potential index out of bounds exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849127 13f79535-47bb-0310-9956-ffa450edef68
2018-12-17 20:41:38 +00:00
Andreas Beeker 458b9e3aed fix junit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849047 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 21:25:57 +00:00
PJ Fanning 8e37e00054 fix findbugs issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849044 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 20:07:23 +00:00
Andreas Beeker fce876b4ef merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1848906 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 00:44:40 +00:00
Andreas Beeker 11cbe34ee5 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1847209 13f79535-47bb-0310-9956-ffa450edef68
2018-11-23 02:08:28 +00:00
Andreas Beeker 30d4934edc merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1847069 13f79535-47bb-0310-9956-ffa450edef68
2018-11-20 22:24:26 +00:00
Andreas Beeker fa5e01e391 Remove commented out System.out calls / Move DummyGraphics2d to testcase area, as it's not used by production code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846946 13f79535-47bb-0310-9956-ffa450edef68
2018-11-19 20:48:10 +00:00
Andreas Beeker 655c24dcb5 Remove/Minimize references to Scratchpad module from other modules
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846931 13f79535-47bb-0310-9956-ffa450edef68
2018-11-19 18:00:42 +00:00
Andreas Beeker 42af181065 #62921 - Provide OOXMLLite alternative for Java 12+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846809 13f79535-47bb-0310-9956-ffa450edef68
2018-11-18 00:01:40 +00:00
Andreas Beeker 940daf0d92 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1846472 13f79535-47bb-0310-9956-ffa450edef68
2018-11-12 23:21:18 +00:00
Andreas Beeker 0e68ef5f84 merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1845617 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 18:35:34 +00:00
Andreas Beeker 8b3974f945 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1845612 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 18:01:50 +00:00
Andreas Beeker acfed6fb29 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1845496 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 16:27:59 +00:00
Andreas Beeker 0a84f6881f #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1845291 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 22:35:45 +00:00
Andreas Beeker 29587e78df #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1844931 13f79535-47bb-0310-9956-ffa450edef68
2018-10-27 00:51:19 +00:00
Dominik Stadler 54cb281413 Set NOSONAR and reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844876 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:19 +00:00
Andreas Beeker 11e4643e5b #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1844524 13f79535-47bb-0310-9956-ffa450edef68
2018-10-21 22:42:03 +00:00
Andreas Beeker 82f118a7d7 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1844522 13f79535-47bb-0310-9956-ffa450edef68
2018-10-21 20:49:03 +00:00
Andreas Beeker 17cc3bab08 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1844380 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 22:53:33 +00:00
Andreas Beeker f927e551cc #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1843342 13f79535-47bb-0310-9956-ffa450edef68
2018-10-09 20:51:14 +00:00
Andreas Beeker 1f93a366f5 merge trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1843032 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 19:33:27 +00:00
Andreas Beeker 2b12e29c92 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1843025 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 18:23:59 +00:00
PJ Fanning 874687c490 lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842302 13f79535-47bb-0310-9956-ffa450edef68
2018-09-29 09:33:52 +00:00
Andreas Beeker 93b7cb0bc7 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1842059 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 22:51:03 +00:00
Andreas Beeker 312fde5bd0 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1842056 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 22:16:33 +00:00
Andreas Beeker b3fc9f4957 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1841897 13f79535-47bb-0310-9956-ffa450edef68
2018-09-24 23:55:52 +00:00
Andreas Beeker 5073f22fce #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1841712 13f79535-47bb-0310-9956-ffa450edef68
2018-09-23 01:58:40 +00:00
Andreas Beeker e6e1f622d8 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1841134 13f79535-47bb-0310-9956-ffa450edef68
2018-09-17 19:25:40 +00:00
Andreas Beeker a6a55a6ca5 #60656 - Support export file that contains emf and render it correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hemf@1840956 13f79535-47bb-0310-9956-ffa450edef68
2018-09-14 21:37:37 +00:00
Andreas Beeker e331ecb3f6 sonar fixes - blocker
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839745 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 11:56:18 +00:00
Andreas Beeker 8ebfec4808 #62649 - Remove OPOIFS* / rename NPOIFS* to POIFS*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839709 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 00:25:50 +00:00
Andreas Beeker 96d5fab483 #62649 - Remove OPOIFS
Fix HPSF UTF-8 encoding error with Bug52311.doc while refactoring CopyCompare/EntryUtils

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839201 13f79535-47bb-0310-9956-ffa450edef68
2018-08-26 11:55:00 +00:00
Tim Allison e55cbeb987 bug 62597 -- bump max record length for ExOleObjStg based on regression corpus
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1838047 13f79535-47bb-0310-9956-ffa450edef68
2018-08-14 19:29:03 +00:00
Tim Allison 9ae7bdd2cd bug 62591 -- revert to ignoring place holders even if they contain metroblobs in ppt
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837742 13f79535-47bb-0310-9956-ffa450edef68
2018-08-09 15:50:34 +00:00
Tim Allison 657ad82438 bug 62597 -- bump max record sizes up based on new failures in regression set. I typically bumped to 2x the max found in regression set.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837387 13f79535-47bb-0310-9956-ffa450edef68
2018-08-03 17:14:34 +00:00
Andreas Beeker 555923c40b #62564 - replace Thread.currentThread().getContextClassLoader() with getClass().getClassLoader()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836590 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 22:57:18 +00:00
Dominik Stadler 11f141e0d4 Somehow the WordToHtml converter now produces slightly more than 6000 chars before the <table element for me
As there is no description why this substring was in the test in the first place I removed it to make
the test less flaky.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834621 13f79535-47bb-0310-9956-ffa450edef68
2018-06-28 15:47:16 +00:00
Andreas Beeker 3077257645 javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832978 13f79535-47bb-0310-9956-ffa450edef68
2018-06-05 22:44:18 +00:00
Andreas Beeker bfe3e6a976 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832748 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 21:28:06 +00:00
Andreas Beeker 9eb3789509 sonar fixes and
disable closing of outputstream in ZipPackage.saveImpl() - see https://stackoverflow.com/questions/50646538/stream-close-exception-occures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832746 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 20:29:35 +00:00
Andreas Beeker 87f7eac9c5 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832735 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 13:01:14 +00:00
Andreas Beeker cdb3de9dc0 #62355 - unsplit packages - 3 - only imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832360 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:13:31 +00:00
Andreas Beeker 0c35761317 #62355 - unsplit packages - 2 - modified classes (not only imports)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832359 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:01:33 +00:00
Andreas Beeker 6ce329eca4 #62355 - unsplit packages - 1 - moved classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832358 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 21:59:18 +00:00
Andreas Beeker d136eaa778 sonar fixes - null dereference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831992 13f79535-47bb-0310-9956-ffa450edef68
2018-05-21 23:17:57 +00:00
Andreas Beeker 82774d4dc2 #62051 - Two shapes have the same shapeId within the same slide.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831947 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 22:00:14 +00:00
Andreas Beeker 4a3ea104fe #62037 - SlideNames should not be null but have a default as if accessed by VBA
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831745 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 21:57:49 +00:00
Andreas Beeker 28e662c5a7 Cleanup Biff8EncryptionKey usage and use HPSF constants instead of duplicated strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830705 13f79535-47bb-0310-9956-ffa450edef68
2018-05-01 18:22:00 +00:00
Andreas Beeker 51f5eaf5e5 disable ImageIO cache - probably need to set it in every test class or disable it in the beginning of all tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830520 13f79535-47bb-0310-9956-ffa450edef68
2018-04-29 21:12:06 +00:00
Andreas Beeker f94245e9d8 #59893 - Forbid calls to InputStream.available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830400 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 21:38:19 +00:00
Andreas Beeker a276d5d3f6 #62319 - handle slide layouts in extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829677 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 20:00:46 +00:00
Andreas Beeker 7ddef62cc4 #61459 - HSLFShape.getShapeName() returns name of shapeType and not the shape name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829656 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 13:45:18 +00:00
Andreas Beeker e816131759 #62319 - Decommission XSLF-/PowerPointExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829653 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 12:52:59 +00:00
Andreas Beeker f395630abd Bug 62092 - Text not extracted from grouped text shapes in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829453 13f79535-47bb-0310-9956-ffa450edef68
2018-04-18 15:02:02 +00:00
Dominik Stadler 2444a5396d Close resources in tests and in case of Exceptions and use try-with-resources. Close the socket-connection during encrpyting/decrypting as soon as it is not needed any more.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828178 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:16:01 +00:00
Dominik Stadler 7d8da8ea59 Bug 61267: detect Word v2 files and report that they are not supported in Apache POI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828176 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:15:42 +00:00
PJ Fanning fa0b3d59b3 [github-103] take latest changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828142 13f79535-47bb-0310-9956-ffa450edef68
2018-04-01 15:37:14 +00:00
PJ Fanning 637d53cae2 add missing license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827177 13f79535-47bb-0310-9956-ffa450edef68
2018-03-19 09:22:46 +00:00
PJ Fanning 76c3f72e5d [github-103] hsmf: support writing properties. Thanks to Dominik Hölzl. This closes #103
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827173 13f79535-47bb-0310-9956-ffa450edef68
2018-03-19 09:10:38 +00:00
Andreas Beeker 9968e86b14 #62096 - Add support for tabstops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823893 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 20:39:18 +00:00
Andreas Beeker 5f71c80131 FindBugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823892 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 20:35:11 +00:00
Dominik Stadler dc621da629 Update some tests and IntelliJ warnings
Ignore disabled test instead of not listing it in the test-report at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819768 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:38:58 +00:00
PJ Fanning f285780483 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819762 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 12:13:53 +00:00
PJ Fanning 4c4bddf5c7 Bug-61947 add back deprecated methods (removed by accident)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819761 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:54:01 +00:00
PJ Fanning fe589a664e Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819759 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:47:53 +00:00
Andreas Beeker 704b41ab9a #61797 - Embed Excel / Ole objects into powerpoint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819710 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 01:14:08 +00:00
Andreas Beeker 8eaecc49a4 #61941 - Move Ole marker generation to Ole10Native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819706 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:22:43 +00:00
Dominik Stadler 89e7fbe6cd Bug 61911: Avoid IndexOutOfBounds access when reading pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:36 +00:00
Dominik Stadler 62c8296c70 Fix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with-resources, update/enhance JavaDoc somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819402 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:26 +00:00
PJ Fanning 819eac1f82 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:23:52 +00:00
Andreas Beeker 0ddda673b3 #61881 - handle invalid font names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
PJ Fanning e0c8416726 use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 20:03:25 +00:00
Dominik Stadler e93f78cd13 Ensure that the tempdir exists when we use ImageIO in one of the tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 12:25:11 +00:00
PJ Fanning acc7b356ee add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 22:10:48 +00:00
PJ Fanning 2d8c9cbc9a [bug-61792] some changes to avoid iterating over chars of Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:35:36 +00:00
Dominik Stadler 76d11ac37e Some JavaDoc adjustments, typos, IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
2017-11-08 14:59:08 +00:00
Dominik Stadler b7f7ff71b4 Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods
Adjust tests slighlty, close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:04 +00:00
Andreas Beeker 37e4c32065 #61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68
2017-11-02 23:15:19 +00:00
Javen O'Neal b3cb1211a4 github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:38:03 +00:00
PJ Fanning 7dce661861 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 21:17:49 +00:00
PJ Fanning e2e3b52013 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813092 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:39:27 +00:00
PJ Fanning 707f266eef Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813085 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:27:47 +00:00
PJ Fanning e52d29df16 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:03:33 +00:00
PJ Fanning 2cd8c7bc65 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:45:35 +00:00
PJ Fanning dffa1ccd9c Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:07:14 +00:00
Javen O'Neal 2ef3af567c replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:41:42 +00:00
Javen O'Neal f786b16f7f for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:33:07 +00:00
PJ Fanning 67e6ad9c47 Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:25:33 +00:00
Dominik Stadler 1b171e8642 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 09:40:22 +00:00
Dominik Stadler d9a818dc22 Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 05:32:05 +00:00
Dominik Stadler fbdf4dca68 Bug 61586: Add test which shows that it works as expected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68
2017-10-06 17:41:20 +00:00
Dominik Stadler bd5a1fb7a6 Adjust some unit-tests, use try-with-resource, enable test which works now, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 12:40:38 +00:00
Tim Allison bf6cd20f10 Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus. Many thanks to Dominik Stadler for running the regression tests!!!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 12:53:10 +00:00
Tim Allison 53b55eb4c3 Bug 61349 -- add more sanity checks when allocating byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
2017-09-21 14:52:59 +00:00
PJ Fanning de664ee97a tidy up some test code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808944 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 21:04:30 +00:00
PJ Fanning 38650a6d2f use non-deprecated versions of getCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:31:55 +00:00
PJ Fanning 1e8ecbec04 change HyperLink getType to return HyperlinkType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 15:55:48 +00:00
PJ Fanning bc0c0b19d2 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:26:16 +00:00
Dominik Stadler 467053d91c Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:23 +00:00
Dominik Stadler 5dadfd7c18 Use Integer.compare() where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:20 +00:00
Dominik Stadler 399381da8d Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler 0cfa1ede4c Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler 3e70d75cfb Remove unnecessary type arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808515 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:24:05 +00:00
Dominik Stadler 4e166ebded Suppress some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808514 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:57 +00:00
Dominik Stadler f1f07e00bb Remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:48 +00:00
Dominik Stadler 4f3e802f50 Remove unnecessary casts and toString() calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808512 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:30 +00:00
Dominik Stadler 202b2b0be5 Remove unnecessary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808511 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:15 +00:00
Dominik Stadler 32370cfd1c Remove unnecessary initialization of members
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:22:59 +00:00
Dominik Stadler 037800436a Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808508 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:21:28 +00:00
Dominik Stadler 98409d3564 Add additional check as mentioned in bug 50060
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808503 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:32 +00:00
PJ Fanning b7e55e211b remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808455 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 12:29:35 +00:00
PJ Fanning 03b4a49d9f remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808400 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 22:19:16 +00:00
Nick Burch bdb0e8199b Copy over and tweak PicturesSource from Apache Tika
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807651 13f79535-47bb-0310-9956-ffa450edef68
2017-09-07 21:36:15 +00:00
Andreas Beeker a98350e40b #61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 20:47:48 +00:00
Andreas Beeker 0d8350b03a #61363 - Unify escher shape id allocation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803483 13f79535-47bb-0310-9956-ffa450edef68
2017-07-30 23:11:36 +00:00
Tim Allison b1a0c7d53d 61337 -- try to convert assertions to exceptions. I left in the assertions for the binary search components.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803092 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 18:43:27 +00:00
Tim Allison a9c4072071 61346 add more sanity checks before allocating byte arrays in emf/wmf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803041 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 12:46:24 +00:00
Tim Allison d7959a403e 61338 -- avoid infinite loop triggered by fuzzed wmf file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802997 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 20:26:57 +00:00
Andreas Beeker b8242721fb Bug 61331 - Font group handling / common font interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
2017-07-23 22:45:47 +00:00
Dominik Stadler d687e94d58 Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802629 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:03 +00:00
PJ Fanning 52d3ea57f4 javadoc: replace invalid self enclosing elements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 08:24:24 +00:00
Tim Allison 1a8b5234ec bug 61294 -- cleaned up based on PJ Fanning's code review. Went with a copy/paste from commons-io.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801952 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 12:48:28 +00:00
Javen O'Neal b6335018c8 bug 61296: suggest de-duplication of purl dublin core namespace url
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801905 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 03:54:12 +00:00
Tim Allison 34cb860998 bug 61294 -- prevent infinite loop in IOUtils' skipFully.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801844 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 16:20:28 +00:00
Javen O'Neal 34d9764ca5 bug 60685: ignore problems with HPBF Publisher Quill Contents PLC hyperlink records so that text extraction can continue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801405 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 01:34:30 +00:00
Javen O'Neal 61841e51e9 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801404 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 01:31:31 +00:00
PJ Fanning 879a6d20c3 [Bug-61268] avoid NegativeArraySizeException parsing doc file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801395 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 22:32:27 +00:00
Andreas Beeker c82aa1a4bb #61169 - Text with Japanese characters overflows textbox
- add resize methods with Graphics argument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801329 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 22:20:55 +00:00
Andreas Beeker 6e6136ba89 #61243 - Refactor and unify toString/toXml in DDF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800452 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 20:21:33 +00:00
PJ Fanning 586b303d74 Remove old XSSFWorkbook wb.xssfSheetIterator method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800248 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:15:50 +00:00
PJ Fanning b68b916d08 Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00