Javen O'Neal
|
f2cfbba58c
|
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:59:47 +00:00 |
Javen O'Neal
|
50ddff8c66
|
move check if border line style is blank before setting the border color to a helper function for readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:57:37 +00:00 |
Javen O'Neal
|
9fc99212a9
|
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:33:24 +00:00 |
Javen O'Neal
|
de2abf5cee
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:02:38 +00:00 |
Javen O'Neal
|
aeb3387171
|
use CellAddress in unit tests where possible to improve readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:01:30 +00:00 |
Javen O'Neal
|
631a29dc54
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:00:45 +00:00 |
Javen O'Neal
|
e216457d77
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 21:35:56 +00:00 |
Andreas Beeker
|
612217589c
|
fixing javadocs errors (in JDK8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 21:28:13 +00:00 |
Andreas Beeker
|
3930739eab
|
fixing javadocs errors (in JDK8)
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 20:19:59 +00:00 |
Andreas Beeker
|
e190b07960
|
javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 19:54:35 +00:00 |
Andreas Beeker
|
396d787dbe
|
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 16:57:15 +00:00 |
Andreas Beeker
|
0f89809206
|
ignore invalid performance issues - e.g. see #57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 01:18:12 +00:00 |
Andreas Beeker
|
85ef689f53
|
revert back to changes of bug 57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:54:01 +00:00 |
Andreas Beeker
|
8f0e87f7bb
|
Common-SS: changed UDFFinder from interface to abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:20:52 +00:00 |
Andreas Beeker
|
e425cd4f14
|
findbugs fixes
changed UDFFinder to abstract class and moved DEFAULT constant to factory method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:12:22 +00:00 |
Andreas Beeker
|
6da9c4514d
|
use newer findbugs version, if we run with java 7+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747936 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 21:23:01 +00:00 |
Dominik Stadler
|
2edb0f535b
|
Add some pre-checks to fail the test with better assertion if the locale is not set correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:59 +00:00 |
Dominik Stadler
|
781a4283b5
|
Downgrade version of download-plugin as the newer one is not found by Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747915 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:53 +00:00 |
Dominik Stadler
|
48b7a76300
|
Set the correct locale for tests in the Sonar-Maven files to not fail on CI machines that have a different locale set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747914 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:46 +00:00 |
Javen O'Neal
|
f44d02f1e1
|
make CellRangeAddresses easier to cross-reference the example with the written out workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 12:18:04 +00:00 |
Javen O'Neal
|
38bac40cf0
|
make these classes more discoverable/searchable using more specific names
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 12:09:23 +00:00 |
Javen O'Neal
|
370a0563e8
|
bug 57840: lazily compute hashCode; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:40:30 +00:00 |
Javen O'Neal
|
460540ded2
|
whitespace (tabs to spaces, 3-space to 4-space)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:35:18 +00:00 |
Javen O'Neal
|
0e0afb3c72
|
bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:28:55 +00:00 |
Javen O'Neal
|
adfb17a916
|
javadoc update and boolean addLeft|Right|Top|Bottom line wrap update
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:12:04 +00:00 |
Javen O'Neal
|
6f68efc02d
|
fix spelling in javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:01:48 +00:00 |
Javen O'Neal
|
55604275ae
|
fix javadocs: remove unnecessary @links, remove references to CellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 10:09:05 +00:00 |
Javen O'Neal
|
3b5a3dc469
|
move loop-invariants outside the loop for readability and execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:58:12 +00:00 |
Javen O'Neal
|
a0e1e136b1
|
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:15:57 +00:00 |
Dominik Stadler
|
50f02c9a0f
|
Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:45:41 +00:00 |
Dominik Stadler
|
ad5e04d5a1
|
Remove invalid removal of findbugs-zip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747862 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:45:33 +00:00 |
Dominik Stadler
|
42f556adef
|
Update to latest versions of Maven plugins for Sonar-build and use properties for some third party libs and some Maven plugins
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747861 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:45:28 +00:00 |
Javen O'Neal
|
ba1446c4f7
|
continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:15:50 +00:00 |
Javen O'Neal
|
ee66d945e9
|
continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:08:04 +00:00 |
Javen O'Neal
|
4030a40ec0
|
add helper functions for verifying template properties were set correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 07:48:32 +00:00 |
Javen O'Neal
|
9a079ea94b
|
whitespace (unwrap lines)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 07:40:46 +00:00 |
Javen O'Neal
|
4c1a2053c0
|
shorten PropertyTemplate.Extent to Extent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 07:10:21 +00:00 |
Javen O'Neal
|
2b720b0f62
|
+props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 07:00:40 +00:00 |
Javen O'Neal
|
de1fd518af
|
bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 06:47:25 +00:00 |
Javen O'Neal
|
8b7f22534c
|
create branch for bug 58787 Border utility to set cell styles around a range of cells
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747847 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 05:39:42 +00:00 |
Javen O'Neal
|
d568d8b73c
|
+props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 04:27:21 +00:00 |
Javen O'Neal
|
110c405135
|
methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 03:05:31 +00:00 |
Javen O'Neal
|
f9409282d9
|
bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 02:28:21 +00:00 |
Javen O'Neal
|
432769694c
|
whitespace (tabs to spaces); +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 02:12:43 +00:00 |
Javen O'Neal
|
e5bc4d22ce
|
bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 02:10:32 +00:00 |
Javen O'Neal
|
b911299bd3
|
bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 01:48:37 +00:00 |
Javen O'Neal
|
ce25a59b60
|
add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 01:41:54 +00:00 |
Javen O'Neal
|
15876029e1
|
add crude unit tests for UDFFinder classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 01:38:27 +00:00 |
Javen O'Neal
|
26886aa04f
|
remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 00:51:12 +00:00 |
Javen O'Neal
|
1a5b422afe
|
+props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747826 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 00:45:12 +00:00 |