Commit Graph

5951 Commits

Author SHA1 Message Date
Dominik Stadler 9c51a2f5b7 Move some tests from "unfixed" to "normal" test classes as the underlying bug is now fixed.
Also make on of the unfixed bugs cause an actual failure so it is justified to stay in "unfixed"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596261 13f79535-47bb-0310-9956-ffa450edef68
2014-05-20 14:12:19 +00:00
Dominik Stadler db09c677fd Bug 53691: Fix a copy/paste error in CFRuleRecord.clone()
also make CFRuleRecord.toString() print out more information which caused the bug to be much harder to find
Add unit tests to verify/reproduce this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596251 13f79535-47bb-0310-9956-ffa450edef68
2014-05-20 14:01:22 +00:00
Dominik Stadler ecf9194b65 Bug 56170: Fix a problem with cells in workbooks becoming disconnected from XMLBeans whenever columns need to be reordered during writing the file. This happens because setCArray() disconnects any previously stored array-item but we try to re-use them. So we need to recreate the CTCell and set it in the XSSFCell to make this work in all currently tested cases.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595659 13f79535-47bb-0310-9956-ffa450edef68
2014-05-18 19:18:27 +00:00
Dominik Stadler 764ec1df17 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
2014-05-16 13:25:45 +00:00
Dominik Stadler b342bc5d8b Fix Bug 56514, add missing null-check if simple shape does not have any text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595127 13f79535-47bb-0310-9956-ffa450edef68
2014-05-16 07:09:55 +00:00
Dominik Stadler e76448a83c Bug 56325: fix Exception when removing sheets with named ranges in the workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595048 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 21:14:52 +00:00
Dominik Stadler d3a50a3388 Avoid unnecessary string creation/concatination for numeric conversion, use Double.toString() instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595047 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 21:14:32 +00:00
Nick Burch 5eacb4c2f7 Add a HSSF print paper size constant for "printer default" for bug #56509
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594848 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 10:15:04 +00:00
Andreas Beeker 95712b5661 Bug 56468 - Writing a workbook more than once corrupts the file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594721 13f79535-47bb-0310-9956-ffa450edef68
2014-05-14 21:14:16 +00:00
Dominik Stadler 8a1411bda1 fix some Eclipse warnings, unnecessary null-check and missing close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594201 13f79535-47bb-0310-9956-ffa450edef68
2014-05-13 11:31:18 +00:00
Nick Burch aa3a7ef63d Based on reading of the new file format docs, start to tweak how fixed length vs variable length / multi-valued properties are handled
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593861 13f79535-47bb-0310-9956-ffa450edef68
2014-05-11 21:16:40 +00:00
Nick Burch eb5866370a Outlook sometimes stores a codepage of ANSI when it means 1252, detect and alias, fixes bug #53983
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593306 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 15:17:22 +00:00
Nick Burch 4c0697dea5 Implement a few more MAPI property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593298 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:49:21 +00:00
Nick Burch fb45a814d4 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593297 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:46:43 +00:00
Andreas Beeker a348d9530f Bug 56486 - Add XOR obfuscation/decryption support to HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592636 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 21:41:31 +00:00
Andreas Beeker faa2a64d4a Bug 56269 - DateFormat - Rounding of fractionals
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592419 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 21:17:18 +00:00
Andreas Beeker 13860b6d5a The NPOIFS-classes result currently in left-over memory mapped buffers.
These are actually hard to workaround, so for Windows the test is ignored, if this error happens.
http://stackoverflow.com/questions/3602783/file-access-synchronized-on-java-object 

Apart of that, the RandomFileAccess instance is saved in the FileBackedDataSource as it needs to
be closed instead of the Channel.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4796385

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592418 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 20:58:42 +00:00
Dominik Stadler 525b8b5335 File leak detector: Close streams in some tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592315 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 08:05:32 +00:00
Nick Burch 1bf21ef3f9 Excel 2007 and later allows for more than 3 Conditional Formatting rules per sheet, so change our hard limit to logging a compatibility warning. Test file from Pau Coma Ramirez from bug #56482
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591959 13f79535-47bb-0310-9956-ffa450edef68
2014-05-02 15:49:23 +00:00
Nick Burch aef0863d26 Generics warnings fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591838 13f79535-47bb-0310-9956-ffa450edef68
2014-05-02 09:15:23 +00:00
Nick Burch da8480ef0b Provide a convenience method for creating a PropertySet from a Directory + Entry
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590650 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 14:19:13 +00:00
Nick Burch db2eb5f3ea Fix generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590642 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 14:03:18 +00:00
Nick Burch 0eb4f7684c Update the HPSF change properties example to use NPOIFS + in-place writes, and have NPOIFS give a helpful error if you try to in-place write on a read only open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590577 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 09:22:58 +00:00
Nick Burch 4e984df1c9 Get NPOIFS in-place-write working!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590556 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 06:35:39 +00:00
Andreas Beeker 59a1590048 junit4 fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590327 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 23:37:40 +00:00
Nick Burch 7b134ca25a More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 22:50:00 +00:00
Nick Burch 813a43f2e5 Fix javadoc layout
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590317 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 22:43:23 +00:00
Nick Burch dcecea15da Convert the HPSF test to JUnit 4, and add a bit more testing for NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590309 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 21:51:28 +00:00
Nick Burch ca16bb9403 Stream tests for NDocumentOutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590303 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 21:33:19 +00:00
Nick Burch 84f3ef670a NDocumentOutputStream write logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590191 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:34:09 +00:00
Nick Burch 023e5205e4 Fix inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590190 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:33:16 +00:00
Nick Burch 6bf09f5b16 Begin to support and test in-place changes to documents within a NPOIFS stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:07:00 +00:00
Nick Burch 9d2023f2ac Support for replacing the contents of a Document in a NPOIFSFileSytem, in place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590177 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:40:51 +00:00
Nick Burch 99a52e7638 Complete NPOIFS write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590162 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:05:46 +00:00
Nick Burch 188c7aa10c When deleting a document in NPOIFS, free the underlying blocks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:00:30 +00:00
Nick Burch 2f81141640 More progress with the write/read npoifs tests, but one bug still to go....
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590153 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:23:10 +00:00
Nick Burch 7e3b3b85d9 Refactor some of the NPOIFS write tests, and begin on the last missing write test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590149 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:11:26 +00:00
Nick Burch 184be5c03b Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:10:52 +00:00
Nick Burch 00db163084 Finish off the next NPOIFS write text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590133 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 20:38:55 +00:00
Nick Burch f9c96e48e7 More NPOIFS mini stream improvements, and more tests for it all
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 18:39:31 +00:00
Nick Burch 92dd03dcd6 Correct mini stream initialisation, and enable more npoifs write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 18:14:28 +00:00
Nick Burch c311ead345 More NPOIFS tests, and a partial mini-stream fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 17:06:10 +00:00
Nick Burch 4cbedafcaf More npoifs write tests, some disabled as failing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589987 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 10:57:15 +00:00
Nick Burch 75826dcd75 Add common code for writing out and reading NPOIFS again, and add a disabled roundtrip test (currently failing...)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589895 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 22:22:06 +00:00
Nick Burch e95e05b875 Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 21:08:34 +00:00
Nick Burch 216343d32d Add TODOs for the next set of NPOIFS write tests we need
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589868 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 20:23:43 +00:00
Nick Burch 9839d90e79 More NPOIFS write testing, and fix a problem with writing xbat details out
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:44:10 +00:00
Nick Burch ea3d7cd99b Update a test to use the existing EntryUtils to copy with, rather than duplciating the logic, and tweak naming/javadocs to clarify what the test does
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589802 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:32:47 +00:00
Nick Burch d99d2e559e More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:25:10 +00:00
Nick Burch 9d0167f5de More int/long sizing fixes for >2gb NPOIFS files, see bug #56447
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 16:15:21 +00:00