Commit Graph

90 Commits

Author SHA1 Message Date
Dominik Stadler bfd2266779 Fix issues found when fuzzing Apache POI via Jazzer
Do not assert when the next line will throw a proper exception anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899162 13f79535-47bb-0310-9956-ffa450edef68
2022-03-24 04:42:34 +00:00
PJ Fanning a1463e32e5 increase max size of hwmf picture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899135 13f79535-47bb-0310-9956-ffa450edef68
2022-03-22 14:58:47 +00:00
PJ Fanning d013349052 use spaces for indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899082 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 10:26:05 +00:00
Dominik Stadler 9949242022 Remove unused imports, remove unnecessary boxing of int-value and apply some other IDE suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899076 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 08:20:00 +00:00
Dominik Stadler d648c6d652 Fix issues found when fuzzing Apache POI via Jazzer
Throw RecordFormatException instead of NPE or assertion for
cases that can be triggered by a malformed document

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899073 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:51 +00:00
Dominik Stadler 9df7e2d847 Prevent one more case of allocating endlessly on invalid TNEF/HMEF/MAPI files
Limit the number of attributes to 10,000 by default

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899072 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:47 +00:00
Dominik Stadler a7810011c7 Fix issues found when fuzzing Apache POI via Jazzer
Replace assertions with actual checks when input-data
can trigger them. We would not handle such
input-data properly otherwise.
Sometimes logging seems a better option if the issue
is not blocking us from parsing the document anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1899070 13f79535-47bb-0310-9956-ffa450edef68
2022-03-20 06:52:38 +00:00
Dominik Stadler 116c3e91ad Add/update some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898385 13f79535-47bb-0310-9956-ffa450edef68
2022-02-24 18:12:39 +00:00
PJ Fanning 1d0b478c16 refactor some stream code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898221 13f79535-47bb-0310-9956-ffa450edef68
2022-02-19 14:01:19 +00:00
PJ Fanning 839f1ad02a refactor some stream code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898216 13f79535-47bb-0310-9956-ffa450edef68
2022-02-19 12:21:04 +00:00
PJ Fanning 788dd3f03c refactor some stream code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898213 13f79535-47bb-0310-9956-ffa450edef68
2022-02-19 12:08:48 +00:00
PJ Fanning 4998436a00 rework test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898212 13f79535-47bb-0310-9956-ffa450edef68
2022-02-19 11:41:46 +00:00
PJ Fanning 6622d9badb [bug-65899] fix issue where malformed tnef file can cause memory problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898208 13f79535-47bb-0310-9956-ffa450edef68
2022-02-19 11:28:50 +00:00
PJ Fanning 1ee199b1ea try to fix build for Java 9+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897344 13f79535-47bb-0310-9956-ffa450edef68
2022-01-22 14:35:20 +00:00
Dominik Stadler 9a0933b04e Introduce an OldVisioFormatException similar to other file-types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897321 13f79535-47bb-0310-9956-ffa450edef68
2022-01-22 06:58:51 +00:00
PJ Fanning f2d37da8fc remove use of deprecated commons-math methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897138 13f79535-47bb-0310-9956-ffa450edef68
2022-01-17 00:58:27 +00:00
Andreas Beeker ff6984df00 remove and prevent links to stackoverflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896899 13f79535-47bb-0310-9956-ffa450edef68
2022-01-10 22:06:26 +00:00
Axel Howind 78f7decf00 Bug 65796: License violation in PICT.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896887 13f79535-47bb-0310-9956-ffa450edef68
2022-01-10 14:37:13 +00:00
Dominik Stadler f331af5a52 Increase new limits for files processed in the mass-regression-tests
Some valid test-files do trigger these limits, which indicates that
we should set them a bit higher

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896745 13f79535-47bb-0310-9956-ffa450edef68
2022-01-06 11:10:33 +00:00
Dominik Stadler 729d78cda6 Limit allocated elements in the PlfLfo structure for word documents
Use large allocation-detection here as well,
otherwise some documents can try to allocate too much memory.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896744 13f79535-47bb-0310-9956-ffa450edef68
2022-01-06 11:10:00 +00:00
PJ Fanning c8fc960d2d use isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896547 13f79535-47bb-0310-9956-ffa450edef68
2021-12-30 21:35:45 +00:00
PJ Fanning 9de29ea3fc use isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896541 13f79535-47bb-0310-9956-ffa450edef68
2021-12-30 20:34:10 +00:00
Dominik Stadler 32311e42c2 Fix Sonar issues and print out some more in test-assertions that do fail sometimes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896531 13f79535-47bb-0310-9956-ffa450edef68
2021-12-30 16:10:52 +00:00
PJ Fanning 6784dd81c2 update some code based on sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896504 13f79535-47bb-0310-9956-ffa450edef68
2021-12-29 13:08:56 +00:00
PJ Fanning d6ab8e8444 [github-290] Customize Spliterator implementations for better parallelism. Thanks to Daniel Shuy. This closes #290
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896305 13f79535-47bb-0310-9956-ffa450edef68
2021-12-23 10:33:59 +00:00
PJ Fanning f4bb4560ed code tidy up
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896139 13f79535-47bb-0310-9956-ffa450edef68
2021-12-18 17:41:36 +00:00
Dominik Stadler 9fa33b2b7e Fix issues found when fuzzing Apache POI via Jazzer
Add some additional allocation limits to avoid OOM in
some more cases with some broken input files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895922 13f79535-47bb-0310-9956-ffa450edef68
2021-12-13 19:22:34 +00:00
PJ Fanning 837590024f [bug-65741] rework previous change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895881 13f79535-47bb-0310-9956-ffa450edef68
2021-12-13 13:12:32 +00:00
Dominik Stadler 1e9efb5562 Fix issues found when fuzzing Apache POI via Jazzer
Add some null-checks and report more meaningful exceptions
This provides a bit more information than simple NullPointExceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895600 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 17:34:44 +00:00
Dominik Stadler f0e7cc0881 Fix issues found when fuzzing Apache POI via Jazzer
Check for negative array allocation size or access and report a more meaningful exception

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895599 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 17:34:19 +00:00
Dominik Stadler d5538d24d8 Apply IDE suggestions, adjust tests, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895596 13f79535-47bb-0310-9956-ffa450edef68
2021-12-05 15:33:39 +00:00
PJ Fanning a18a52316a remove unfinished test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895458 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:58:22 +00:00
PJ Fanning 6c3fe307f5 fix merge issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895457 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:57:10 +00:00
PJ Fanning c8d61cbfe3 code formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895454 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:49:25 +00:00
PJ Fanning add71cb80a spelling of embedded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895452 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 11:33:25 +00:00
PJ Fanning 43438ee6ef [bug-65715] fix bug in getDrawingPatriarch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895447 13f79535-47bb-0310-9956-ffa450edef68
2021-12-01 08:49:03 +00:00
Andreas Beeker d9b0e2ebfa Fix date format differences Java 8 vs 9+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895383 13f79535-47bb-0310-9956-ffa450edef68
2021-11-27 23:07:15 +00:00
Andreas Beeker d3ff953cf7 #65694 - HSLF - handle date/time fields and formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895248 13f79535-47bb-0310-9956-ffa450edef68
2021-11-22 00:01:31 +00:00
PJ Fanning d96869c870 some incorrect uses of
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895151 13f79535-47bb-0310-9956-ffa450edef68
2021-11-18 13:17:24 +00:00
PJ Fanning 9d765c755c javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895077 13f79535-47bb-0310-9956-ffa450edef68
2021-11-16 00:30:15 +00:00
PJ Fanning 8365ee1611 [github-278] Resolve all SpotBugs P1 issues in Main and Test. Thanks to Andreas Reichel. This closes #278
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895016 13f79535-47bb-0310-9956-ffa450edef68
2021-11-14 10:18:40 +00:00
PJ Fanning 161f02ad9e javadoc typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894858 13f79535-47bb-0310-9956-ffa450edef68
2021-11-09 10:16:58 +00:00
Dominik Stadler 761a78b49f Use append(char) instead of string where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894814 13f79535-47bb-0310-9956-ffa450edef68
2021-11-07 15:00:03 +00:00
Dominik Stadler 034c95ec55 Add some more forbidden-apis to prefer core JDK classes over Guava and commons-codec
Also prevent java logging from being used inadvertently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894810 13f79535-47bb-0310-9956-ffa450edef68
2021-11-07 14:59:40 +00:00
Andreas Beeker 4b230fa142 #65653 - HSLF FillType for texture and background color fills ignored
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894538 13f79535-47bb-0310-9956-ffa450edef68
2021-10-24 22:07:59 +00:00
PJ Fanning 977a870899 configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894526 13f79535-47bb-0310-9956-ffa450edef68
2021-10-24 09:37:50 +00:00
PJ Fanning 6a12c6cb25 [bug-65650] use image/x-pict mime type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894507 13f79535-47bb-0310-9956-ffa450edef68
2021-10-23 10:49:18 +00:00
PJ Fanning 732d640c41 remove deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894496 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 22:50:59 +00:00
PJ Fanning c0cc881114 more support for configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894494 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 21:08:53 +00:00
PJ Fanning 5b554e7534 more support for configurable max record len
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894493 13f79535-47bb-0310-9956-ffa450edef68
2021-10-22 20:53:54 +00:00