Commit Graph

7065 Commits

Author SHA1 Message Date
Dominik Stadler e1f1c5c01c Bug 57914: Provide a better error message for OOXML strict format which we do not support yet.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 10:23:46 +00:00
Dominik Stadler abc5c69c42 Add missing file for bug 59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732612 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 08:41:21 +00:00
Dominik Stadler 896446bd39 Update to JaCoCo 0.7.6 to try to restore coverage on builds.a.o
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732611 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 08:41:07 +00:00
Nick Burch 6e21b85d8e #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch 05d455310c Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:43:59 +00:00
Nick Burch 170fab2461 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:54 +00:00
Nick Burch 7fdd90fecb Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Andreas Beeker c6fa344c54 Regression fixes for H/XSLF and HWMF
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler 784bdfe20f Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Dominik Stadler 3655e070c1 Add xlsx which verifies via the integration-tests that the namespace fix works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732234 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:38:53 +00:00
Nick Burch 22f6743fca #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:24:09 +00:00
Nick Burch 112dc844a0 Pull out two more XSSF namespace definitions as re-usable constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:16:54 +00:00
Nick Burch 798795638c Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:10:20 +00:00
Nick Burch b1d13db902 Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 21:17:23 +00:00
Dominik Stadler 17ed7975e2 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:42:05 +00:00
Dominik Stadler e89cb5544d Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Tim Allison 12ac00eafd POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
2016-02-19 15:46:26 +00:00
Javen O'Neal 36ae29751d bug 58896: comment out time-dependent test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 17:53:13 +00:00
Nick Burch db635c18aa Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 11:16:11 +00:00
Javen O'Neal 865bf1d24f move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 04:05:45 +00:00
Javen O'Neal 2ffd1d9dd5 bug 58896: add unit test to time Sheet.autoSizeColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 03:33:25 +00:00
Javen O'Neal cb43e54594 avoid redundant null check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 02:03:11 +00:00
Tim Allison 0b0911db6b 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:49:59 +00:00
Javen O'Neal 9ee05a1452 bug 56345: reject single-cell merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Dominik Stadler 8cbb571d9c Add test which verifies that bug 52684 is not a problem (any more)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
2016-02-17 21:35:22 +00:00
Javen O'Neal b6a21ab3aa bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Dominik Stadler e7729d8b1b Tried to reproduce bug 55476, but could not, added unit test anyway
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 19:16:45 +00:00
Nick Burch 8c203f1366 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00
Nick Burch 3b5586ea79 Start generalising the IgnoredErrorType code for later HSSF use too #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:40:24 +00:00
Dominik Stadler d1d31485a1 No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 10:08:26 +00:00
Dominik Stadler 16b90ce342 GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 09:26:51 +00:00
Dominik Stadler e156c3d691 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 08:33:12 +00:00
Dominik Stadler 6979efe474 Improve error messages to state which bounds are exceeded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 07:41:47 +00:00
Dominik Stadler 50aa8f07c8 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:30:10 +00:00
Dominik Stadler 115b5fa0c6 Regression analysis: the additional testing of cloning sheets showed a
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:46 +00:00
Dominik Stadler 23be95a474 Ignore a failure during cloning if we exceed file-format limits
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:23 +00:00
Dominik Stadler 4308b2e398 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
2016-02-12 09:44:47 +00:00
Nick Burch 6f46cd95be Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 15:13:40 +00:00
Nick Burch f597a1717c Allow common tests to do auto-sizing even on SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 15:13:01 +00:00
Andreas Beeker b2d6b7c51a Add example for adding videos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
2016-02-06 22:23:47 +00:00
Andreas Beeker f2a8846bd4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 22:03:44 +00:00
Dominik Stadler ad696c04cb Remove file from expected failures after changes for bug 56880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 07:51:35 +00:00
Tim Allison 991c5d0a00 Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
2016-02-04 19:54:15 +00:00
Javen O'Neal d1e2c186ec remove deprecated (2009) HSSFComment#setColumn(short). int version is available.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:52:32 +00:00
Javen O'Neal 996c2d53ab HSSFComment: note a final field
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:33:00 +00:00
Javen O'Neal 4c82305d3d fix O(n^2) runtime unnecessarily recreating an array inside a for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:14:55 +00:00
Javen O'Neal f7a27ae67a bug 58885: fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 04:04:56 +00:00
Javen O'Neal 0281af7928 bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 03:27:35 +00:00
Dominik Stadler 7622fde4b7 Adjust test to pass forbidden-apis-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
2016-01-30 11:02:54 +00:00
Dominik Stadler 3705ceeb57 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 22:09:03 +00:00