From 02bd3e60f854360de90e867bb87baef874546edf Mon Sep 17 00:00:00 2001 From: David Pilato Date: Thu, 21 Dec 2023 14:50:18 +0100 Subject: [PATCH] ClientConfigurer is only available in MaybeSecureClientConfigurationBuilder. The documentation code does not compile and I'm not sure if it's a bug in the code or a miss in the documentation. When you want to configure a client, the doc says to use: ```java ClientConfiguration.builder().withClientConfigurer( // ... ``` But `withClientConfigurer(ClientConfiguration.ClientConfigurationCallback clientConfigurer)` is only available in `TerminalClientConfigurationBuilder` interface. And `ClientConfiguration.builder()` returns a `ClientConfigurationBuilderWithRequiredEndpoint` interface. --- src/main/antora/modules/ROOT/pages/elasticsearch/clients.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/antora/modules/ROOT/pages/elasticsearch/clients.adoc b/src/main/antora/modules/ROOT/pages/elasticsearch/clients.adoc index 0c2b4a66f..0f8d8c102 100644 --- a/src/main/antora/modules/ROOT/pages/elasticsearch/clients.adoc +++ b/src/main/antora/modules/ROOT/pages/elasticsearch/clients.adoc @@ -192,6 +192,7 @@ This callback provides a `org.elasticsearch.client.RestClientBuilder` that can b [source,java] ---- ClientConfiguration.builder() + .connectedTo("localhost:9200", "localhost:9291") .withClientConfigurer(ElasticsearchClients.ElasticsearchRestClientConfigurationCallback.from(restClientBuilder -> { // configure the Elasticsearch RestClient return restClientBuilder; @@ -210,6 +211,7 @@ used by the `RestClient`. [source,java] ---- ClientConfiguration.builder() + .connectedTo("localhost:9200", "localhost:9291") .withClientConfigurer(ElasticsearchClients.ElasticsearchHttpClientConfigurationCallback.from(httpAsyncClientBuilder -> { // configure the HttpAsyncClient return httpAsyncClientBuilder;