diff --git a/CI.adoc b/CI.adoc index 8fa861021..207950573 100644 --- a/CI.adoc +++ b/CI.adoc @@ -1,8 +1,8 @@ = Continuous Integration -image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2Fmaster&subject=Moore%20(master)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] -image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2F3.1.x&subject=Lovelace%20(3.1.x)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] -image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2F2.1.x&subject=Ingalls%20(2.1.x)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] +image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2Fmaster&subject=2020.0.0%20(master)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] +image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2F4.0.x&subject=Neumann%20(4.0.x)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] +image:https://jenkins.spring.io/buildStatus/icon?job=spring-data-elasticsearch%2F3.2.x&subject=Moore%20(3.2.x)[link=https://jenkins.spring.io/view/SpringData/job/spring-data-elasticsearch/] == Running CI tasks locally diff --git a/README.adoc b/README.adoc index 69a0d9524..590bef71d 100644 --- a/README.adoc +++ b/README.adoc @@ -197,6 +197,10 @@ If you want to build with the regular `mvn` command, you will need https://maven _Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests, and in particular please sign the https://cla.pivotal.io/sign/spring[Contributor’s Agreement] before submitting your first pull request._ +IMPORTANT: When contributing, please make sure an issue exists in Jira and comment on this issue with how you want to address it. By this we not only know that someone is working on an issue, we can also align architectural questions and possible solutions before work is invested. We so can prevent that much work is put into Pull Requests that have little +or no chances of being merged. + + === Building reference documentation Building the documentation builds also the project without running tests. diff --git a/src/main/asciidoc/reference/elasticsearch-auditing.adoc b/src/main/asciidoc/reference/elasticsearch-auditing.adoc index 4b805cbdf..63726588e 100644 --- a/src/main/asciidoc/reference/elasticsearch-auditing.adoc +++ b/src/main/asciidoc/reference/elasticsearch-auditing.adoc @@ -37,18 +37,18 @@ public class Person implements Persistable { private Instant lastModifiedDate; private String lastModifiedBy; - public Long getId() { <1> + public Long getId() { // <.> return id; } @Override public boolean isNew() { - return id == null || (createdDate == null && createdBy == null); <2> + return id == null || (createdDate == null && createdBy == null); // <.> } } ---- -<1> the getter also is the required implementation from the interface -<2> an object is new if it either has no `id` or none of fields containing creation attributes are set. +<.> the getter is the required implementation from the interface +<.> an object is new if it either has no `id` or none of fields containing creation attributes are set. === Activating auditing diff --git a/src/main/asciidoc/reference/elasticsearch-object-mapping.adoc b/src/main/asciidoc/reference/elasticsearch-object-mapping.adoc index b1023af3f..43d1b3bb6 100644 --- a/src/main/asciidoc/reference/elasticsearch-object-mapping.adoc +++ b/src/main/asciidoc/reference/elasticsearch-object-mapping.adoc @@ -28,7 +28,7 @@ The `MappingElasticsearchConverter` uses metadata to drive the mapping of object The following annotations are available: * `@Document`: Applied at the class level to indicate this class is a candidate for mapping to the database. The most important attributes are: -** `indexName`: the name of the index to store this entity in +** `indexName`: the name of the index to store this entity in. This can contain a SpEL template expression like `"log-#{T(java.time.LocalDate).now().toString()}"` ** `type`: [line-through]#the mapping type. If not set, the lowercased simple name of the class is used.# (deprecated since version 4.0) ** `shards`: the number of shards for the index. ** `replicas`: the number of replicas for the index. @@ -48,7 +48,7 @@ The following annotations are available: ** `analyzer`, `searchAnalyzer`, `normalizer` for specifying custom custom analyzers and normalizer. * `@GeoPoint`: marks a field as _geo_point_ datatype. Can be omitted if the field is an instance of the `GeoPoint` class. -NOTE: Properties that derive from `TemporalAccessor` must either have a `@Field` annotation of type `FieldType.Date` or a custom converter must be registerd for this type. + +NOTE: Properties that derive from `TemporalAccessor` must either have a `@Field` annotation of type `FieldType.Date` or a custom converter must be registered for this type. + If you are using a custom date format, you need to use _uuuu_ for the year instead of _yyyy_. This is due to a https://www.elastic.co/guide/en/elasticsearch/reference/current/migrate-to-java-time.html#java-time-migration-incompatible-date-formats[change in Elasticsearch 7]. The mapping metadata infrastructure is defined in a separate spring-data-commons project that is technology agnostic.