Cwikius-Spring/spring-data-elasticsearch
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-data-elasticsearch.git synced 2025-06-23 04:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

DATAES-461 - Make deleteAll(entities) more performant.

Browse Source 
Original PR: #375
This commit is contained in:
alesharik 2020-01-05 12:36:14 +03:00 committed by Peter-Josef Meisch
parent 9fea1365ac
commit 5eb83464a1
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/org/springframework/data/elasticsearch/repository/support/AbstractElasticsearchRepository.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2013-2019 the original author or authors. * Copyright 2013-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -26,6 +26,7 @@ import java.util.Optional;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.elasticsearch.ElasticsearchException; import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.index.query.IdsQueryBuilder;
import org.elasticsearch.index.query.QueryBuilder; import org.elasticsearch.index.query.QueryBuilder;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -69,6 +70,7 @@ import org.springframework.util.Assert;
* @author Sascha Woo * @author Sascha Woo
* @author Murali Chevuri * @author Murali Chevuri
* @author Peter-Josef Meisch * @author Peter-Josef Meisch
* @author Aleksei Arsenev
*/ */
public abstract class AbstractElasticsearchRepository<T, ID> implements ElasticsearchRepository<T, ID> { public abstract class AbstractElasticsearchRepository<T, ID> implements ElasticsearchRepository<T, ID> {
@ -290,9 +292,19 @@ public abstract class AbstractElasticsearchRepository<T, ID> implements Elastics
Assert.notNull(entities, "Cannot delete 'null' list."); Assert.notNull(entities, "Cannot delete 'null' list.");
IndexCoordinates indexCoordinates = getIndexCoordinates(); IndexCoordinates indexCoordinates = getIndexCoordinates();
IdsQueryBuilder idsQueryBuilder = idsQuery();
for (T entity : entities) { for (T entity : entities) {
doDelete(extractIdFromBean(entity), indexCoordinates); ID id = extractIdFromBean(entity);
if (id != null) {
idsQueryBuilder.addIds(stringIdRepresentation(id));
}
} }
if(idsQueryBuilder.ids().isEmpty()) {
return;
}
DeleteQuery deleteQuery = new DeleteQuery();
deleteQuery.setQuery(idsQueryBuilder);
operations.delete(deleteQuery, indexCoordinates);
indexOperations.refresh(indexCoordinates); indexOperations.refresh(indexCoordinates);
} }