From 77f43ce64cf7905c6acbc4d9b0fed47a87c9d6c6 Mon Sep 17 00:00:00 2001 From: Peter-Josef Meisch Date: Tue, 11 Feb 2020 19:03:00 +0100 Subject: [PATCH] DATAES-738 - Removing one save method as it does not fit the naming scheme. --- .../core/AbstractElasticsearchTemplate.java | 5 ----- .../core/DocumentOperations.java | 20 +++++-------------- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/src/main/java/org/springframework/data/elasticsearch/core/AbstractElasticsearchTemplate.java b/src/main/java/org/springframework/data/elasticsearch/core/AbstractElasticsearchTemplate.java index f2c6b46ca..e7a1b019d 100644 --- a/src/main/java/org/springframework/data/elasticsearch/core/AbstractElasticsearchTemplate.java +++ b/src/main/java/org/springframework/data/elasticsearch/core/AbstractElasticsearchTemplate.java @@ -146,11 +146,6 @@ public abstract class AbstractElasticsearchTemplate implements ElasticsearchOper return save(Arrays.asList(entities)); } - @Override - public Iterable save(IndexCoordinates index, T... entities) { - return save(Arrays.asList(entities), index); - } - @Override public void delete(Query query, Class clazz, IndexCoordinates index) { diff --git a/src/main/java/org/springframework/data/elasticsearch/core/DocumentOperations.java b/src/main/java/org/springframework/data/elasticsearch/core/DocumentOperations.java index 72285ab83..9442236dc 100644 --- a/src/main/java/org/springframework/data/elasticsearch/core/DocumentOperations.java +++ b/src/main/java/org/springframework/data/elasticsearch/core/DocumentOperations.java @@ -38,7 +38,7 @@ public interface DocumentOperations { /** * Saves an entity to the index specified in the entity's Document annotation - * + * * @param entity the entity to save, must not be {@literal null} * @param the entity type * @return the saved entity @@ -47,7 +47,7 @@ public interface DocumentOperations { /** * Saves an entity to the index specified in the entity's Document annotation - * + * * @param entity the entity to save, must not be {@literal null} * @param index the index to save the entity in, must not be {@literal null} * @param the entity type @@ -57,7 +57,7 @@ public interface DocumentOperations { /** * saves the given entities to the index retrieved from the entities' Document annotation - * + * * @param entities must not be {@literal null} * @param the entity type * @return the saved entites @@ -79,20 +79,10 @@ public interface DocumentOperations { * * @param entities must not be {@literal null} * @param the entity type - * @return the saved entites as Iterable + * @return the saved entities as Iterable */ Iterable save(T... entities); - /** - * saves the given entities to the given index. - * - * @param index the idnex to save the entities in, must not be {@literal null} - * @param entities must not be {@literal null} - * @param the entity type - * @return the saved entites as Iterable - */ - Iterable save(IndexCoordinates index, T... entities); - /** * Index an object. Will do save or update. * @@ -135,7 +125,7 @@ public interface DocumentOperations { /** * Bulk index all objects. Will do save or update. - * + * * @param queries the queries to execute in bulk * @param bulkOptions options to be added to the bulk request * @return the ids of the indexed objects