From 7f1d26dac33e68d65a4cacd1dbda0affb0b008c5 Mon Sep 17 00:00:00 2001 From: Mohsin Husen Date: Wed, 15 May 2013 17:27:49 +0100 Subject: [PATCH] Updated Test (Scan and Scroll) which was causing build failure --- .../core/ElasticsearchTemplateTests.java | 44 +++++++++++++++---- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java b/src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java index c0d413c60..bd4001bec 100644 --- a/src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java +++ b/src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java @@ -555,18 +555,20 @@ public class ElasticsearchTemplateTests { indexQuery2.setObject(sampleEntity2); indexQueries.add(indexQuery2); + + List entities = createSampleEntitiesWithMessage("Test message", 30); // when - elasticsearchTemplate.bulkIndex(indexQueries); + elasticsearchTemplate.bulkIndex(entities); elasticsearchTemplate.refresh(SampleEntity.class, true); // then SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(matchAllQuery()).withIndices("test-index") - .withTypes("test-type").withPageable(new PageRequest(0, 1)).build(); + .withTypes("test-type").withPageable(new PageRequest(0, 10)).build(); String scrollId = elasticsearchTemplate.scan(searchQuery, 1000, false); List sampleEntities = new ArrayList(); boolean hasRecords = true; - while (hasRecords) { + while (hasRecords) { Page page = elasticsearchTemplate.scroll(scrollId, 5000L, new ResultsMapper() { @Override public Page mapResults(SearchResponse response) { @@ -580,21 +582,45 @@ public class ElasticsearchTemplateTests { user.setMessage((String) searchHit.getSource().get("message")); chunk.add(user); } - return new PageImpl(chunk); + if(chunk.size() > 0){ + + return new PageImpl(chunk); + } + return null; } }); if (page != null) { sampleEntities.addAll(page.getContent()); - hasRecords = page.hasNextPage(); - } else { - hasRecords = false; - } + } else { + hasRecords = false; + } } - assertThat(sampleEntities.size(), is(equalTo(2))); + assertThat(sampleEntities.size(), is(equalTo(30))); } + private static List createSampleEntitiesWithMessage(String message, int numberOfEntities) { + List sampleEntities = new ArrayList(); + List indexQueries = new ArrayList(); + for (int i = 0; i < numberOfEntities; i++) { + String documentId = randomNumeric(5); + SampleEntity sampleEntity = new SampleEntity(); + sampleEntity.setId(documentId); + sampleEntity.setMessage(message); + sampleEntity.setRate(2); + sampleEntity.setVersion(System.currentTimeMillis()); + IndexQuery indexQuery2 = new IndexQuery(); + indexQuery2.setId(documentId); + indexQuery2.setObject(sampleEntity); + + indexQueries.add(indexQuery2); + sampleEntities.add(sampleEntity); + + } + return indexQueries; + } + @Test public void shouldReturnListForGivenCriteria() { // given