Cwikius-Spring/spring-data-elasticsearch
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-data-elasticsearch.git synced 2025-06-29 07:12:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

DATAES-316 - Revert: NodeClientFactoryBean doesn't shutdown ES on destroy life-cycle.

Browse Source 
Original PR: #335
This commit is contained in:
Peter-Josef Meisch 2019-10-25 21:38:46 +02:00 committed by GitHub
parent 29f34b05d3
commit d4f23a50e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/org/springframework/data/elasticsearch/client/NodeClientFactoryBean.java
View File

@ -152,9 +152,12 @@ public class NodeClientFactoryBean implements FactoryBean<Client>, InitializingB
try {
// NodeClient.close() is a noop, no need to call it here
logger.info("Closing elasticSearch node");
if (node != null) {
node.close();
}
// closing the Node causes tests to fail in the pipeline build and on some
// "mvn test" runs, there seem still to be tests relying on a running instance that
// is not properly set up.
// if (node != null) {
// node.close();
// }
} catch (final Exception e) {
logger.error("Error closing ElasticSearch client: ", e);
}