Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-01 09:42:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-2330: CacheControlHeadersWriter use a single header

Browse Source
This commit is contained in:
Rob Winch 2013-09-18 16:12:34 -05:00
parent 05a7c58daa
commit 0114b457c0
6 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/src/test/groovy/org/springframework/security/config/http/HttpHeadersConfigTests.groovy
View File

@ -388,7 +388,7 @@ class HttpHeadersConfigTests extends AbstractHttpConfigTests {
def assertHeaders(MockHttpServletResponse response, Map<String,String> expected) { def assertHeaders(MockHttpServletResponse response, Map<String,String> expected) {
assert response.headerNames == expected.keySet() assert response.headerNames == expected.keySet()
expected.each { headerName, value -> expected.each { headerName, value ->
assert response.getHeaderValues(headerName) == value.split(',') assert response.getHeaderValues(headerName) == [value]
} }
} }
} }

2
web/src/main/java/org/springframework/security/web/header/writers/CacheControlHeadersWriter.java
View File

@ -42,7 +42,7 @@ public final class CacheControlHeadersWriter extends StaticHeadersWriter {
private static List<Header> createHeaders() { private static List<Header> createHeaders() {
List<Header> headers = new ArrayList<Header>(2); List<Header> headers = new ArrayList<Header>(2);
headers.add(new Header("Cache-Control","no-cache","no-store","max-age=0","must-revalidate")); headers.add(new Header("Cache-Control","no-cache, no-store, max-age=0, must-revalidate"));
headers.add(new Header("Pragma","no-cache")); headers.add(new Header("Pragma","no-cache"));
return headers; return headers;
} }

2
web/src/test/java/org/springframework/security/web/header/writers/CacheControlHeadersWriterTests.java
View File

@ -48,7 +48,7 @@ public class CacheControlHeadersWriterTests {
writer.writeHeaders(request, response); writer.writeHeaders(request, response);
assertThat(response.getHeaderNames().size()).isEqualTo(2); assertThat(response.getHeaderNames().size()).isEqualTo(2);
assertThat(response.getHeaderValues("Cache-Control")).isEqualTo(Arrays.asList("no-cache","no-store","max-age=0","must-revalidate")); assertThat(response.getHeaderValues("Cache-Control")).isEqualTo(Arrays.asList("no-cache, no-store, max-age=0, must-revalidate"));
assertThat(response.getHeaderValues("Pragma")).isEqualTo(Arrays.asList("no-cache")); assertThat(response.getHeaderValues("Pragma")).isEqualTo(Arrays.asList("no-cache"));
} }
} }